104968 2012-12-13 15:47:32 -0800 [chromium] Expose a WebLayerTreeView getter on WebWidget to make it easier for the embedder to interface with the compositor 2012-12-13 16:23:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dglazkov enne fishd tkent+wkapi webkit.review.bot oldest_to_newest 791031 0 jamesr 2012-12-13 15:47:32 -0800 [chromium] Expose a WebLayerTreeView getter on WebWidget to make it easier for the embedder to interface with the compositor 791032 1 179357 jamesr 2012-12-13 15:48:04 -0800 Created attachment 179357 Patch 791034 2 179357 jamesr 2012-12-13 15:49:19 -0800 Comment on attachment 179357 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179357&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:1727 > +void WebViewImpl::webLayerTreeView() lol i rite code gud 791037 3 179360 jamesr 2012-12-13 15:50:53 -0800 Created attachment 179360 Patch 791043 4 179360 enne 2012-12-13 15:54:09 -0800 Comment on attachment 179360 Patch R=me. Seems reasonable to me! 791048 5 webkit.review.bot 2012-12-13 15:57:29 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 791080 6 179360 webkit.review.bot 2012-12-13 16:23:37 -0800 Comment on attachment 179360 Patch Clearing flags on attachment: 179360 Committed r137681: <http://trac.webkit.org/changeset/137681> 791081 7 webkit.review.bot 2012-12-13 16:23:40 -0800 All reviewed patches have been landed. Closing bug. 179357 2012-12-13 15:48:04 -0800 2012-12-13 15:50:51 -0800 Patch bug-104968-20121213154524.patch text/plain 3304 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRiZjdhNDg3M2M2NDlmZTlmYzJiY2I0YmE4ZmYyMzBhMjQyOTA5ZDYuLjQ4NmRjMzVkMzAxNjc1 NmY0NTVhYjZlNjBjY2YwYmRkNmFiMjlmNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMTItMTMgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEV4cG9zZSBhIFdlYkxheWVyVHJlZVZpZXcg Z2V0dGVyIG9uIFdlYldpZGdldCB0byBtYWtlIGl0IGVhc2llciBmb3IgdGhlIGVtYmVkZGVyIHRv IGludGVyZmFjZSB3aXRoIHRoZSBjb21wb3NpdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ5NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGFuIGludGVybWVkaWF0ZSBzdGVwIG9uIHRo ZSB3YXkgdG8gaHR0cHM6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWls P2lkPTE1NjE3NS4KKworICAgICAgICAqIHB1YmxpYy9XZWJXaWRnZXQuaDoKKyAgICAgICAgKFdl YktpdCk6CisgICAgICAgIChXZWJXaWRnZXQpOgorICAgICAgICAoV2ViS2l0OjpXZWJXaWRnZXQ6 OmxheWVyVHJlZVZpZXcpOgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlZpZXdJbXBsOjp3ZWJMYXllclRyZWVWaWV3KToKKyAgICAgICAgKFdlYktp dCk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6CisgICAgICAgIChXZWJWaWV3SW1wbCk6 CisKIDIwMTItMTItMTMgIFl1c3VmIE96dXlzYWwgIDx5dXN1Zm9AZ29vZ2xlLmNvbT4KIAogICAg ICAgICBDaGVjayB3aGV0aGVyIGEgdG91Y2hEb3duIGxhbmRzIG9uIGEgcmVnaXN0ZXJlZCB0b3Vj aCBldmVudCBoYW5kbGVyIGZyb20gdGhlIGNvbXBvc2l0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViV2lkZ2V0LmgKaW5kZXggZGEyMzk1MWY5NDBmN2NmMjhmMGEwNzY3MDg1OWI5 MTZlZTk5ZTc4NS4uYjIxYTMxNjM3OThhNTZjZjE4MjQxNzZhNjE3Yjg3MjMxYTJkNGU0YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKQEAgLTQ2LDYgKzQ2LDcg QEAKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBXZWJJbnB1dEV2ZW50OworY2xhc3MgV2Vi TGF5ZXJUcmVlVmlldzsKIGNsYXNzIFdlYk1vdXNlRXZlbnQ7CiBjbGFzcyBXZWJTdHJpbmc7CiBz dHJ1Y3QgV2ViUG9pbnQ7CkBAIC0xMzQsNiArMTM1LDEwIEBAIHB1YmxpYzoKICAgICAvLyByZWFk eSB0byB1c2UuCiAgICAgdmlydHVhbCB2b2lkIHNldENvbXBvc2l0b3JTdXJmYWNlUmVhZHkoKSA9 IDA7CiAKKyAgICAvLyBSZXR1cm5zIHRoaXMgd2lkZ2V0J3MgV2ViTGF5ZXJUcmVlVmlldyBpZiBj b21wb3NpdGluZyBpcyBhY3RpdmUsIG5pbAorICAgIC8vIG90aGVyd2lzZS4KKyAgICB2aXJ0dWFs IFdlYkxheWVyVHJlZVZpZXcqIGxheWVyVHJlZVZpZXcoKSB7IHJldHVybiAwOyB9CisKICAgICAv LyBUZW1wb3JhcnkgbWV0aG9kIGZvciB0aGUgZW1iZWRkZXIgdG8gbm90aWZ5IHRoZSBXZWJXaWRn ZXQgdGhhdCB0aGUgd2lkZ2V0CiAgICAgLy8gaGFzIHRha2VuIGRhbWFnZSwgZS5nLiBkdWUgdG8g YSB3aW5kb3cgZXhwb3NlLiBUaGlzIG1ldGhvZCB3aWxsIGJlCiAgICAgLy8gcmVtb3ZlZCB3aGVu IHRoZSBXZWJXaWRnZXQgaW52ZXJzaW9uIHBhdGNoIGxhbmRzIC0tLSBodHRwOi8vY3JidWcuY29t LzExMjgzNwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4 IDY5OTM0MWMzZmM0ZGI4YThmM2YzYTFlNjdkYjY4N2M5ODcyOGM4ZjkuLmJiYWNlZWZjZmY1ZWI5 OTQxOTBlY2VkZjVmNGUzNjIyYzNkMDRjNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE3MjQsNiArMTcyNCwxMSBAQCB2b2lkIFdlYlZpZXdJbXBs OjpzZXRDb21wb3NpdG9yU3VyZmFjZVJlYWR5KCkKICAgICAgICAgbV9sYXllclRyZWVWaWV3LT5z ZXRTdXJmYWNlUmVhZHkoKTsKIH0KIAordm9pZCBXZWJWaWV3SW1wbDo6d2ViTGF5ZXJUcmVlVmll dygpCit7CisgICAgcmV0dXJuIG1fbGF5ZXJUcmVlVmlldy5nZXQoKTsKK30KKwogdm9pZCBXZWJW aWV3SW1wbDo6YW5pbWF0ZShkb3VibGUpCiB7CiAjaWYgRU5BQkxFKFJFUVVFU1RfQU5JTUFUSU9O X0ZSQU1FKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKaW5kZXggODZm NTY5NDEwOWNjNWE5YzViZjk0NTg4ZTIzNjFlMjViOWNmNGM4ZS4uZWQ0YTQ5ODE3ZjBiMmE2NjRj OGUxOTQzZDEwOTc1YzhkMzEwMTllYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5oCkBAIC0xNDIsNiArMTQyLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCB3 aWxsRXhpdEZ1bGxTY3JlZW4oKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkRXhpdEZ1bGxTY3JlZW4o KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q29tcG9zaXRvclN1cmZhY2VSZWFkeSgpOworICAgIHZp cnR1YWwgV2ViTGF5ZXJUcmVlVmlldyogd2ViTGF5ZXJUcmVlVmlldygpOwogICAgIHZpcnR1YWwg dm9pZCBhbmltYXRlKGRvdWJsZSk7CiAgICAgdmlydHVhbCB2b2lkIGxheW91dCgpOyAvLyBBbHNv IGltcGxlbWVudHMgV2ViTGF5ZXJUcmVlVmlld0NsaWVudDo6bGF5b3V0KCkKICAgICB2aXJ0dWFs IHZvaWQgZW50ZXJGb3JjZUNvbXBvc2l0aW5nTW9kZShib29sIGVuYWJsZSkgT1ZFUlJJREU7Cg== 179360 2012-12-13 15:50:53 -0800 2012-12-13 16:23:37 -0800 Patch bug-104968-20121213154813.patch text/plain 3317 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRiZjdhNDg3M2M2NDlmZTlmYzJiY2I0YmE4ZmYyMzBhMjQyOTA5ZDYuLjQ4NmRjMzVkMzAxNjc1 NmY0NTVhYjZlNjBjY2YwYmRkNmFiMjlmNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMTItMTMgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEV4cG9zZSBhIFdlYkxheWVyVHJlZVZpZXcg Z2V0dGVyIG9uIFdlYldpZGdldCB0byBtYWtlIGl0IGVhc2llciBmb3IgdGhlIGVtYmVkZGVyIHRv IGludGVyZmFjZSB3aXRoIHRoZSBjb21wb3NpdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ5NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGFuIGludGVybWVkaWF0ZSBzdGVwIG9uIHRo ZSB3YXkgdG8gaHR0cHM6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWls P2lkPTE1NjE3NS4KKworICAgICAgICAqIHB1YmxpYy9XZWJXaWRnZXQuaDoKKyAgICAgICAgKFdl YktpdCk6CisgICAgICAgIChXZWJXaWRnZXQpOgorICAgICAgICAoV2ViS2l0OjpXZWJXaWRnZXQ6 OmxheWVyVHJlZVZpZXcpOgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlZpZXdJbXBsOjp3ZWJMYXllclRyZWVWaWV3KToKKyAgICAgICAgKFdlYktp dCk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6CisgICAgICAgIChXZWJWaWV3SW1wbCk6 CisKIDIwMTItMTItMTMgIFl1c3VmIE96dXlzYWwgIDx5dXN1Zm9AZ29vZ2xlLmNvbT4KIAogICAg ICAgICBDaGVjayB3aGV0aGVyIGEgdG91Y2hEb3duIGxhbmRzIG9uIGEgcmVnaXN0ZXJlZCB0b3Vj aCBldmVudCBoYW5kbGVyIGZyb20gdGhlIGNvbXBvc2l0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViV2lkZ2V0LmgKaW5kZXggZGEyMzk1MWY5NDBmN2NmMjhmMGEwNzY3MDg1OWI5 MTZlZTk5ZTc4NS4uYjIxYTMxNjM3OThhNTZjZjE4MjQxNzZhNjE3Yjg3MjMxYTJkNGU0YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKQEAgLTQ2LDYgKzQ2LDcg QEAKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBXZWJJbnB1dEV2ZW50OworY2xhc3MgV2Vi TGF5ZXJUcmVlVmlldzsKIGNsYXNzIFdlYk1vdXNlRXZlbnQ7CiBjbGFzcyBXZWJTdHJpbmc7CiBz dHJ1Y3QgV2ViUG9pbnQ7CkBAIC0xMzQsNiArMTM1LDEwIEBAIHB1YmxpYzoKICAgICAvLyByZWFk eSB0byB1c2UuCiAgICAgdmlydHVhbCB2b2lkIHNldENvbXBvc2l0b3JTdXJmYWNlUmVhZHkoKSA9 IDA7CiAKKyAgICAvLyBSZXR1cm5zIHRoaXMgd2lkZ2V0J3MgV2ViTGF5ZXJUcmVlVmlldyBpZiBj b21wb3NpdGluZyBpcyBhY3RpdmUsIG5pbAorICAgIC8vIG90aGVyd2lzZS4KKyAgICB2aXJ0dWFs IFdlYkxheWVyVHJlZVZpZXcqIGxheWVyVHJlZVZpZXcoKSB7IHJldHVybiAwOyB9CisKICAgICAv LyBUZW1wb3JhcnkgbWV0aG9kIGZvciB0aGUgZW1iZWRkZXIgdG8gbm90aWZ5IHRoZSBXZWJXaWRn ZXQgdGhhdCB0aGUgd2lkZ2V0CiAgICAgLy8gaGFzIHRha2VuIGRhbWFnZSwgZS5nLiBkdWUgdG8g YSB3aW5kb3cgZXhwb3NlLiBUaGlzIG1ldGhvZCB3aWxsIGJlCiAgICAgLy8gcmVtb3ZlZCB3aGVu IHRoZSBXZWJXaWRnZXQgaW52ZXJzaW9uIHBhdGNoIGxhbmRzIC0tLSBodHRwOi8vY3JidWcuY29t LzExMjgzNwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4 IDY5OTM0MWMzZmM0ZGI4YThmM2YzYTFlNjdkYjY4N2M5ODcyOGM4ZjkuLjQxZWU1MGEzNzQ5ODNi YzcyYjUwOGExM2I1ZDMwYjViY2FhMjEwY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE3MjQsNiArMTcyNCwxMSBAQCB2b2lkIFdlYlZpZXdJbXBs OjpzZXRDb21wb3NpdG9yU3VyZmFjZVJlYWR5KCkKICAgICAgICAgbV9sYXllclRyZWVWaWV3LT5z ZXRTdXJmYWNlUmVhZHkoKTsKIH0KIAorV2ViTGF5ZXJUcmVlVmlldyogV2ViVmlld0ltcGw6Ondl YkxheWVyVHJlZVZpZXcoKQoreworICAgIHJldHVybiBtX2xheWVyVHJlZVZpZXcuZ2V0KCk7Cit9 CisKIHZvaWQgV2ViVmlld0ltcGw6OmFuaW1hdGUoZG91YmxlKQogewogI2lmIEVOQUJMRShSRVFV RVNUX0FOSU1BVElPTl9GUkFNRSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5oCmluZGV4IDg2ZjU2OTQxMDljYzVhOWM1YmY5NDU4OGUyMzYxZTI1YjljZjRjOGUuLmVkNGE0 OTgxN2YwYjJhNjY0YzhlMTk0M2QxMDk3NWM4ZDMxMDE5ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViVmlld0ltcGwuaApAQCAtMTQyLDYgKzE0Miw3IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgd2lsbEV4aXRGdWxsU2NyZWVuKCk7CiAgICAgdmlydHVhbCB2b2lkIGRpZEV4 aXRGdWxsU2NyZWVuKCk7CiAgICAgdmlydHVhbCB2b2lkIHNldENvbXBvc2l0b3JTdXJmYWNlUmVh ZHkoKTsKKyAgICB2aXJ0dWFsIFdlYkxheWVyVHJlZVZpZXcqIHdlYkxheWVyVHJlZVZpZXcoKTsK ICAgICB2aXJ0dWFsIHZvaWQgYW5pbWF0ZShkb3VibGUpOwogICAgIHZpcnR1YWwgdm9pZCBsYXlv dXQoKTsgLy8gQWxzbyBpbXBsZW1lbnRzIFdlYkxheWVyVHJlZVZpZXdDbGllbnQ6OmxheW91dCgp CiAgICAgdmlydHVhbCB2b2lkIGVudGVyRm9yY2VDb21wb3NpdGluZ01vZGUoYm9vbCBlbmFibGUp IE9WRVJSSURFOwo=