104961 2012-12-13 14:52:42 -0800 Add a missing nullity check in RenderObject::containingBlock 2012-12-13 19:33:37 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vollick vollick adamk eric fishd ojan.autocc webkit.review.bot oldest_to_newest 790970 0 vollick 2012-12-13 14:52:42 -0800 At one point we assert that !o->isAnonymousBlock(), but it's quite possible that o is null. 790973 1 179347 vollick 2012-12-13 14:54:04 -0800 Created attachment 179347 Patch 790976 2 179347 enne 2012-12-13 14:59:18 -0800 Comment on attachment 179347 Patch R=me. That looks safe. Later in the function there's a similar !o || !o->foo() assert. 791040 3 179347 webkit.review.bot 2012-12-13 15:53:36 -0800 Comment on attachment 179347 Patch Clearing flags on attachment: 179347 Committed r137674: <http://trac.webkit.org/changeset/137674> 791041 4 webkit.review.bot 2012-12-13 15:53:39 -0800 All reviewed patches have been landed. Closing bug. 791203 5 ap 2012-12-13 18:19:18 -0800 Why didn't this patch have a regression test? It's not OK to ignore those for fixes made through code inspection (I'd say that it's even more important for those fixes). 791249 6 vollick 2012-12-13 19:33:37 -0800 (In reply to comment #5) > Why didn't this patch have a regression test? It's not OK to ignore those for fixes made through code inspection (I'd say that it's even more important for those fixes). This patch was not initiated by code inspection, it was made to fix a debug-only crash in a layout test http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fullscreen%2Ffull-screen-fixed-pos-parent.html%2Cfullscreen%2Ffull-screen-iframe-without-allow-attribute-allowed-from-parent.html The crash resulted from asking a valid RenderObject what its containing block was -- something that, I believe, shouldn't run you the risk of crashing -- and appeared to be an oversight when the assertion was written. 179347 2012-12-13 14:54:04 -0800 2012-12-13 15:53:36 -0800 Patch bug-104961-20121213175124.patch text/plain 1553 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MxNjc3MjdiZDFiZTU5 ZTI2NDk2MjM5MzI4YjJlY2EzMGM1ZjI2My4uYjNmYWJiZjcwZDc4NTkxNGZmOTIxMWI4NTYwNjk5 NTA2NDRiMDU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTEyLTEzICBJYW4g Vm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgogCisgICAgICAgIEFkZCBhIG1pc3Npbmcg bnVsbGl0eSBjaGVjayBpbiBSZW5kZXJPYmplY3Q6OmNvbnRhaW5pbmdCbG9jaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0OTYxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkcyBhIG1pc3NpbmcgbnVs bGl0eSBjaGVjayBpbiBhbiBhc3NlcnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFu Z2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3Qu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0Ojpjb250YWluaW5nQmxvY2spOgor CisyMDEyLTEyLTEzICBJYW4gVm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgorCiAgICAg ICAgIFtjaHJvbWl1bV0gQXV0b21hdGljYWxseSB1c2UgY29tcG9zaXRlZCBzY3JvbGxpbmcKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NzQzCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKaW5kZXggNzE4Y2RiM2NiOTQw YTQ1Y2Y0NDJhNDY1OGZjYmI2Y2RiOTZjMTAzMC4uYWMwZjY3ZGRhZTJlZjk2YTc0MTUxZTIxOTE0 MzIwNWQyNzQ5OWJhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5j cHAKQEAgLTc2OCw3ICs3NjgsNyBAQCBSZW5kZXJCbG9jayogUmVuZGVyT2JqZWN0Ojpjb250YWlu aW5nQmxvY2soKSBjb25zdAogI2VuZGlmCiAgICAgICAgICAgICBvID0gby0+cGFyZW50KCk7CiAg ICAgICAgIH0KLSAgICAgICAgQVNTRVJUKCFvLT5pc0Fub255bW91c0Jsb2NrKCkpOworICAgICAg ICBBU1NFUlQoIW8gfHwgIW8tPmlzQW5vbnltb3VzQmxvY2soKSk7CiAgICAgfSBlbHNlIGlmICgh aXNUZXh0KCkgJiYgbV9zdHlsZS0+cG9zaXRpb24oKSA9PSBBYnNvbHV0ZVBvc2l0aW9uKSB7CiAg ICAgICAgIHdoaWxlIChvKSB7CiAgICAgICAgICAgICAvLyBGb3IgcmVscG9zaXRpb25lZCBpbmxp bmVzLCB3ZSByZXR1cm4gdGhlIG5lYXJlc3Qgbm9uLWFub255bW91cyBlbmNsb3NpbmcgYmxvY2su IFdlIGRvbid0IHRyeQo=