104957 2012-12-13 14:41:55 -0800 Make --profile output easier to understand for pprof on linux 2012-12-13 15:31:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric dpranke pdr webkit.review.bot oldest_to_newest 790952 0 eric 2012-12-13 14:41:55 -0800 Make --profile output easier to understand for pprof on linux 790954 1 179343 eric 2012-12-13 14:43:08 -0800 Created attachment 179343 Patch 790956 2 eric 2012-12-13 14:44:02 -0800 Now the output looks like this: %run-perf-tests --profile --chromium Bindings Running 24 tests Running Bindings/append-child.html (1 of 24) Finished: 16.911530 s First 10 lines of pprof --text: 150 9.0% 9.0% 150 9.0% __pthread_getspecific 138 8.2% 17.2% 152 9.1% v8::internal::Object::IsFunctionTemplateInfo (inline) 120 7.2% 24.4% 231 13.8% lookup (inline) 111 6.6% 31.0% 111 6.6% intHash (inline) 81 4.8% 35.8% 104 6.2% v8::Object::GetAlignedPointerFromInternalField (inline) 55 3.3% 39.1% 138 8.2% WebCore::ContainerNode::appendChild 53 3.2% 42.3% 317 18.9% WTF::HashTable::find 45 2.7% 45.0% 45 2.7% WebCore::TreeShared::deref (inline) 44 2.6% 47.6% 1382 82.6% WebCore::V8Node::appendChildCallback 43 2.6% 50.2% 354 21.1% v8::FunctionTemplate::HasInstance http://google-perftools.googlecode.com/svn/trunk/doc/cpuprofile.html documents output. To interact with the the full profile, including produce graphs: /usr/bin/google-pprof /src/WebKit/out/Release/DumpRenderTree /src/WebKit/Source/WebKit/chromium/webkit/Release/layout-test-results/test-15.pprof 791012 3 179343 webkit.review.bot 2012-12-13 15:31:52 -0800 Comment on attachment 179343 Patch Clearing flags on attachment: 179343 Committed r137666: <http://trac.webkit.org/changeset/137666> 791013 4 webkit.review.bot 2012-12-13 15:31:56 -0800 All reviewed patches have been landed. Closing bug. 179343 2012-12-13 14:43:08 -0800 2012-12-13 15:31:52 -0800 Patch bug-104957-20121213144028.patch text/plain 2801 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWMwM2U0OTM3MGE5NTFjMzhkZmQ5OTBlYjgwZjdhNTJi ZmNlYTgxOC4uZWVjNDczZGNkNjU1OTFmYmYzZmRiNDk3YWFiZmI3MTFmZjZhOTdmYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTEyLTEzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBNYWtlIC0tcHJvZmlsZSBvdXRwdXQgZWFzaWVyIHRvIHVuZGVyc3RhbmQgZm9yIHBwcm9mIG9u IGxpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDQ5NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBw cHJvZiBpcyBraW5kYSBteXN0ZXJpb3VzLCBzbyB3ZSBwcmludCBzb21lIGluZm9ybWF0aW9uCisg ICAgICAgIG9uIGhvdyB0byB1c2UgaXQsIGFuZCBob3cgdG8gbGVhcm4gaG93IHRvIHJlYWQgdGhl IHNhbXBsZSBkdW1wLgorICAgICAgICBUaGlzIGlzIHNpbWlsYXIgdG8gd2hhdCB3ZSd2ZSBkb25l IGZvciBwZXJmIG91dHB1dCBmb3IgQ2hyb21pdW0gQW5kcm9pZC4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wcm9maWxlci5weToKKyAgICAgICAgKEdvb2dsZVBQ cm9mLl9wcHJvZl9wYXRoKToKKyAgICAgICAgKEdvb2dsZVBQcm9mLnByb2ZpbGVfYWZ0ZXJfZXhp dCk6CisKIDIwMTItMTItMTMgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgc3VwcG9ydCAtd2syIHBvcnQgbmFtZXMgcHJvcGVybHkgaW4gd2Via2l0cHkubGF5 b3V0X3Rlc3RzLnBvcnQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L3N5c3RlbS9wcm9maWxlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl bS9wcm9maWxlci5weQppbmRleCAxMzA0NTkyMDdkM2QwMWNjNzFkZGQ3OTEyY2JhY2E3ZWU3MDVk Y2U4Li5lNDQ1MmQyMmVjM2Q3ZGE3NzdiNmIyNzRkZDZkMTcyMjNiNjRjY2EzIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcHJvZmlsZXIucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3Byb2ZpbGVyLnB5CkBAIC03Niwx OSArNzYsMjUgQEAgY2xhc3MgR29vZ2xlUFByb2YoU2luZ2xlRmlsZU91dHB1dFByb2ZpbGVyKToK ICAgICAgICAgbWF0Y2ggPSByZS5zZWFyY2goIl5Ub3RhbDpbXlxuXSpcbigoPzpbXlxuXSpcbil7 MCwxMH0pIiwgcHByb2Zfb3V0cHV0LCByZS5NVUxUSUxJTkUpCiAgICAgICAgIHJldHVybiBtYXRj aC5ncm91cCgxKSBpZiBtYXRjaCBlbHNlIE5vbmUKIAotICAgIGRlZiBwcm9maWxlX2FmdGVyX2V4 aXQoc2VsZik6CisgICAgZGVmIF9wcHJvZl9wYXRoKHNlbGYpOgogICAgICAgICAjIEZJWE1FOiBX ZSBzaG91bGQgaGF2ZSBjb2RlIHRvIGZpbmQgdGhlIHJpZ2h0IGdvb2dsZS1wcHJvZiBleGVjdXRh YmxlLCBzb21lIEdvb2dsZXJzIGhhdmUKICAgICAgICAgIyBnb29nbGUtcHByb2YgaW5zdGFsbGVk IGFzICJwcHJvZiIgb24gdGhlaXIgbWFjaGluZXMgZm9yIHRoZW0uCi0gICAgICAgICMgRklYTUU6 IFNpbWlsYXJseSB3ZSBzaG91bGQgZmluZCB0aGUgcmlnaHQgcGVybCEKKyAgICAgICAgcmV0dXJu ICcvdXNyL2Jpbi9nb29nbGUtcHByb2YnCiAKKyAgICBkZWYgcHJvZmlsZV9hZnRlcl9leGl0KHNl bGYpOgogICAgICAgICAjIGdvb2dsZS1wcHJvZiBkb2Vzbid0IGNoZWNrIGl0cyBhcmd1bWVudHMs IHNvIHdlIGhhdmUgdG8uCiAgICAgICAgIGlmIG5vdCAoc2VsZi5faG9zdC5maWxlc3lzdGVtLmV4 aXN0cyhzZWxmLl9vdXRwdXRfcGF0aCkpOgogICAgICAgICAgICAgcHJpbnQgIkZhaWxlZCB0byBn YXRoZXIgcHJvZmlsZSwgJXMgZG9lcyBub3QgZXhpc3QuIiAlIHNlbGYuX291dHB1dF9wYXRoCiAg ICAgICAgICAgICByZXR1cm4KIAotICAgICAgICBwcHJvZl9hcmdzID0gWycvdXNyL2Jpbi9wZXJs JywgJy91c3IvYmluL2dvb2dsZS1wcHJvZicsICctLXRleHQnLCBzZWxmLl9leGVjdXRhYmxlX3Bh dGgsIHNlbGYuX291dHB1dF9wYXRoXQorICAgICAgICBwcHJvZl9hcmdzID0gW3NlbGYuX3Bwcm9m X3BhdGgoKSwgJy0tdGV4dCcsIHNlbGYuX2V4ZWN1dGFibGVfcGF0aCwgc2VsZi5fb3V0cHV0X3Bh dGhdCiAgICAgICAgIHByb2ZpbGVfdGV4dCA9IHNlbGYuX2hvc3QuZXhlY3V0aXZlLnJ1bl9jb21t YW5kKHBwcm9mX2FyZ3MpCisgICAgICAgIHByaW50ICJGaXJzdCAxMCBsaW5lcyBvZiBwcHJvZiAt LXRleHQ6IgogICAgICAgICBwcmludCBzZWxmLl9maXJzdF90ZW5fbGluZXNfb2ZfcHJvZmlsZShw cm9maWxlX3RleHQpCisgICAgICAgIHByaW50ICJodHRwOi8vZ29vZ2xlLXBlcmZ0b29scy5nb29n bGVjb2RlLmNvbS9zdm4vdHJ1bmsvZG9jL2NwdXByb2ZpbGUuaHRtbCBkb2N1bWVudHMgb3V0cHV0 LiIKKyAgICAgICAgcHJpbnQKKyAgICAgICAgcHJpbnQgIlRvIGludGVyYWN0IHdpdGggdGhlIHRo ZSBmdWxsIHByb2ZpbGUsIGluY2x1ZGluZyBwcm9kdWNlIGdyYXBoczoiCisgICAgICAgIHByaW50 ICcgJy5qb2luKFtzZWxmLl9wcHJvZl9wYXRoKCksIHNlbGYuX2V4ZWN1dGFibGVfcGF0aCwgc2Vs Zi5fb3V0cHV0X3BhdGhdKQogCiAKIGNsYXNzIElQcm9maWxlcihTaW5nbGVGaWxlT3V0cHV0UHJv ZmlsZXIpOgo=