104945 2012-12-13 13:34:03 -0800 Layout Test fast/events/mouse-cursor-image-set.html is flaky 2012-12-13 16:43:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric rbyers bdakin rbyers webkit.review.bot oldest_to_newest 790864 0 eric 2012-12-13 13:34:03 -0800 The following layout test is flaky on all (chromium?) platforms fast/events/mouse-cursor-image-set.html http://trac.webkit.org/browser/trunk/LayoutTests/fast/events/mouse-cursor-image-set.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fevents%2Fmouse-cursor-image-set.html This test has only been around for 7 days. 790865 1 eric 2012-12-13 13:35:25 -0800 I'm not sure if it's an image loading issue: TEST CASE: Implicit hot-spot at (5,4) physical for 1x and (28,3) physical for 2x -Cursor Info: type=Custom hotSpot=5,4 image=25x25 +Cursor Info: type=Custom hotSpot=0,0 image=0x0 it always seems to fail the same subtest. 790866 2 eric 2012-12-13 13:37:42 -0800 I think it's this typo here: { url: 'resources/greenbox-hotspot35-4.cur' }, the '3'. The loading system seems fragile. Maybe we could read those images from the CSS values? 790896 3 rbyers 2012-12-13 13:59:39 -0800 I'll look into this. Yes if the test fails to reliably preload one of the images then it can get output like this. Ideally I'd be able to assert that an image was already preloaded or something. And yes I thought about trying to combine the lists to avoid duplication and risk of inconsistency but I didn't come up with anything that was clean and simple. I'll re-evaluate. Let me know if you have any suggestions. 790908 4 rbyers 2012-12-13 14:07:05 -0800 Dammit, and yes this is just a typo or copy-paste error with 'hotspot35-4' that should be 'hotspot5-4', dammit - sorry about that. I'll submit a trivial fix now, and file a separate bug to improve the infrastructure to make such mismatches impossible (which I probably won't get to until next week since I'm travelling this week). 790916 5 rbyers 2012-12-13 14:12:57 -0800 Underlying issue tracked in bug 104952 791057 6 179363 rbyers 2012-12-13 16:05:27 -0800 Created attachment 179363 Patch 791065 7 179363 eric 2012-12-13 16:11:53 -0800 Comment on attachment 179363 Patch Thank you Rick and Beth! 791105 8 rbyers 2012-12-13 16:42:26 -0800 (In reply to comment #7) > (From update of attachment 179363 [details]) > Thank you Rick and Beth! Thank you for noticing and ccing me! I wish we had a way for test owners to be auto-notified of any failures. 791106 9 179363 webkit.review.bot 2012-12-13 16:43:33 -0800 Comment on attachment 179363 Patch Clearing flags on attachment: 179363 Committed r137684: <http://trac.webkit.org/changeset/137684> 791107 10 webkit.review.bot 2012-12-13 16:43:36 -0800 All reviewed patches have been landed. Closing bug. 179363 2012-12-13 16:05:27 -0800 2012-12-13 16:43:33 -0800 Patch bug-104945-20121213190247.patch text/plain 1572 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTE1ODNkYTY3ZGMxYWM2M2Y2MjVl ZjVmZjMzMzJjZDlhZTM5ZWQ5My4uOGRjNGRhZjFjOTEwYmE2MjFkNjk3YTI0ZGFkODI0NDcwZTMx OTkxMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTEzICBSaWNrIEJ5ZXJzICA8cmJ5 ZXJzQGNocm9taXVtLm9yZz4KKworICAgICAgICBMYXlvdXQgVGVzdCBmYXN0L2V2ZW50cy9tb3Vz ZS1jdXJzb3ItaW1hZ2Utc2V0Lmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDk0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0eXBvIHRoYXQgcHJldmVudGVkIG9uZSBvZiB0 aGUgaW1hZ2VzIGZyb20gYmVpbmcgcmVsaWFibHkgcHJlLWxvYWRlZC4KKyAgICAgICAgQSBkZWVw ZXIgZml4IHRvIGF2b2lkIHRoZXNlIGNsYXNzIG9mIGlzc3VlcyBpcyB0cmFja2VkIGJ5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ5NTIKKworICAg ICAgICAqIGZhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1pbWFnZS1zZXQuaHRtbDoKKwogMjAxMi0x Mi0xMyAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGhpcyB0ZXN0 IGhhcyBiZWVuIGZhaWxpbmcgb24gdGhlIE1hYyBib3RzIGZvciBhIHdoaWxlLiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1pbWFnZS1zZXQuaHRtbCBi L0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1pbWFnZS1zZXQuaHRtbAppbmRl eCAxYzkxNmE0MzY0MzE0NzVmMDdiYTE5NGMyZDBkYzUzZjZjNjdhYzYwLi4zZTg0MDVjZGM3ZTk2 OWEwNTBjMTM5YjA3MmUzMDk3NDUzYWUzOTQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2V2ZW50cy9tb3VzZS1jdXJzb3ItaW1hZ2Utc2V0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9ldmVudHMvbW91c2UtY3Vyc29yLWltYWdlLXNldC5odG1sCkBAIC0xMTMsNyArMTEzLDcgQEAg dmFyIGltYWdlc1RvTG9hZCA9IFsKICB7IHVybDogJ3Jlc291cmNlcy9ncmVlbmJveC5wbmcnIH0s CiAgeyB1cmw6ICdyZXNvdXJjZXMvZ3JlZW5ib3gzMC5wbmcnIH0sCiAgeyB1cmw6ICdyZXNvdXJj ZXMvZ3JlZW5ib3gyMDAucG5nJyB9LAotIHsgdXJsOiAncmVzb3VyY2VzL2dyZWVuYm94LWhvdHNw b3QzNS00LmN1cicgfSwKKyB7IHVybDogJ3Jlc291cmNlcy9ncmVlbmJveC1ob3RzcG90NS00LmN1 cicgfSwKICB7IHVybDogJ3Jlc291cmNlcy9ncmVlbmJveDMwLWhvdHNwb3QyOC0zLmN1cicgfSwK ICB7IHVybDogJ2RvZXNudGV4aXN0LnBuZycsIGVycm9yOiB0cnVlIH0gXTsKIGVuc3VyZUltYWdl c0xvYWRlZChpbWFnZXNUb0xvYWQsIHJ1blRlc3RzKTsK