104939 2012-12-13 12:31:49 -0800 Get rid of DownloadManager::shared 2012-12-13 12:53:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 790818 0 andersca 2012-12-13 12:31:49 -0800 Get rid of DownloadManager::shared 790820 1 179316 andersca 2012-12-13 12:33:56 -0800 Created attachment 179316 Patch 790838 2 andersca 2012-12-13 12:53:59 -0800 Committed r137640: <http://trac.webkit.org/changeset/137640> 179316 2012-12-13 12:33:56 -0800 2012-12-13 12:41:46 -0800 Patch bug-104939-20121213123116.patch text/plain 7340 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjY0NDg1NzAyNGM0NmZm NDVmNDJjNDZkN2M1ZDMxYjViNjU0NDcwOC4uMGYwNDA2YjlmN2FkY2U3M2FkNjcyMWUyNGE4ZjUy NDU1MzI0YzNhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMzIEBACiAyMDEyLTEyLTEzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgR2V0IHJpZCBvZiBE b3dubG9hZE1hbmFnZXI6OnNoYXJlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA0OTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTW92ZSB0aGUgRG93bmxvYWRNYW5hZ2VyIHNpbmdsZXRvbiB0byBXZWJQ cm9jZXNzIGFuZCBzdHViIG91dCBhIERvd25sb2FkTWFuYWdlcjo6Q2xpZW50IGNsYXNzLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYW5hZ2VyLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6RG93bmxvYWRNYW5hZ2VyOjpEb3dubG9hZE1hbmFnZXIpOgorICAgICAgICAq IFdlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5oOgorICAgICAgICAoQ2xpZW50 KToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRNYW5hZ2VyOjpDbGllbnQ6On5DbGllbnQpOgor ICAgICAgICAoRG93bmxvYWRNYW5hZ2VyKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViRnJhbWUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZTo6c3RhcnREb3dubG9hZCk6 CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lOjpjb252ZXJ0SGFuZGxlVG9Eb3dubG9hZCk6Cisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UHJvY2Vzczo6ZG93bmxvYWRNYW5hZ2VyKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChX ZWJLaXQ6OldlYlByb2Nlc3M6OnNob3VsZFRlcm1pbmF0ZSk6CisgICAgICAgIChXZWJLaXQ6Oldl YlByb2Nlc3M6OmRvd25sb2FkUmVxdWVzdCk6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6 OmNhbmNlbERvd25sb2FkKToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6c3RhcnRUcmFu c2Zlcik6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6CisgICAgICAgIChXZWJQ cm9jZXNzKToKKworMjAxMi0xMi0xMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCiAgICAgICAgIERvd25sb2FkIG9iamVjdHMgc2hvdWxkIGtlZXAgdHJhY2sgb2YgdGhl aXIgYXNzb2NpYXRlZCBEb3dubG9hZE1hbmFnZXIgb2JqZWN0CiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ5MzYKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYW5hZ2VyLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5jcHAKaW5kZXgg MDU5OGYwM2VjN2E0MjhlZTdlOTRjY2FjODM4ZGQ0N2MzZTA4ZjAzZC4uMGMzNjdiM2I4Y2U4ZTE1 MjY0MmQ2MjkzYjNlZTZlN2ZkMWU4YzI4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZE1hbmFnZXIuY3BwCkBAIC0zNCwxNCArMzQs MTEgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi1E b3dubG9hZE1hbmFnZXImIERvd25sb2FkTWFuYWdlcjo6c2hhcmVkKCkKLXsKLSAgICBERUZJTkVf U1RBVElDX0xPQ0FMKERvd25sb2FkTWFuYWdlciwgZG93bmxvYWRNYW5hZ2VyLCAoKSk7Ci0gICAg cmV0dXJuIGRvd25sb2FkTWFuYWdlcjsKLX0KLQotRG93bmxvYWRNYW5hZ2VyOjpEb3dubG9hZE1h bmFnZXIoKQorRG93bmxvYWRNYW5hZ2VyOjpEb3dubG9hZE1hbmFnZXIoQ2xpZW50KiBjbGllbnQp CisgICAgOiBtX2NsaWVudChjbGllbnQpCiB7CisgICAgLy8gRklYTUU6IEFjdHVhbGx5IHVzZSB0 aGUgY2xpZW50IGZvciBzb21ldGhpbmcuCisgICAgKHZvaWQpbV9jbGllbnQ7CiB9CiAKIHZvaWQg RG93bmxvYWRNYW5hZ2VyOjpzdGFydERvd25sb2FkKHVpbnQ2NF90IGRvd25sb2FkSUQsIGNvbnN0 IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5oIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYW5hZ2VyLmgKaW5kZXggODEyZTliODBlMjZiZDI2 YjBlMzZiYWM3YWJiZWMwYTNkYTE1YjExYS4uNDBlYTNiNzk2ODFmM2VhYjViNWNlNzhmNjA1Mjlk ZmNjY2IwNWU0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9h ZHMvRG93bmxvYWRNYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3du bG9hZHMvRG93bmxvYWRNYW5hZ2VyLmgKQEAgLTQ4LDcgKzQ4LDEyIEBAIGNsYXNzIERvd25sb2Fk TWFuYWdlciB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRG93bmxvYWRNYW5hZ2VyKTsKIAog cHVibGljOgotICAgIHN0YXRpYyBEb3dubG9hZE1hbmFnZXImIHNoYXJlZCgpOworICAgIGNsYXNz IENsaWVudCB7CisgICAgcHVibGljOgorICAgICAgICB2aXJ0dWFsIH5DbGllbnQoKSB7IH0KKyAg ICB9OworCisgICAgZXhwbGljaXQgRG93bmxvYWRNYW5hZ2VyKENsaWVudCopOwogCiAgICAgdm9p ZCBzdGFydERvd25sb2FkKHVpbnQ2NF90IGRvd25sb2FkSUQsIGNvbnN0IFdlYkNvcmU6OlJlc291 cmNlUmVxdWVzdCYpOwogICAgIHZvaWQgY29udmVydEhhbmRsZVRvRG93bmxvYWQodWludDY0X3Qg ZG93bmxvYWRJRCwgV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBjb25zdCBXZWJDb3JlOjpSZXNv dXJjZVJlcXVlc3QmLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJik7CkBAIC02Myw4 ICs2OCw3IEBAIHB1YmxpYzoKICNlbmRpZgogCiBwcml2YXRlOgotICAgIERvd25sb2FkTWFuYWdl cigpOwotCisgICAgQ2xpZW50KiBtX2NsaWVudDsKICAgICBIYXNoTWFwPHVpbnQ2NF90LCBEb3du bG9hZCo+IG1fZG93bmxvYWRzOwogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJGcmFtZS5jcHAKaW5kZXggYmMyMjUyOWQ5ODRiYjRkMmFlNWJjMjg0NWExZDY4 ZTRhMjY2MGJlOS4uYjM3NGFiMzY5YWMxOWRhYjgxMDI4MDVmYzE4OWIwZmJmM2ZhNmRkMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCkBAIC0y MzYsNyArMjM2LDcgQEAgdm9pZCBXZWJGcmFtZTo6c3RhcnREb3dubG9hZChjb25zdCBXZWJDb3Jl OjpSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCiB7CiAgICAgQVNTRVJUKG1fcG9saWN5RG93bmxv YWRJRCk7CiAKLSAgICBEb3dubG9hZE1hbmFnZXI6OnNoYXJlZCgpLnN0YXJ0RG93bmxvYWQobV9w b2xpY3lEb3dubG9hZElELCByZXF1ZXN0KTsKKyAgICBXZWJQcm9jZXNzOjpzaGFyZWQoKS5kb3du bG9hZE1hbmFnZXIoKS5zdGFydERvd25sb2FkKG1fcG9saWN5RG93bmxvYWRJRCwgcmVxdWVzdCk7 CiAKICAgICBtX3BvbGljeURvd25sb2FkSUQgPSAwOwogfQpAQCAtMjQ1LDcgKzI0NSw3IEBAIHZv aWQgV2ViRnJhbWU6OmNvbnZlcnRIYW5kbGVUb0Rvd25sb2FkKFJlc291cmNlSGFuZGxlKiBoYW5k bGUsIGNvbnN0IFJlc291cmNlUmVxCiB7CiAgICAgQVNTRVJUKG1fcG9saWN5RG93bmxvYWRJRCk7 CiAKLSAgICBEb3dubG9hZE1hbmFnZXI6OnNoYXJlZCgpLmNvbnZlcnRIYW5kbGVUb0Rvd25sb2Fk KG1fcG9saWN5RG93bmxvYWRJRCwgaGFuZGxlLCByZXF1ZXN0LCByZXNwb25zZSk7CisgICAgV2Vi UHJvY2Vzczo6c2hhcmVkKCkuZG93bmxvYWRNYW5hZ2VyKCkuY29udmVydEhhbmRsZVRvRG93bmxv YWQobV9wb2xpY3lEb3dubG9hZElELCBoYW5kbGUsIHJlcXVlc3QsIHJlc3BvbnNlKTsKICAgICBt X3BvbGljeURvd25sb2FkSUQgPSAwOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ cm9jZXNzLmNwcAppbmRleCBmNzM2MDIwNmQyYTUzYmU0ZTQ2MDA4NTMzN2UyYTkwMmZiMmZmMWVl Li5lNjhhYTExM2YyNjlmYWE5Y2I4YTAxMThhMTIwZDk4YjdjM2RiZDEyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKQEAgLTQxNyw2ICs0MTcsMTYgQEAgdm9pZCBX ZWJQcm9jZXNzOjpkZXN0cm95UHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbigpCiAjZW5kaWYKIH0KIAor RG93bmxvYWRNYW5hZ2VyJiBXZWJQcm9jZXNzOjpkb3dubG9hZE1hbmFnZXIoKQoreworI2lmIEVO QUJMRShORVRXT1JLX1BST0NFU1MpCisgICAgQVNTRVJUKCFtX3VzZXNOZXR3b3JrUHJvY2Vzcyk7 CisjZW5kaWYKKworICAgIERFRklORV9TVEFUSUNfTE9DQUwoRG93bmxvYWRNYW5hZ2VyLCBkb3du bG9hZE1hbmFnZXIsICh0aGlzKSk7CisgICAgcmV0dXJuIGRvd25sb2FkTWFuYWdlcjsKK30KKwog dm9pZCBXZWJQcm9jZXNzOjpzZXRWaXNpdGVkTGlua1RhYmxlKGNvbnN0IFNoYXJlZE1lbW9yeTo6 SGFuZGxlJiBoYW5kbGUpCiB7CiAgICAgUmVmUHRyPFNoYXJlZE1lbW9yeT4gc2hhcmVkTWVtb3J5 ID0gU2hhcmVkTWVtb3J5OjpjcmVhdGUoaGFuZGxlLCBTaGFyZWRNZW1vcnk6OlJlYWRPbmx5KTsK QEAgLTY3MSw3ICs2ODEsNyBAQCBib29sIFdlYlByb2Nlc3M6OnNob3VsZFRlcm1pbmF0ZSgpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIEFTU0VSVChtX3BhZ2VNYXAuaXNFbXB0eSgpKTsK LSAgICBBU1NFUlQoIURvd25sb2FkTWFuYWdlcjo6c2hhcmVkKCkuaXNEb3dubG9hZGluZygpKTsK KyAgICBBU1NFUlQoIWRvd25sb2FkTWFuYWdlcigpLmlzRG93bmxvYWRpbmcoKSk7CiAKICAgICAv LyBGSVhNRTogdGhlIFNob3VsZFRlcm1pbmF0ZSBtZXNzYWdlIHNob3VsZCBhbHNvIHNlbmQgdGVy bWluYXRpb24gcGFyYW1ldGVycywgc3VjaCBhcyBhbnkgc2Vzc2lvbiBjb29raWVzIHRoYXQgbmVl ZCB0byBiZSBwcmVzZXJ2ZWQuCiAgICAgYm9vbCBzaG91bGRUZXJtaW5hdGUgPSBmYWxzZTsKQEAg LTExNDMsMTggKzExNTMsMTggQEAgdm9pZCBXZWJQcm9jZXNzOjpkb3dubG9hZFJlcXVlc3QodWlu dDY0X3QgZG93bmxvYWRJRCwgdWludDY0X3QgaW5pdGlhdGluZ1BhZ2VJRCwKICAgICBpZiAoaW5p dGlhdGluZ1BhZ2UpCiAgICAgICAgIGluaXRpYXRpbmdQYWdlLT5tYWluRnJhbWUoKS0+bG9hZGVy KCktPnNldE9yaWdpbmFsVVJMRm9yRG93bmxvYWRSZXF1ZXN0KHJlcXVlc3RXaXRoT3JpZ2luYWxV UkwpOwogCi0gICAgRG93bmxvYWRNYW5hZ2VyOjpzaGFyZWQoKS5zdGFydERvd25sb2FkKGRvd25s b2FkSUQsIHJlcXVlc3RXaXRoT3JpZ2luYWxVUkwpOworICAgIGRvd25sb2FkTWFuYWdlcigpLnN0 YXJ0RG93bmxvYWQoZG93bmxvYWRJRCwgcmVxdWVzdFdpdGhPcmlnaW5hbFVSTCk7CiB9CiAKIHZv aWQgV2ViUHJvY2Vzczo6Y2FuY2VsRG93bmxvYWQodWludDY0X3QgZG93bmxvYWRJRCkKIHsKLSAg ICBEb3dubG9hZE1hbmFnZXI6OnNoYXJlZCgpLmNhbmNlbERvd25sb2FkKGRvd25sb2FkSUQpOwor ICAgIGRvd25sb2FkTWFuYWdlcigpLmNhbmNlbERvd25sb2FkKGRvd25sb2FkSUQpOwogfQogCiAj aWYgUExBVEZPUk0oUVQpCiB2b2lkIFdlYlByb2Nlc3M6OnN0YXJ0VHJhbnNmZXIodWludDY0X3Qg ZG93bmxvYWRJRCwgY29uc3QgU3RyaW5nJiBkZXN0aW5hdGlvbikKIHsKLSAgICBEb3dubG9hZE1h bmFnZXI6OnNoYXJlZCgpLnN0YXJ0VHJhbnNmZXIoZG93bmxvYWRJRCwgZGVzdGluYXRpb24pOwor ICAgIGRvd25sb2FkTWFuYWdlcigpLnN0YXJ0VHJhbnNmZXIoZG93bmxvYWRJRCwgZGVzdGluYXRp b24pOwogfQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUHJvY2Vzcy5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKaW5k ZXggNzM0YzYzNTQ5Y2RjNTVlNjJmNmI3ZWNmYjE2NGZlNzE2MGJlYmE0Yi4uOTU3YWU0Y2YxNmU5 NDA5MmE1MTUyY2M4YmVmZTZlZGI4OTZiYzQxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQcm9jZXNzLmgKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2luY2x1ZGUgIkNhY2hlTW9kZWwuaCIK ICNpbmNsdWRlICJDaGlsZFByb2Nlc3MuaCIKKyNpbmNsdWRlICJEb3dubG9hZE1hbmFnZXIuaCIK ICNpbmNsdWRlICJEcmF3aW5nQXJlYS5oIgogI2luY2x1ZGUgIkV2ZW50RGlzcGF0Y2hlci5oIgog I2luY2x1ZGUgIk1lc3NhZ2VSZWNlaXZlck1hcC5oIgpAQCAtMTA4LDcgKzEwOSw3IEBAIGNsYXNz IE5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbjsKIGNsYXNzIFNlY0l0ZW1SZXNwb25zZURhdGE7CiAj ZW5kaWYKIAotY2xhc3MgV2ViUHJvY2VzcyA6IHB1YmxpYyBDaGlsZFByb2Nlc3MsIHByaXZhdGUg Q29yZUlQQzo6Q29ubmVjdGlvbjo6UXVldWVDbGllbnQgeworY2xhc3MgV2ViUHJvY2VzcyA6IHB1 YmxpYyBDaGlsZFByb2Nlc3MsIHByaXZhdGUgQ29yZUlQQzo6Q29ubmVjdGlvbjo6UXVldWVDbGll bnQsIHByaXZhdGUgRG93bmxvYWRNYW5hZ2VyOjpDbGllbnQgewogcHVibGljOgogICAgIHN0YXRp YyBXZWJQcm9jZXNzJiBzaGFyZWQoKTsKIApAQCAtMjE1LDYgKzIxNiw4IEBAIHB1YmxpYzoKICAg ICB2b2lkIGVuc3VyZVByaXZhdGVCcm93c2luZ1Nlc3Npb24oKTsKICAgICB2b2lkIGRlc3Ryb3lQ cml2YXRlQnJvd3NpbmdTZXNzaW9uKCk7CiAKKyAgICBEb3dubG9hZE1hbmFnZXImIGRvd25sb2Fk TWFuYWdlcigpOworCiBwcml2YXRlOgogICAgIFdlYlByb2Nlc3MoKTsKIAo=