104936 2012-12-13 11:29:12 -0800 Download objects should keep track of their associated DownloadManager object 2012-12-13 21:36:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca haraken kling ktf.kim ryuan.choi sh53.lee oldest_to_newest 790785 0 andersca 2012-12-13 11:29:12 -0800 Download objects should keep track of their associated DownloadManager object 790786 1 179307 andersca 2012-12-13 11:32:29 -0800 Created attachment 179307 Patch 790811 2 andersca 2012-12-13 12:13:03 -0800 Committed r137636: <http://trac.webkit.org/changeset/137636> 791201 3 179307 haraken 2012-12-13 18:16:25 -0800 Comment on attachment 179307 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179307&action=review > Source/WebKit2/WebProcess/Downloads/Download.cpp:-49 > - : m_downloadID(downloadID) What's the rationale for removing this line? See https://bugs.webkit.org/show_bug.cgi?id=104978 791317 4 ktf.kim 2012-12-13 21:36:47 -0800 > Source/WebKit2/WebProcess/Downloads/Download.cpp:-49 > - : m_downloadID(downloadID) The EFL API test failed due to the uninitialized downloadID: 9/53 Test #9: test_ewk2_download_job [ RUN ] EWK2UnitTestBase.ewk_download ASSERTION FAILED: m_downloads.contains(download->downloadID()) Source/WebKit2/WebProcess/Downloads/DownloadManager.cpp(70) : void WebKit::DownloadManager::downloadFinished(WebKit::Download*) 179307 2012-12-13 11:32:29 -0800 2012-12-13 18:16:25 -0800 Patch bug-104936-20121213112950.patch text/plain 5901 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzE2NDcwMWU2ZTYxNjk4 NGFmOTg1NWE0ZjYzNTcxZDA1Yjc5Mzk2Zi4uMDE3MjAzOGI5YzkyNDI0ODY4OGY5OTAyODM0NGUw NzE2NjJhMDkwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTEyLTEzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgRG93bmxvYWQgb2Jq ZWN0cyBzaG91bGQga2VlcCB0cmFjayBvZiB0aGVpciBhc3NvY2lhdGVkIERvd25sb2FkTWFuYWdl ciBvYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNDkzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgaXMgdGhlIGZpcnN0IHN0ZXAgdG93YXJkcyBlbGltaW5hdGluZyBEb3dubG9hZE1hbmFn ZXI6OnNoYXJlZC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkLmNw cDoKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWQ6OmNyZWF0ZSk6CisgICAgICAgIChXZWJLaXQ6 OkRvd25sb2FkOjpEb3dubG9hZCk6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkOjpkaWRGaW5p c2gpOgorICAgICAgICAoV2ViS2l0OjpEb3dubG9hZDo6ZGlkRmFpbCk6CisgICAgICAgIChXZWJL aXQ6OkRvd25sb2FkOjpkaWRDYW5jZWwpOgorICAgICAgICAqIFdlYlByb2Nlc3MvRG93bmxvYWRz L0Rvd25sb2FkLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYW5h Z2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRNYW5hZ2VyOjpzdGFydERvd25sb2Fk KToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRNYW5hZ2VyOjpjb252ZXJ0SGFuZGxlVG9Eb3du bG9hZCk6CisKKzIwMTItMTItMTMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv bT4KKwogICAgICAgICBSZW1vdmUgdW51c2VkIGluaXRpYXRpbmdQYWdlIHBhcmFtZXRlciBmcm9t IGRvd25sb2FkIG9iamVjdHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNDkzMwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L0Rvd25sb2Fkcy9Eb3dubG9hZC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25s b2Fkcy9Eb3dubG9hZC5jcHAKaW5kZXggMWQwNTk0MTVhZjhhYzY2ODMwODE3MmQ0NTkyM2I0ODFj MTZjNWI3ZC4uZDY1MmEwMjUxNDA1ZWZkNWU2ZTk2ZmRkZDA4NTgzOTU4YWEzYmViYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkLmNwcApAQCAt NDAsMTMgKzQwLDEzIEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2Vi S2l0IHsKIAotUGFzc093blB0cjxEb3dubG9hZD4gRG93bmxvYWQ6OmNyZWF0ZSh1aW50NjRfdCBk b3dubG9hZElELCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCitQYXNzT3duUHRyPERv d25sb2FkPiBEb3dubG9hZDo6Y3JlYXRlKERvd25sb2FkTWFuYWdlciYgZG93bmxvYWRNYW5hZ2Vy LCB1aW50NjRfdCBkb3dubG9hZElELCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCiB7 Ci0gICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBEb3dubG9hZChkb3dubG9hZElELCByZXF1ZXN0KSk7 CisgICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBEb3dubG9hZChkb3dubG9hZE1hbmFnZXIsIGRvd25s b2FkSUQsIHJlcXVlc3QpKTsKIH0KIAotRG93bmxvYWQ6OkRvd25sb2FkKHVpbnQ2NF90IGRvd25s b2FkSUQsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKLSAgICA6IG1fZG93bmxvYWRJ RChkb3dubG9hZElEKQorRG93bmxvYWQ6OkRvd25sb2FkKERvd25sb2FkTWFuYWdlciYgZG93bmxv YWRNYW5hZ2VyLCB1aW50NjRfdCBkb3dubG9hZElELCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJl cXVlc3QpCisgICAgOiBtX2Rvd25sb2FkTWFuYWdlcihkb3dubG9hZE1hbmFnZXIpCiAgICAgLCBt X3JlcXVlc3QocmVxdWVzdCkKICNpZiBVU0UoQ0ZORVRXT1JLKQogICAgICwgbV9hbGxvd092ZXJ3 cml0ZShmYWxzZSkKQEAgLTEzNyw3ICsxMzcsOCBAQCB2b2lkIERvd25sb2FkOjpkaWRGaW5pc2go KQogCiAgICAgaWYgKG1fc2FuZGJveEV4dGVuc2lvbikKICAgICAgICAgbV9zYW5kYm94RXh0ZW5z aW9uLT5pbnZhbGlkYXRlKCk7Ci0gICAgRG93bmxvYWRNYW5hZ2VyOjpzaGFyZWQoKS5kb3dubG9h ZEZpbmlzaGVkKHRoaXMpOworCisgICAgbV9kb3dubG9hZE1hbmFnZXIuZG93bmxvYWRGaW5pc2hl ZCh0aGlzKTsKIH0KIAogdm9pZCBEb3dubG9hZDo6ZGlkRmFpbChjb25zdCBSZXNvdXJjZUVycm9y JiBlcnJvciwgY29uc3QgQ29yZUlQQzo6RGF0YVJlZmVyZW5jZSYgcmVzdW1lRGF0YSkKQEAgLTE0 Niw3ICsxNDcsNyBAQCB2b2lkIERvd25sb2FkOjpkaWRGYWlsKGNvbnN0IFJlc291cmNlRXJyb3Im IGVycm9yLCBjb25zdCBDb3JlSVBDOjpEYXRhUmVmZXJlbmNlJgogCiAgICAgaWYgKG1fc2FuZGJv eEV4dGVuc2lvbikKICAgICAgICAgbV9zYW5kYm94RXh0ZW5zaW9uLT5pbnZhbGlkYXRlKCk7Ci0g ICAgRG93bmxvYWRNYW5hZ2VyOjpzaGFyZWQoKS5kb3dubG9hZEZpbmlzaGVkKHRoaXMpOworICAg IG1fZG93bmxvYWRNYW5hZ2VyLmRvd25sb2FkRmluaXNoZWQodGhpcyk7CiB9CiAKIHZvaWQgRG93 bmxvYWQ6OmRpZENhbmNlbChjb25zdCBDb3JlSVBDOjpEYXRhUmVmZXJlbmNlJiByZXN1bWVEYXRh KQpAQCAtMTU1LDcgKzE1Niw3IEBAIHZvaWQgRG93bmxvYWQ6OmRpZENhbmNlbChjb25zdCBDb3Jl SVBDOjpEYXRhUmVmZXJlbmNlJiByZXN1bWVEYXRhKQogCiAgICAgaWYgKG1fc2FuZGJveEV4dGVu c2lvbikKICAgICAgICAgbV9zYW5kYm94RXh0ZW5zaW9uLT5pbnZhbGlkYXRlKCk7Ci0gICAgRG93 bmxvYWRNYW5hZ2VyOjpzaGFyZWQoKS5kb3dubG9hZEZpbmlzaGVkKHRoaXMpOworICAgIG1fZG93 bmxvYWRNYW5hZ2VyLmRvd25sb2FkRmluaXNoZWQodGhpcyk7CiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMv RG93bmxvYWQuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2Fk LmgKaW5kZXggYTlkZTM0ZTQyYWEwNDQ1OWIwMDYyNGFiZDNmZTY2NWViYjA5YzhhYy4uNzczODdi MmNkYjQxNTg0MjBkNjQ0MGZhMTM0ZWJmNzdlMWIzZGUxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWQuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZC5oCkBAIC02Miw2ICs2Miw3IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBEb3dubG9hZEF1dGhl bnRpY2F0aW9uQ2xpZW50OworY2xhc3MgRG93bmxvYWRNYW5hZ2VyOwogY2xhc3MgU2FuZGJveEV4 dGVuc2lvbjsKIGNsYXNzIFdlYlBhZ2U7CiAKQEAgLTcyLDcgKzczLDcgQEAgY2xhc3MgUXRGaWxl RG93bmxvYWRlcjsKIGNsYXNzIERvd25sb2FkIDogcHVibGljIENvcmVJUEM6Ok1lc3NhZ2VTZW5k ZXI8RG93bmxvYWQ+IHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShEb3dubG9hZCk7CiBwdWJs aWM6Ci0gICAgc3RhdGljIFBhc3NPd25QdHI8RG93bmxvYWQ+IGNyZWF0ZSh1aW50NjRfdCBkb3du bG9hZElELCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmKTsKKyAgICBzdGF0aWMgUGFz c093blB0cjxEb3dubG9hZD4gY3JlYXRlKERvd25sb2FkTWFuYWdlciYsIHVpbnQ2NF90IGRvd25s b2FkSUQsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYpOwogICAgIH5Eb3dubG9hZCgp OwogCiAgICAgLy8gVXNlZCBieSBNZXNzYWdlU2VuZGVyLgpAQCAtMTE3LDEyICsxMTgsMTMgQEAg cHVibGljOgogICAgIHZvaWQgY2FuY2VsQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoY29uc3QgV2Vi Q29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmKTsKIAogcHJpdmF0ZToKLSAgICBEb3dubG9h ZCh1aW50NjRfdCBkb3dubG9hZElELCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmKTsK KyAgICBEb3dubG9hZChEb3dubG9hZE1hbmFnZXImLCB1aW50NjRfdCBkb3dubG9hZElELCBjb25z dCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmKTsKIAogICAgIHZvaWQgcGxhdGZvcm1JbnZhbGlk YXRlKCk7CiAKICAgICBTdHJpbmcgcmV0cmlldmVEZXN0aW5hdGlvbldpdGhTdWdnZXN0ZWRGaWxl bmFtZShjb25zdCBTdHJpbmcmIGZpbGVuYW1lLCBib29sJiBhbGxvd092ZXJ3cml0ZSk7CiAKKyAg ICBEb3dubG9hZE1hbmFnZXImIG1fZG93bmxvYWRNYW5hZ2VyOwogICAgIHVpbnQ2NF90IG1fZG93 bmxvYWRJRDsKICAgICBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QgbV9yZXF1ZXN0OwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZE1hbmFn ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYW5h Z2VyLmNwcAppbmRleCA0YjI1Zjc5YTM3ZDcxZjgyMTQ0NmU1NDFiNTEzYjlmZjk1OTUwZmFlLi4w NTk4ZjAzZWM3YTQyOGVlN2U5NGNjYWM4MzhkZDQ3YzNlMDhmMDNkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZE1hbmFnZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5jcHAK QEAgLTQ2LDcgKzQ2LDcgQEAgRG93bmxvYWRNYW5hZ2VyOjpEb3dubG9hZE1hbmFnZXIoKQogCiB2 b2lkIERvd25sb2FkTWFuYWdlcjo6c3RhcnREb3dubG9hZCh1aW50NjRfdCBkb3dubG9hZElELCBj b25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCiB7Ci0gICAgT3duUHRyPERvd25sb2FkPiBk b3dubG9hZCA9IERvd25sb2FkOjpjcmVhdGUoZG93bmxvYWRJRCwgcmVxdWVzdCk7CisgICAgT3du UHRyPERvd25sb2FkPiBkb3dubG9hZCA9IERvd25sb2FkOjpjcmVhdGUoKnRoaXMsIGRvd25sb2Fk SUQsIHJlcXVlc3QpOwogICAgIGRvd25sb2FkLT5zdGFydCgpOwogCiAgICAgQVNTRVJUKCFtX2Rv d25sb2Fkcy5jb250YWlucyhkb3dubG9hZElEKSk7CkBAIC01NSw3ICs1NSw3IEBAIHZvaWQgRG93 bmxvYWRNYW5hZ2VyOjpzdGFydERvd25sb2FkKHVpbnQ2NF90IGRvd25sb2FkSUQsIGNvbnN0IFJl c291cmNlUmVxdWVzdCYKIAogdm9pZCBEb3dubG9hZE1hbmFnZXI6OmNvbnZlcnRIYW5kbGVUb0Rv d25sb2FkKHVpbnQ2NF90IGRvd25sb2FkSUQsIFJlc291cmNlSGFuZGxlKiBoYW5kbGUsIGNvbnN0 IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9u c2UpCiB7Ci0gICAgT3duUHRyPERvd25sb2FkPiBkb3dubG9hZCA9IERvd25sb2FkOjpjcmVhdGUo ZG93bmxvYWRJRCwgcmVxdWVzdCk7CisgICAgT3duUHRyPERvd25sb2FkPiBkb3dubG9hZCA9IERv d25sb2FkOjpjcmVhdGUoKnRoaXMsIGRvd25sb2FkSUQsIHJlcXVlc3QpOwogCiAgICAgZG93bmxv YWQtPnN0YXJ0V2l0aEhhbmRsZShoYW5kbGUsIHJlc3BvbnNlKTsKICAgICBBU1NFUlQoIW1fZG93 bmxvYWRzLmNvbnRhaW5zKGRvd25sb2FkSUQpKTsK