104931 2012-12-13 10:18:18 -0800 [GTK] Safeguard against possible NULL-dereference 2013-01-16 10:01:46 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 0 csaavedra webkit-unassigned aboxhall apinheiro cfleizach dmazzoni jdiggs webkit.review.bot oldest_to_newest 790725 0 csaavedra 2012-12-13 10:18:18 -0800 [GTK] Safeguard against possible NULL-dereference 790728 1 179298 csaavedra 2012-12-13 10:19:56 -0800 Created attachment 179298 Patch 790798 2 179298 webkit.review.bot 2012-12-13 11:52:52 -0800 Comment on attachment 179298 Patch Clearing flags on attachment: 179298 Committed r137633: <http://trac.webkit.org/changeset/137633> 790799 3 webkit.review.bot 2012-12-13 11:52:55 -0800 All reviewed patches have been landed. Closing bug. 808262 4 csaavedra 2013-01-16 04:14:05 -0800 The patch is actually broken as it doesn't let the other cases be handled. I'll attach a sane version now, sorry for this. 808270 5 182959 csaavedra 2013-01-16 04:24:28 -0800 Created attachment 182959 Patch 808323 6 182959 mrobinson 2013-01-16 06:17:15 -0800 Comment on attachment 182959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182959&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:412 > - if (!parent) > - return -1; > - > if (!parent && isRootObject(coreObject)) { > AtkObject* atkParent = atkParentOfRootObject(object); > if (!atkParent) Looks good to me, but I'd like Joanie or Mario to do an unofficial review here. 808332 7 jdiggs 2013-01-16 06:24:49 -0800 (In reply to comment #6) > Looks good to me, but I'd like Joanie or Mario to do an unofficial review here. Looks good to me as well. Thanks for doing it Claudio!! 808467 8 182959 webkit.review.bot 2013-01-16 10:01:42 -0800 Comment on attachment 182959 Patch Clearing flags on attachment: 182959 Committed r139890: <http://trac.webkit.org/changeset/139890> 808468 9 webkit.review.bot 2013-01-16 10:01:46 -0800 All reviewed patches have been landed. Closing bug. 179298 2012-12-13 10:19:56 -0800 2013-01-16 04:24:22 -0800 Patch bug-104931-20121213191715.patch text/plain 1569 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWY5ZjJhYzAzNWEyZDIx YWE1ZGFkMDIxZmM5YjMyMjdjMjc3Yjg2YS4uODNhZTM1ZTk5ZDFlODZhMmI4MzA0MDYyZmQ1MTU1 OWY4ZmZjMDc5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTEzICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gU2Fm ZWd1YXJkIGFnYWluc3QgcG9zc2libGUgTlVMTC1kZXJlZmVyZW5jZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0OTMxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3YXMgc3BvdHRlZCBieSBDb3Zl cml0eS4gU2VlIGJ1ZyAxMDQxMTQuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJL aXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRBY2Nlc3NpYmxlR2V0 SW5kZXhJblBhcmVudCk6IElmIHBhcmVudCBpcyBOVUxMCisgICAgICAgIGJhaWwgb3V0IGVhcmx5 LgorCiAyMDEyLTEyLTEzICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBFeHBvc2UgQVJJQSByb2xlcyBmb3IgdGFiLCB0YWJwYW5lbCBhbmQgdGFi bGlzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0 QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9h dGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCmluZGV4IDU5OTFhZjcxMzcwNjNkMWI0 MzgzZmNkMjdiY2ZiZWI3NWNlNTRjYTYuLmQyOWYxOTJjMTVhMGY2ODI1OTdiMGM5YzEzZjM5NTY3 OThmODVjMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dl YktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKQEAgLTQwNyw2ICs0MDcs OSBAQCBzdGF0aWMgZ2ludCB3ZWJraXRBY2Nlc3NpYmxlR2V0SW5kZXhJblBhcmVudChBdGtPYmpl Y3QqIG9iamVjdCkKICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0ID0gY29yZShv YmplY3QpOwogICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIHBhcmVudCA9IGNvcmVPYmplY3QtPnBh cmVudE9iamVjdFVuaWdub3JlZCgpOwogCisgICAgaWYgKCFwYXJlbnQpCisgICAgICAgIHJldHVy biAtMTsKKwogICAgIGlmICghcGFyZW50ICYmIGlzUm9vdE9iamVjdChjb3JlT2JqZWN0KSkgewog ICAgICAgICBBdGtPYmplY3QqIGF0a1BhcmVudCA9IGF0a1BhcmVudE9mUm9vdE9iamVjdChvYmpl Y3QpOwogICAgICAgICBpZiAoIWF0a1BhcmVudCkK 182959 2013-01-16 04:24:28 -0800 2013-01-16 10:01:42 -0800 Patch bug-104931-20130116142129.patch text/plain 1883 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA5NzVkZGRlOTkxMzE2 ZmZmOWVhMThmMmI5ZTA5NTBiY2JhY2YyZi4uMzFiYzFjNTUzNTJhNzkzODEzNDg0NTA5MGZhMjkx OTQ1MmM4MmYyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTE2ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gU2Fm ZWd1YXJkIGFnYWluc3QgcG9zc2libGUgTlVMTC1kZXJlZmVyZW5jZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0OTMxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJL aXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRBY2Nlc3NpYmxlR2V0 SW5kZXhJblBhcmVudCk6IE1vdmUgdGhlIE5VTEwtc2FmZWd1YXJkIHRvIGEKKyAgICAgICAgcGxh Y2Ugd2hlcmUgaXQgYWN0dWFsbHkgbWFrZXMgc2Vuc2UuCisKIDIwMTMtMDEtMTYgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgR2V0IHJpZCBvZiBOb2RlOjpjcmVh dGVSYXJlRGF0YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsv V2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCmluZGV4IGYyODRiMjUzNmM3 ODViMzg0YTY0MTNhN2ZhNjcwNjI0ZjNmNTVlZjEuLmU0NmM4NmRkNzEwYjhhY2EwMWE2ODAzZjkz Mzg4M2NiODQyNmRlMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv YXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKQEAgLTQwNyw5 ICs0MDcsNiBAQCBzdGF0aWMgZ2ludCB3ZWJraXRBY2Nlc3NpYmxlR2V0SW5kZXhJblBhcmVudChB dGtPYmplY3QqIG9iamVjdCkKICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0ID0g Y29yZShvYmplY3QpOwogICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIHBhcmVudCA9IGNvcmVPYmpl Y3QtPnBhcmVudE9iamVjdFVuaWdub3JlZCgpOwogCi0gICAgaWYgKCFwYXJlbnQpCi0gICAgICAg IHJldHVybiAtMTsKLQogICAgIGlmICghcGFyZW50ICYmIGlzUm9vdE9iamVjdChjb3JlT2JqZWN0 KSkgewogICAgICAgICBBdGtPYmplY3QqIGF0a1BhcmVudCA9IGF0a1BhcmVudE9mUm9vdE9iamVj dChvYmplY3QpOwogICAgICAgICBpZiAoIWF0a1BhcmVudCkKQEAgLTQzMCw2ICs0MjcsOSBAQCBz dGF0aWMgZ2ludCB3ZWJraXRBY2Nlc3NpYmxlR2V0SW5kZXhJblBhcmVudChBdGtPYmplY3QqIG9i amVjdCkKICAgICBpZiAocGFyZW50ICYmIHBhcmVudC0+aXNUYWJsZVJvdygpICYmIGNvcmVPYmpl Y3QtPmlzVGFibGVDZWxsKCkpCiAgICAgICAgIHJldHVybiBnZXRJbmRleEluUGFyZW50Rm9yQ2Vs bEluUm93KGNvcmVPYmplY3QpOwogCisgICAgaWYgKCFwYXJlbnQpCisgICAgICAgIHJldHVybiAt MTsKKwogICAgIHNpemVfdCBpbmRleCA9IHBhcmVudC0+Y2hpbGRyZW4oKS5maW5kKGNvcmVPYmpl Y3QpOwogICAgIHJldHVybiAoaW5kZXggPT0gV1RGOjpub3RGb3VuZCkgPyAtMSA6IGluZGV4Owog fQo=