104902 2012-12-13 04:14:04 -0800 Web Inspector: "Add Attribute" context menu on closing tag should apply on the opening tag on Elements Panel 2012-12-13 07:25:26 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vivekg vivek.vg apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 790488 0 vivekg 2012-12-13 04:14:04 -0800 Web Inspector: "Add Attribute" context menu shouldn't appear on closing tag on Elements Panel. Steps: 1. Open any page with inspector open 2. Navigate to Elements panel 3. Expand some nodes so you can view the closing tag separately 4. Perform action (right click for linux/windows) to open context menu on the Closing Tag. 5. "Add Attribute" context menu item is shown 6. Go ahead with adding some attribute value 7. The attribute is seen even on the closing tag e.g. <div id="test"> ... </div id="test"> Expected: The "Add Attribute" on a closing tag shouldn't be shown Patch to follow. 790489 1 179247 vivekg 2012-12-13 04:17:28 -0800 Created attachment 179247 Patch 790492 2 apavlov 2012-12-13 04:26:19 -0800 Perhaps, instead of forbidding to add attributes on the closing tag, we might automatically add them to the opening tag? If |this| is the closing tag, you can bind this._addNewAttribute() to the opening tag using this.findTreeElement(this.representedObject), something like this: contextMenu.appendItem(..., this._addNewAttribute.bind(this._elementCloseTag ? this.treeOutline.findTreeElement(this.representedObject) : this)); 790513 3 179252 vivek.vg 2012-12-13 04:59:27 -0800 Created attachment 179252 Patch 790515 4 179252 apavlov 2012-12-13 05:05:42 -0800 Comment on attachment 179252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179252&action=review The code looks good, just a minor ChangeLog fix is needed. > Source/WebCore/ChangeLog:8 > + The context menu action on the Closing Tag takes to the Opening tag for adding the attribute. There should be no caps in the middle of the sentence. Also, "takes" -> "scrolls to" > Source/WebCore/ChangeLog:10 > + No new tests as UI tweak. No new tests, as this is a UI change. (I've seen a guideline somewhere that imposes the use of common English rather than slang-ish/ambiguous terms, like "tweak".) 790555 5 179264 vivek.vg 2012-12-13 06:41:04 -0800 Created attachment 179264 Patch 790562 6 179264 apavlov 2012-12-13 06:52:18 -0800 Comment on attachment 179264 Patch r=me 790596 7 179264 webkit.review.bot 2012-12-13 07:25:22 -0800 Comment on attachment 179264 Patch Clearing flags on attachment: 179264 Committed r137594: <http://trac.webkit.org/changeset/137594> 790597 8 webkit.review.bot 2012-12-13 07:25:26 -0800 All reviewed patches have been landed. Closing bug. 179247 2012-12-13 04:17:28 -0800 2012-12-13 04:59:22 -0800 Patch bug-104902-20121213174533.patch text/plain 2113 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjY0OTVjYTg5MTU1NjFk NmY0YWY0OTdiZWQ1YjYyMjQ1MjMwNTJjZS4uYjEyYmYyOTYwMTQxYWQzNzUyOTU4Y2I1MzljZjI5 ZDBiNzkyMjhhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTEzICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6ICJBZGQgQXR0cmlidXRlIiBjb250ZXh0IG1lbnUgc2hvdWxkbid0IGFwcGVhciBvbiBjbG9z aW5nIHRhZyBvbiBFbGVtZW50cyBQYW5lbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA0OTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIGNvbnRleHQgbWVudSBpdGVtICJBZGQgQXR0cmlidXRlIiBz aG91bGQgbm90IGJlIGFkZGVkIGZvciB0aGUgY2xvc2luZyB0YWdzLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBhcyBVSSByZWxhdGVkIHR3ZWFrLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1l bnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl9wb3B1bGF0ZVRhZ0NvbnRleHRNZW51KToKKwogMjAx Mi0xMi0xMiAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4g UGx1Z0luT3JpZ2luSGFzaCB3aXRoIGVtcHR5IE1JTUUgdHlwZSAoMTA0ODgyKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5l LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRs aW5lLmpzCmluZGV4IDBmMzQwZmM5YjJhYTZmZjM1ODVlMmU2YjQ2MzFlNTRkMjFhMWRjZjUuLjdh M2E4OGVmNWMzMmZmZjU3ZmIzMmJjZmZkZjY4NzEwNjUxMDAwNTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUu anMKQEAgLTExODQsNyArMTE4NCw4IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50 LnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIG5ld0F0dHJpYnV0ZSA9IGV2ZW50LnRhcmdldC5l bmNsb3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJhZGQtYXR0cmlidXRlIik7CiAKICAgICAgICAg Ly8gQWRkIGF0dHJpYnV0ZS1yZWxhdGVkIGFjdGlvbnMuCi0gICAgICAgIGNvbnRleHRNZW51LmFw cGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKFdlYkluc3BlY3Rvci51c2VMb3dlckNhc2VN ZW51VGl0bGVzKCkgPyAiQWRkIGF0dHJpYnV0ZSIgOiAiQWRkIEF0dHJpYnV0ZSIpLCB0aGlzLl9h ZGROZXdBdHRyaWJ1dGUuYmluZCh0aGlzKSk7CisgICAgICAgIGlmICghdGhpcy5fZWxlbWVudENs b3NlVGFnKQorICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoV2ViSW5zcGVjdG9yLnVzZUxvd2VyQ2FzZU1lbnVUaXRsZXMoKSA/ICJBZGQgYXR0 cmlidXRlIiA6ICJBZGQgQXR0cmlidXRlIiksIHRoaXMuX2FkZE5ld0F0dHJpYnV0ZS5iaW5kKHRo aXMpKTsKICAgICAgICAgaWYgKGF0dHJpYnV0ZSAmJiAhbmV3QXR0cmlidXRlKQogICAgICAgICAg ICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoV2ViSW5zcGVj dG9yLnVzZUxvd2VyQ2FzZU1lbnVUaXRsZXMoKSA/ICJFZGl0IGF0dHJpYnV0ZSIgOiAiRWRpdCBB dHRyaWJ1dGUiKSwgdGhpcy5fc3RhcnRFZGl0aW5nQXR0cmlidXRlLmJpbmQodGhpcywgYXR0cmli dXRlLCBldmVudC50YXJnZXQpKTsKICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9y KCk7Cg== 179252 2012-12-13 04:59:27 -0800 2012-12-13 06:40:57 -0800 Patch bug-104902-20121213182732.patch text/plain 2613 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjY0OTVjYTg5MTU1NjFk NmY0YWY0OTdiZWQ1YjYyMjQ1MjMwNTJjZS4uNzkyMDZhMWM5ODRkNDg3YzFhOTMzMzQ4ZWY5MTgy ODgxMGJiYzIwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTEzICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6ICJBZGQgQXR0cmlidXRlIiBjb250ZXh0IG1lbnUgb24gY2xvc2luZyB0YWcgc2hvdWxkIGFw cGx5IG9uIHRoZSBvcGVuaW5nIHRhZyBvbiBFbGVtZW50cyBQYW5lbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0OTAyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvbnRleHQgbWVudSBhY3Rpb24g b24gdGhlIENsb3NpbmcgVGFnIHRha2VzIHRvIHRoZSBPcGVuaW5nIHRhZyBmb3IgYWRkaW5nIHRo ZSBhdHRyaWJ1dGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIFVJIHR3ZWFrLgorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl9wb3B1bGF0ZVRh Z0NvbnRleHRNZW51KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50 LnByb3RvdHlwZS5fYWRkTmV3QXR0cmlidXRlKToKKwogMjAxMi0xMi0xMiAgSm9uIExlZSAgPGpv bmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gUGx1Z0luT3JpZ2luSGFzaCB3aXRo IGVtcHR5IE1JTUUgdHlwZSAoMTA0ODgyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCmluZGV4IDBmMzQwZmM5 YjJhYTZmZjM1ODVlMmU2YjQ2MzFlNTRkMjFhMWRjZjUuLmMxYzI3NWU5OWI4MjRhYTM5MTg5MDIw Y2U2MjMwZmY0NDg1MWM5NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKQEAgLTExODQsNyArMTE4NCw4 IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAg ICAgdmFyIG5ld0F0dHJpYnV0ZSA9IGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0 aENsYXNzKCJhZGQtYXR0cmlidXRlIik7CiAKICAgICAgICAgLy8gQWRkIGF0dHJpYnV0ZS1yZWxh dGVkIGFjdGlvbnMuCi0gICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9y LlVJU3RyaW5nKFdlYkluc3BlY3Rvci51c2VMb3dlckNhc2VNZW51VGl0bGVzKCkgPyAiQWRkIGF0 dHJpYnV0ZSIgOiAiQWRkIEF0dHJpYnV0ZSIpLCB0aGlzLl9hZGROZXdBdHRyaWJ1dGUuYmluZCh0 aGlzKSk7CisgICAgICAgIHZhciB0cmVlRWxlbWVudCA9IHRoaXMuX2VsZW1lbnRDbG9zZVRhZyA/ IHRoaXMudHJlZU91dGxpbmUuZmluZFRyZWVFbGVtZW50KHRoaXMucmVwcmVzZW50ZWRPYmplY3Qp IDogdGhpczsKKyAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlT dHJpbmcoV2ViSW5zcGVjdG9yLnVzZUxvd2VyQ2FzZU1lbnVUaXRsZXMoKSA/ICJBZGQgYXR0cmli dXRlIiA6ICJBZGQgQXR0cmlidXRlIiksIHRoaXMuX2FkZE5ld0F0dHJpYnV0ZS5iaW5kKHRyZWVF bGVtZW50KSk7CiAgICAgICAgIGlmIChhdHRyaWJ1dGUgJiYgIW5ld0F0dHJpYnV0ZSkKICAgICAg ICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKFdlYklu c3BlY3Rvci51c2VMb3dlckNhc2VNZW51VGl0bGVzKCkgPyAiRWRpdCBhdHRyaWJ1dGUiIDogIkVk aXQgQXR0cmlidXRlIiksIHRoaXMuX3N0YXJ0RWRpdGluZ0F0dHJpYnV0ZS5iaW5kKHRoaXMsIGF0 dHJpYnV0ZSwgZXZlbnQudGFyZ2V0KSk7CiAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFy YXRvcigpOwpAQCAtMTI2Miw2ICsxMjYzLDcgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVs ZW1lbnQucHJvdG90eXBlID0gewogCiAgICAgICAgIHZhciB0YWcgPSB0aGlzLmxpc3RJdGVtRWxl bWVudC5nZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCJ3ZWJraXQtaHRtbC10YWciKVswXTsKICAgICAg ICAgdGhpcy5faW5zZXJ0SW5MYXN0QXR0cmlidXRlUG9zaXRpb24odGFnLCBhdHRyKTsKKyAgICAg ICAgYXR0ci5zY3JvbGxJbnRvVmlld0lmTmVlZGVkKHRydWUpOwogICAgICAgICByZXR1cm4gdGhp cy5fc3RhcnRFZGl0aW5nQXR0cmlidXRlKGF0dHIsIGF0dHIpOwogICAgIH0sCiAK 179264 2012-12-13 06:41:04 -0800 2012-12-13 07:25:22 -0800 Patch bug-104902-20121213200823.patch text/plain 2612 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgxYTEzOWM3NWYzNmYz MDRhMTRkMWIzYTM1NDc0OWEyNDIzMzQxNy4uNmRiZTQ1NjZiMjYyZTIxNTExNGU3OTI4NmFmZmUw NDE5N2U4ZmVkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTEzICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6ICJBZGQgQXR0cmlidXRlIiBjb250ZXh0IG1lbnUgb24gY2xvc2luZyB0YWcgc2hvdWxkIGFw cGx5IG9uIHRoZSBvcGVuaW5nIHRhZyBvbiBFbGVtZW50cyBQYW5lbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0OTAyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvbnRleHQgbWVudSBhY3Rpb24g b24gdGhlIGNsb3NpbmcgdGFnIHNjcm9sbHMgdG8gdGhlIG9wZW5pbmcgdGFnIGZvciBhZGRpbmcg dGhlIGF0dHJpYnV0ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBpcyBhIFVJIGNo YW5nZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGlu ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlw ZS5fcG9wdWxhdGVUYWdDb250ZXh0TWVudSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVu dHNUcmVlRWxlbWVudC5wcm90b3R5cGUuX2FkZE5ld0F0dHJpYnV0ZSk6CisKIDIwMTItMTItMTMg IEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIERv bid0IGxlYWsgR1N0YXRpY1JlY011dGV4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKaW5kZXggMGYzNDBmYzli MmFhNmZmMzU4NWUyZTZiNDYzMWU1NGQyMWExZGNmNS4uYzFjMjc1ZTk5YjgyNGFhMzkxODkwMjBj ZTYyMzBmZjQ0ODUxYzk1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwpAQCAtMTE4NCw3ICsxMTg0LDgg QEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAg ICB2YXIgbmV3QXR0cmlidXRlID0gZXZlbnQudGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRo Q2xhc3MoImFkZC1hdHRyaWJ1dGUiKTsKIAogICAgICAgICAvLyBBZGQgYXR0cmlidXRlLXJlbGF0 ZWQgYWN0aW9ucy4KLSAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoV2ViSW5zcGVjdG9yLnVzZUxvd2VyQ2FzZU1lbnVUaXRsZXMoKSA/ICJBZGQgYXR0 cmlidXRlIiA6ICJBZGQgQXR0cmlidXRlIiksIHRoaXMuX2FkZE5ld0F0dHJpYnV0ZS5iaW5kKHRo aXMpKTsKKyAgICAgICAgdmFyIHRyZWVFbGVtZW50ID0gdGhpcy5fZWxlbWVudENsb3NlVGFnID8g dGhpcy50cmVlT3V0bGluZS5maW5kVHJlZUVsZW1lbnQodGhpcy5yZXByZXNlbnRlZE9iamVjdCkg OiB0aGlzOworICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0 cmluZyhXZWJJbnNwZWN0b3IudXNlTG93ZXJDYXNlTWVudVRpdGxlcygpID8gIkFkZCBhdHRyaWJ1 dGUiIDogIkFkZCBBdHRyaWJ1dGUiKSwgdGhpcy5fYWRkTmV3QXR0cmlidXRlLmJpbmQodHJlZUVs ZW1lbnQpKTsKICAgICAgICAgaWYgKGF0dHJpYnV0ZSAmJiAhbmV3QXR0cmlidXRlKQogICAgICAg ICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoV2ViSW5z cGVjdG9yLnVzZUxvd2VyQ2FzZU1lbnVUaXRsZXMoKSA/ICJFZGl0IGF0dHJpYnV0ZSIgOiAiRWRp dCBBdHRyaWJ1dGUiKSwgdGhpcy5fc3RhcnRFZGl0aW5nQXR0cmlidXRlLmJpbmQodGhpcywgYXR0 cmlidXRlLCBldmVudC50YXJnZXQpKTsKICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJh dG9yKCk7CkBAIC0xMjYyLDYgKzEyNjMsNyBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxl bWVudC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgdmFyIHRhZyA9IHRoaXMubGlzdEl0ZW1FbGVt ZW50LmdldEVsZW1lbnRzQnlDbGFzc05hbWUoIndlYmtpdC1odG1sLXRhZyIpWzBdOwogICAgICAg ICB0aGlzLl9pbnNlcnRJbkxhc3RBdHRyaWJ1dGVQb3NpdGlvbih0YWcsIGF0dHIpOworICAgICAg ICBhdHRyLnNjcm9sbEludG9WaWV3SWZOZWVkZWQodHJ1ZSk7CiAgICAgICAgIHJldHVybiB0aGlz Ll9zdGFydEVkaXRpbmdBdHRyaWJ1dGUoYXR0ciwgYXR0cik7CiAgICAgfSwKIAo=