104901 2012-12-13 04:05:05 -0800 [GTK] Don't leak GStaticRecMutex 2012-12-13 06:03:18 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 0 berto webkit-unassigned dglazkov eric.carlson feature-media-reviews levin+threading pnormand webkit.review.bot oldest_to_newest 790486 0 berto 2012-12-13 04:05:05 -0800 There's a GStaticRecMutex allocated in webkit_web_audio_src_init(), but it's never freed. 790494 1 179249 berto 2012-12-13 04:29:06 -0800 Created attachment 179249 Patch 790496 2 179249 mrobinson 2012-12-13 04:31:31 -0800 Comment on attachment 179249 Patch Nice catch. 790520 3 179249 webkit.review.bot 2012-12-13 05:12:47 -0800 Comment on attachment 179249 Patch Attachment 179249 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15314239 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 790536 4 179249 webkit.review.bot 2012-12-13 06:03:14 -0800 Comment on attachment 179249 Patch Clearing flags on attachment: 179249 Committed r137587: <http://trac.webkit.org/changeset/137587> 790537 5 webkit.review.bot 2012-12-13 06:03:18 -0800 All reviewed patches have been landed. Closing bug. 179249 2012-12-13 04:29:06 -0800 2012-12-13 06:03:14 -0800 Patch mutex.diff text/plain 2621 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MDljZjk2Li5lZDgwMWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMTItMTMgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIERvbid0IGxlYWsgR1N0YXRpY1JlY011dGV4CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ5MDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbXV0ZXggaW4gV2ViS2l0V2ViQXVk aW9Tb3VyY2VHU3RyZWFtZXIgaXMgYWxsb2NhdGVkIHVzaW5nCisgICAgICAgIGdfbmV3KCksIGJ1 dCB0aGF0IG1lbW9yeSBpcyBub3QgZnJlZWQgd2hlbiB0aGUgb2JqZWN0IGlzCisgICAgICAgIGRl c3Ryb3llZC4KKworICAgICAgICBUaGlzIHBhdGNoIHJlcGxhY2VzIHRoYXQgcG9pbnRlciB3aXRo IHRoZSBzdHJ1Y3R1cmUgaXRzZWxmLCB3aGljaAorICAgICAgICBpcyBmYXN0ZXIgYW5kIGRvZXNu J3QgbmVlZCB0byBiZSBleHBsaWNpdGx5IGZyZWVkLgorCisgICAgICAgICogcGxhdGZvcm0vYXVk aW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAg KF9XZWJLaXRXZWJBdWRpb1NvdXJjZVByaXZhdGUpOgorICAgICAgICAod2Via2l0X3dlYl9hdWRp b19zcmNfaW5pdCk6CisgICAgICAgICh3ZWJLaXRXZWJBdWRpb1NyY0ZpbmFsaXplKToKKwogMjAx Mi0xMi0xMSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJFR1JFU1NJT04ocjEzNjk0OCk6IGluc3BlY3Rvci9zdHlsZXMvaW1wb3J0LXBzZXVkb2Ns YXNzLWNyYXNoLmh0bWwgaGl0cyBhbiBhc3NlcnRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1l ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2Vi QXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4IDU4M2MxM2EuLjgyNzdmMjYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRp b1NvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcApAQCAtNTUsNyArNTUs NyBAQCBzdHJ1Y3QgX1dlYktpdFdlYkF1ZGlvU291cmNlUHJpdmF0ZSB7CiAgICAgR1JlZlB0cjxH c3RFbGVtZW50PiB3YXZFbmNvZGVyOwogCiAgICAgR1JlZlB0cjxHc3RUYXNrPiB0YXNrOwotICAg IEdTdGF0aWNSZWNNdXRleCogbXV0ZXg7CisgICAgR1N0YXRpY1JlY011dGV4IG11dGV4OwogCiAg ICAgR1NMaXN0KiBwYWRzOyAvLyBMaXN0IG9mIHF1ZXVlIHNpbmsgcGFkcy4gT25lIHF1ZXVlIGZv ciBlYWNoIHBsYW5hciBhdWRpbyBjaGFubmVsLgogICAgIEdzdFBhZCogc291cmNlUGFkOyAvLyBz cmMgcGFkIG9mIHRoZSBlbGVtZW50LCBpbnRlcmxlYXZlZCB3YXYgZGF0YSBpcyBwdXNoZWQgdG8g aXQuCkBAIC0xODUsMTEgKzE4NSwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2F1ZGlvX3Ny Y19pbml0KFdlYktpdFdlYkF1ZGlvU3JjKiBzcmMpCiAgICAgcHJpdi0+cHJvdmlkZXIgPSAwOwog ICAgIHByaXYtPmJ1cyA9IDA7CiAKLSAgICBwcml2LT5tdXRleCA9IGdfbmV3KEdTdGF0aWNSZWNN dXRleCwgMSk7Ci0gICAgZ19zdGF0aWNfcmVjX211dGV4X2luaXQocHJpdi0+bXV0ZXgpOworICAg IGdfc3RhdGljX3JlY19tdXRleF9pbml0KCZwcml2LT5tdXRleCk7CiAKICAgICBwcml2LT50YXNr ID0gZ3N0X3Rhc2tfY3JlYXRlKHJlaW50ZXJwcmV0X2Nhc3Q8R3N0VGFza0Z1bmN0aW9uPih3ZWJL aXRXZWJBdWRpb1NyY0xvb3ApLCBzcmMpOwotICAgIGdzdF90YXNrX3NldF9sb2NrKHByaXYtPnRh c2suZ2V0KCksIHByaXYtPm11dGV4KTsKKyAgICBnc3RfdGFza19zZXRfbG9jayhwcml2LT50YXNr LmdldCgpLCAmcHJpdi0+bXV0ZXgpOwogfQogCiBzdGF0aWMgdm9pZCB3ZWJLaXRXZWJBdWRpb1Ny Y0NvbnN0cnVjdGVkKEdPYmplY3QqIG9iamVjdCkKQEAgLTI1NCw3ICsyNTMsNyBAQCBzdGF0aWMg dm9pZCB3ZWJLaXRXZWJBdWRpb1NyY0ZpbmFsaXplKEdPYmplY3QqIG9iamVjdCkKICAgICBXZWJL aXRXZWJBdWRpb1NyYyogc3JjID0gV0VCS0lUX1dFQl9BVURJT19TUkMob2JqZWN0KTsKICAgICBX ZWJLaXRXZWJBdWRpb1NvdXJjZVByaXZhdGUqIHByaXYgPSBzcmMtPnByaXY7CiAKLSAgICBnX3N0 YXRpY19yZWNfbXV0ZXhfZnJlZShwcml2LT5tdXRleCk7CisgICAgZ19zdGF0aWNfcmVjX211dGV4 X2ZyZWUoJnByaXYtPm11dGV4KTsKIAogICAgIGdfc2xpc3RfZnJlZV9mdWxsKHByaXYtPnBhZHMs IHJlaW50ZXJwcmV0X2Nhc3Q8R0Rlc3Ryb3lOb3RpZnk+KGdzdF9vYmplY3RfdW5yZWYpKTsKIAo=