104896 2012-12-13 02:58:34 -0800 [Tools] Add exception for gtk_style_context_get() 2012-12-13 04:03:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 csaavedra webkit-unassigned webkit.review.bot oldest_to_newest 790452 0 csaavedra 2012-12-13 02:58:34 -0800 This method needs a NULL sentinel. Shut the checker up. 790453 1 179241 csaavedra 2012-12-13 02:59:50 -0800 Created attachment 179241 2012-12-13 Claudio Saavedra <csaavedra@igalia.com> [Tools] Add exception for gtk_style_context_get() https://bugs.webkit.org/show_bug.cgi?id=104896 Reviewed by NOBODY (OOPS!). Add new exception for gtk_style_context_get(). * Scripts/webkitpy/style/checkers/cpp.py: (check_for_null): Add exception for gtk_style_context_get(). 790462 2 179242 csaavedra 2012-12-13 03:10:41 -0800 Created attachment 179242 [Tools] Add exception for gtk_style_context_get() https://bugs.webkit.org/show_bug.cgi?id=104896 Reviewed by NOBODY (OOPS!). Add new exception for gtk_style_context_get(). * Scripts/webkitpy/style/checkers/cpp.py: (check_for_null): Add exception for gtk_style_context_get(). 790482 3 179242 webkit.review.bot 2012-12-13 04:03:37 -0800 Comment on attachment 179242 [Tools] Add exception for gtk_style_context_get() https://bugs.webkit.org/show_bug.cgi?id=104896 Clearing flags on attachment: 179242 Committed r137583: <http://trac.webkit.org/changeset/137583> 790483 4 webkit.review.bot 2012-12-13 04:03:41 -0800 All reviewed patches have been landed. Closing bug. 179241 2012-12-13 02:59:50 -0800 2012-12-13 03:10:41 -0800 2012-12-13 Claudio Saavedra <csaavedra@igalia.com> 2012-12-13-Claudio-Saavedra-csaavedraigaliacom.patch text/plain 2383 csaavedra RnJvbSA2YWQzY2EyMzcwZjE1NDhhNjM2YjIwNTgxNzM4NzFhNGNiYzhiMzdmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDbGF1ZGlvIFNhYXZlZHJhIDxjc2FhdmVkcmFAaWdhbGlhLmNv bT4KRGF0ZTogVGh1LCAxMyBEZWMgMjAxMiAxMTo1NjoyOCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IDIwMTItMTItMTMgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KCiAg ICAgICAgW1Rvb2xzXSBBZGQgZXhjZXB0aW9uIGZvciBndGtfc3R5bGVfY29udGV4dF9nZXQoKQog ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ4OTYKCiAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFkZCBuZXcgZXhjZXB0 aW9uIGZvciBndGtfc3R5bGVfY29udGV4dF9nZXQoKS4KCiAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKICAgICAgICAoY2hlY2tfZm9yX251bGwpOiBBZGQg ZXhjZXB0aW9uIGZvciBndGtfc3R5bGVfY29udGV4dF9nZXQoKS4KLS0tCiBUb29scy9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgfCAgNCArKy0tCiAyIGZpbGVz IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDkyYWViNzQuLjJkY2JkNTcg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0xMi0xMyAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtUb29sc10gQWRkIGV4Y2VwdGlvbiBmb3IgZ3RrX3N0eWxlX2Nv bnRleHRfZ2V0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNDg5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBuZXcgZXhjZXB0aW9uIGZvciBndGtfc3R5bGVfY29udGV4dF9nZXQoKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAo Y2hlY2tfZm9yX251bGwpOiBBZGQgZXhjZXB0aW9uIGZvciBndGtfc3R5bGVfY29udGV4dF9nZXQo KS4KKwogMjAxMi0xMi0xMyAgWGluZ25hbiBXYW5nICA8eGluZ25hbi53YW5nQGludGVsLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLiBBZGRpbmcgbXlzZWxmIHRvIGNvbW1pdHRlcnMgbGlzdC4K ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggYTAz Mjg0YS4uZWRhOGJiYiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKQEAgLTI1NDcsOCArMjU0Nyw4IEBAIGRlZiBjaGVja19mb3JfbnVsbChjbGVhbl9s aW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKToKICAgICBpZiBzZWFyY2gocidc Ymdka19waXhidWZfc2F2ZV90b1x3K1xiJywgbGluZSk6CiAgICAgICAgIHJldHVybgogCi0gICAg IyBEb24ndCB3YXJuIGFib3V0IE5VTEwgdXNhZ2UgaW4gZ3RrX3dpZGdldF9zdHlsZV9nZXQoKSBv ciBndGtfc3R5bGVfY29udGV4dF9nZXRfc3R5bGUuIFNlZSBCdWcgNTE3NTgKLSAgICBpZiBzZWFy Y2gocidcYmd0a193aWRnZXRfc3R5bGVfZ2V0XChcdytcYicsIGxpbmUpIG9yIHNlYXJjaChyJ1xi Z3RrX3N0eWxlX2NvbnRleHRfZ2V0X3N0eWxlXChcdytcYicsIGxpbmUpOgorICAgICMgRG9uJ3Qg d2FybiBhYm91dCBOVUxMIHVzYWdlIGluIGd0a193aWRnZXRfc3R5bGVfZ2V0KCksIGd0a19zdHls ZV9jb250ZXh0X2dldF9zdHlsZSgpLCBvciBndGtfc3R5bGVfY29udGV4dF9nZXQoKS4gU2VlIEJ1 ZyA1MTc1OAorICAgIGlmIHNlYXJjaChyJ1xiZ3RrX3dpZGdldF9zdHlsZV9nZXRcKFx3K1xiJywg bGluZSkgb3Igc2VhcmNoKHInXGJndGtfc3R5bGVfY29udGV4dF9nZXRfc3R5bGVcKFx3K1xiJywg bGluZSkgb3Igc2VhcmNoKHInXGJndGtfc3R5bGVfY29udGV4dF9nZXRcKFx3K1xiJywgbGluZSk6 CiAgICAgICAgIHJldHVybgogCiAgICAgIyBEb24ndCB3YXJuIGFib3V0IE5VTEwgdXNhZ2UgaW4g c291cF9zZXJ2ZXJfbmV3KCkuIFNlZSBCdWcgNzc4OTAuCi0tIAoxLjcuMTEuNw== 179242 2012-12-13 03:10:41 -0800 2012-12-13 04:03:37 -0800 [Tools] Add exception for gtk_style_context_get() https://bugs.webkit.org/show_bug.cgi?id=104896 -Tools-Add-exception-for-gtkstylecontextget-httpsb.patch text/plain 3364 csaavedra RnJvbSBhMmM4OWUxOTcyYzkyZDFlOWJkOWFkN2MxZDgzNDMyZDVmZmI4NjJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDbGF1ZGlvIFNhYXZlZHJhIDxjc2FhdmVkcmFAaWdhbGlhLmNv bT4KRGF0ZTogVGh1LCAxMyBEZWMgMjAxMiAxMTo1NjoyOCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd ICAgICAgICAgW1Rvb2xzXSBBZGQgZXhjZXB0aW9uIGZvciBndGtfc3R5bGVfY29udGV4dF9nZXQo KSAgIAogICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODk2 CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBBZGQgbmV3IGV4 Y2VwdGlvbiBmb3IgZ3RrX3N0eWxlX2NvbnRleHRfZ2V0KCkuCgogICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CiAgICAgICAgKGNoZWNrX2Zvcl9udWxsKTog QWRkIGV4Y2VwdGlvbiBmb3IgZ3RrX3N0eWxlX2NvbnRleHRfZ2V0KCkuCi0tLQogVG9vbHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxNSArKysrKysr KysrKysrKysKIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5ICAg ICAgICAgIHwgIDQgKystLQogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHBfdW5pdHRlc3QucHkgfCAgMyArKysKIDMgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggOTJhZWI3NC4uZGFmZjlmMiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTEzICBD bGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1Rvb2xz XSBBZGQgZXhjZXB0aW9uIGZvciBndGtfc3R5bGVfY29udGV4dF9nZXQoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODk2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG5ldyBleGNlcHRpb24gZm9y IGd0a19zdHlsZV9jb250ZXh0X2dldCgpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19mb3JfbnVsbCk6IEFkZCBleGNl cHRpb24gZm9yIGd0a19zdHlsZV9jb250ZXh0X2dldCgpLgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5 bGVUZXN0LnRlc3RfbnVsbF9mYWxzZV96ZXJvKTogQWRkIGEgdW5pdAorICAgICAgICB0ZXN0IGZv ciB0aGUgbmV3IGV4Y2VwdGlvbi4KKwogMjAxMi0xMi0xMyAgWGluZ25hbiBXYW5nICA8eGluZ25h bi53YW5nQGludGVsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBBZGRpbmcgbXlzZWxmIHRv IGNvbW1pdHRlcnMgbGlzdC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKaW5kZXggYTAzMjg0YS4uZWRhOGJiYiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTI1NDcsOCArMjU0Nyw4IEBAIGRlZiBjaGVj a19mb3JfbnVsbChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKToK ICAgICBpZiBzZWFyY2gocidcYmdka19waXhidWZfc2F2ZV90b1x3K1xiJywgbGluZSk6CiAgICAg ICAgIHJldHVybgogCi0gICAgIyBEb24ndCB3YXJuIGFib3V0IE5VTEwgdXNhZ2UgaW4gZ3RrX3dp ZGdldF9zdHlsZV9nZXQoKSBvciBndGtfc3R5bGVfY29udGV4dF9nZXRfc3R5bGUuIFNlZSBCdWcg NTE3NTgKLSAgICBpZiBzZWFyY2gocidcYmd0a193aWRnZXRfc3R5bGVfZ2V0XChcdytcYicsIGxp bmUpIG9yIHNlYXJjaChyJ1xiZ3RrX3N0eWxlX2NvbnRleHRfZ2V0X3N0eWxlXChcdytcYicsIGxp bmUpOgorICAgICMgRG9uJ3Qgd2FybiBhYm91dCBOVUxMIHVzYWdlIGluIGd0a193aWRnZXRfc3R5 bGVfZ2V0KCksIGd0a19zdHlsZV9jb250ZXh0X2dldF9zdHlsZSgpLCBvciBndGtfc3R5bGVfY29u dGV4dF9nZXQoKS4gU2VlIEJ1ZyA1MTc1OAorICAgIGlmIHNlYXJjaChyJ1xiZ3RrX3dpZGdldF9z dHlsZV9nZXRcKFx3K1xiJywgbGluZSkgb3Igc2VhcmNoKHInXGJndGtfc3R5bGVfY29udGV4dF9n ZXRfc3R5bGVcKFx3K1xiJywgbGluZSkgb3Igc2VhcmNoKHInXGJndGtfc3R5bGVfY29udGV4dF9n ZXRcKFx3K1xiJywgbGluZSk6CiAgICAgICAgIHJldHVybgogCiAgICAgIyBEb24ndCB3YXJuIGFi b3V0IE5VTEwgdXNhZ2UgaW4gc291cF9zZXJ2ZXJfbmV3KCkuIFNlZSBCdWcgNzc4OTAuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVz dC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5CmluZGV4IDc5MWVkZjEuLjgzZDI5ZmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC00Mzk2LDYgKzQzOTYs OSBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAg ICAnZ3RrX3N0eWxlX2NvbnRleHRfZ2V0X3N0eWxlKGNvbnRleHQsICJwcm9wZXJ0eU5hbWUiLCAm dmFsdWUsICJvdGhlck5hbWUiLCAmb3RoZXJWYWx1ZSwgTlVMTCk7JywKICAgICAgICAgICAgICcn KQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2d0a19zdHlsZV9jb250 ZXh0X2dldChjb250ZXh0LCBzdGF0aWNfY2FzdDxHdGtTdGF0ZUZsYWdzPigwKSwgInByb3BlcnR5 IiwgJnZhbHVlLCBOVUxMKTsnLAorICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0 X2xpbnQoCiAgICAgICAgICAgICAnZ3RrX3dpZGdldF9zdHlsZV9nZXRfcHJvcGVydHkoc3R5bGUs IE5VTEwsIE5VTEwpOycsCiAgICAgICAgICAgICAnVXNlIDAgaW5zdGVhZCBvZiBOVUxMLiAgW3Jl YWRhYmlsaXR5L251bGxdIFs1XScsCiAgICAgICAgICAgICAnZm9vLmNwcCcpCi0tIAoxLjcuMTEu Nw==