104889 2012-12-13 01:00:04 -0800 [QT][GTK][EFL] Add guard for WebInspectorServer 2012-12-13 17:11:35 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned webkit.review.bot oldest_to_newest 790385 0 seokju 2012-12-13 01:00:04 -0800 Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer. 790531 1 179255 seokju 2012-12-13 05:39:13 -0800 Created attachment 179255 Patch 791025 2 179255 kenneth 2012-12-13 15:40:07 -0800 Comment on attachment 179255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179255&action=review > Source/WebKit2/ChangeLog:9 > + > + Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer. > + Are you sure that is defined by default by all these ports? 791026 3 seokju 2012-12-13 15:42:21 -0800 (In reply to comment #2) > (From update of attachment 179255 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179255&action=review > > > Source/WebKit2/ChangeLog:9 > > + > > + Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer. > > + > > Are you sure that is defined by default by all these ports? in Source/WebKit2/config.h #ifndef ENABLE_INSPECTOR_SERVER #if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL) #define ENABLE_INSPECTOR_SERVER 1 #endif #endif 791139 4 179255 webkit.review.bot 2012-12-13 17:11:32 -0800 Comment on attachment 179255 Patch Clearing flags on attachment: 179255 Committed r137687: <http://trac.webkit.org/changeset/137687> 791140 5 webkit.review.bot 2012-12-13 17:11:35 -0800 All reviewed patches have been landed. Closing bug. 179255 2012-12-13 05:39:13 -0800 2012-12-13 17:11:32 -0800 Patch bug-104889-20121213223633.patch text/plain 2926 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzIxMGYwODBlNjI1M2Rj MGE2OGYyNDQ3NGZhMTVlNmIxZTBkNWE1MS4uMWZiY2I2OWEwOTVlYjdjMGY3MTI1OTQyNDQxYjFi ZTRhZTExMzdkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTEzICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbUVRdW0dUS11bRUZM XSBBZGQgZ3VhcmQgZm9yIFdlYkluc3BlY3RvclNlcnZlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEVOQUJMRShJTlNQRUNUT1JfU0VSVkVSKSBn dWFyZCBhcm91bmQgcGxhdGZvcm0tc3BlY2lmaWMgaW1wbGVtZW50YXRpb24gZm9yIFdlYkluc3Bl Y3RvclNlcnZlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvZWZsL1dl Ykluc3BlY3RvclNlcnZlckVmbC5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL0luc3BlY3RvclNl cnZlci9ndGsvV2ViSW5zcGVjdG9yU2VydmVyR3RrLmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv SW5zcGVjdG9yU2VydmVyL3F0L1dlYkluc3BlY3RvclNlcnZlclF0LmNwcDoKKwogMjAxMi0xMi0x MyAgSm9hcXVpbSBSb2NoYSAgPGpyb2NoYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04gKHIxMzc0MzIpOiBUaGUgL3dlYmtpdDIvV2ViS2l0Q29va2llTWFuYWdlci9hY2NlcHQtcG9s aWN5IHVuaXQgdGVzdCBpcyBmYWlsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvSW5zcGVjdG9yU2VydmVyL2VmbC9XZWJJbnNwZWN0b3JTZXJ2ZXJFZmwuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9lZmwvV2ViSW5zcGVjdG9yU2Vy dmVyRWZsLmNwcAppbmRleCA5YmExYjhmZDMzNWQxMDUzMzc2ZWEyZGI3Yjg1ZGFhZGYwNjFhNGJj Li44NzY3NTVjZDEzZTc4NWI4YTUyNzA4YjZhZGQ5OWE4YjBlNjFiZjcxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL2VmbC9XZWJJbnNwZWN0b3JT ZXJ2ZXJFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2 ZXIvZWZsL1dlYkluc3BlY3RvclNlcnZlckVmbC5jcHAKQEAgLTIzLDYgKzIzLDggQEAKICAqLwog CiAjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNpZiBFTkFCTEUoSU5TUEVDVE9SX1NFUlZFUikKICNp bmNsdWRlICJXZWJJbnNwZWN0b3JTZXJ2ZXIuaCIKIAogI2luY2x1ZGUgIldlYkluc3BlY3RvclBy b3h5LmgiCkBAIC0xMDMsMyArMTA1LDQgQEAgdm9pZCBXZWJJbnNwZWN0b3JTZXJ2ZXI6OmJ1aWxk UGFnZUxpc3QoVmVjdG9yPGNoYXI+JiBkYXRhLCBTdHJpbmcmIGNvbnRlbnRUeXBlKQogfQogCiB9 CisjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JT ZXJ2ZXIvZ3RrL1dlYkluc3BlY3RvclNlcnZlckd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvSW5zcGVjdG9yU2VydmVyL2d0ay9XZWJJbnNwZWN0b3JTZXJ2ZXJHdGsuY3BwCmluZGV4 IGUzMzliZmVkOTNhMTRjZDNkZmZhNzczYzMwZDdhMDQ5M2ExYzU1NjAuLjc3NjJkZTkxZjhkN2Qz YjhlMTUzNTU1NzMxZDk1ZWY0YzM4NzRhYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvZ3RrL1dlYkluc3BlY3RvclNlcnZlckd0ay5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9ndGsvV2ViSW5zcGVj dG9yU2VydmVyR3RrLmNwcApAQCAtMjMsNiArMjMsOCBAQAogICovCiAKICNpbmNsdWRlICJjb25m aWcuaCIKKworI2lmIEVOQUJMRShJTlNQRUNUT1JfU0VSVkVSKQogI2luY2x1ZGUgIldlYkluc3Bl Y3RvclNlcnZlci5oIgogCiAjaW5jbHVkZSAiV2ViSW5zcGVjdG9yUHJveHkuaCIKQEAgLTk0LDMg Kzk2LDQgQEAgdm9pZCBXZWJJbnNwZWN0b3JTZXJ2ZXI6OmJ1aWxkUGFnZUxpc3QoVmVjdG9yPGNo YXI+JiBkYXRhLCBTdHJpbmcmIGNvbnRlbnRUeXBlKQogfQogCiB9CisjZW5kaWYKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvcXQvV2ViSW5zcGVj dG9yU2VydmVyUXQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZl ci9xdC9XZWJJbnNwZWN0b3JTZXJ2ZXJRdC5jcHAKaW5kZXggMTFlNTdjZmQ1ZWJjNzEwM2U1ZjUw ZmNhYmU4Zjc0NTc4Y2M0NzU4ZC4uMmQwNjBkMDY4MDc5NDkxOGJjOTgzNWY0YjgzNzcxOWYzMmU4 ZTcwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZl ci9xdC9XZWJJbnNwZWN0b3JTZXJ2ZXJRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0luc3BlY3RvclNlcnZlci9xdC9XZWJJbnNwZWN0b3JTZXJ2ZXJRdC5jcHAKQEAgLTIxLDYg KzIxLDcgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgogCisjaWYgRU5BQkxFKElOU1BFQ1RPUl9T RVJWRVIpCiAjaW5jbHVkZSAiV2ViSW5zcGVjdG9yU2VydmVyLmgiCiAKICNpbmNsdWRlICJXZWJJ bnNwZWN0b3JQcm94eS5oIgpAQCAtMTA0LDMgKzEwNSw0IEBAIHZvaWQgV2ViSW5zcGVjdG9yU2Vy dmVyOjpidWlsZFBhZ2VMaXN0KFZlY3RvcjxjaGFyPiYgZGF0YSwgU3RyaW5nJiBjb250ZW50VHlw ZSkKIH0KIAogfQorI2VuZGlmCg==