104884 2012-12-13 00:03:38 -0800 Safari spends a lot of time in WebCore::findSimpleWordBoundary while selecting text on large scrabutility.com page 2012-12-13 02:10:21 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa barraclough darin enrica jiapu.mail kling koivisto mifenton morrita webkit.review.bot oldest_to_newest 790340 0 rniwa 2012-12-13 00:03:38 -0800 Visit http://scrabutility.com/4_TWL06.php and select text by mouse drags. You see a spin. <rdar://problem/12188622> 790341 1 rniwa 2012-12-13 00:03:53 -0800 It appears that this could be a regression from http://trac.webkit.org/changeset/120357. 790343 2 rniwa 2012-12-13 00:04:57 -0800 We’re spending a significant amount of time in AlternativeTextController::respondToChangedSelection Running Time Self Symbol Name 1183.0ms 50.6% 1183.0 icu::RuleBasedBreakIterator::handleNext(icu::RBBIStateTable const*) 1183.0ms 50.6% 0.0 icu::RuleBasedBreakIterator::next() 1183.0ms 50.6% 0.0 icu::RuleBasedBreakIterator::following(int) 1183.0ms 50.6% 0.0 -[NSAttributedString(NSAttributedStringKitAdditions) doubleClickAtIndex:inRange:] 1183.0ms 50.6% 0.0 WebCore::findWordBoundary(unsigned short const*, int, int, int*, int*) 1183.0ms 50.6% 0.0 WebCore::endWordBoundary(unsigned short const*, unsigned int, unsigned int, WebCore::BoundarySearchContextAvailability, bool&) 1183.0ms 50.6% 0.0 WebCore::nextBoundary(WebCore::VisiblePosition const&, unsigned int (*)(unsigned short const*, unsigned int, unsigned int, WebCore::BoundarySearchContextAvailability, bool&)) 1183.0ms 50.6% 0.0 WebCore::endOfWord(WebCore::VisiblePosition const&, WebCore::EWordSide) 1183.0ms 50.6% 0.0 WebCore::AlternativeTextController::respondToChangedSelection(WebCore::VisibleSelection const&, unsigned int) 1183.0ms 50.6% 0.0 WebCore::Editor::respondToChangedSelection(WebCore::VisibleSelection const&, unsigned int) 1183.0ms 50.6% 0.0 WebCore::FrameSelection::setSelection(WebCore::VisibleSelection const&, unsigned int, WebCore::FrameSelection::CursorAlignOnScroll, WebCore::TextGranularity) 790357 3 rniwa 2012-12-13 00:21:04 -0800 Okay, I have a fix for this particular bug but selection is still very laggy. Now we spend most of time clipping selection rect :( Running Time Self Symbol Name 2832.0ms 62.5% 0.0 -[WebTileLayer drawInContext:] 2832.0ms 62.5% 0.0 WebCore::TileCache::drawLayer(WebTileLayer*, CGContext*) 2832.0ms 62.5% 0.0 drawLayerContents(CGContext*, CALayer*, WebCore::PlatformCALayer*) 2830.0ms 62.4% 0.0 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::IntRect const&) 2830.0ms 62.4% 0.0 WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, unsigned int, WebCore::IntRect const&) 2830.0ms 62.4% 0.0 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, unsigned int, unsigned int) 2829.0ms 62.4% 0.0 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext*, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int) 2829.0ms 62.4% 0.0 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext*, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int) 2829.0ms 62.4% 2.0 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext*, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int) 2827.0ms 62.4% 0.0 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 2826.0ms 62.3% 0.0 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 2819.0ms 62.2% 0.0 WebCore::RenderBlock::paintFloats(WebCore::PaintInfo&, WebCore::LayoutPoint const&, bool) 2819.0ms 62.2% 0.0 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 2819.0ms 62.2% 0.0 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 1904.0ms 42.0% 0.0 WebCore::RenderBlock::paintSelection(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 1363.0ms 30.0% 52.0 WebCore::RenderBlock::selectionGaps(WebCore::RenderBlock*, WebCore::LayoutPoint const&, WebCore::LayoutSize const&, WebCore::LayoutUnit&, WebCore::LayoutUnit&, WebCore::LayoutUnit&, WebCore::PaintInfo const*) 1300.0ms 28.7% 12.0 WebCore::GraphicsContext::clipOut(WebCore::IntRect const&) 790360 4 179219 rniwa 2012-12-13 00:24:39 -0800 Created attachment 179219 Don't find word boundaries outside of editable region 790367 5 rniwa 2012-12-13 00:29:46 -0800 +antti, +kling in the case they know how to improve GraphicsContext::clipOut. 790372 6 179219 morrita 2012-12-13 00:37:09 -0800 Comment on attachment 179219 Don't find word boundaries outside of editable region Looks an easy win. You'd file a bug for tracking slowness of selection in general. 790376 7 179219 rniwa 2012-12-13 00:45:19 -0800 Comment on attachment 179219 Don't find word boundaries outside of editable region Thanks for the review. 790380 8 rniwa 2012-12-13 00:53:12 -0800 (In reply to comment #6) > (From update of attachment 179219 [details]) > Looks an easy win. You'd file a bug for tracking slowness of selection in general. Yeah, I'll go talk with someone familiar with GraphicsContext and see there's anyway to improve clipping. 790426 9 179219 webkit.review.bot 2012-12-13 02:10:17 -0800 Comment on attachment 179219 Don't find word boundaries outside of editable region Clearing flags on attachment: 179219 Committed r137577: <http://trac.webkit.org/changeset/137577> 790427 10 webkit.review.bot 2012-12-13 02:10:21 -0800 All reviewed patches have been landed. Closing bug. 179219 2012-12-13 00:24:39 -0800 2012-12-13 02:10:16 -0800 Don't find word boundaries outside of editable region bug-104884-20121213002159.patch text/plain 1855 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzU3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTEzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNhZmFyaSBzcGVuZHMgYSBsb3Qg b2YgdGltZSBpbiBXZWJDb3JlOjpmaW5kU2ltcGxlV29yZEJvdW5kYXJ5IHdoaWxlIHNlbGVjdGlu ZyB0ZXh0IG9uIGxhcmdlIHNjcmFidXRpbGl0eS5jb20gcGFnZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODg0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBkbyBhbnl0aGlu ZyBpbiBBbHRlcm5hdGl2ZVRleHRDb250cm9sbGVyIGlmIHNlbGVjdGlvbiBpcyBhbHJlYWR5IG91 dHNpZGUgb2YgdGhlIGVkaXRhYmxlIHJlZ2lvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXJl IGFkZGVkIHNpbmNlIHRoaXMgaXMgb25seSBhIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50LCBhbmQg ZG9lc24ndCBjaGFuZ2UgYW55IGFzeW1wdG90aWMgYmVoYXZpb3IuCisKKyAgICAgICAgKiBlZGl0 aW5nL0FsdGVybmF0aXZlVGV4dENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWx0 ZXJuYXRpdmVUZXh0Q29udHJvbGxlcjo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbik6CisKIDIw MTItMTItMDcgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IEFkZCBzdXBwb3J0IGZvciB0cmFja2luZyBoaXQgdGVzdCByZWN0YW5nbGVzIHRvIGVuYWJsZSBm YXN0IGV2ZW50IHJlamVjdGlvbiBpbiB0aGUgY29tcG9zaXRvcgpJbmRleDogU291cmNlL1dlYkNv cmUvZWRpdGluZy9BbHRlcm5hdGl2ZVRleHRDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FsdGVybmF0aXZlVGV4dENvbnRyb2xsZXIuY3BwCShyZXZp c2lvbiAxMzc0MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FsdGVybmF0aXZlVGV4dENv bnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTIsNyArNDUyLDcgQEAgdm9pZCBBbHRl cm5hdGl2ZVRleHRDb250cm9sbGVyOjpyZXNwb25kVAogICAgIC8vIGNvbnRhaW5pbmcgdGhlIG9y aWdpbmFsIHByZS1jb3JyZWN0aW9uIHdvcmQgc28gdGhhdCB1c2VyIGNhbiBxdWlja2x5IHJldmVy dCB0aGUKICAgICAvLyB1bmRlc2lyZWQgYXV0b2NvcnJlY3Rpb24uIEhlcmUsIHdlIHN0YXJ0IGNv cnJlY3Rpb24gcGFuZWwgdGltZXIgb25jZSB3ZSBjb25maXJtIHRoYXQKICAgICAvLyB0aGUgbmV3 IGNhcmV0IHBvc2l0aW9uIGlzIGF0IHRoZSBlbmQgb2YgYSB3b3JkLgotICAgIGlmICghY3VycmVu dFNlbGVjdGlvbi5pc0NhcmV0KCkgfHwgY3VycmVudFNlbGVjdGlvbiA9PSBvbGRTZWxlY3Rpb24p CisgICAgaWYgKCFjdXJyZW50U2VsZWN0aW9uLmlzQ2FyZXQoKSB8fCBjdXJyZW50U2VsZWN0aW9u ID09IG9sZFNlbGVjdGlvbiB8fCAhY3VycmVudFNlbGVjdGlvbi5pc0NvbnRlbnRFZGl0YWJsZSgp KQogICAgICAgICByZXR1cm47CiAKICAgICBWaXNpYmxlUG9zaXRpb24gc2VsZWN0aW9uUG9zaXRp b24gPSBjdXJyZW50U2VsZWN0aW9uLnN0YXJ0KCk7Cg==