104883 2012-12-13 00:02:31 -0800 Regression(r137486): Broke EFL build 2012-12-13 08:36:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104718 1 cdumez cdumez ap eric webkit.review.bot oldest_to_newest 790339 0 cdumez 2012-12-13 00:02:31 -0800 http://trac.webkit.org/changeset/137486 broke the EFL build: [ 86%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/WebDatabaseManagerProxy.cpp.o /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp: In member function ‘void TestRunner::addDisallowedURL(JSStringRef)’: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp:71:276: error: ‘notImplementedLoggingChannel’ was not declared in this scope /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp:71:276: note: suggested alternative: 790344 1 179213 cdumez 2012-12-13 00:05:36 -0800 Created attachment 179213 Patch 790348 2 eric 2012-12-13 00:10:19 -0800 LGTM. 790369 3 cdumez 2012-12-13 00:30:38 -0800 Committed r137572: <http://trac.webkit.org/changeset/137572> 790638 4 ap 2012-12-13 08:36:06 -0800 Thank you for fixing this! 179213 2012-12-13 00:05:36 -0800 2012-12-13 00:30:08 -0800 Patch 104883_buildfix.patch text/plain 1471 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZDJjZmE2Li4zNGEwMGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTItMTMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzc0ODYpOiBCcm9rZSBFRkwgYnVpbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDg4MworCisg ICAgICAgIFVucmV2aWV3ZWQgRUZMIGJ1aWxkIGZpeC4KKworICAgICAgICBGaXggRUZMIGJ1aWxk IGJyZWFrIGFmdGVyIHIxMzc0ODYgZHVlIHRvIG1pc3NpbmcgV2ViQ29yZTo6CisgICAgICAgIG5h bWVzcGFjZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZSBmb3Ig bGF5b3V0IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vTm90SW1wbGVtZW50ZWQuaDoKKwog MjAxMi0xMi0wNyAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgQWRkIHN1cHBvcnQgZm9yIHRyYWNraW5nIGhpdCB0ZXN0IHJlY3RhbmdsZXMgdG8gZW5hYmxl IGZhc3QgZXZlbnQgcmVqZWN0aW9uIGluIHRoZSBjb21wb3NpdG9yCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9Ob3RJbXBsZW1lbnRlZC5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vTm90SW1wbGVtZW50ZWQuaAppbmRleCAyZTA1MGRmLi5jN2UzZjExIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Ob3RJbXBsZW1lbnRlZC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL05vdEltcGxlbWVudGVkLmgKQEAgLTQ4LDcgKzQ4LDcgQEAgV1RGTG9n Q2hhbm5lbCogbm90SW1wbGVtZW50ZWRMb2dnaW5nQ2hhbm5lbCgpOwogI2RlZmluZSBub3RJbXBs ZW1lbnRlZCgpIGRvIHsgXAogICAgICAgICBzdGF0aWMgYm9vbCBoYXZlUHJpbnRlZCA9IGZhbHNl OyBcCiAgICAgICAgIGlmICghaGF2ZVByaW50ZWQgJiYgIXN1cHJlc3NOb3RJbXBsZW1lbnRlZFdh cm5pbmcoKSkgeyBcCi0gICAgICAgICAgICBXVEZMb2dWZXJib3NlKF9fRklMRV9fLCBfX0xJTkVf XywgV1RGX1BSRVRUWV9GVU5DVElPTiwgbm90SW1wbGVtZW50ZWRMb2dnaW5nQ2hhbm5lbCgpLCAi VU5JTVBMRU1FTlRFRDogIik7IFwKKyAgICAgICAgICAgIFdURkxvZ1ZlcmJvc2UoX19GSUxFX18s IF9fTElORV9fLCBXVEZfUFJFVFRZX0ZVTkNUSU9OLCBXZWJDb3JlOjpub3RJbXBsZW1lbnRlZExv Z2dpbmdDaGFubmVsKCksICJVTklNUExFTUVOVEVEOiAiKTsgXAogICAgICAgICAgICAgaGF2ZVBy aW50ZWQgPSB0cnVlOyBcCiAgICAgICAgIH0gXAogICAgIH0gd2hpbGUgKDApCg==