104882 2012-12-12 23:56:03 -0800 Crash in PlugInOriginHash with empty MIME type 2012-12-13 00:43:50 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.8 RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee abarth andersca ap japhet simon.fraser webkit-bug-importer webkit-ews webkit.review.bot oldest_to_newest 790333 0 jonlee 2012-12-12 23:56:03 -0800 A plug-in with no specified type will crash PlugInOriginHash. 790334 1 webkit-bug-importer 2012-12-12 23:56:19 -0800 <rdar://problem/12872298> 790355 2 179217 jonlee 2012-12-13 00:18:31 -0800 Created attachment 179217 Patch 790371 3 179217 webkit-ews 2012-12-13 00:34:03 -0800 Comment on attachment 179217 Patch Attachment 179217 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15314160 790375 4 jonlee 2012-12-13 00:43:50 -0800 Committed r137573: <http://trac.webkit.org/changeset/137573> 179217 2012-12-13 00:18:31 -0800 2012-12-13 00:34:03 -0800 Patch bug-104882-20121213001552.patch text/plain 6532 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGI4OGVlZThlZmM1MTlk N2MxZjFiZmVhZWY1NWY2ZDAxNjc0NjBlYS4uMGJkMmUyNmE5MmM3ZjZlMGEzMzk1ZjM2YTc0ODgx NmVkNzUwYjc3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEyLTEyICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBQbHVnSW5PcmlnaW5I YXNoIHdpdGggZW1wdHkgTUlNRSB0eXBlICgxMDQ4ODIpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ4ODIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzEyODcyMjk4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBjcmFzaCBvY2N1cnMgYmVjYXVzZSB0aGUgc3RyaW5ncyBtaWdodCBiZSBudWxsLiBB ZGQgYSBjaGVjayBmb3IgaXQsIGJ1dCBhbHNvIHRyeSB0byBpbmZlciBhIE1JTUUgdHlwZQorICAg ICAgICBpbiBjYXNlIHRoZSBtYXJrdXAgZG9lcyBub3QgaW5jbHVkZSBhIHR5cGUgYXR0cmlidXRl LCBidXQgd2UgY2FuIGZpbmQgaXQgZnJvbSB0aGUgZXh0ZW5zaW9uIGluIHRoZSBVUkwuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9LVVJMLmNwcDogQWRkIGEgbmV3IGZ1bmN0aW9uIG1pbWVUeXBlRnJv bVVSTCgpIHdoaWNoIHRyaWVzIHRvIHJldHVybiB0aGUgaW1wbGllZCBNSU1FIHR5cGUKKyAgICAg ICAgYmFzZWQgb24gdGhlIFVSTCBwcm92aWRlZC4gSWYgbm90aGluZyB3YXMgZm91bmQsIHJldHVy biBhIG51bGwgc3RyaW5nLgorICAgICAgICAoV2ViQ29yZTo6bWltZVR5cGVGcm9tVVJMKTogRmFj dG9yZWQgb3V0IGZyb20gRnJhbWVMb2FkZXI6OmRlZmF1bHRPYmplY3RDb250ZW50VHlwZSgpLgor ICAgICAgICAqIHBsYXRmb3JtL0tVUkwuaDoKKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6ZGVmYXVsdE9iamVjdENvbnRl bnRUeXBlKTogUmVmYWN0b3IgdG8gdXNlIG1pbWVUeXBlRnJvbVVSTCgpLgorICAgICAgICAqIHBs dWdpbnMvUGx1Z0luT3JpZ2luSGFzaC5jcHA6CisgICAgICAgIChXZWJDb3JlOjphZGRDYXNlRm9s ZGVkQ2hhcmFjdGVycyk6IEFkZCBhIGNoZWNrIGZvciBhbiBlbXB0eSBzdHJpbmcuCisgICAgICAg IChXZWJDb3JlOjpQbHVnSW5PcmlnaW5IYXNoOjpoYXNoKTogSWYgdGhlIHNlcnZpY2UgdHlwZSBp cyBlbXB0eSwgdHJ5IHRvIGluZmVyIHRoZSBNSU1FIHR5cGUuCisKIDIwMTItMTItMTIgIE5vJ2Ft IFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OOiByMTM3NDgxIGNhdXNlZCBhIGJ1aWxkIGZhaWx1cmUgd2l0aCBHVEsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IGZhZjFlN2RhMjNkMTBjNDQzNGI4OWIzM2M2MGYy MzQ3N2Q2YjY5MTIuLjQ5ZWU3ZmUwMTg0ZDk0Yzc2MTlmMGY2YTNlNmFkODE2NTVlNWI2ODMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtODg0LDEyICs4ODQsOSBAQCB2 b2lkIEZyYW1lTG9hZGVyOjpsb2FkQXJjaGl2ZShQYXNzUmVmUHRyPEFyY2hpdmU+IGFyY2hpdmUp CiBPYmplY3RDb250ZW50VHlwZSBGcmFtZUxvYWRlcjo6ZGVmYXVsdE9iamVjdENvbnRlbnRUeXBl KGNvbnN0IEtVUkwmIHVybCwgY29uc3QgU3RyaW5nJiBtaW1lVHlwZUluLCBib29sIHNob3VsZFBy ZWZlclBsdWdJbnNGb3JJbWFnZXMpCiB7CiAgICAgU3RyaW5nIG1pbWVUeXBlID0gbWltZVR5cGVJ bjsKLSAgICBTdHJpbmcgZGVjb2RlZFBhdGggPSBkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXModXJs LnBhdGgoKSk7Ci0gICAgU3RyaW5nIGV4dGVuc2lvbiA9IGRlY29kZWRQYXRoLnN1YnN0cmluZyhk ZWNvZGVkUGF0aC5yZXZlcnNlRmluZCgnLicpICsgMSk7CiAKLSAgICAvLyBXZSBkb24ndCB1c2Ug TUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JQYXRoKCkgYmVjYXVzZSBpdCByZXR1cm5z ICJhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0iIHVwb24gZmFpbHVyZQogICAgIGlmIChtaW1lVHlw ZS5pc0VtcHR5KCkpCi0gICAgICAgIG1pbWVUeXBlID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlN RVR5cGVGb3JFeHRlbnNpb24oZXh0ZW5zaW9uKTsKKyAgICAgICAgbWltZVR5cGUgPSBtaW1lVHlw ZUZyb21VUkwodXJsKTsKIAogI2lmICFQTEFURk9STShNQUMpICYmICFQTEFURk9STShDSFJPTUlV TSkgJiYgIVBMQVRGT1JNKEVGTCkgLy8gTWFjIGhhcyBubyBQbHVnaW5EYXRhYmFzZSwgbm9yIGRv ZXMgQ2hyb21pdW0gb3IgRUZMCiAgICAgaWYgKG1pbWVUeXBlLmlzRW1wdHkoKSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vS1VSTC5jcHAKaW5kZXggMGQyYTZkOGIzNmJhNDFkMzg5MmVlYjU4MWU0MzBlNTI2NTI3 M2FiMS4uYTFlMDExNDY2ZTk1ZGMyM2FjYjE0NWU0YTJiOTUyNmJjMThhYzhkMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vS1VSTC5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJLVVJMLmgiCiAK ICNpbmNsdWRlICJEZWNvZGVFc2NhcGVTZXF1ZW5jZXMuaCIKKyNpbmNsdWRlICJNSU1FVHlwZVJl Z2lzdHJ5LmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1NZW1vcnlJbnN0cnVtZW50YXRpb24uaCIKICNp bmNsdWRlICJUZXh0RW5jb2RpbmcuaCIKICNpbmNsdWRlIDxzdGRpby5oPgpAQCAtMTkxOCw2ICsx OTE5LDE1IEBAIFN0cmluZyBtaW1lVHlwZUZyb21EYXRhVVJMKGNvbnN0IFN0cmluZyYgdXJsKQog ICAgIHJldHVybiAiIjsKIH0KIAorU3RyaW5nIG1pbWVUeXBlRnJvbVVSTChjb25zdCBLVVJMJiB1 cmwpCit7CisgICAgU3RyaW5nIGRlY29kZWRQYXRoID0gZGVjb2RlVVJMRXNjYXBlU2VxdWVuY2Vz KHVybC5wYXRoKCkpOworICAgIFN0cmluZyBleHRlbnNpb24gPSBkZWNvZGVkUGF0aC5zdWJzdHJp bmcoZGVjb2RlZFBhdGgucmV2ZXJzZUZpbmQoJy4nKSArIDEpOworCisgICAgLy8gV2UgZG9uJ3Qg dXNlIE1JTUVUeXBlUmVnaXN0cnk6OmdldE1JTUVUeXBlRm9yUGF0aCgpIGJlY2F1c2UgaXQgcmV0 dXJucyAiYXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtIiB1cG9uIGZhaWx1cmUKKyAgICByZXR1cm4g TUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24oZXh0ZW5zaW9uKTsKK30K Kwogdm9pZCBLVVJMOjpyZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlP YmplY3RJbmZvKSBjb25zdAogewogICAgIE1lbW9yeUNsYXNzSW5mbyBpbmZvKG1lbW9yeU9iamVj dEluZm8sIHRoaXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5oCmluZGV4IDc4Yjg2NDllNjIwNmExZTc4 MjQ2NmJjZTg3NjI4NTk4NGYwZjhkY2YuLjEzMDEzZmJiNDAyMDgwMjEyMjMzNzBjOTU0NGM4ODZm OGM4NTI5MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmgKQEAgLTI5MCw2ICsyOTAsNyBAQCBib29s IHBvcnRBbGxvd2VkKGNvbnN0IEtVUkwmKTsgLy8gQmxhY2tsaXN0IHBvcnRzIHRoYXQgc2hvdWxk IG5ldmVyIGJlIHVzZWQgZm9yCiBib29sIGlzVmFsaWRQcm90b2NvbChjb25zdCBTdHJpbmcmKTsK IAogU3RyaW5nIG1pbWVUeXBlRnJvbURhdGFVUkwoY29uc3QgU3RyaW5nJiB1cmwpOworU3RyaW5n IG1pbWVUeXBlRnJvbVVSTChjb25zdCBLVVJMJik7CiAKIC8vIFVuZXNjYXBlcyB0aGUgZ2l2ZW4g c3RyaW5nIHVzaW5nIFVSTCBlc2NhcGluZyBydWxlcywgZ2l2ZW4gYW4gb3B0aW9uYWwKIC8vIGVu Y29kaW5nIChkZWZhdWx0aW5nIHRvIFVURi04IG90aGVyd2lzZSkuIERBTkdFUjogSWYgdGhlIFVS TCBoYXMgIiUwMCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z0luT3Jp Z2luSGFzaC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdJbk9yaWdpbkhhc2guY3Bw CmluZGV4IGNhMGZlYTllOTg4YWQyZTI5YTIzNTM0ODUzODQwNmI2MDAzZWZlY2MuLmNkNWIwZGI0 NzE1ZTM5YTQ3MDA5N2FiNDE1YmRkNjcxNTljYjg1YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsdWdpbnMvUGx1Z0luT3JpZ2luSGFzaC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1 Z2lucy9QbHVnSW5PcmlnaW5IYXNoLmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIkhU TUxQbHVnSW5JbWFnZUVsZW1lbnQuaCIKICNpbmNsdWRlICJLVVJMLmgiCiAjaW5jbHVkZSAiTG9n Z2luZy5oIgorI2luY2x1ZGUgIk1JTUVUeXBlUmVnaXN0cnkuaCIKICNpbmNsdWRlICJQYWdlLmgi CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgogCkBAIC0zOCw2ICszOSw4IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGlubGluZSB2b2lkIGFkZENhc2VGb2xkZWRDaGFy YWN0ZXJzKFN0cmluZ0hhc2hlciYgaGFzaGVyLCBjb25zdCBTdHJpbmcmIHN0cmluZykKIHsKKyAg ICBpZiAoc3RyaW5nLmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIGlmIChzdHJpbmcu aXM4Qml0KCkpCiAgICAgICAgIHJldHVybiBoYXNoZXIuYWRkQ2hhcmFjdGVyczxMQ2hhciwgQ2Fz ZUZvbGRpbmdIYXNoOjpmb2xkQ2FzZTxMQ2hhcj4gPihzdHJpbmcuY2hhcmFjdGVyczgoKSwgc3Ry aW5nLmxlbmd0aCgpKTsKICAgICByZXR1cm4gaGFzaGVyLmFkZENoYXJhY3RlcnM8VUNoYXIsIENh c2VGb2xkaW5nSGFzaDo6Zm9sZENhc2U8VUNoYXI+ID4oc3RyaW5nLmNoYXJhY3RlcnMxNigpLCBz dHJpbmcubGVuZ3RoKCkpOwpAQCAtNDcsNiArNTAsMTAgQEAgdW5zaWduZWQgUGx1Z0luT3JpZ2lu SGFzaDo6aGFzaChIVE1MUGx1Z0luSW1hZ2VFbGVtZW50KiBwbHVnSW5FbGVtZW50LCBjb25zdCBL VVIKIHsKICAgICBBU1NFUlQocGx1Z0luRWxlbWVudC0+ZG9jdW1lbnQoKS0+cGFnZSgpKTsKIAor ICAgIFN0cmluZyBtaW1lVHlwZSA9IHBsdWdJbkVsZW1lbnQtPnNlcnZpY2VUeXBlKCk7CisgICAg aWYgKG1pbWVUeXBlLmlzRW1wdHkoKSkKKyAgICAgICAgbWltZVR5cGUgPSBtaW1lVHlwZUZyb21V UkwocGx1Z0luVVJMKTsKKwogICAgIC8vIFdlIHdhbnQgdG8gYXZvaWQgY29uY2F0ZW5hdGluZyB0 aGUgc3RyaW5ncyBhbmQgdGhlbiB0YWtpbmcgdGhlIGhhc2gsIHNpbmNlIHRoYXQgY291bGQgbGVh ZCB0byBhbiBleHBlbnNpdmUgY29udmVyc2lvbi4KICAgICAvLyBXZSBhbHNvIHdhbnQgdG8gYXZv aWQgdXNpbmcgdGhlIGhhc2goKSBmdW5jdGlvbiBpbiBTdHJpbmdJbXBsIG9yIENhc2VGb2xkaW5n SGFzaCBiZWNhdXNlIHRoYXQgbWFza3Mgb3V0IGJpdHMgZm9yIHRoZSB1c2Ugb2YgZmxhZ3MuCiAg ICAgU3RyaW5nSGFzaGVyIGhhc2hlcjsKQEAgLTU0LDggKzYxLDggQEAgdW5zaWduZWQgUGx1Z0lu T3JpZ2luSGFzaDo6aGFzaChIVE1MUGx1Z0luSW1hZ2VFbGVtZW50KiBwbHVnSW5FbGVtZW50LCBj b25zdCBLVVIKICAgICBoYXNoZXIuYWRkQ2hhcmFjdGVyKDApOwogICAgIGFkZENhc2VGb2xkZWRD aGFyYWN0ZXJzKGhhc2hlciwgcGx1Z0luVVJMLmhvc3QoKSk7CiAgICAgaGFzaGVyLmFkZENoYXJh Y3RlcigwKTsKLSAgICBhZGRDYXNlRm9sZGVkQ2hhcmFjdGVycyhoYXNoZXIsIHBsdWdJbkVsZW1l bnQtPnNlcnZpY2VUeXBlKCkpOwotICAgIExPRyhQbHVnaW5zLCAiSGFzaDogJXMgJXMgJXMiLCBw bHVnSW5FbGVtZW50LT5kb2N1bWVudCgpLT5wYWdlKCktPm1haW5GcmFtZSgpLT5kb2N1bWVudCgp LT5iYXNlVVJMKCkuaG9zdCgpLnV0ZjgoKS5kYXRhKCksIHBsdWdJblVSTC5ob3N0KCkudXRmOCgp LmRhdGEoKSwgcGx1Z0luRWxlbWVudC0+c2VydmljZVR5cGUoKS51dGY4KCkuZGF0YSgpKTsKKyAg ICBhZGRDYXNlRm9sZGVkQ2hhcmFjdGVycyhoYXNoZXIsIG1pbWVUeXBlKTsKKyAgICBMT0coUGx1 Z2lucywgIkhhc2g6ICVzICVzICVzIiwgcGx1Z0luRWxlbWVudC0+ZG9jdW1lbnQoKS0+cGFnZSgp LT5tYWluRnJhbWUoKS0+ZG9jdW1lbnQoKS0+YmFzZVVSTCgpLmhvc3QoKS51dGY4KCkuZGF0YSgp LCBwbHVnSW5VUkwuaG9zdCgpLnV0ZjgoKS5kYXRhKCksIG1pbWVUeXBlLnV0ZjgoKS5kYXRhKCkp OwogICAgIHJldHVybiBoYXNoZXIuaGFzaCgpOwogfQogCg==