104879 2012-12-12 22:23:50 -0800 [WebKit2] Only register NSNotificationCenter observers once per WebContext 2012-12-13 12:45:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aestes aestes ap oldest_to_newest 790296 0 aestes 2012-12-12 22:23:50 -0800 [WebKit2] Only register NSNotificationCenter observers once per WebContext 790298 1 179197 aestes 2012-12-12 22:29:33 -0800 Created attachment 179197 Patch 790637 2 179197 ap 2012-12-13 08:34:59 -0800 Comment on attachment 179197 Patch Thank you! 790826 3 aestes 2012-12-13 12:45:19 -0800 Committed r137637: <http://trac.webkit.org/changeset/137637> 179197 2012-12-12 22:29:33 -0800 2012-12-13 08:34:59 -0800 Patch bug-104879-20121212222654.patch text/plain 6952 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmU3NDdjOTdmMzU4N2Zl ZjkxMzA2YzNlYjlkOGI2NDY0YzQ4YTZlNS4uZTE2NWJjYjIxMjg2YWMxYzZlZjdmMWVlNzAxY2Vj OWE1ZmE1ZDMwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTEyLTEyICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBbV2ViS2l0Ml0gT25seSByZWdp c3RlciBOU05vdGlmaWNhdGlvbkNlbnRlciBvYnNlcnZlcnMgb25jZSBwZXIgV2ViQ29udGV4dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODc5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViQ29udGV4 dCB3YXMgbWlzdGFrZW5seSByZWdpc3RlcmluZyBOU05vdGlmaWNhdGlvbkNlbnRlciBvYnNlcnZl cnMKKyAgICAgICAgZXZlcnkgdGltZSBhIG5ldyB3ZWIgcHJvY2VzcyB3YXMgY3JlYXRlZC4gSW4g YSBtdWx0aS1XZWJQcm9jZXNzIHdvcmxkLAorICAgICAgICB0aGlzIGNhdXNlZCBkdXBsaWNhdGUg b2JzZXJ2ZXJzIHRvIGJlIG5lZWRsZXNzbHkgcmVnaXN0ZXJlZC4gRml4IHRoaXMKKyAgICAgICAg YnkgcmVnaXN0ZXJpbmcgb2JzZXJ2ZXJzIGF0IFdlYkNvbnRleHQgY3JlYXRpb24gdGltZSAoYW5k IGZpeCBhIHJlbGF0ZWQKKyAgICAgICAgYnVnIHdoZXJlIHR3byBvZiB0aGUgb2JzZXJ2ZXJzIHdl cmUgbmV2ZXIgdW5yZWdpc3RlcmVkKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0 Lmg6CisgICAgICAgICogVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWFjLm1tOgorICAgICAgICAo V2ViS2l0OjpXZWJDb250ZXh0OjpwbGF0Zm9ybUluaXRpYWxpemUpOiBSZWdpc3RlciBvYnNlcnZl cnMgd2hlbiBpbml0aWFsaXppbmcgdGhlIGNvbnRleHQuCisgICAgICAgIChXZWJLaXQ6OldlYkNv bnRleHQ6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MpOiBEb24ndCByZWdpc3RlciBvYnNl cnZlcnMgaGVyZS4KKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6cGxhdGZvcm1JbnZhbGlk YXRlQ29udGV4dCk6IFVucmVnaXN0ZXIgb2JzZXJ2ZXJzIHdoZW4gaW52YWxpZGF0aW5nIHRoZSBj b250ZXh0LgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0OjpyZWdpc3Rlck5vdGlmaWNhdGlv bk9ic2VydmVycyk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnVucmVnaXN0ZXJOb3Rp ZmljYXRpb25PYnNlcnZlcnMpOgorCisyMDEyLTEyLTEyICBBbmR5IEVzdGVzICA8YWVzdGVzQGFw cGxlLmNvbT4KKwogICAgICAgICBSZW5hbWUgY3VycmVudE1vdXNlUG9zaXRpb24oKSB0byBsYXN0 S25vd25Nb3VzZVBvc2l0aW9uKCkgYW5kIG1hcmsgaXQgYXMgT1ZFUlJJREUuCiAKICAgICAgICAg KiBXZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5oOgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJDb250ZXh0LmgKaW5kZXggNzhkNjQ3NzA5MTRmNmUzYjIyYzA1NjFmYzcxYmY1YzdlNjgw MjkwMy4uZDc2ZWE5N2M2OTJkOTAwY2IxNWIxNDM3Y2EyZjJlYmVhYTNjYTUxYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCkBAIC0zMTksNiArMzE5LDggQEAgcHJpdmF0ZToK ICAgICBzdGF0aWMgdm9pZCBhcHBsaWNhdGlvbkJlY2FtZU9jY2x1ZGVkKHVpbnQzMl90LCB2b2lk KiwgdWludDMyX3QsIHZvaWQqLCB1aW50MzJfdCk7CiAgICAgc3RhdGljIHZvaWQgaW5pdGlhbGl6 ZVByb2Nlc3NTdXBwcmVzc2lvblN1cHBvcnQoKTsKICAgICBzdGF0aWMgdm9pZCByZWdpc3Rlck9j Y2x1c2lvbk5vdGlmaWNhdGlvbkhhbmRsZXJzKCk7CisgICAgdm9pZCByZWdpc3Rlck5vdGlmaWNh dGlvbk9ic2VydmVycygpOworICAgIHZvaWQgdW5yZWdpc3Rlck5vdGlmaWNhdGlvbk9ic2VydmVy cygpOwogI2VuZGlmCiAKICAgICB2b2lkIGFkZFBsdWdJbkF1dG9TdGFydE9yaWdpbkhhc2goY29u c3QgU3RyaW5nJiBwYWdlT3JpZ2luLCB1bnNpZ25lZCBwbHVnSW5PcmlnaW5IYXNoKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1hYy5tbSBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1hYy5tbQppbmRleCBmZDQxNWZh MDVlMGRhNTI3MjQ4YjZiZjZhOGM0YWJkZTMwMmVlY2NhLi43NGJkMGU3NTI5MGYzZDYyMjg4MDRl YWJjNTZlZjI5ZTczZDUwNzliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dlYkNvbnRleHRNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9X ZWJDb250ZXh0TWFjLm1tCkBAIC03OSw2ICs3OSw3IEBAIHN0YXRpYyB2b2lkIHJlZ2lzdGVyVXNl ckRlZmF1bHRzSWZOZWVkZWQoKQogdm9pZCBXZWJDb250ZXh0OjpwbGF0Zm9ybUluaXRpYWxpemUo KQogewogICAgIHJlZ2lzdGVyVXNlckRlZmF1bHRzSWZOZWVkZWQoKTsKKyAgICByZWdpc3Rlck5v dGlmaWNhdGlvbk9ic2VydmVycygpOwogfQogCiBTdHJpbmcgV2ViQ29udGV4dDo6YXBwbGljYXRp b25DYWNoZURpcmVjdG9yeSgpCkBAIC0xMzEsMzAgKzEzMiwxMSBAQCB2b2lkIFdlYkNvbnRleHQ6 OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVy cyYgcGFyYQogICAgIE5TQXJyYXkgKnNjaGVtZXMgPSBbW1dLQnJvd3NpbmdDb250ZXh0Q29udHJv bGxlciBjdXN0b21TY2hlbWVzXSBhbGxPYmplY3RzXTsKICAgICBmb3IgKHNpemVfdCBpID0gMDsg aSA8IFtzY2hlbWVzIGNvdW50XTsgKytpKQogICAgICAgICBwYXJhbWV0ZXJzLnVybFNjaGVtZXNS ZWdpc3RlcmVkRm9yQ3VzdG9tUHJvdG9jb2xzLmFwcGVuZChbc2NoZW1lcyBvYmplY3RBdEluZGV4 OmldKTsKLQotICAgIC8vIEZJWE1FKE11bHRpLVdlYlByb2Nlc3MpOiBXZSByZWdpc3RlciBvYnNl cnZlcnMgZm9yIGV2ZXJ5IHByb2Nlc3MgdGhhdCBpcyBjcmVhdGVkLCB3aGljaCBtYWtlcyBubyBz ZW5zZS4KLQotICAgIG1fY3VzdG9tU2NoZW1lUmVnaXN0ZXJlZE9ic2VydmVyID0gW1tOU05vdGlm aWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSBhZGRPYnNlcnZlckZvck5hbWU6V2ViS2l0OjpT Y2hlbWVGb3JDdXN0b21Qcm90b2NvbFJlZ2lzdGVyZWROb3RpZmljYXRpb25OYW1lIG9iamVjdDpu aWwgcXVldWU6W05TT3BlcmF0aW9uUXVldWUgY3VycmVudFF1ZXVlXSB1c2luZ0Jsb2NrOl4oTlNO b3RpZmljYXRpb24gKm5vdGlmaWNhdGlvbikgewotICAgICAgICBOU1N0cmluZyAqc2NoZW1lID0g W25vdGlmaWNhdGlvbiBvYmplY3RdOwotICAgICAgICBBU1NFUlQoW3NjaGVtZSBpc0tpbmRPZkNs YXNzOltOU1N0cmluZyBjbGFzc11dKTsKLSAgICAgICAgc2VuZFRvQWxsUHJvY2Vzc2VzKE1lc3Nh Z2VzOjpXZWJQcm9jZXNzOjpSZWdpc3RlclNjaGVtZUZvckN1c3RvbVByb3RvY29sKHNjaGVtZSkp OwotICAgIH1dOwotICAgIAotICAgIG1fY3VzdG9tU2NoZW1lVW5yZWdpc3RlcmVkT2JzZXJ2ZXIg PSBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIGFkZE9ic2VydmVyRm9yTmFt ZTpXZWJLaXQ6OlNjaGVtZUZvckN1c3RvbVByb3RvY29sVW5yZWdpc3RlcmVkTm90aWZpY2F0aW9u TmFtZSBvYmplY3Q6bmlsIHF1ZXVlOltOU09wZXJhdGlvblF1ZXVlIGN1cnJlbnRRdWV1ZV0gdXNp bmdCbG9jazpeKE5TTm90aWZpY2F0aW9uICpub3RpZmljYXRpb24pIHsKLSAgICAgICAgTlNTdHJp bmcgKnNjaGVtZSA9IFtub3RpZmljYXRpb24gb2JqZWN0XTsKLSAgICAgICAgQVNTRVJUKFtzY2hl bWUgaXNLaW5kT2ZDbGFzczpbTlNTdHJpbmcgY2xhc3NdXSk7Ci0gICAgICAgIHNlbmRUb0FsbFBy b2Nlc3NlcyhNZXNzYWdlczo6V2ViUHJvY2Vzczo6VW5yZWdpc3RlclNjaGVtZUZvckN1c3RvbVBy b3RvY29sKHNjaGVtZSkpOwotICAgIH1dOwotICAgIAotICAgIC8vIExpc3RlbiBmb3IgZW5oYW5j ZWQgYWNjZXNzaWJpbGl0eSBjaGFuZ2VzIGFuZCBwcm9wYWdhdGUgdGhlbSB0byB0aGUgV2ViUHJv Y2Vzcy4KLSAgICBtX2VuaGFuY2VkQWNjZXNzaWJpbGl0eU9ic2VydmVyID0gW1tOU05vdGlmaWNh dGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSBhZGRPYnNlcnZlckZvck5hbWU6V2ViS2l0QXBwbGlj YXRpb25EaWRDaGFuZ2VBY2Nlc3NpYmlsaXR5RW5oYW5jZWRVc2VySW50ZXJmYWNlTm90aWZpY2F0 aW9uIG9iamVjdDpuaWwgcXVldWU6W05TT3BlcmF0aW9uUXVldWUgY3VycmVudFF1ZXVlXSB1c2lu Z0Jsb2NrOl4oTlNOb3RpZmljYXRpb24gKm5vdGUpIHsKLSAgICAgICAgc2V0RW5oYW5jZWRBY2Nl c3NpYmlsaXR5KFtbW25vdGUgdXNlckluZm9dIG9iamVjdEZvcktleTpAIkFYRW5oYW5jZWRVc2Vy SW50ZXJmYWNlIl0gYm9vbFZhbHVlXSk7Ci0gICAgfV07CiB9CiAKIHZvaWQgV2ViQ29udGV4dDo6 cGxhdGZvcm1JbnZhbGlkYXRlQ29udGV4dCgpCiB7Ci0gICAgW1tOU05vdGlmaWNhdGlvbkNlbnRl ciBkZWZhdWx0Q2VudGVyXSByZW1vdmVPYnNlcnZlcjooaWQpbV9lbmhhbmNlZEFjY2Vzc2liaWxp dHlPYnNlcnZlci5nZXQoKV07CisgICAgdW5yZWdpc3Rlck5vdGlmaWNhdGlvbk9ic2VydmVycygp OwogfQogCiBTdHJpbmcgV2ViQ29udGV4dDo6cGxhdGZvcm1EZWZhdWx0RGlza0NhY2hlRGlyZWN0 b3J5KCkgY29uc3QKQEAgLTM1Miw1ICszMzQsMzIgQEAgdm9pZCBXZWJDb250ZXh0OjpyZWdpc3Rl ck9jY2x1c2lvbk5vdGlmaWNhdGlvbkhhbmRsZXJzKCkKICAgICAgICAgV1RGTG9nQWx3YXlzKCJS ZWdpc3RlcmF0aW9uIG9mIFwiQXBwIEJlY2FtZSBPY2NsdWRlZFwiIG5vdGlmaWNhdGlvbiBoYW5k bGVyIGZhaWxlZC5cbiIpOwogI2VuZGlmCiB9CisgICAgCit2b2lkIFdlYkNvbnRleHQ6OnJlZ2lz dGVyTm90aWZpY2F0aW9uT2JzZXJ2ZXJzKCkKK3sKKyAgICBtX2N1c3RvbVNjaGVtZVJlZ2lzdGVy ZWRPYnNlcnZlciA9IFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2Jz ZXJ2ZXJGb3JOYW1lOldlYktpdDo6U2NoZW1lRm9yQ3VzdG9tUHJvdG9jb2xSZWdpc3RlcmVkTm90 aWZpY2F0aW9uTmFtZSBvYmplY3Q6bmlsIHF1ZXVlOltOU09wZXJhdGlvblF1ZXVlIGN1cnJlbnRR dWV1ZV0gdXNpbmdCbG9jazpeKE5TTm90aWZpY2F0aW9uICpub3RpZmljYXRpb24pIHsKKyAgICAg ICAgTlNTdHJpbmcgKnNjaGVtZSA9IFtub3RpZmljYXRpb24gb2JqZWN0XTsKKyAgICAgICAgQVNT RVJUKFtzY2hlbWUgaXNLaW5kT2ZDbGFzczpbTlNTdHJpbmcgY2xhc3NdXSk7CisgICAgICAgIHNl bmRUb0FsbFByb2Nlc3NlcyhNZXNzYWdlczo6V2ViUHJvY2Vzczo6UmVnaXN0ZXJTY2hlbWVGb3JD dXN0b21Qcm90b2NvbChzY2hlbWUpKTsKKyAgICB9XTsKKyAgICAKKyAgICBtX2N1c3RvbVNjaGVt ZVVucmVnaXN0ZXJlZE9ic2VydmVyID0gW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2Vu dGVyXSBhZGRPYnNlcnZlckZvck5hbWU6V2ViS2l0OjpTY2hlbWVGb3JDdXN0b21Qcm90b2NvbFVu cmVnaXN0ZXJlZE5vdGlmaWNhdGlvbk5hbWUgb2JqZWN0Om5pbCBxdWV1ZTpbTlNPcGVyYXRpb25R dWV1ZSBjdXJyZW50UXVldWVdIHVzaW5nQmxvY2s6XihOU05vdGlmaWNhdGlvbiAqbm90aWZpY2F0 aW9uKSB7CisgICAgICAgIE5TU3RyaW5nICpzY2hlbWUgPSBbbm90aWZpY2F0aW9uIG9iamVjdF07 CisgICAgICAgIEFTU0VSVChbc2NoZW1lIGlzS2luZE9mQ2xhc3M6W05TU3RyaW5nIGNsYXNzXV0p OworICAgICAgICBzZW5kVG9BbGxQcm9jZXNzZXMoTWVzc2FnZXM6OldlYlByb2Nlc3M6OlVucmVn aXN0ZXJTY2hlbWVGb3JDdXN0b21Qcm90b2NvbChzY2hlbWUpKTsKKyAgICB9XTsKKyAgICAKKyAg ICAvLyBMaXN0ZW4gZm9yIGVuaGFuY2VkIGFjY2Vzc2liaWxpdHkgY2hhbmdlcyBhbmQgcHJvcGFn YXRlIHRoZW0gdG8gdGhlIFdlYlByb2Nlc3MuCisgICAgbV9lbmhhbmNlZEFjY2Vzc2liaWxpdHlP YnNlcnZlciA9IFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2 ZXJGb3JOYW1lOldlYktpdEFwcGxpY2F0aW9uRGlkQ2hhbmdlQWNjZXNzaWJpbGl0eUVuaGFuY2Vk VXNlckludGVyZmFjZU5vdGlmaWNhdGlvbiBvYmplY3Q6bmlsIHF1ZXVlOltOU09wZXJhdGlvblF1 ZXVlIGN1cnJlbnRRdWV1ZV0gdXNpbmdCbG9jazpeKE5TTm90aWZpY2F0aW9uICpub3RlKSB7Cisg ICAgICAgIHNldEVuaGFuY2VkQWNjZXNzaWJpbGl0eShbW1tub3RlIHVzZXJJbmZvXSBvYmplY3RG b3JLZXk6QCJBWEVuaGFuY2VkVXNlckludGVyZmFjZSJdIGJvb2xWYWx1ZV0pOworICAgIH1dOwor fQorCit2b2lkIFdlYkNvbnRleHQ6OnVucmVnaXN0ZXJOb3RpZmljYXRpb25PYnNlcnZlcnMoKQor eworICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gcmVtb3ZlT2JzZXJ2 ZXI6KGlkKW1fY3VzdG9tU2NoZW1lUmVnaXN0ZXJlZE9ic2VydmVyLmdldCgpXTsKKyAgICBbW05T Tm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVyOihpZCltX2N1 c3RvbVNjaGVtZVVucmVnaXN0ZXJlZE9ic2VydmVyLmdldCgpXTsKKyAgICBbW05TTm90aWZpY2F0 aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVyOihpZCltX2VuaGFuY2VkQWNj ZXNzaWJpbGl0eU9ic2VydmVyLmdldCgpXTsKK30KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==