104876 2012-12-12 21:02:27 -0800 Add ASSERTions to ensure that when a CSSProperty is a variable it only ever refers to a CSSValue that is a variable. 2012-12-17 21:36:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson cmarcelo haraken macpherson menard ojan.autocc steveblock webkit.review.bot oldest_to_newest 790253 0 macpherson 2012-12-12 21:02:27 -0800 Add ASSERTions to ensure that CSSPropertys that are variables only ever refer to CSSValues that are variables. 790260 1 179194 macpherson 2012-12-12 21:10:01 -0800 Created attachment 179194 Patch 790287 2 179194 steveblock 2012-12-12 21:52:53 -0800 Comment on attachment 179194 Patch LGTM given that this is all behind ENABLE_CSS_VARIABLES 790292 3 179194 webkit.review.bot 2012-12-12 22:16:11 -0800 Comment on attachment 179194 Patch Clearing flags on attachment: 179194 Committed r137569: <http://trac.webkit.org/changeset/137569> 790293 4 webkit.review.bot 2012-12-12 22:16:14 -0800 All reviewed patches have been landed. Closing bug. 790507 5 haraken 2012-12-13 04:53:16 -0800 A bunch of CSS tests hit the ASSERTs: css3/filters/reference-filter-update-after-remove.html fast/css/variables/border-width.html fast/css/variables/calc-inside-calc.html fast/css/variables/calc-invalid-value.html fast/css/variables/calc-negated-variable.html fast/css/variables/calc-vw-crash.html fast/css/variables/calc.html fast/css/variables/case-insensitive.html fast/css/variables/colors-test.html fast/css/variables/complex-cycle.html fast/css/variables/computed-style.html fast/css/variables/deferred-image-load-from-variable.html fast/css/variables/inherited-values.html fast/css/variables/inline-styles.html fast/css/variables/invalid-shorthand.html fast/css/variables/invalid-variable-value.html fast/css/variables/multi-level-cycle.html fast/css/variables/redefinition.html fast/css/variables/shorthand.html fast/css/variables/simple-cycle.html fast/css/variables/transform-test.html fast/css/variables/use-before-defined.html fast/css/variables/var-filter.html fast/css/variables/var-inside-pair.html fast/css/variables/var-inside-quad.html fast/css/variables/var-inside-shape.html fast/css/variables/var-inside-shorthand.html fast/css/variables/variable-chain.html inspector/styles/variables/css-variables.html 790508 6 haraken 2012-12-13 04:53:49 -0800 Rolled out the patch in r137584. Would you take a look? 790982 7 macpherson 2012-12-13 15:04:48 -0800 (In reply to comment #6) > Rolled out the patch in r137584. Would you take a look? Absolutely. Thanks for rolling it out. 793267 8 179859 macpherson 2012-12-17 19:14:27 -0800 Created attachment 179859 Patch 793285 9 179867 macpherson 2012-12-17 19:40:39 -0800 Created attachment 179867 Patch 793293 10 179867 steveblock 2012-12-17 20:10:45 -0800 Comment on attachment 179867 Patch r=me 793347 11 179867 webkit.review.bot 2012-12-17 21:36:40 -0800 Comment on attachment 179867 Patch Clearing flags on attachment: 179867 Committed r137984: <http://trac.webkit.org/changeset/137984> 793348 12 webkit.review.bot 2012-12-17 21:36:44 -0800 All reviewed patches have been landed. Closing bug. 179194 2012-12-12 21:10:01 -0800 2012-12-17 19:14:22 -0800 Patch bug-104876-20121213160721.patch text/plain 1984 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk5MTk2MzA0MjUxY2Jm OWU0MjFmNjFhMWZhYThhYmUyMGZlMmM4ZS4uZDMyYTcwNzYxMDk3YzY4NzA5YTc5MDY4N2FkNjY3 YWRhYjMzOWJjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTEyICBMdWtl IE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIEFT U0VSVGlvbnMgdG8gZW5zdXJlIHRoYXQgQ1NTUHJvcGVydHlzIHRoYXQgYXJlIHZhcmlhYmxlcyBv bmx5IGV2ZXIgcmVmZXIgdG8gQ1NTVmFsdWVzIHRoYXQgYXJlIHZhcmlhYmxlcy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDg3NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhc3NlcnRpb25zIHRv IENTU1Byb3BlcnR5IGNvbnN0cnVjdG9ycyB0byBtYWtlIHRoYXQgaWYgaXQgaXMgaW5pdGlhbGl6 ZWQgd2l0aCBDU1NQcm9wZXJ0eVZhcmlhYmxlIHRoYXQKKyAgICAgICAgdGhlIHZhbHVlIHR5cGUg YXNzb2NpYXRlZCB3aXRoIGl0IGlzIGFsc28gYSB2YXJpYWJsZS4gVGhpcyBpcyBhbHJlYWR5IGFz c2VydGVkIGF0IHJlYWQgdGltZSwgYnV0IEFTU0VSVGluZworICAgICAgICBoZXJlIHdpbGwgcHJv ZHVjZSBhIG1vcmUgdXNlZnVsIGJhY2t0cmFjZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMg ZnVuY3Rpb25hbGl0eSB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBjc3MvQ1NTUHJvcGVydHkuaDoK KyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5OjpDU1NQcm9wZXJ0eSk6CisKIDIwMTItMTIt MTIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1d IGRvbid0IHdyaXRlIGFkZGl0aW9uYWwgaWRsIGZpbGVzIHRvIGEgZ3lwIHRlbXAgZmlsZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5LmggYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUHJvcGVydHkuaAppbmRleCAyNzY1MGVmNzQyNTA3MzNjN2E3ODcyZDY1MDQ1M2E4 ODIyMThhOWEyLi4yYThiNWY5N2ExNDBhYjEwMTU1YmE3ZmFhZjI0M2VkMTA2OTk4MzBjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydHkuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUHJvcGVydHkuaApAQCAtNTcsNiArNTcsOSBAQCBwdWJsaWM6CiAgICAgICAg IDogbV9tZXRhZGF0YShwcm9wZXJ0eUlELCBzaG9ydGhhbmRJRCwgaW1wb3J0YW50LCBpbXBsaWNp dCwgaXNJbmhlcml0ZWRQcm9wZXJ0eShwcm9wZXJ0eUlEKSkKICAgICAgICAgLCBtX3ZhbHVlKHZh bHVlKQogICAgIHsKKyNpZiBFTkFCTEUoQ1NTX1ZBUklBQkxFUykKKyAgICBBU1NFUlQoKHByb3Bl cnR5SUQgPT0gQ1NTUHJvcGVydHlWYXJpYWJsZSkgPT0gKHZhbHVlICYmIHZhbHVlLT5pc1Zhcmlh YmxlVmFsdWUoKSkpOworI2VuZGlmCiAgICAgfQogCiAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlz LgpAQCAtNjQsNiArNjcsOSBAQCBwdWJsaWM6CiAgICAgICAgIDogbV9tZXRhZGF0YShtZXRhZGF0 YSkKICAgICAgICAgLCBtX3ZhbHVlKHZhbHVlKQogICAgIHsKKyNpZiBFTkFCTEUoQ1NTX1ZBUklB QkxFUykKKyAgICBBU1NFUlQoKG1ldGFkYXRhLm1fcHJvcGVydHlJRCA9PSBDU1NQcm9wZXJ0eVZh cmlhYmxlKSA9PSAodmFsdWUgJiYgdmFsdWUtPmlzVmFyaWFibGVWYWx1ZSgpKSk7CisjZW5kaWYK ICAgICB9CiAKICAgICBDU1NQcm9wZXJ0eUlEIGlkKCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nh c3Q8Q1NTUHJvcGVydHlJRD4obV9tZXRhZGF0YS5tX3Byb3BlcnR5SUQpOyB9Cg== 179859 2012-12-17 19:14:27 -0800 2012-12-17 19:40:34 -0800 Patch bug-104876-20121218141144.patch text/plain 1982 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzAxM2E3MDAxYjI5NmQx N2RkZTk5OWRmNGU3NjkzZGFiMjdlMjEwOS4uYWU0MjU5ZTdhZjUzZjg5MWI3OGQ3NzdjOWI3NDgy MDE0YzIwYjkxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTE2ICBMdWtl IE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIEFT U0VSVGlvbnMgdG8gZW5zdXJlIHRoYXQgQ1NTUHJvcGVydHlzIHRoYXQgYXJlIHZhcmlhYmxlcyBv bmx5IGV2ZXIgcmVmZXIgdG8gQ1NTVmFsdWVzIHRoYXQgYXJlIHZhcmlhYmxlcy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDg3NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhc3NlcnRpb25zIHRv IENTU1Byb3BlcnR5IGNvbnN0cnVjdG9ycyB0byBtYWtlIHRoYXQgaWYgaXQgaXMgaW5pdGlhbGl6 ZWQgd2l0aCBDU1NQcm9wZXJ0eVZhcmlhYmxlIHRoYXQKKyAgICAgICAgdGhlIHZhbHVlIHR5cGUg YXNzb2NpYXRlZCB3aXRoIGl0IGlzIGFsc28gYSB2YXJpYWJsZS4gVGhpcyBpcyBhbHJlYWR5IGFz c2VydGVkIGF0IHJlYWQgdGltZSwgYnV0IEFTU0VSVGluZworICAgICAgICBoZXJlIHdpbGwgcHJv ZHVjZSBhIG1vcmUgdXNlZnVsIGJhY2t0cmFjZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMg ZnVuY3Rpb25hbGl0eSB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBjc3MvQ1NTUHJvcGVydHkuaDoK KyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5OjpDU1NQcm9wZXJ0eSk6CisKIDIwMTItMTIt MTYgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IGJ1aWx0LWlu IFBERiBwbHVnaW4gYW5kIHBsdWdpbiBkb2N1bWVudHMgdG8gYXV0by1zdGFydApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5LmggYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUHJvcGVydHkuaAppbmRleCAyNzY1MGVmNzQyNTA3MzNjN2E3ODcyZDY1MDQ1M2E4ODIyMThh OWEyLi40NzY3YTllZjMzODZhMTI3OTJlNDMzYzYwZGRiNmI3NWUyN2M2N2Q2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUHJvcGVydHkuaApAQCAtNTcsNiArNTcsOSBAQCBwdWJsaWM6CiAgICAgICAgIDogbV9t ZXRhZGF0YShwcm9wZXJ0eUlELCBzaG9ydGhhbmRJRCwgaW1wb3J0YW50LCBpbXBsaWNpdCwgaXNJ bmhlcml0ZWRQcm9wZXJ0eShwcm9wZXJ0eUlEKSkKICAgICAgICAgLCBtX3ZhbHVlKHZhbHVlKQog ICAgIHsKKyNpZiBFTkFCTEUoQ1NTX1ZBUklBQkxFUykKKyAgICBBU1NFUlQoKHByb3BlcnR5SUQg PT0gQ1NTUHJvcGVydHlWYXJpYWJsZSkgPT0gKG1fdmFsdWUgJiYgbV92YWx1ZS0+aXNWYXJpYWJs ZVZhbHVlKCkpKTsKKyNlbmRpZgogICAgIH0KIAogICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcy4K QEAgLTY0LDYgKzY3LDkgQEAgcHVibGljOgogICAgICAgICA6IG1fbWV0YWRhdGEobWV0YWRhdGEp CiAgICAgICAgICwgbV92YWx1ZSh2YWx1ZSkKICAgICB7CisjaWYgRU5BQkxFKENTU19WQVJJQUJM RVMpCisgICAgQVNTRVJUKChtZXRhZGF0YS5tX3Byb3BlcnR5SUQgPT0gQ1NTUHJvcGVydHlWYXJp YWJsZSkgPT0gKHZhbHVlICYmIHZhbHVlLT5pc1ZhcmlhYmxlVmFsdWUoKSkpOworI2VuZGlmCiAg ICAgfQogCiAgICAgQ1NTUHJvcGVydHlJRCBpZCgpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0 PENTU1Byb3BlcnR5SUQ+KG1fbWV0YWRhdGEubV9wcm9wZXJ0eUlEKTsgfQo= 179867 2012-12-17 19:40:39 -0800 2012-12-17 21:36:40 -0800 Patch bug-104876-20121218143756.patch text/plain 1986 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzAxM2E3MDAxYjI5NmQx N2RkZTk5OWRmNGU3NjkzZGFiMjdlMjEwOS4uYWU0MjU5ZTdhZjUzZjg5MWI3OGQ3NzdjOWI3NDgy MDE0YzIwYjkxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTE2ICBMdWtl IE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIEFT U0VSVGlvbnMgdG8gZW5zdXJlIHRoYXQgQ1NTUHJvcGVydHlzIHRoYXQgYXJlIHZhcmlhYmxlcyBv bmx5IGV2ZXIgcmVmZXIgdG8gQ1NTVmFsdWVzIHRoYXQgYXJlIHZhcmlhYmxlcy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDg3NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhc3NlcnRpb25zIHRv IENTU1Byb3BlcnR5IGNvbnN0cnVjdG9ycyB0byBtYWtlIHRoYXQgaWYgaXQgaXMgaW5pdGlhbGl6 ZWQgd2l0aCBDU1NQcm9wZXJ0eVZhcmlhYmxlIHRoYXQKKyAgICAgICAgdGhlIHZhbHVlIHR5cGUg YXNzb2NpYXRlZCB3aXRoIGl0IGlzIGFsc28gYSB2YXJpYWJsZS4gVGhpcyBpcyBhbHJlYWR5IGFz c2VydGVkIGF0IHJlYWQgdGltZSwgYnV0IEFTU0VSVGluZworICAgICAgICBoZXJlIHdpbGwgcHJv ZHVjZSBhIG1vcmUgdXNlZnVsIGJhY2t0cmFjZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMg ZnVuY3Rpb25hbGl0eSB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBjc3MvQ1NTUHJvcGVydHkuaDoK KyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5OjpDU1NQcm9wZXJ0eSk6CisKIDIwMTItMTIt MTYgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IGJ1aWx0LWlu IFBERiBwbHVnaW4gYW5kIHBsdWdpbiBkb2N1bWVudHMgdG8gYXV0by1zdGFydApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5LmggYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUHJvcGVydHkuaAppbmRleCAyNzY1MGVmNzQyNTA3MzNjN2E3ODcyZDY1MDQ1M2E4ODIyMThh OWEyLi41MjJjOWRmMWI5NmFlYjdlNDZiZjZhMGY1Y2VlYmYwZGU5NDI5MWQ0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUHJvcGVydHkuaApAQCAtNTcsNiArNTcsOSBAQCBwdWJsaWM6CiAgICAgICAgIDogbV9t ZXRhZGF0YShwcm9wZXJ0eUlELCBzaG9ydGhhbmRJRCwgaW1wb3J0YW50LCBpbXBsaWNpdCwgaXNJ bmhlcml0ZWRQcm9wZXJ0eShwcm9wZXJ0eUlEKSkKICAgICAgICAgLCBtX3ZhbHVlKHZhbHVlKQog ICAgIHsKKyNpZiBFTkFCTEUoQ1NTX1ZBUklBQkxFUykKKyAgICBBU1NFUlQoKHByb3BlcnR5SUQg PT0gQ1NTUHJvcGVydHlWYXJpYWJsZSkgPT0gKG1fdmFsdWUgJiYgbV92YWx1ZS0+aXNWYXJpYWJs ZVZhbHVlKCkpKTsKKyNlbmRpZgogICAgIH0KIAogICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcy4K QEAgLTY0LDYgKzY3LDkgQEAgcHVibGljOgogICAgICAgICA6IG1fbWV0YWRhdGEobWV0YWRhdGEp CiAgICAgICAgICwgbV92YWx1ZSh2YWx1ZSkKICAgICB7CisjaWYgRU5BQkxFKENTU19WQVJJQUJM RVMpCisgICAgQVNTRVJUKChtZXRhZGF0YS5tX3Byb3BlcnR5SUQgPT0gQ1NTUHJvcGVydHlWYXJp YWJsZSkgPT0gKG1fdmFsdWUgJiYgbV92YWx1ZS0+aXNWYXJpYWJsZVZhbHVlKCkpKTsKKyNlbmRp ZgogICAgIH0KIAogICAgIENTU1Byb3BlcnR5SUQgaWQoKSBjb25zdCB7IHJldHVybiBzdGF0aWNf Y2FzdDxDU1NQcm9wZXJ0eUlEPihtX21ldGFkYXRhLm1fcHJvcGVydHlJRCk7IH0K