104866 2012-12-12 17:18:22 -0800 DOM/DOMWalk.html fails on Chromium Windows 2013-01-15 00:30:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 102500 P2 Normal --- 77037 1 noel.gordon rniwa dominicc eric morrita pdr rniwa shinyak webkit.review.bot oldest_to_newest 790089 0 noel.gordon 2012-12-12 17:18:22 -0800 Chromium win release perf bots at webkit.org are mostly always red. http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Perf%29?numbuilds=100 Cause is test DOM/DOMWalk.html, which reports that time goes backwards or some such, on just about every perf test run. Running DOM/DOMWalk.html (35 of 113) runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 FAILED Finished: 9.610000 s The same error is seen on Chromium Linux, though much less often. 790091 1 rniwa 2012-12-12 17:19:54 -0800 yeah, we need to make those tests use window.performance instead. 790097 2 noel.gordon 2012-12-12 17:23:56 -0800 How do I disable this test (at least until it's fixed by someone who knows this test)? I want green perf bots so I can catch real regressions. 790103 3 rniwa 2012-12-12 17:26:55 -0800 (In reply to comment #2) > How do I disable this test (at least until it's fixed by someone who knows this test)? I want green perf bots so I can catch real regressions. You never catch regressions on webkit perf. bots. Bots run red iff tests fail to complete as expected. It doesn’t catch perf regressions. To do that, you have to look at graphs on webkit-perf.appspot.com 790105 4 noel.gordon 2012-12-12 17:28:14 -0800 /meh I want green perf bots. 790137 5 noel.gordon 2012-12-12 17:53:58 -0800 (In reply to comment #4) > /meh I want green perf bots. so, how do I disable this test? 790158 6 rniwa 2012-12-12 18:13:38 -0800 We don't have a way of skipping a test on one platform. If you want a green bot, please either fix the test or Date.now implementation. I'll try to look into it in the next couple of days in my spare time but don't count on me. 790438 7 179237 rniwa 2012-12-13 02:40:14 -0800 Created attachment 179237 Hopefully fixes the bug 790440 8 rniwa 2012-12-13 02:41:50 -0800 *** Bug 99432 has been marked as a duplicate of this bug. *** 790477 9 179237 noel.gordon 2012-12-13 03:46:58 -0800 Comment on attachment 179237 Hopefully fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=179237&action=review > PerformanceTests/ChangeLog:3 > + [chromium perf] DOM/DOMWalk.html failures Thank you, LGTM. 790704 10 179237 eric 2012-12-13 09:57:28 -0800 Comment on attachment 179237 Hopefully fixes the bug Fancy 790770 11 179237 webkit.review.bot 2012-12-13 11:12:18 -0800 Comment on attachment 179237 Hopefully fixes the bug Clearing flags on attachment: 179237 Committed r137623: <http://trac.webkit.org/changeset/137623> 790772 12 webkit.review.bot 2012-12-13 11:12:22 -0800 All reviewed patches have been landed. Closing bug. 795101 13 rniwa 2012-12-19 19:14:13 -0800 This test is still failing on Chromium Windows. Someone needs to debug this. 795104 14 rniwa 2012-12-19 19:17:34 -0800 Also see https://bugs.webkit.org/show_bug.cgi?id=105491. 807053 15 dominicc 2013-01-15 00:30:51 -0800 *** This bug has been marked as a duplicate of bug 102500 *** 179237 2012-12-13 02:40:14 -0800 2012-12-13 11:12:18 -0800 Hopefully fixes the bug bug-104866-20121213023735.patch text/plain 2406 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzc1NzgpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTEzICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFtjaHJvbWl1bSBwZXJm XSBET00vRE9NV2Fsay5odG1sIGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ4NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVc2UgUGVyZlRlc3RSdW5uZXIubm93IHdoaWNoIGluIHR1cm4g dXNlcyB3aW5kb3cucGVyZm9ybWFuY2Uubm93KCkgd2hlbiBpdCdzIGF2YWlsYWJsZS4KKworICAg ICAgICAqIERPTS9yZXNvdXJjZXMvZG9tLXBlcmYuanM6CisgICAgICAgIChJbnRlcnZhbC5zdGFy dCk6CisgICAgICAgIChJbnRlcnZhbC5zdG9wKToKKyAgICAgICAgKEJlbmNobWFya1N1aXRlLnBy b3RvdHlwZS5SdW5TaW5nbGUpOgorCiAyMDEyLTEyLTA1ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlu eWFrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbU2hhZG93XSBQZXJmb3JtYW5jZSB0ZXN0cyBm b3IgU2hhZG93RE9NIGRpc3RyaWJ1dGlvbgpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9ET00vcmVz b3VyY2VzL2RvbS1wZXJmLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvRE9NL3Jl c291cmNlcy9kb20tcGVyZi5qcwkocmV2aXNpb24gMTM3NTc0KQorKysgUGVyZm9ybWFuY2VUZXN0 cy9ET00vcmVzb3VyY2VzL2RvbS1wZXJmLmpzCSh3b3JraW5nIGNvcHkpCkBAIC04NCw4ICs4NCw4 IEBAIGJ5SWQgPSBmdW5jdGlvbihpZCwgZG9jKSB7CiBmdW5jdGlvbiBJbnRlcnZhbCgpIHsKICAg dmFyIHN0YXJ0XyA9IDA7CiAgIHZhciBzdG9wXyA9IDA7Ci0gIHRoaXMuc3RhcnQgPSBmdW5jdGlv bigpIHsgc3RhcnRfID0gbmV3IERhdGUoKTsgfTsKLSAgdGhpcy5zdG9wID0gZnVuY3Rpb24oKSB7 IHN0b3BfID0gbmV3IERhdGUoKTsgfTsKKyAgdGhpcy5zdGFydCA9IGZ1bmN0aW9uKCkgeyBzdGFy dF8gPSBQZXJmVGVzdFJ1bm5lci5ub3coKTsgfTsKKyAgdGhpcy5zdG9wID0gZnVuY3Rpb24oKSB7 IHN0b3BfID0gUGVyZlRlc3RSdW5uZXIubm93KCk7IH07CiAgIHRoaXMubWljcm9zZWNvbmRzID0g ZnVuY3Rpb24oKSB7IHJldHVybiAoc3RvcF8gLSBzdGFydF8pICogMTAwMDsgfTsKIH0KIApAQCAt MTM5LDcgKzEzOSw3IEBAIGZ1bmN0aW9uIEJlbmNobWFya1N1aXRlKG5hbWUsIGJlbmNobWFya3MK IAogLy8gVGhpcyBjb21wdXRlcyB0aGUgYW1vdW50IG9mIG92ZXJoZWFkIGlzIGFzc29jaWF0ZWQg d2l0aCB0aGUgY2FsbCB0byB0aGUgdGVzdAogLy8gZnVuY3Rpb24gYW5kIGdldHRpbmcgdGhlIGRh dGUuIAotQmVuY2htYXJrU3VpdGUuc3RhcnQgPSBuZXcgRGF0ZSgpOworQmVuY2htYXJrU3VpdGUu c3RhcnQgPSBQZXJmVGVzdFJ1bm5lci5ub3coKTsKIAogQmVuY2htYXJrU3VpdGUuTWF0aCA9IG5l dyAoZnVuY3Rpb24oKSB7CiAgICAgLy8gQ29tcHV0ZXMgdGhlIGdlb21ldHJpYyBtZWFuIG9mIGEg c2V0IG9mIG51bWJlcnMuCkBAIC0yMTUsNyArMjE1LDcgQEAgZnVuY3Rpb24gQmVuY2htYXJrUmVz dWx0KGJlbmNobWFyaywgdGltZQogLy8gc2luZ2xlIGl0ZXJhdGlvbi4KIEJlbmNobWFya1N1aXRl LnByb3RvdHlwZS5SdW5TaW5nbGUgPSBmdW5jdGlvbihiZW5jaG1hcmssIHRpbWVzKSB7CiAgICAg dmFyIGVsYXBzZWQgPSAwOwotICAgIHZhciBzdGFydCA9IG5ldyBEYXRlKCk7CisgICAgdmFyIHN0 YXJ0ID0gUGVyZlRlc3RSdW5uZXIubm93KCk7CiAgICAgdmFyIHJ1bkludGVydmFsID0gbmV3IElu dGVydmFsKCk7CiAgICAgdmFyIHNldHVwUmV0dXJuID0gbnVsbDsKICAgICB2YXIgcnVuUmV0dXJu ID0gbnVsbDsKQEAgLTI1NCw3ICsyNTQsNyBAQCBCZW5jaG1hcmtTdWl0ZS5wcm90b3R5cGUuUnVu U2luZ2xlID0gZnVuCiAgICAgICAgIH0gY2F0Y2ggKGUpIHsKICAgICAgICAgICAgIGVycm9yID0g ZTsKICAgICAgICAgfQotICAgICAgICB0b3RhbFRpbWUgPSBuZXcgRGF0ZSgpIC0gc3RhcnQ7Cisg ICAgICAgIHRvdGFsVGltZSA9IFBlcmZUZXN0UnVubmVyLm5vdygpIC0gc3RhcnQ7CiAgIH0KIAog ICAgIHZhciByZXN1bHQgPSBuZXcgQmVuY2htYXJrUmVzdWx0KGJlbmNobWFyaywgdGltZXMsIGVy cm9yLCBudWxsKTsK