104862 2012-12-12 16:50:42 -0800 "loader_unittests should reset state between runs" 2012-12-14 14:59:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jparent jparent dpranke ojan tony webkit.review.bot oldest_to_newest 790068 0 jparent 2012-12-12 16:50:42 -0800 "loader_unittests should reset state between runs" 790071 1 179152 jparent 2012-12-12 16:54:20 -0800 Created attachment 179152 Patch 790078 2 179152 dpranke 2012-12-12 17:01:52 -0800 Comment on attachment 179152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179152&action=review seems reasonable. > Tools/TestResultServer/static-dashboards/loader_unittests.js:91 > + parseCrossDashboardParameters(); was the parseCrossDashboardParameters() line meant to be part of this? 790086 3 jparent 2012-12-12 17:15:17 -0800 Yeah, parseCrossDashboardParameters() was intentional. One of the other tests calls it, and this test was depending on the modifications to global variables that parseCrossDashboardParameters made (and of course, to that other test running before this one!!!). Once I added the call to resetGlobals(), that state was getting reset, so this test needs to explicitly call it 790095 4 dpranke 2012-12-12 17:22:16 -0800 (In reply to comment #3) > Yeah, parseCrossDashboardParameters() was intentional. One of the other tests calls it, and this test was depending on the modifications to global variables that parseCrossDashboardParameters made (and of course, to that other test running before this one!!!). Once I added the call to resetGlobals(), that state was getting reset, so this test needs to explicitly call it Yeah, sorry, I figured that out after looking at the code but forgot to delete the comment. 790115 5 179152 webkit.review.bot 2012-12-12 17:37:13 -0800 Comment on attachment 179152 Patch Rejecting attachment 179152 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15312045 790646 6 179279 jparent 2012-12-13 08:55:13 -0800 Created attachment 179279 Patch for landing 790655 7 179279 webkit.review.bot 2012-12-13 09:09:46 -0800 Comment on attachment 179279 Patch for landing Clearing flags on attachment: 179279 Committed r137599: <http://trac.webkit.org/changeset/137599> 790656 8 webkit.review.bot 2012-12-13 09:09:50 -0800 All reviewed patches have been landed. Closing bug. 791883 9 179279 ojan 2012-12-14 14:59:28 -0800 Comment on attachment 179279 Patch for landing Hopefully we can get rid of this once Loader no longer uses any globals? 179152 2012-12-12 16:54:20 -0800 2012-12-13 08:55:11 -0800 Patch bug-104862-20121212165141.patch text/plain 2678 jparent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTI1MWFkMDY4ZWIyZjQ2YzQ2MGM1NjFmOTYwNzU2M2Nk NzJkMjdhYi4uZDQ1MWJjYzJkMWVjMTQ4NTYxNDdmZTVjZDRjMDkwNzdhYzEyMTIzMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEyLTEyICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICAibG9hZGVyX3VuaXR0ZXN0cyBzaG91bGQgcmVzZXQgc3RhdGUgYmV0d2VlbiBydW5z IgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODYy CisKKyAgICAgICAgVGhlIGxvYWRlcl91bml0dGVzdHMgd2VyZSBub3QgcmVzZXR0aW5nIHN0YXRl IGJldHdlZW4gcnVucywgbGVhdmluZworICAgICAgICBhIGxvdCBvZiBkYXRhIGJlaGluZCBpbiBn bG9iYWwgb2JqZWN0cyB0aGF0IHRoZSBkYXNoYm9hcmQgYW5kIHRlc3RzCisgICAgICAgIHJlbHkg b24uICBBIGhhbmRmdWwgd2VyZSByZXNldHRpbmcganVzdCBhIGZldyBvYmplY3RzLiAgVXNlIHRo ZSBjb21tb24KKyAgICAgICAgcmVzZXRHbG9iYWxzKCkgbWV0aG9kIGluc3RlYWQuCisKKyAgICAg ICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2xvYWRlcl91bml0dGVzdHMu anM6CisKIDIwMTItMTItMTIgIEp1c3RpbiBOb3Zvc2FkICA8anVub3ZAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBBZGRpbmcgbXlzZWxmIHRvIFNraWFHcmFwaGljcyB3YXRjaGxpc3QKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvbG9hZGVyX3VuaXR0 ZXN0cy5qcyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvbG9hZGVy X3VuaXR0ZXN0cy5qcwppbmRleCA4ODFlMDE3OWFkMGJmZjU5NmRkZDY0ODEzOGQ4YTE3MDlkYjdl YzVmLi44ZjYwYmI2M2UxOTBjN2E3ZWNhMWM3MzgxM2YyOTJiNmJkMjdlYzkwIDEwMDY0NAotLS0g YS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2xvYWRlcl91bml0dGVz dHMuanMKKysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2Fk ZXJfdW5pdHRlc3RzLmpzCkBAIC0yOSw2ICsyOSw3IEBACiBtb2R1bGUoJ2xvYWRlcicpOwogCiB0 ZXN0KCdsb2FkaW5nIHN0ZXBzJywgMSwgZnVuY3Rpb24oKSB7CisgICAgcmVzZXRHbG9iYWxzKCk7 CiAgICAgdmFyIGxvYWRlZFN0ZXBzID0gW107CiAgICAgdmFyIHJlc291cmNlTG9hZGVyID0gbmV3 IGxvYWRlci5Mb2FkZXIoKTsKICAgICBmdW5jdGlvbiBsb2FkaW5nU3RlcDEoKSB7CkBAIC01NCw2 ICs1NSw3IEBAIHRlc3QoJ2xvYWRpbmcgc3RlcHMnLCAxLCBmdW5jdGlvbigpIHsKIH0pOwogCiB0 ZXN0KCdyZXN1bHRzIGZpbGVzIGxvYWRpbmcnLCA1LCBmdW5jdGlvbigpIHsKKyAgICByZXNldEds b2JhbHMoKTsKICAgICB2YXIgZXhwZWN0ZWRMb2FkZWRCdWlsZGVycyA9IFsiV2ViS2l0IExpbnV4 IiwgIldlYktpdCBXaW4iXTsKICAgICB2YXIgbG9hZGVkQnVpbGRlcnMgPSBbXTsKICAgICB2YXIg cmVzb3VyY2VMb2FkZXIgPSBuZXcgbG9hZGVyLkxvYWRlcigpOwpAQCAtODAsMTMgKzgyLDEzIEBA IHRlc3QoJ3Jlc3VsdHMgZmlsZXMgbG9hZGluZycsIDUsIGZ1bmN0aW9uKCkgewogICAgIHRyeSB7 CiAgICAgICAgIHJlc291cmNlTG9hZGVyLl9sb2FkUmVzdWx0c0ZpbGVzKCk7CiAgICAgfSBmaW5h bGx5IHsKLSAgICAgICAgZ19idWlsZGVycyA9IHVuZGVmaW5lZDsKLSAgICAgICAgZ19yZXN1bHRz QnlCdWlsZGVyID0ge307CiAgICAgICAgIGxvYWRlci5yZXF1ZXN0ID0gcmVxdWVzdEZ1bmN0aW9u OwogICAgIH0KIH0pOwogCiB0ZXN0KCdleHBlY3RhdGlvbnMgZmlsZXMgbG9hZGluZycsIDEsIGZ1 bmN0aW9uKCkgeworICAgIHJlc2V0R2xvYmFscygpOworICAgIHBhcnNlQ3Jvc3NEYXNoYm9hcmRQ YXJhbWV0ZXJzKCk7CiAgICAgdmFyIGV4cGVjdGVkTG9hZGVkUGxhdGZvcm1zID0gWyJjaHJvbWl1 bSIsICJjaHJvbWl1bS1hbmRyb2lkIiwgImVmbCIsICJlZmwtd2sxIiwgImVmbC13azIiLCAiZ3Rr IiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImd0ay13azIiLCAibWFjIiwg Im1hYy1saW9uIiwgIm1hYy1zbm93bGVvcGFyZCIsICJxdCIsICJ3aW4iLCAid2syIl07CiAgICAg dmFyIGxvYWRlZFBsYXRmb3JtcyA9IFtdOwpAQCAtMTA5LDkgKzExMSw5IEBAIHRlc3QoJ2V4cGVj dGF0aW9ucyBmaWxlcyBsb2FkaW5nJywgMSwgZnVuY3Rpb24oKSB7CiB9KTsKIAogdGVzdCgncmVz dWx0cyBmaWxlIGZhaWxpbmcgdG8gbG9hZCcsIDIsIGZ1bmN0aW9uKCkgeworICAgIHJlc2V0R2xv YmFscygpOwogICAgIC8vIEZJWE1FOiBsb2FkZXIgc2hvdWxkbid0IGRlcGVuZCBvbiBzdGF0ZSBk ZWZpbmVkIGluIGRhc2hib2FyZF9iYXNlLmpzLgogICAgIGdfYnVpbGRlcnNUaGF0RmFpbGVkVG9M b2FkID0gW107Ci0gICAgZ19idWlsZGVycyA9IHt9OwogCiAgICAgdmFyIHJlc291cmNlTG9hZGVy ID0gbmV3IGxvYWRlci5Mb2FkZXIoKTsKICAgICB2YXIgcmVzb3VyY2VMb2FkQ291bnQgPSAwOwo= 179279 2012-12-13 08:55:13 -0800 2012-12-14 14:59:28 -0800 Patch for landing bug-104862-20121213085233.patch text/plain 2713 jparent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTI1MWFkMDY4ZWIyZjQ2YzQ2MGM1NjFmOTYwNzU2M2Nk NzJkMjdhYi4uN2M0ZTU0MDlhZDdhNmZiNDg2ZTk5ODE5ZmRiZDg4NDgzNGM0YjdiZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEyLTEyICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBMb2FkZXJfdW5pdHRlc3RzIHNob3VsZCByZXNldCBzdGF0ZSBiZXR3ZWVuIHJ1bnMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ4NjIK KworICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFByYW5rZS4KKworICAgICAgICBUaGUgbG9hZGVy X3VuaXR0ZXN0cyB3ZXJlIG5vdCByZXNldHRpbmcgc3RhdGUgYmV0d2VlbiBydW5zLCBsZWF2aW5n CisgICAgICAgIGEgbG90IG9mIGRhdGEgYmVoaW5kIGluIGdsb2JhbCBvYmplY3RzIHRoYXQgdGhl IGRhc2hib2FyZCBhbmQgdGVzdHMKKyAgICAgICAgcmVseSBvbi4gIEEgaGFuZGZ1bCB3ZXJlIHJl c2V0dGluZyBqdXN0IGEgZmV3IG9iamVjdHMuICBVc2UgdGhlIGNvbW1vbgorICAgICAgICByZXNl dEdsb2JhbHMoKSBtZXRob2QgaW5zdGVhZC4KKworICAgICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIv c3RhdGljLWRhc2hib2FyZHMvbG9hZGVyX3VuaXR0ZXN0cy5qczoKKwogMjAxMi0xMi0xMiAgSnVz dGluIE5vdm9zYWQgIDxqdW5vdkBnb29nbGUuY29tPgogCiAgICAgICAgIEFkZGluZyBteXNlbGYg dG8gU2tpYUdyYXBoaWNzIHdhdGNobGlzdApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNl cnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2FkZXJfdW5pdHRlc3RzLmpzIGIvVG9vbHMvVGVzdFJl c3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9sb2FkZXJfdW5pdHRlc3RzLmpzCmluZGV4IDg4 MWUwMTc5YWQwYmZmNTk2ZGRkNjQ4MTM4ZDhhMTcwOWRiN2VjNWYuLjhmNjBiYjYzZTE5MGM3YTdl Y2ExYzczODEzZjI5MmI2YmQyN2VjOTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2 ZXIvc3RhdGljLWRhc2hib2FyZHMvbG9hZGVyX3VuaXR0ZXN0cy5qcworKysgYi9Ub29scy9UZXN0 UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2xvYWRlcl91bml0dGVzdHMuanMKQEAgLTI5 LDYgKzI5LDcgQEAKIG1vZHVsZSgnbG9hZGVyJyk7CiAKIHRlc3QoJ2xvYWRpbmcgc3RlcHMnLCAx LCBmdW5jdGlvbigpIHsKKyAgICByZXNldEdsb2JhbHMoKTsKICAgICB2YXIgbG9hZGVkU3RlcHMg PSBbXTsKICAgICB2YXIgcmVzb3VyY2VMb2FkZXIgPSBuZXcgbG9hZGVyLkxvYWRlcigpOwogICAg IGZ1bmN0aW9uIGxvYWRpbmdTdGVwMSgpIHsKQEAgLTU0LDYgKzU1LDcgQEAgdGVzdCgnbG9hZGlu ZyBzdGVwcycsIDEsIGZ1bmN0aW9uKCkgewogfSk7CiAKIHRlc3QoJ3Jlc3VsdHMgZmlsZXMgbG9h ZGluZycsIDUsIGZ1bmN0aW9uKCkgeworICAgIHJlc2V0R2xvYmFscygpOwogICAgIHZhciBleHBl Y3RlZExvYWRlZEJ1aWxkZXJzID0gWyJXZWJLaXQgTGludXgiLCAiV2ViS2l0IFdpbiJdOwogICAg IHZhciBsb2FkZWRCdWlsZGVycyA9IFtdOwogICAgIHZhciByZXNvdXJjZUxvYWRlciA9IG5ldyBs b2FkZXIuTG9hZGVyKCk7CkBAIC04MCwxMyArODIsMTMgQEAgdGVzdCgncmVzdWx0cyBmaWxlcyBs b2FkaW5nJywgNSwgZnVuY3Rpb24oKSB7CiAgICAgdHJ5IHsKICAgICAgICAgcmVzb3VyY2VMb2Fk ZXIuX2xvYWRSZXN1bHRzRmlsZXMoKTsKICAgICB9IGZpbmFsbHkgewotICAgICAgICBnX2J1aWxk ZXJzID0gdW5kZWZpbmVkOwotICAgICAgICBnX3Jlc3VsdHNCeUJ1aWxkZXIgPSB7fTsKICAgICAg ICAgbG9hZGVyLnJlcXVlc3QgPSByZXF1ZXN0RnVuY3Rpb247CiAgICAgfQogfSk7CiAKIHRlc3Qo J2V4cGVjdGF0aW9ucyBmaWxlcyBsb2FkaW5nJywgMSwgZnVuY3Rpb24oKSB7CisgICAgcmVzZXRH bG9iYWxzKCk7CisgICAgcGFyc2VDcm9zc0Rhc2hib2FyZFBhcmFtZXRlcnMoKTsKICAgICB2YXIg ZXhwZWN0ZWRMb2FkZWRQbGF0Zm9ybXMgPSBbImNocm9taXVtIiwgImNocm9taXVtLWFuZHJvaWQi LCAiZWZsIiwgImVmbC13azEiLCAiZWZsLXdrMiIsICJndGsiLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiZ3RrLXdrMiIsICJtYWMiLCAibWFjLWxpb24iLCAibWFjLXNub3ds ZW9wYXJkIiwgInF0IiwgIndpbiIsICJ3azIiXTsKICAgICB2YXIgbG9hZGVkUGxhdGZvcm1zID0g W107CkBAIC0xMDksOSArMTExLDkgQEAgdGVzdCgnZXhwZWN0YXRpb25zIGZpbGVzIGxvYWRpbmcn LCAxLCBmdW5jdGlvbigpIHsKIH0pOwogCiB0ZXN0KCdyZXN1bHRzIGZpbGUgZmFpbGluZyB0byBs b2FkJywgMiwgZnVuY3Rpb24oKSB7CisgICAgcmVzZXRHbG9iYWxzKCk7CiAgICAgLy8gRklYTUU6 IGxvYWRlciBzaG91bGRuJ3QgZGVwZW5kIG9uIHN0YXRlIGRlZmluZWQgaW4gZGFzaGJvYXJkX2Jh c2UuanMuCiAgICAgZ19idWlsZGVyc1RoYXRGYWlsZWRUb0xvYWQgPSBbXTsKLSAgICBnX2J1aWxk ZXJzID0ge307CiAKICAgICB2YXIgcmVzb3VyY2VMb2FkZXIgPSBuZXcgbG9hZGVyLkxvYWRlcigp OwogICAgIHZhciByZXNvdXJjZUxvYWRDb3VudCA9IDA7Cg==