<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>104858</bug_id>
          
          <creation_ts>2012-12-12 16:09:22 -0800</creation_ts>
          <short_desc>&quot;Running 1 DumpRenderTree over X shards&quot; is not a helpful output</short_desc>
          <delta_ts>2012-12-14 14:15:01 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Ryosuke Niwa">rniwa</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>leviw</cc>
    
    <cc>mjs</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>790018</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-12-12 16:09:22 -0800</bug_when>
    <thetext>Apparently, &quot;shards&quot; in this context means a list of tests, usually directories. I don&apos;t we should be using made up words like &quot;shards&quot; that most of people don&apos;t know the exact meaning of.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790039</commentid>
    <comment_count>1</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-12-12 16:20:51 -0800</bug_when>
    <thetext>As discussed, &quot;shard&quot; is not a made up term. As multiple people have told you, it is a common term used when scheduling a set of tasks to be run across multiple physical resources.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790066</commentid>
    <comment_count>2</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2012-12-12 16:46:58 -0800</bug_when>
    <thetext>Alternate name suggestions (for the UI level at least):

- chunk
- part
- section
- group
- group
- subgroup
- subset

Or any of these (or the word &quot;shard&quot;) could be prefixed with &quot;test&quot;.

I&apos;m sure there&apos;s many other possibilities.

I think shard makes non-server-experts think of separate (possibly physically separate) computing resources, rather than just pieces of data. Thus, for people without good knowledge of server infrastructure, &quot;over 240 shards&quot; would sound like it&apos;s running on 240 different physical/logical servers or 240 different databases, not just running 240 semi-arbitrary chunks of the full test suite.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790072</commentid>
    <comment_count>3</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-12-12 16:56:05 -0800</bug_when>
    <thetext>Also, a typical WebKit contributor doesn’t have an experience working on distributed computing systems. e.g. I graduated from UC Berkeley very recently but I had never heard of the word &quot;shard&quot; in any of my classes except in the context of distributed computing until I joined Google where everyone refers to all sorts of things by &quot;sharding&quot;.

One thing that makes contributing to WebKit really painful is mounds of technical jargons used in our community like &quot;layout tests&quot;, &quot;DRT&quot;, &quot;NRWT&quot;, etc… We should strive to get rid of them as much as possible so that a reasonably intelligent person can understand various things without having to go through many wiki pages.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790092</commentid>
    <comment_count>4</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-12-12 17:20:41 -0800</bug_when>
    <thetext>jargon is often, but not always, bad. Sometimes inventing new terms to accurately and concisely describe concepts is the right thing to do (I am not necessarily making that claim here, mind you).

All of Maciej&apos;s suggestions in comment #2 have the downside of being vague and interpreted as one of many possible concepts. In particular, NRWT already uses &quot;part&quot; and &quot;chunk&quot; to refer to different subsets of the test as well. &quot;shard&quot; has the virtue of having fairly specific connotations, even if they are being applied slightly differently here than one might be used to seeing them.

As I mentioned over #irc, in the server clustering / cloud community, a shard is *not* necessarily a separate physical resource; shards are virtual concepts that get mapped onto physical resources, typically in an M:N manner (which may of course be 1:1, but the whole point of a shard as opposed to a parallel database is that you can move shards between physical resources to redistribute the load, which is exactly what we&apos;re doing here).

&quot;batch&quot; or &quot;job&quot; might be better terms that are at least closer in spirit to &quot;shard&quot; than something generic like &quot;section&quot;. 

Unfortunately, we also use --batch-size in NRWT to mean something else. &quot;suite&quot; is also close, but not quiet right (since people might get confused when a suite doesn&apos;t refer exactly to a directory).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790096</commentid>
    <comment_count>5</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-12-12 17:22:35 -0800</bug_when>
    <thetext>I’d vote for &quot;test groups&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790394</commentid>
    <comment_count>6</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2012-12-13 01:13:57 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; jargon is often, but not always, bad. Sometimes inventing new terms to accurately and concisely describe concepts is the right thing to do (I am not necessarily making that claim here, mind you).
&gt; 
&gt; All of Maciej&apos;s suggestions in comment #2 have the downside of being vague and interpreted as one of many possible concepts. In particular, NRWT already uses &quot;part&quot; and &quot;chunk&quot; to refer to different subsets of the test as well. &quot;shard&quot; has the virtue of having fairly specific connotations, even if they are being applied slightly differently here than one might be used to seeing them.
&gt; 
&gt; As I mentioned over #irc, in the server clustering / cloud community, a shard is *not* necessarily a separate physical resource; shards are virtual concepts that get mapped onto physical resources, typically in an M:N manner (which may of course be 1:1, but the whole point of a shard as opposed to a parallel database is that you can move shards between physical resources to redistribute the load, which is exactly what we&apos;re doing here).

I agree that sometimes jargon can be good for its precision, but you have to consider the possibility that a particular term may confuse more than it enlightens.

At least four WebKit contributors said on IRC that they actually found this confusing and misinterpreted the message. 

In light of this, it seems like a poor defense to say that it&apos;s technically correct jargon in the server clustering / cloud community. Probably most WebKit contributors are not part of the server clustering / cloud community, nor is there any reason to even assume server clustering is the context here..


(Also, it&apos;s kind of crazy that NRWT has so many distinct ways to group the tests that it&apos;s hard to find a free term! I am curious what &quot;part&quot; and &quot;chunk&quot; refer to and why they different from &quot;shard&quot;.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790641</commentid>
    <comment_count>7</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2012-12-13 08:42:43 -0800</bug_when>
    <thetext>If a shard to DRT is almost always a directory, why not say: &quot;running DRT in parallel over X directories&quot; or something similar.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790707</commentid>
    <comment_count>8</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-12-13 09:59:12 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; I agree that sometimes jargon can be good for its precision, but you have to consider the possibility that a particular term may confuse more than it enlightens.

Of course. That&apos;s why I said I wasn&apos;t necessarily making that argument.

&gt; At least four WebKit contributors said on IRC that they actually found this confusing and misinterpreted the message. 
&gt; 

At least as many people on IRC said that they thought this was a correct and accurate term. And it may be that now that the others have had this explained, they are enlightened. I&apos;m pretty sure that&apos;s how learning new vocabulary works.
 
&gt; (Also, it&apos;s kind of crazy that NRWT has so many distinct ways to group the tests that it&apos;s hard to find a free term! I am curious what &quot;part&quot; and &quot;chunk&quot; refer to and why they different from &quot;shard&quot;.)

From new-run-webkit-tests --help:

    --run-chunk=RUN_CHUNK
                        Run a specified chunk (n:l), the nth of len l, of the
                        layout tests
    --run-part=RUN_PART
                        Run a specified part (n:m), the nth of m parts, of the
                        layout tests
    --batch-size=BATCH_SIZE
                        Run a the tests in batches (n), after every n tests,
                        DumpRenderTree is relaunched.

&quot;chunk&quot; and &quot;part&quot; control which tests are run; sharding controls how they are run and is pretty much an internal detail that the user doesn&apos;t normally need to be aware of.

(In reply to comment #7)
&gt; If a shard to DRT is almost always a directory, why not say: &quot;running DRT in parallel over X directories&quot; or something similar.

Because it&apos;s not always a directory. Even in the default case, we carve all of the http tests into a few shards (1/4 the number of DRTs by default), which means that multiple directories are usually in a single shard here. 

Finally, I will note that the code refers to &quot;shards&quot; in multiple places. Any change should update the code as well as the text string in the message.

I suggest that we either leave the wording alone, or make the sharding a debug message so that devs don&apos;t normally see it. I&apos;m fine with either option. Learning a new use of a word is not a bad thing. I am also about to write more documentation about how NRWT works, and will need to refer to this concept as part of that (so it would be good to end this debate sooner rather than later). Perhaps having the documentation will partially address your concerns over confusing users not familiar with this usage.

If you are dead set on wanting to change this, of all of the alternatives that have been suggested, &quot;batch&quot; is probably the second-best word to describe things after &quot;shard&quot;. I don&apos;t think the --batch-size flag is used very often, and we could and should probably rename it to something more descriptive like --restart-drt-after-every-n-tests or something.

I do not like any of those other suggestions that we use generic collective words like &quot;part&quot;, &quot;chunk&quot;, &quot;group&quot;, or &quot;section&quot;. There are already too many generic collections in NRWT and I have been working hard to get rid of them in order to make things clearer. Using one of these words would be a step backwards.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790751</commentid>
    <comment_count>9</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-12-13 10:44:13 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #6)
&gt; &gt; I agree that sometimes jargon can be good for its precision, but you have to consider the possibility that a particular term may confuse more than it enlightens.
&gt; 
&gt; Of course. That&apos;s why I said I wasn&apos;t necessarily making that argument.
&gt; 
&gt; &gt; At least four WebKit contributors said on IRC that they actually found this confusing and misinterpreted the message. 
&gt;
&gt; At least as many people on IRC said that they thought this was a correct and accurate term. And it may be that now that the others have had this explained, they are enlightened. I&apos;m pretty sure that&apos;s how learning new vocabulary works.

As far as I could recall, everyone who said they know what sharding mean in this context were all Google employees.

&gt; (In reply to comment #7)
&gt; Finally, I will note that the code refers to &quot;shards&quot; in multiple places. Any change should update the code as well as the text string in the message.
&gt; 
&gt; I suggest that we either leave the wording alone, or make the sharding a debug message so that devs don&apos;t normally see it. I&apos;m fine with either option.

Making it a debug message will be fine with me so that ordinary users don&apos;t have to get confused by this message.

&gt; Learning a new use of a word is not a bad thing.

As a user of this development tool, I don&apos;t want to learn or need to know anything new unless it&apos;s absolutely necessary to use the tool. The number of technical jargons we have, even in just NRWT, is absolutely insane. This whole elitism and egoism towards knowledge in our industry always drives me nuts. Times like this, I really consider stop being a software engineer and go do something else. And this is why I don&apos;t think software engineers should ever design UIs or write documentations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>790773</commentid>
    <comment_count>10</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-12-13 11:13:41 -0800</bug_when>
    <thetext>&quot;test queues&quot;?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>791282</commentid>
    <comment_count>11</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2012-12-13 20:35:19 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #6)
&gt; &gt; At least four WebKit contributors said on IRC that they actually found this confusing and misinterpreted the message. 
&gt; &gt; 
&gt; 
&gt; At least as many people on IRC said that they thought this was a correct and accurate term. And it may be that now that the others have had this explained, they are enlightened. I&apos;m pretty sure that&apos;s how learning new vocabulary works.

Come on, let&apos;s be a little less smug. This is a UI design problem, not an opportunity to show the class our superior knowledge of jargon terms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>791481</commentid>
    <comment_count>12</comment_count>
      <attachid>179453</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-12-14 02:07:54 -0800</bug_when>
    <thetext>Created attachment 179453
Only mention shards in the debug mode</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>791649</commentid>
    <comment_count>13</comment_count>
      <attachid>179453</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-12-14 09:06:20 -0800</bug_when>
    <thetext>Comment on attachment 179453
Only mention shards in the debug mode

View in context: https://bugs.webkit.org/attachment.cgi?id=179453&amp;action=review

&gt; Tools/Scripts/webkitpy/layout_tests/views/printing.py:119
&gt; +            self._print_debug(&quot;Running %d %ss in parallel over %d shards (%d locked).&quot; %

I would like to keep the &quot;Running 5 DumpRenderTrees&quot; part of the message showing up at the info level. That is a very useful message.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>791727</commentid>
    <comment_count>14</comment_count>
      <attachid>179504</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-12-14 11:31:51 -0800</bug_when>
    <thetext>Created attachment 179504
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>791730</commentid>
    <comment_count>15</comment_count>
      <attachid>179504</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-12-14 11:34:48 -0800</bug_when>
    <thetext>Comment on attachment 179504
Patch

Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>791853</commentid>
    <comment_count>16</comment_count>
      <attachid>179504</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-12-14 14:14:56 -0800</bug_when>
    <thetext>Comment on attachment 179504
Patch

Clearing flags on attachment: 179504

Committed r137770: &lt;http://trac.webkit.org/changeset/137770&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>791854</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-12-14 14:15:01 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>179453</attachid>
            <date>2012-12-14 02:07:54 -0800</date>
            <delta_ts>2012-12-14 11:31:48 -0800</delta_ts>
            <desc>Only mention shards in the debug mode</desc>
            <filename>bug-104858-20121214020516.patch</filename>
            <type>text/plain</type>
            <size>1968</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEzNzczMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE3IEBACisyMDEyLTEyLTE0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor
CisgICAgICAgICJSdW5uaW5nIDEgRHVtcFJlbmRlclRyZWUgb3ZlciBYIHNoYXJkcyIgaXMgbm90
IGEgaGVscGZ1bCBvdXRwdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTEwNDg1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFRoZSB3b3JkICJzaGFyZCIgaXMgbm90IHR5cGljYWxseSB1c2VkIGluIHRlc3Qg
ZnJhbWV3b3Jrcy4gVGhpcyB3b3JkIGlzIGNvbmZ1c2luZyBmb3IgbWFueSBXZWJLaXQKKyAgICAg
ICAgY29udHJpYnV0b3JzIHdobyB0eXBpY2FsbHkgZG9uJ3QgaGF2ZSBtdWNoIGV4cGVyaWVuY2Ug
b24gZGlzdHJpYnV0ZWQgY29tcHV0YXRpb25zIGFuZCBkYXRhYmFzZXMuCisgICAgICAgIFNvIG9u
bHkgcHJpbnQgdGhpcyBtZXNzYWdlIG91dCBpbiB0aGUgZGVidWcgbW9kZS4KKworICAgICAgICAq
IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL3ByaW50aW5nLnB5OgorICAgICAg
ICAoUHJpbnRlci5wcmludF93b3JrZXJzX2FuZF9zaGFyZHMpOgorCiAyMDEyLTEyLTEzICBFcmlj
IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgLS1wcm9maWxlcj1QUk9G
SUxFUiBvcHRpb24gdG8gcnVuLXBlcmYtdGVzdHMgdG8gYWxsb3cgc3BlY2lmeWluZyB3aGljaCBw
cm9maWxlciB0byB1c2Ugb24gcGxhdGZvcm1zIHdpdGggbWFueQpJbmRleDogVG9vbHMvU2NyaXB0
cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3MvcHJpbnRpbmcucHkKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3MvcHJpbnRpbmcucHkJKHJl
dmlzaW9uIDEzNzczMykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Zp
ZXdzL3ByaW50aW5nLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMTQsOSArMTE0LDkgQEAgY2xhc3Mg
UHJpbnRlcihvYmplY3QpOgogICAgIGRlZiBwcmludF93b3JrZXJzX2FuZF9zaGFyZHMoc2VsZiwg
bnVtX3dvcmtlcnMsIG51bV9zaGFyZHMsIG51bV9sb2NrZWRfc2hhcmRzKToKICAgICAgICAgZHJp
dmVyX25hbWUgPSBzZWxmLl9wb3J0LmRyaXZlcl9uYW1lKCkKICAgICAgICAgaWYgbnVtX3dvcmtl
cnMgPT0gMToKLSAgICAgICAgICAgIHNlbGYuX3ByaW50X2RlZmF1bHQoIlJ1bm5pbmcgMSAlcyBv
dmVyICVzLiIgJSAoZHJpdmVyX25hbWUsIGdyYW1tYXIucGx1cmFsaXplKCdzaGFyZCcsIG51bV9z
aGFyZHMpKSkKKyAgICAgICAgICAgIHNlbGYuX3ByaW50X2RlYnVnKCJSdW5uaW5nIDEgJXMgb3Zl
ciAlcy4iICUgKGRyaXZlcl9uYW1lLCBncmFtbWFyLnBsdXJhbGl6ZSgnc2hhcmQnLCBudW1fc2hh
cmRzKSkpCiAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICBzZWxmLl9wcmludF9kZWZhdWx0KCJS
dW5uaW5nICVkICVzcyBpbiBwYXJhbGxlbCBvdmVyICVkIHNoYXJkcyAoJWQgbG9ja2VkKS4iICUK
KyAgICAgICAgICAgIHNlbGYuX3ByaW50X2RlYnVnKCJSdW5uaW5nICVkICVzcyBpbiBwYXJhbGxl
bCBvdmVyICVkIHNoYXJkcyAoJWQgbG9ja2VkKS4iICUKICAgICAgICAgICAgICAgICAobnVtX3dv
cmtlcnMsIGRyaXZlcl9uYW1lLCBudW1fc2hhcmRzLCBudW1fbG9ja2VkX3NoYXJkcykpCiAgICAg
ICAgIHNlbGYuX3ByaW50X2RlZmF1bHQoJycpCiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>179504</attachid>
            <date>2012-12-14 11:31:51 -0800</date>
            <delta_ts>2012-12-14 14:14:56 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-104858-20121214112911.patch</filename>
            <type>text/plain</type>
            <size>3242</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEzNzczMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDEyLTEyLTE0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor
CisgICAgICAgICJSdW5uaW5nIDEgRHVtcFJlbmRlclRyZWUgb3ZlciBYIHNoYXJkcyIgaXMgbm90
IGEgaGVscGZ1bCBvdXRwdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTEwNDg1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFRoZSB3b3JkICJzaGFyZCIgaXMgbm90IHR5cGljYWxseSB1c2VkIGluIHRlc3Qg
ZnJhbWV3b3Jrcy4gVGhpcyB3b3JkIGlzIGNvbmZ1c2luZyBmb3IgbWFueSBXZWJLaXQKKyAgICAg
ICAgY29udHJpYnV0b3JzIHdobyB0eXBpY2FsbHkgZG9uJ3QgaGF2ZSBtdWNoIGV4cGVyaWVuY2Ug
b24gZGlzdHJpYnV0ZWQgY29tcHV0YXRpb25zIGFuZCBkYXRhYmFzZXMuCisgICAgICAgIFNvIG9u
bHkgcHJpbnQgdGhpcyBtZXNzYWdlIG91dCBpbiB0aGUgZGVidWcgbW9kZS4KKworICAgICAgICAq
IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRp
b250ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdz
L3ByaW50aW5nLnB5OgorICAgICAgICAoUHJpbnRlci5wcmludF93b3JrZXJzX2FuZF9zaGFyZHMp
OgorCiAyMDEyLTEyLTEzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAg
ICBBZGQgLS1wcm9maWxlcj1QUk9GSUxFUiBvcHRpb24gdG8gcnVuLXBlcmYtdGVzdHMgdG8gYWxs
b3cgc3BlY2lmeWluZyB3aGljaCBwcm9maWxlciB0byB1c2Ugb24gcGxhdGZvcm1zIHdpdGggbWFu
eQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90
ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkJKHJl
dmlzaW9uIDEzNzczMykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1
bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMTcs
NyArMzE3LDcgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UsIFN0cmVhbQogICAg
ICAgICAgICAgZGVsIG9zLmVudmlyb25bIldFQktJVF9URVNUX01BWF9MT0NLRURfU0hBUkRTIl0K
ICAgICAgICAgXywgcmVndWxhcl9vdXRwdXQsIF8gPSBsb2dnaW5nX3J1bihbJy0tZGVidWctcnd0
LWxvZ2dpbmcnLCAnLS1jaGlsZC1wcm9jZXNzZXMnLCAnMiddLCBzaGFyZWRfcG9ydD1GYWxzZSkK
ICAgICAgICAgdHJ5OgotICAgICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKGFueShbJygxIGxvY2tl
ZCknIGluIGxpbmUgZm9yIGxpbmUgaW4gcmVndWxhcl9vdXRwdXQuYnVmbGlzdF0pKQorICAgICAg
ICAgICAgc2VsZi5hc3NlcnRUcnVlKGFueShbJzEgbG9ja2VkJyBpbiBsaW5lIGZvciBsaW5lIGlu
IHJlZ3VsYXJfb3V0cHV0LmJ1Zmxpc3RdKSkKICAgICAgICAgZmluYWxseToKICAgICAgICAgICAg
IGlmIHNhdmVfZW52X3dlYmtpdF90ZXN0X21heF9sb2NrZWRfc2hhcmRzOgogICAgICAgICAgICAg
ICAgIG9zLmVudmlyb25bIldFQktJVF9URVNUX01BWF9MT0NLRURfU0hBUkRTIl0gPSBzYXZlX2Vu
dl93ZWJraXRfdGVzdF9tYXhfbG9ja2VkX3NoYXJkcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9sYXlvdXRfdGVzdHMvdmlld3MvcHJpbnRpbmcucHkKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv
U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3MvcHJpbnRpbmcucHkJKHJldmlzaW9u
IDEzNzczMykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL3By
aW50aW5nLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMTQsMTAgKzExNCwxMSBAQCBjbGFzcyBQcmlu
dGVyKG9iamVjdCk6CiAgICAgZGVmIHByaW50X3dvcmtlcnNfYW5kX3NoYXJkcyhzZWxmLCBudW1f
d29ya2VycywgbnVtX3NoYXJkcywgbnVtX2xvY2tlZF9zaGFyZHMpOgogICAgICAgICBkcml2ZXJf
bmFtZSA9IHNlbGYuX3BvcnQuZHJpdmVyX25hbWUoKQogICAgICAgICBpZiBudW1fd29ya2VycyA9
PSAxOgotICAgICAgICAgICAgc2VsZi5fcHJpbnRfZGVmYXVsdCgiUnVubmluZyAxICVzIG92ZXIg
JXMuIiAlIChkcml2ZXJfbmFtZSwgZ3JhbW1hci5wbHVyYWxpemUoJ3NoYXJkJywgbnVtX3NoYXJk
cykpKQorICAgICAgICAgICAgc2VsZi5fcHJpbnRfZGVmYXVsdCgiUnVubmluZyAxICVzLiIgJSBk
cml2ZXJfbmFtZSkKKyAgICAgICAgICAgIHNlbGYuX3ByaW50X2RlYnVnKCIoJXMpLiIgJSBncmFt
bWFyLnBsdXJhbGl6ZSgnc2hhcmQnLCBudW1fc2hhcmRzKSkKICAgICAgICAgZWxzZToKLSAgICAg
ICAgICAgIHNlbGYuX3ByaW50X2RlZmF1bHQoIlJ1bm5pbmcgJWQgJXNzIGluIHBhcmFsbGVsIG92
ZXIgJWQgc2hhcmRzICglZCBsb2NrZWQpLiIgJQotICAgICAgICAgICAgICAgIChudW1fd29ya2Vy
cywgZHJpdmVyX25hbWUsIG51bV9zaGFyZHMsIG51bV9sb2NrZWRfc2hhcmRzKSkKKyAgICAgICAg
ICAgIHNlbGYuX3ByaW50X2RlZmF1bHQoIlJ1bm5pbmcgJWQgJXNzIGluIHBhcmFsbGVsLiIgJSAo
bnVtX3dvcmtlcnMsIGRyaXZlcl9uYW1lKSkKKyAgICAgICAgICAgIHNlbGYuX3ByaW50X2RlYnVn
KCIoJWQgc2hhcmRzOyAlZCBsb2NrZWQpLiIgJSAobnVtX3NoYXJkcywgbnVtX2xvY2tlZF9zaGFy
ZHMpKQogICAgICAgICBzZWxmLl9wcmludF9kZWZhdWx0KCcnKQogCiAgICAgZGVmIF9wcmludF9l
eHBlY3RlZF9yZXN1bHRzX29mX3R5cGUoc2VsZiwgcnVuX3Jlc3VsdHMsIHJlc3VsdF90eXBlLCBy
ZXN1bHRfdHlwZV9zdHIsIHRlc3RzX3dpdGhfcmVzdWx0X3R5cGVfY2FsbGJhY2spOgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>