104856 2012-12-12 16:00:49 -0800 rework ChromiumAndroidDriver.start() et. al to avoid funky layering 2012-12-12 17:59:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric ojan peter webkit.review.bot oldest_to_newest 790012 0 dpranke 2012-12-12 16:00:49 -0800 rework ChromiumAndroidDriver.start() et. al to avoid funky layering 790016 1 179141 dpranke 2012-12-12 16:07:46 -0800 Created attachment 179141 Patch 790024 2 179141 eric 2012-12-12 16:14:45 -0800 Comment on attachment 179141 Patch I'll test your patch locally and report back. 790047 3 179141 eric 2012-12-12 16:28:19 -0800 Comment on attachment 179141 Patch LGTM. 790147 4 179141 webkit.review.bot 2012-12-12 17:59:18 -0800 Comment on attachment 179141 Patch Clearing flags on attachment: 179141 Committed r137550: <http://trac.webkit.org/changeset/137550> 790148 5 webkit.review.bot 2012-12-12 17:59:22 -0800 All reviewed patches have been landed. Closing bug. 179141 2012-12-12 16:07:46 -0800 2012-12-12 17:59:18 -0800 Patch bug-104856-20121212160622.patch text/plain 5109 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmFiN2RhM2I1ODZlNTY3NDFkNDBkMmI2NjYxMDI0ZWNm ZGQ0ZjNhOS4uN2ViNzJmMzFhOWVhN2U4M2I2ZWJjZDE3MTVlNjk1YjdjYzNiNmJmMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTEyLTEyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHJld29yayBDaHJvbWl1bUFuZHJvaWREcml2ZXIuc3RhcnQoKSBldC4gYWwgdG8gYXZv aWQgZnVua3kgbGF5ZXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNDg1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIHIxMzc1MjMgLyBidWcgMTAzNTcgaW50cm9kdWNlZCBzb21lIGJhY2stYW5kLWZv cnRoIGhvcHBpbmcgZHVyaW5nCisgICAgICAgIGRyaXZlci5zdGFydCgpIGluIHRoZSBjaHJvbWl1 bSBhbmRyb2lkIHBvcnQuIFRoaXMgcGF0Y2ggY2xlYW5zIGl0CisgICAgICAgIHVwIGEgYml0Lgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9h bmRyb2lkLnB5OgorICAgICAgICAoQ2hyb21pdW1BbmRyb2lkRHJpdmVyLl9faW5pdF9fKToKKyAg ICAgICAgKENocm9taXVtQW5kcm9pZERyaXZlci5fc3RhcnRfb25jZSk6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkX3VuaXR0ZXN0 LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZHJpdmVy LnB5OgorICAgICAgICAoRHJpdmVyLnN0YXJ0KToKKyAgICAgICAgKERyaXZlci5fc3RhcnQpOgor CiAyMDEyLTEyLTEyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBB ZGQgc3VwcG9ydCBmb3IgcnVuLXBlcmYtdGVzdHMgLS1jaHJvbWl1bS1hbmRyb2lkIC0tcHJvZmls ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9j aHJvbWl1bV9hbmRyb2lkLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5CmluZGV4IDQyMWE1MGE2YzhhZTllZDhjNjJmZTFlZjc2 NmMwZjNlOGE4YTcyZjUuLmRiZmM0NjFkMjMwZDJkZDlkNTQ2ZWI5NWEyNWUyMmQ2ZDVhZjU0Njgg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hy b21pdW1fYW5kcm9pZC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkKQEAgLTUwNyw3ICs1MDcsNiBAQCBjbGFzcyBDaHJv bWl1bUFuZHJvaWREcml2ZXIoZHJpdmVyLkRyaXZlcik6CiAgICAgICAgICAgICAgICAgc3lzLmV4 aXQoMSkKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHNlbGYuX3Byb2ZpbGVyID0gTm9uZQot ICAgICAgICBzZWxmLl9kZWxheV9wb3N0X3N0YXJ0X3Rhc2tzID0gRmFsc2UKIAogICAgIGRlZiBf X2RlbF9fKHNlbGYpOgogICAgICAgICBzZWxmLl90ZWFyZG93bl9wZXJmb3JtYW5jZSgpCkBAIC03 NjcsNyArNzY2LDYgQEAgY2xhc3MgQ2hyb21pdW1BbmRyb2lkRHJpdmVyKGRyaXZlci5Ecml2ZXIp OgogICAgICAgICBzZWxmLl9hYm9ydCgnRmFpbGVkIHRvIHN0YXJ0IER1bXBSZW5kZXJUcmVlIGFw cGxpY2F0aW9uIG11bHRpcGxlIHRpbWVzLiBHaXZlIHVwLicpCiAKICAgICBkZWYgX3N0YXJ0X29u Y2Uoc2VsZiwgcGl4ZWxfdGVzdHMsIHBlcl90ZXN0X2FyZ3MpOgotICAgICAgICBzZWxmLl9kZWxh eV9wb3N0X3N0YXJ0X3Rhc2tzID0gVHJ1ZSAgIyBUaGlzIGlzIGEgaGFjayB0byBub3Qgc3RhcnQg dGhlIHByb2ZpbGVyIHVudGlsIGFmdGVyIHRoZSByZW1vdGUgcHJvY2VzcyBpcyBmdWxseSBzZXR1 cC4KICAgICAgICAgc3VwZXIoQ2hyb21pdW1BbmRyb2lkRHJpdmVyLCBzZWxmKS5fc3RhcnQocGl4 ZWxfdGVzdHMsIHBlcl90ZXN0X2FyZ3MpCiAKICAgICAgICAgc2VsZi5fbG9nX2RlYnVnKCdTdGFy dGluZyBmb3J3YXJkZXInKQpAQCAtODM2LDE4ICs4MzQsMTAgQEAgY2xhc3MgQ2hyb21pdW1BbmRy b2lkRHJpdmVyKGRyaXZlci5Ecml2ZXIpOgogICAgICAgICAgICAgX2xvZy5lcnJvcignRmFpbGVk IHRvIHN0YXJ0IER1bXBSZW5kZXJUcmVlOiBcbiVzJyAlIG91dHB1dCkKICAgICAgICAgICAgIHJl dHVybiBGYWxzZQogCi0gICAgICAgIHNlbGYuX2RlbGF5X3Bvc3Rfc3RhcnRfdGFza3MgPSBGYWxz ZQotICAgICAgICBzZWxmLl9ydW5fcG9zdF9zdGFydF90YXNrcygpCi0KICAgICAgICAgIyBJbmZv cm0gdGhlIGRlYWRsb2NrIGRldGVjdG9yIHRoYXQgdGhlIHN0YXJ0dXAgaXMgc3VjY2Vzc2Z1bCB3 aXRob3V0IGRlYWRsb2NrLgogICAgICAgICBub3JtYWxfc3RhcnR1cF9ldmVudC5zZXQoKQogICAg ICAgICByZXR1cm4gVHJ1ZQogCi0gICAgZGVmIF9ydW5fcG9zdF9zdGFydF90YXNrcyhzZWxmKToK LSAgICAgICAgaWYgc2VsZi5fZGVsYXlfcG9zdF9zdGFydF90YXNrczoKLSAgICAgICAgICAgIHJl dHVybgotICAgICAgICBzdXBlcihDaHJvbWl1bUFuZHJvaWREcml2ZXIsIHNlbGYpLl9ydW5fcG9z dF9zdGFydF90YXNrcygpCi0KICAgICBkZWYgX3BpZF9mcm9tX2FuZHJvaWRfcHNfb3V0cHV0KHNl bGYsIHBzX291dHB1dCwgcGFja2FnZV9uYW1lKToKICAgICAgICAgIyBwcyBvdXRwdXQgc2VlbXMg dG8gYmUgZml4ZWQgd2lkdGgsIHdlIG9ubHkgY2FyZSBhYm91dCB0aGUgbmFtZSBhbmQgdGhlIHBp ZAogICAgICAgICAjIHUwX2E3MiAgICAyMTYzMCAxMjUgICA5NDc5MjAgNTkzNjQgZmZmZmZmZmYg NDAwYmVlZTQgUyBvcmcuY2hyb21pdW0ubmF0aXZlX3Rlc3QKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZF91bml0dGVz dC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1f YW5kcm9pZF91bml0dGVzdC5weQppbmRleCA1MmQ4MDMzOGZkMzdiYTQ1NGI5YjZkYTJmNTgzNWMy ODA3MjNhMzM5Li44MThmNjAzZjBiN2JhYzM0ZTQ4OGQ4MmFlMjEwMmMyZWVlYmMwOTgwIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVt X2FuZHJvaWRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkX3VuaXR0ZXN0LnB5CkBAIC0zMDksNyArMzA5LDcg QEAgU2FtcGxlcyBpbiBrZXJuZWwgbW9kdWxlcyBjYW4ndCBiZSByZXNvbHZlZCBhcyB3ZWxsLgog ICAgICAyLjczJSAgIER1bXBSZW5kZXJUcmVlICBEdW1wUmVuZGVyVHJlZSAgICAgICAgICAgICAg IFsuXSBXZWJDb3JlOjpEb2N1bWVudFY4SW50ZXJuYWw6OmdldEVsZW1lbnRzQnlUYWdOYW1lQ2Fs bGJhY2sodjg6OkFyZ3VtZW50cyBjb25zdCYpCiAiIiIKICAgICAgICAgaG9zdCA9IE1vY2tTeXN0 ZW1Ib3N0KCkKLSAgICAgICAgcHJvZmlsZXIgPSBjaHJvbWl1bV9hbmRyb2lkLkFuZHJvaWRQZXJm KGhvc3QsICcvYmluL2V4ZWN1dGFibGUnLCAnL3RtcC9vdXRwdXQnLCAnZGV2aWNlLXNlcmlhbCcs ICdmb28nKQorICAgICAgICBwcm9maWxlciA9IGNocm9taXVtX2FuZHJvaWQuQW5kcm9pZFBlcmYo aG9zdCwgJy9iaW4vZXhlY3V0YWJsZScsICcvdG1wL291dHB1dCcsICdhZGItcGF0aCcsICdkZXZp Y2Utc2VyaWFsJywgJ2ZvbycpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocHJvZmlsZXIuX2Zp cnN0X3Rlbl9saW5lc19vZl9wcm9maWxlKHBlcmZfb3V0cHV0KSwgZXhwZWN0ZWRfZmlyc3RfdGVu X2xpbmVzKQogCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvZHJpdmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9kcml2ZXIucHkKaW5kZXggNTQ3YjRlYjc5MGNlMTFmNjAyNWIzMTVlNTlhMDkzN2QyNTIy ODViNi4uMmJhZjU5ZTk0NWIzYzEzMGQ2YjQ2ODI0NDRiN2FkODVhNjNlYWRhMiAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9kcml2ZXIucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9kcml2ZXIucHkKQEAg LTI3Niw2ICsyNzYsNyBAQCBjbGFzcyBEcml2ZXIob2JqZWN0KToKICAgICAgICAgIyBpbnRvIHJ1 bl90ZXN0KCkgZGlyZWN0bHkuCiAgICAgICAgIGlmIG5vdCBzZWxmLl9zZXJ2ZXJfcHJvY2VzczoK ICAgICAgICAgICAgIHNlbGYuX3N0YXJ0KHBpeGVsX3Rlc3RzLCBwZXJfdGVzdF9hcmdzKQorICAg ICAgICAgICAgc2VsZi5fcnVuX3Bvc3Rfc3RhcnRfdGFza3MoKQogCiAgICAgZGVmIF9zZXR1cF9l bnZpcm9uX2Zvcl9kcml2ZXIoc2VsZiwgZW52aXJvbm1lbnQpOgogICAgICAgICBlbnZpcm9ubWVu dFsnRFlMRF9MSUJSQVJZX1BBVEgnXSA9IHNlbGYuX3BvcnQuX2J1aWxkX3BhdGgoKQpAQCAtMjk5 LDcgKzMwMCw2IEBAIGNsYXNzIERyaXZlcihvYmplY3QpOgogICAgICAgICBzZWxmLl9jcmFzaGVk X3BpZCA9IE5vbmUKICAgICAgICAgc2VsZi5fc2VydmVyX3Byb2Nlc3MgPSBzZWxmLl9wb3J0Ll9z ZXJ2ZXJfcHJvY2Vzc19jb25zdHJ1Y3RvcihzZWxmLl9wb3J0LCBzZXJ2ZXJfbmFtZSwgc2VsZi5j bWRfbGluZShwaXhlbF90ZXN0cywgcGVyX3Rlc3RfYXJncyksIGVudmlyb25tZW50KQogICAgICAg ICBzZWxmLl9zZXJ2ZXJfcHJvY2Vzcy5zdGFydCgpCi0gICAgICAgIHNlbGYuX3J1bl9wb3N0X3N0 YXJ0X3Rhc2tzKCkKIAogICAgIGRlZiBfcnVuX3Bvc3Rfc3RhcnRfdGFza3Moc2VsZik6CiAgICAg ICAgICMgUmVtb3RlIGRyaXZlcnMgbWF5IG92ZXJyaWRlIHRoaXMgdG8gZGVsYXkgcG9zdC1zdGFy dCB0YXNrcyB1bnRpbCB0aGUgc2VydmVyIGhhcyBhY2snZC4K