104855 2012-12-12 15:39:24 -0800 Block level pseudo elements bleed background color to <html> 2012-12-20 10:49:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn dglazkov eric jchaffraix ojan webkit.review.bot oldest_to_newest 789990 0 esprehn 2012-12-12 15:39:24 -0800 Block level pseudo elements bleed background color to <html> 790007 1 179138 esprehn 2012-12-12 15:55:28 -0800 Created attachment 179138 Patch 790088 2 179138 webkit.review.bot 2012-12-12 17:17:39 -0800 Comment on attachment 179138 Patch Attachment 179138 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15317012 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 790125 3 esprehn 2012-12-12 17:48:50 -0800 (In reply to comment #2) > (From update of attachment 179138 [details]) > Attachment 179138 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15317012 > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html This is definitely not related, seeing as this patch only contains tests. :) 790855 4 179138 jchaffraix 2012-12-13 13:18:04 -0800 Comment on attachment 179138 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179138&action=review > LayoutTests/ChangeLog:21 > + This was reported as a Chromium Bug: > + https://code.google.com/p/chromium/issues/detail?id=75544 We usually don't put downstream bug here as they have little signification in WebKit. > LayoutTests/ChangeLog:23 > + Extra space. > LayoutTests/fast/css-generated-content/html-pseudo-background-color.html:8 > + } I think you should also check for html:after. Either in this test (with a different color and the condition for passing would be "there should be no background color" or another one. > LayoutTests/fast/css-generated-content/html-pseudo-background-color.html:11 > +<p> Your bug should say what it tests (ie include a description). Without the ChangeLog, it is difficult to see what could go wrong. Including the bug number and title is also nice. 795133 5 esprehn 2012-12-19 20:49:03 -0800 (In reply to comment #4) > (From update of attachment 179138 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179138&action=review > ... > > Your bug should say what it tests (ie include a description). Without the ChangeLog, it is difficult to see what could go wrong. So to explain what this bug is about: RenderObject::isRoot checks if document()->documentElement() == m_node and in the old generated content implementation m_node was set to the generatingNode so for html:before or html:after so isRoot() would return true. This meant that when we go through RenderBox::paintBackground we would end up painting the generated content's background color over the whole document. This is fixed by the new generated content implementation that was turned on in r137336 because m_node is now the PseudoElement, not the <html> element. 795138 6 180271 esprehn 2012-12-19 21:03:54 -0800 Created attachment 180271 Patch 795560 7 180271 webkit.review.bot 2012-12-20 10:49:49 -0800 Comment on attachment 180271 Patch Clearing flags on attachment: 180271 Committed r138274: <http://trac.webkit.org/changeset/138274> 795561 8 webkit.review.bot 2012-12-20 10:49:56 -0800 All reviewed patches have been landed. Closing bug. 179138 2012-12-12 15:55:28 -0800 2012-12-19 21:03:50 -0800 Patch bug-104855-20121212155249.patch text/plain 2603 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTE3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2MyZWU3YTU4ZTIwMWYwYmQ0Y2U4 MDNmZDlmNDEzNTUzYmQwODYzYS4uMjVhNjU5ZGEyZDQ1ZWRhNWVjZjdhYmEwMTIxNjBlOWNmMzZh ZmNhYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTEyLTEyICBFbGxpb3R0IFNwcmVobiAg PGVzcHJlaG5AZ21haWwuY29tPgorCisgICAgICAgIEJsb2NrIGxldmVsIHBzZXVkbyBlbGVtZW50 cyBibGVlZCBiYWNrZ3JvdW5kIGNvbG9yIHRvIDxodG1sPgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVmb3JlIHIxMzczMzYgcGxhY2luZyBhIHBzZXVk byBlbGVtZW50IDpiZWZvcmUgb3IgOmFmdGVyIHRoYXQgd2FzIGRpc3BsYXkKKyAgICAgICAgYmxv Y2sgb24gdGhlIDxodG1sPiBlbGVtZW50IHdvdWxkIGFsc28gc2V0IHRoZSBiYWNrZ3JvdW5kIGNv bG9yIG9mIHRoZQorICAgICAgICByb290IG9mIHRoZSBkb2N1bWVudC4KKworICAgICAgICBUaGlz IHdhcyBiZWNhdXNlIFJlbmRlck9iamVjdDo6aXNSb290IGNoZWNrZWQgaWYgZG9jdW1lbnQoKS0+ ZG9jdW1lbnRFbGVtZW50KCkgPT0gbV9ub2RlLAorICAgICAgICB3aGljaCB3YXMgdHJ1ZSBmb3Ig aHRtbDpiZWZvcmUgb3IgaHRtbDphZnRlciB3aXRoIHRoZSBvbGQgaW1wbGVtZW50YXRpb24KKyAg ICAgICAgb2YgZ2VuZXJhdGVkIGNvbnRlbnQuIEluc3RlYWQgaXQgc2hvdWxkIGhhdmUgY29tcGFy ZWQgYWdhaW5zdCBub2RlKCkgd2hpY2gKKyAgICAgICAgd291bGQgaGF2ZSBjb21wZW5zYXRlZCBm b3IgdGhlIGFub255bW91cyBnZW5lcmF0ZWQgY29udGVudC4KKworICAgICAgICBUaGlzIGlzIGZp eGVkIGJ5IHRoZSBuZXcgZ2VuZXJhdGVkIGNvbnRlbnQgaW1wbGVtZW50YXRpb24gdGhhdCB3YXMg dHVybmVkCisgICAgICAgIG9uIGluIHIxMzczMzYgYmVjYXVzZSBtX25vZGUgaXMgbm93IHRoZSBQ c2V1ZG9FbGVtZW50LCBub3QgdGhlIGdlbmVyYXRpbmdOb2RlLgorCisgICAgICAgIFRoaXMgd2Fz IHJlcG9ydGVkIGFzIGEgQ2hyb21pdW0gQnVnOgorICAgICAgICBodHRwczovL2NvZGUuZ29vZ2xl LmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9NzU1NDQKKworCisgICAgICAgICogZmFz dC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaHRtbC1wc2V1ZG8tYmFja2dyb3VuZC1jb2xvci1leHBl Y3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9o dG1sLXBzZXVkby1iYWNrZ3JvdW5kLWNvbG9yLmh0bWw6IEFkZGVkLgorCiAyMDEyLTEyLTEyICBD aHJpcyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IE9m ZmxpbmVBdWRpb0NvbnRleHQgY29uc3RydWN0b3IKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2h0bWwtcHNldWRvLWJhY2tncm91bmQtY29sb3ItZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2h0bWwt cHNldWRvLWJhY2tncm91bmQtY29sb3ItZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wMmI3YTUy ODFjYzQwN2VhMjE4NDk3YTY3ODU3ODZhYTVhNDIzYzYzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaHRtbC1wc2V1ZG8tYmFja2dyb3Vu ZC1jb2xvci1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsNSBAQAorPCFET0NUWVBFIGh0bWw+CisK KzxwPgorICAgIFRoZSBwYWdlIHNob3VsZCBub3QgYmUgcmVkLgorPC9wPgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaHRtbC1wc2V1ZG8tYmFja2dy b3VuZC1jb2xvci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQv aHRtbC1wc2V1ZG8tYmFja2dyb3VuZC1jb2xvci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmM5MGMzMjc2NmE4 OTZlOTU2Yzc3ZGVkYzBjM2E3NThhYjBkYzIzZmMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9odG1sLXBzZXVkby1iYWNrZ3JvdW5kLWNv bG9yLmh0bWwKQEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIGh0bWw+CisKKzxzdHlsZT4KKyAg ICBodG1sOmJlZm9yZSB7CisgICAgICAgIGJhY2tncm91bmQ6IHJlZDsKKyAgICAgICAgY29udGVu dDogIiI7CisgICAgICAgIGRpc3BsYXk6IGJsb2NrOworICAgIH0KKzwvc3R5bGU+CisKKzxwPgor ICAgIFRoZSBwYWdlIHNob3VsZCBub3QgYmUgcmVkLgorPC9wPgo= 180271 2012-12-19 21:03:54 -0800 2012-12-20 10:49:49 -0800 Patch bug-104855-20121219210110.patch text/plain 3025 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjE0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOThmMGMwMmVmMjMxN2FiNWZhOWY5 Y2JkODJlNmIzOTkyMTEwOTMyZC4uM2M5NTEzODhmMDcwOGJmOTFiNTVkZjA2NzliODEwMDY0ZDU2 MDcwZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEyLTE5ICBFbGxpb3R0IFNwcmVobiAg PGVzcHJlaG5AZ21haWwuY29tPgorCisgICAgICAgIEJsb2NrIGxldmVsIHBzZXVkbyBlbGVtZW50 cyBibGVlZCBiYWNrZ3JvdW5kIGNvbG9yIHRvIDxodG1sPgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg SnVsaWVuIENoYWZmcmFpeC4KKworICAgICAgICBCZWZvcmUgcjEzNzMzNiBwbGFjaW5nIGEgcHNl dWRvIGVsZW1lbnQgOmJlZm9yZSBvciA6YWZ0ZXIgdGhhdCB3YXMgZGlzcGxheQorICAgICAgICBi bG9jayBvbiB0aGUgPGh0bWw+IGVsZW1lbnQgd291bGQgYWxzbyBzZXQgdGhlIGJhY2tncm91bmQg Y29sb3Igb2YgdGhlCisgICAgICAgIHJvb3Qgb2YgdGhlIGRvY3VtZW50LgorCisgICAgICAgIFRo aXMgd2FzIGJlY2F1c2UgUmVuZGVyT2JqZWN0Ojppc1Jvb3QgY2hlY2tlZCBpZiBkb2N1bWVudCgp LT5kb2N1bWVudEVsZW1lbnQoKSA9PSBtX25vZGUsCisgICAgICAgIHdoaWNoIHdhcyB0cnVlIGZv ciBodG1sOmJlZm9yZSBvciBodG1sOmFmdGVyIHdpdGggdGhlIG9sZCBpbXBsZW1lbnRhdGlvbgor ICAgICAgICBvZiBnZW5lcmF0ZWQgY29udGVudC4gSW5zdGVhZCBpdCBzaG91bGQgaGF2ZSBjb21w YXJlZCBhZ2FpbnN0IG5vZGUoKSB3aGljaAorICAgICAgICB3b3VsZCBoYXZlIGNvbXBlbnNhdGVk IGZvciB0aGUgYW5vbnltb3VzIGdlbmVyYXRlZCBjb250ZW50LgorCisgICAgICAgIFRoaXMgaXMg Zml4ZWQgYnkgdGhlIG5ldyBnZW5lcmF0ZWQgY29udGVudCBpbXBsZW1lbnRhdGlvbiB0aGF0IHdh cyB0dXJuZWQKKyAgICAgICAgb24gaW4gcjEzNzMzNiBiZWNhdXNlIG1fbm9kZSBpcyBub3cgdGhl IFBzZXVkb0VsZW1lbnQsIG5vdCB0aGUgZ2VuZXJhdGluZ05vZGUuCisKKyAgICAgICAgKiBmYXN0 L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9odG1sLXBzZXVkby1iYWNrZ3JvdW5kLWNvbG9yLWV4cGVj dGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2h0 bWwtcHNldWRvLWJhY2tncm91bmQtY29sb3IuaHRtbDogQWRkZWQuCisKIDIwMTItMTItMTkgIEZp bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBKU09iamVjdDo6ZW5zdXJl PEluZGV4aW5nVHlwZT4gc2hvdWxkIGdyYWNlZnVsbHkgaGFuZGxlIEludGVyY2VwdHNHZXRPd24u Li4sIGFuZCBzaG91bGQgbmV2ZXIgYmUgY2FsbGVkIHdoZW4gdGhlICd0aGlzJyBpcyBub3QgYW4g b2JqZWN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVu dC9odG1sLXBzZXVkby1iYWNrZ3JvdW5kLWNvbG9yLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9odG1sLXBzZXVkby1iYWNrZ3JvdW5kLWNvbG9y LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzk3NmNkOGM2NjhiNTY1NzRlNGEzYWQxMDdhYjE3 NjU1YzMzMGVlYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVy YXRlZC1jb250ZW50L2h0bWwtcHNldWRvLWJhY2tncm91bmQtY29sb3ItZXhwZWN0ZWQuaHRtbApA QCAtMCwwICsxLDkgQEAKKzwhRE9DVFlQRSBodG1sPgorCis8cD5CdWcgMTA0ODU1OiBCbG9jayBs ZXZlbCBwc2V1ZG8gZWxlbWVudHMgYmxlZWQgYmFja2dyb3VuZCBjb2xvciB0byAmbHQ7aHRtbCZn dDs8L3A+CisKKzxwPk5laXRoZXIgZnJhbWUgc2hvdWxkIGJlIHJlZC48L3A+CisKKzxpZnJhbWU+ PC9pZnJhbWU+CisKKzxpZnJhbWU+PC9pZnJhbWU+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9odG1sLXBzZXVkby1iYWNrZ3JvdW5kLWNvbG9yLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9odG1sLXBzZXVkby1i YWNrZ3JvdW5kLWNvbG9yLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODMyMDQyMjNmOTAxNzVmYzk3NzgwMTll ZDRkMTY5ZTZhMjMyMDRkZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz LWdlbmVyYXRlZC1jb250ZW50L2h0bWwtcHNldWRvLWJhY2tncm91bmQtY29sb3IuaHRtbApAQCAt MCwwICsxLDI1IEBACis8IURPQ1RZUEUgaHRtbD4KKworPHA+QnVnIDEwNDg1NTogQmxvY2sgbGV2 ZWwgcHNldWRvIGVsZW1lbnRzIGJsZWVkIGJhY2tncm91bmQgY29sb3IgdG8gJmx0O2h0bWwmZ3Q7 PC9wPgorCis8cD5OZWl0aGVyIGZyYW1lIHNob3VsZCBiZSByZWQuPC9wPgorCis8aWZyYW1lIHNy Y2RvYz0nCisgICAgPHN0eWxlPgorICAgICAgICBodG1sOmJlZm9yZSB7IAorICAgICAgICAgICAg Y29udGVudDogIiI7CisgICAgICAgICAgICBkaXNwbGF5OiBibG9jazsKKyAgICAgICAgICAgIGJh Y2tncm91bmQ6IHJlZDsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisnPjwvaWZyYW1lPgorCis8 aWZyYW1lIHNyY2RvYz0nCisgICAgPHN0eWxlPgorICAgICAgICBodG1sOmFmdGVyIHsgCisgICAg ICAgICAgICBjb250ZW50OiAiIjsKKyAgICAgICAgICAgIGRpc3BsYXk6IGJsb2NrOworICAgICAg ICAgICAgYmFja2dyb3VuZDogcmVkOworICAgICAgICB9CisgICAgPC9zdHlsZT4KKyc+PC9pZnJh bWU+Cg==