104852 2012-12-12 15:07:57 -0800 GraphicsLayer::supportsBackgroundColorContent() should include Apple Windows 2012-12-12 18:37:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser webkit-unassigned noam roger_fong simon.fraser oldest_to_newest 789964 0 simon.fraser 2012-12-12 15:07:57 -0800 static bool supportsBackgroundColorContent() { #if PLATFORM(MAC) || USE(TEXTURE_MAPPER) return true; #else return false; #endif } We want this on for Apple windows too. 789966 1 simon.fraser 2012-12-12 15:12:18 -0800 USE(CA) might be the right thing to use instead of PLATFORM(MAC) 790011 2 roger_fong 2012-12-12 15:59:04 -0800 USE(CA) does indeed appear to work... 790109 3 179159 roger_fong 2012-12-12 17:32:53 -0800 Created attachment 179159 patch 790122 4 roger_fong 2012-12-12 17:44:52 -0800 actually, any tests i should be enabling now? 790163 5 179159 simon.fraser 2012-12-12 18:16:38 -0800 Comment on attachment 179159 patch There are a bunch of ref tests in compositing/background-color. 790172 6 roger_fong 2012-12-12 18:27:22 -0800 (In reply to comment #5) > (From update of attachment 179159 [details]) > There are a bunch of ref tests in compositing/background-color. Alas, guess not then, silly ref tests. 790180 7 roger_fong 2012-12-12 18:37:03 -0800 http://trac.webkit.org/changeset/137557 179159 2012-12-12 17:32:53 -0800 2012-12-12 18:16:38 -0800 patch useca.patch text/plain 1165 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzU0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEyLTEyICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSW5jbHVkZSBBcHBsZSBXaW5k b3dzIGluIEdyYXBoaWNzTGF5ZXI6OnN1cHBvcnRzQmFja2dyb3VuZENvbG9yQ29udGVudCgpLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODUyLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NM YXllcjo6c3VwcG9ydHNCYWNrZ3JvdW5kQ29sb3JDb250ZW50KToKKwogMjAxMi0xMi0xMiAgQW5k eSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgZGlzcGF0Y2ggZmFr ZSBtb3VzZW1vdmUgZXZlbnRzIHdoZW4gd2UgZG9uJ3Qga25vdyB3aGVyZSB0aGUgY3Vyc29yIGlz CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NM YXllci5oCShyZXZpc2lvbiAxMzc1MDIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc0xheWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTQyNyw3ICs0MjcsNyBAQCBw dWJsaWM6CiAKICAgICBzdGF0aWMgYm9vbCBzdXBwb3J0c0JhY2tncm91bmRDb2xvckNvbnRlbnQo KQogICAgIHsKLSNpZiBQTEFURk9STShNQUMpIHx8IFVTRShURVhUVVJFX01BUFBFUikKKyNpZiBV U0UoQ0EpIHx8IFVTRShURVhUVVJFX01BUFBFUikKICAgICAgICAgcmV0dXJuIHRydWU7CiAjZWxz ZQogICAgICAgICByZXR1cm4gZmFsc2U7Cg==