104849 2012-12-12 15:01:28 -0800 Web Inspector: Don't throw exceptions when we don't have a callstack 2013-01-09 23:07:08 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 johnjbarton webkit-unassigned apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 789955 0 johnjbarton 2012-12-12 15:01:28 -0800 If WebInspector.debuggerModel.debuggerPausedDetails() gives details.reason === 'other', then we try to execute details.callFrames[0].createLiveLocation(didGetUILocation.bind(this)); but if callFrames.length === 0 we fail. I suspect that the 'other' is related to liveEdit. 789962 1 179132 johnjbarton 2012-12-12 15:07:21 -0800 Created attachment 179132 Patch 791393 2 179132 pfeldman 2012-12-14 00:07:10 -0800 Comment on attachment 179132 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179132&action=review > Source/WebCore/inspector/front-end/ScriptsPanel.js:307 > + if (details.callFrames.length) Out of curiosity: have you seen this happening? We expect at least one call frame at all times. Could be related to live editing? > Source/WebCore/inspector/front-end/ScriptsPanel.js:310 > + this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused, reason unknown.")); I don't think we need this line since we will anyways see the problem due to no call frames. 791645 3 johnjbarton 2012-12-14 08:53:56 -0800 (In reply to comment #2) > (From update of attachment 179132 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179132&action=review > > > Source/WebCore/inspector/front-end/ScriptsPanel.js:307 > > + if (details.callFrames.length) > > Out of curiosity: have you seen this happening? Yes, I found this by having break-on-exceptions set on devtools-on-devtools. > We expect at least one call frame at all times. Could be related to live editing? I'm pretty sure the case I hit was live edit. > > > Source/WebCore/inspector/front-end/ScriptsPanel.js:310 > > + this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused, reason unknown.")); > > I don't think we need this line since we will anyways see the problem due to no call frames. But as you say above the no-call-frames case is unexpected. So this message is really intended for us, so we can be alert for the no-call-frame case and learn about it. However, I cannot find the output from setStatus() in the UI anyway. 792937 4 179784 johnjbarton 2012-12-17 12:51:24 -0800 Created attachment 179784 Patch 795576 5 180372 johnjbarton 2012-12-20 11:04:52 -0800 Created attachment 180372 Patch 800602 6 johnjbarton 2013-01-04 14:00:02 -0800 (In reply to comment #2) > (From update of attachment 179132 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179132&action=review > > > Source/WebCore/inspector/front-end/ScriptsPanel.js:307 > > + if (details.callFrames.length) > > Out of curiosity: have you seen this happening? We expect at least one call frame at all times. Could be related to live editing? I hit this without doing live editing today. In this case I had devtools running on devtools so this one may be related to the known incorrect behavior of js debugging in this set up. 803486 7 johnjbarton 2013-01-09 10:49:14 -0800 Can we push this to commit-queue? 804090 8 180372 webkit.review.bot 2013-01-09 23:07:03 -0800 Comment on attachment 180372 Patch Clearing flags on attachment: 180372 Committed r139285: <http://trac.webkit.org/changeset/139285> 804091 9 webkit.review.bot 2013-01-09 23:07:08 -0800 All reviewed patches have been landed. Closing bug. 179132 2012-12-12 15:07:21 -0800 2012-12-17 12:51:22 -0800 Patch bug-104849-20121212150441.patch text/plain 1898 johnjbarton U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU5NTZiNWY3M2ZhYzgx ZWRhYWIyOGQ4ZTU2Yjg2ZjliZmFjZTFiOS4uYjJhYzAxNDQ5MDUxNWUzZGFiZjMyY2E0YjM0NzVl ZmM3MGNjMzMwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTEyICBKb2hu IEouIEJhcnRvbiAgPGpvaG5qYmFydG9uQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBEb24ndCB0aHJvdyBleGNlcHRpb25zIHdoZW4gd2UgZG9uJ3QgaGF2ZSBhIGNhbGxz dGFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hl Y2sgYXJyYXkgZGV0YWlscy5jYWxsRnJhbWVzLmxlbmd0aCBiZWZvcmUgYWNjZXNzaW5nIGFycmF5 OworCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnV0IHRoaXMgZml4IG1heSBoZWxwIHVzIGZpbmQg dGhlIGNhdXNlIG9mICdvdGhlcicgcmVhc29ucy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5l bC5wcm90b3R5cGUuX2RlYnVnZ2VyUGF1c2VkKToKKwogMjAxMi0xMi0xMiAgS3J6eXN6dG9mIEN6 ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBQb3NzaWJpbGl0eSB0 byB0dXJuIG9mZiBhY2Nlc3NpYmlsaXR5IGZlYXR1cmUgZm9yIFdlYktpdC1FRkwuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCmluZGV4 IDQ0ODBkNTgwMWJiZTI4ZDZkZmI1OTc2ODIxNTU0MjI4YzQyMjcyNjguLjI4YzBiN2QxNTkzYTg4 NzM0NmM1NDRhYWM0YTc0MzlmNDAxOTVjMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCkBAIC0zMDQsNyArMzA0LDEwIEBAIFdl Ykluc3BlY3Rvci5TY3JpcHRzUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIHRo aXMuc2lkZWJhclBhbmVzLmpzQnJlYWtwb2ludHMuaGlnaGxpZ2h0QnJlYWtwb2ludChicmVha3Bv aW50KTsKICAgICAgICAgICAgICAgICB0aGlzLnNpZGViYXJQYW5lcy5jYWxsc3RhY2suc2V0U3Rh dHVzKFdlYkluc3BlY3Rvci5VSVN0cmluZygiUGF1c2VkIG9uIGEgSmF2YVNjcmlwdCBicmVha3Bv aW50LiIpKTsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGRldGFpbHMuY2FsbEZyYW1lc1sw XS5jcmVhdGVMaXZlTG9jYXRpb24oZGlkR2V0VUlMb2NhdGlvbi5iaW5kKHRoaXMpKTsKKyAgICAg ICAgICAgIGlmIChkZXRhaWxzLmNhbGxGcmFtZXMubGVuZ3RoKSAKKyAgICAgICAgICAgICAgICBk ZXRhaWxzLmNhbGxGcmFtZXNbMF0uY3JlYXRlTGl2ZUxvY2F0aW9uKGRpZEdldFVJTG9jYXRpb24u YmluZCh0aGlzKSk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgdGhpcy5zaWRl YmFyUGFuZXMuY2FsbHN0YWNrLnNldFN0YXR1cyhXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlBhdXNl ZCwgcmVhc29uIHVua25vd24uIikpOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fc2hvd0Rl YnVnZ2VyU2lkZWJhcigpOwo= 179784 2012-12-17 12:51:24 -0800 2012-12-20 11:04:48 -0800 Patch bug-104849-20121217124842.patch text/plain 1929 johnjbarton U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJiOGU1ZjllZmRjMGJj NDcyMTBjOTcyM2ZhYTc2NTY0NDRhYjNmNC4uNmMzYzFhYWU1NjRiN2IzMDk3MTI3ZTZhZGJhOWUz YTExZGRiODI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTEyICBKb2hu IEouIEJhcnRvbiAgPGpvaG5qYmFydG9uQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBEb24ndCB0aHJvdyBleGNlcHRpb25zIHdoZW4gd2UgZG9uJ3QgaGF2ZSBhIGNhbGxz dGFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hl Y2sgYXJyYXkgZGV0YWlscy5jYWxsRnJhbWVzLmxlbmd0aCBiZWZvcmUgYWNjZXNzaW5nIGFycmF5 OworCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnV0IHRoaXMgZml4IG1heSBoZWxwIHVzIGZpbmQg dGhlIGNhdXNlIG9mICdvdGhlcicgcmVhc29ucy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5l bC5wcm90b3R5cGUuX2RlYnVnZ2VyUGF1c2VkKToKKwogMjAxMi0xMi0xNyAgQmVtIEpvbmVzLUJl eSAgPGJqb25lc2JlQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIEV4Y2x1c2lvbnNdIEZsb2F0 cyBzaG91bGQgcmVzcGVjdCBzaGFwZS1pbnNpZGUgb24gZXhjbHVzaW9ucwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRleCA0NDgw ZDU4MDFiYmUyOGQ2ZGZiNTk3NjgyMTU1NDIyOGM0MjI3MjY4Li40OTVmMmQyNjhkNjY3MDc4YzA1 YzM4ODUxOTczM2VlY2MyNWExMjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwpAQCAtMzA0LDcgKzMwNCwxMCBAQCBXZWJJbnNw ZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICB0aGlzLnNp ZGViYXJQYW5lcy5qc0JyZWFrcG9pbnRzLmhpZ2hsaWdodEJyZWFrcG9pbnQoYnJlYWtwb2ludCk7 CiAgICAgICAgICAgICAgICAgdGhpcy5zaWRlYmFyUGFuZXMuY2FsbHN0YWNrLnNldFN0YXR1cyhX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlBhdXNlZCBvbiBhIEphdmFTY3JpcHQgYnJlYWtwb2ludC4i KSk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBkZXRhaWxzLmNhbGxGcmFtZXNbMF0uY3Jl YXRlTGl2ZUxvY2F0aW9uKGRpZEdldFVJTG9jYXRpb24uYmluZCh0aGlzKSk7CisgICAgICAgICAg ICBpZiAoZGV0YWlscy5jYWxsRnJhbWVzLmxlbmd0aCkgCisgICAgICAgICAgICAgICAgZGV0YWls cy5jYWxsRnJhbWVzWzBdLmNyZWF0ZUxpdmVMb2NhdGlvbihkaWRHZXRVSUxvY2F0aW9uLmJpbmQo dGhpcykpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGNvbnNvbGUud2Fybigi U2NyaXB0c1BhbmVsIHBhdXNlZCwgYnV0IGNhbGxGcmFtZXMubGVuZ3RoIGlzIHplcm8uIik7IC8v IFRPRE8gcmVtb3ZlIHRoaXMgb25jZSB3ZSB1bmRlcnN0YW5kIHRoaXMgY2FzZSBiZXR0ZXIKICAg ICAgICAgfQogCiAgICAgICAgIHRoaXMuX3Nob3dEZWJ1Z2dlclNpZGViYXIoKTsK 180372 2012-12-20 11:04:52 -0800 2013-01-09 23:07:03 -0800 Patch bug-104849-20121220110208.patch text/plain 1928 johnjbarton U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNkNTIxZWRjN2Y4ZTNm NDBhZGYxNTA3NmY5NDFkMGI4MTliZjM5Ni4uOGZjN2Q4Y2ExNjQ0NDZhNmJiMDI1ZWYzYjZiMmE2 ZmE1OGY1ODQzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTEyICBKb2hu IEouIEJhcnRvbiAgPGpvaG5qYmFydG9uQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBEb24ndCB0aHJvdyBleGNlcHRpb25zIHdoZW4gd2UgZG9uJ3QgaGF2ZSBhIGNhbGxz dGFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hl Y2sgYXJyYXkgZGV0YWlscy5jYWxsRnJhbWVzLmxlbmd0aCBiZWZvcmUgYWNjZXNzaW5nIGFycmF5 OworCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnV0IHRoaXMgZml4IG1heSBoZWxwIHVzIGZpbmQg dGhlIGNhdXNlIG9mICdvdGhlcicgcmVhc29ucy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5l bC5wcm90b3R5cGUuX2RlYnVnZ2VyUGF1c2VkKToKKwogMjAxMi0xMi0yMCAgRXJpayBBcnZpZHNz b24gIDxhcnZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENvZGVHZW46IE1ha2UgW1JlZmxlY3Rd IHVzZSBmYXN0R2V0QXR0cmlidXRlIGFuZCBmYXN0SGFzQXR0cmlidXRlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCmluZGV4IDdhZDk1 ZmE1Yjk2YmJiYjhjY2ZiYzQwNmU3NTM1YTRlZjFkMmU3YjAuLjg1OThiZTZkYmJjMmUzYzNhODg3 YmYzNTk5MGQyNWI0Y2FhZWZiZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCkBAIC0zMTEsNyArMzExLDEwIEBAIFdlYkluc3Bl Y3Rvci5TY3JpcHRzUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIHRoaXMuc2lk ZWJhclBhbmVzLmpzQnJlYWtwb2ludHMuaGlnaGxpZ2h0QnJlYWtwb2ludChicmVha3BvaW50KTsK ICAgICAgICAgICAgICAgICB0aGlzLnNpZGViYXJQYW5lcy5jYWxsc3RhY2suc2V0U3RhdHVzKFdl Ykluc3BlY3Rvci5VSVN0cmluZygiUGF1c2VkIG9uIGEgSmF2YVNjcmlwdCBicmVha3BvaW50LiIp KTsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGRldGFpbHMuY2FsbEZyYW1lc1swXS5jcmVh dGVMaXZlTG9jYXRpb24oZGlkR2V0VUlMb2NhdGlvbi5iaW5kKHRoaXMpKTsKKyAgICAgICAgICAg IGlmIChkZXRhaWxzLmNhbGxGcmFtZXMubGVuZ3RoKSAKKyAgICAgICAgICAgICAgICBkZXRhaWxz LmNhbGxGcmFtZXNbMF0uY3JlYXRlTGl2ZUxvY2F0aW9uKGRpZEdldFVJTG9jYXRpb24uYmluZCh0 aGlzKSk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgY29uc29sZS53YXJuKCJT Y3JpcHRzUGFuZWwgcGF1c2VkLCBidXQgY2FsbEZyYW1lcy5sZW5ndGggaXMgemVyby4iKTsgLy8g VE9ETyByZW1vdmUgdGhpcyBvbmNlIHdlIHVuZGVyc3RhbmQgdGhpcyBjYXNlIGJldHRlcgogICAg ICAgICB9CiAKICAgICAgICAgdGhpcy5fc2hvd0RlYnVnZ2VyU2lkZWJhcigpOwo=