104841 2012-12-12 14:13:57 -0800 [Chromium] Spellchecker should provide suggestions for non-caret selection, too 2012-12-19 21:26:25 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 groby groby morrita webkit.review.bot oldest_to_newest 789904 0 groby 2012-12-12 14:13:57 -0800 If you double-click a misspelled word and then right-click it, we should still display a spellcheck suggestion. Currently, this is not the case. (Turned off due to bug #94189) 789971 1 179134 groby 2012-12-12 15:17:47 -0800 Created attachment 179134 Patch 790909 2 groby 2012-12-13 14:08:05 -0800 May I ask for a review (and possibly commit), please? 795148 3 179134 webkit.review.bot 2012-12-19 21:26:22 -0800 Comment on attachment 179134 Patch Clearing flags on attachment: 179134 Committed r138216: <http://trac.webkit.org/changeset/138216> 795149 4 webkit.review.bot 2012-12-19 21:26:25 -0800 All reviewed patches have been landed. Closing bug. 179134 2012-12-12 15:17:47 -0800 2012-12-19 21:26:22 -0800 Patch bug-104841-20121212151508.patch text/plain 3546 groby U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDI4NmY5Y2FmNDNiMjQwZjdjODRlNzM0MDFlNmQzODkyMmFkNmI2MWYuLmYwMTllMGY4ODljZTAz NDgyZmI1MWZhNDRkOGZhNDY4OTU3MjI1MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMTItMTIgIFJhY2hlbCBCbHVtICA8Z3JvYnlAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gU3BlbGxjaGVja2VyIHNob3VsZCBwcm92aWRlIHN1 Z2dlc3Rpb25zIGZvciBub24tY2FyZXQgc2VsZWN0aW9uLCB0b28KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDg0MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93IHNwZWxsaW5nIHN1Z2dlc3Rpb25z IGZvciBhIHdvcmQgaWYgdGhlIHdvcmQgaXMgYWxyZWFkeSBzZWxlY3RlZC4gTm8gc3VnZ2VzdGlv biAKKyAgICAgICAgaWYgc3Vic2V0IG9mIGEgd29yZCBvciBtb3JlIHRoYW4gYSB3b3JkIGlzIHNl bGVjdGVkLgorCisgICAgICAgICogc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OkNvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZh dWx0SXRlbXMpOgorCiAyMDEyLTEyLTEyICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29n bGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogQ2hhbmdlIHRoZSBkYXRhIGNoYW5u ZWwgZGVzY3JpcHRvciBwYXR0ZXJuIHRvIGEgaGFuZGxlciBwYXR0ZXJuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAppbmRleCBi ZGExYjJlOWFjMjNmZDQ4OTU1NGM5NzA4MWU2YjkwMDJiNDdmZTA3Li4zMzk1NmJjYTc4NGUwMTk0 NTliMmY5M2Q0YjQ2MDFjNTZlZjUwMzI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKQEAgLTI3NywxMSArMjc3LDE5IEBA IFBsYXRmb3JtTWVudURlc2NyaXB0aW9uIENvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9t TWVudUZyb21EZWZhdWx0SXRlbXMoCiAgICAgICAgIC8vIGEgbW91c2Ugb24gYSB3b3JkLCBDaHJv bWUganVzdCBuZWVkcyB0byBmaW5kIGEgc3BlbGxpbmcgbWFya2VyIG9uIHRoZSB3b3JkIGluc3Ry ZWFkIG9mIHNwZWxsY2hlY2tpbmcgaXQuCiAgICAgICAgIGlmIChzZWxlY3RlZEZyYW1lLT5zZXR0 aW5ncygpICYmIHNlbGVjdGVkRnJhbWUtPnNldHRpbmdzKCktPmFzeW5jaHJvbm91c1NwZWxsQ2hl Y2tpbmdFbmFibGVkKCkpIHsKICAgICAgICAgICAgIFZpc2libGVTZWxlY3Rpb24gc2VsZWN0aW9u ID0gc2VsZWN0ZWRGcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpOwotICAgICAgICAgICAg aWYgKHNlbGVjdGlvbi5pc0NhcmV0KCkpIHsKLSAgICAgICAgICAgICAgICBzZWxlY3Rpb24uZXhw YW5kVXNpbmdHcmFudWxhcml0eShXb3JkR3JhbnVsYXJpdHkpOworICAgICAgICAgICAgYm9vbCBz aG91bGRVcGRhdGVTZWxlY3Rpb24gPSBmYWxzZTsKKyAgICAgICAgICAgIGlmIChzZWxlY3Rpb24u aXNDYXJldE9yUmFuZ2UoKSkgeworICAgICAgICAgICAgICAgIGlmIChzZWxlY3Rpb24uaXNDYXJl dCgpKSB7CisgICAgICAgICAgICAgICAgICAgIHNlbGVjdGlvbi5leHBhbmRVc2luZ0dyYW51bGFy aXR5KFdvcmRHcmFudWxhcml0eSk7CisgICAgICAgICAgICAgICAgICAgIHNob3VsZFVwZGF0ZVNl bGVjdGlvbiA9IHRydWU7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIFJlZlB0 cjxSYW5nZT4gcmFuZ2UgPSBzZWxlY3Rpb24udG9Ob3JtYWxpemVkUmFuZ2UoKTsKICAgICAgICAg ICAgICAgICBWZWN0b3I8RG9jdW1lbnRNYXJrZXIqPiBtYXJrZXJzID0gc2VsZWN0ZWRGcmFtZS0+ ZG9jdW1lbnQoKS0+bWFya2VycygpLT5tYXJrZXJzSW5SYW5nZShyYW5nZS5nZXQoKSwgRG9jdW1l bnRNYXJrZXI6OlNwZWxsaW5nIHwgRG9jdW1lbnRNYXJrZXI6OkdyYW1tYXIpOwogICAgICAgICAg ICAgICAgIGlmIChtYXJrZXJzLnNpemUoKSA9PSAxKSB7CisgICAgICAgICAgICAgICAgICAgIGlm IChtYXJrZXJzWzBdLT5zdGFydE9mZnNldCgpICE9IHN0YXRpY19jYXN0PHVuc2lnbmVkPihyYW5n ZS0+c3RhcnRPZmZzZXQoKSkgfHwgbWFya2Vyc1swXS0+ZW5kT2Zmc2V0KCkgIT0gc3RhdGljX2Nh c3Q8dW5zaWduZWQ+KHJhbmdlLT5lbmRPZmZzZXQoKSkpCisgICAgICAgICAgICAgICAgICAgICAg ICBtYXJrZXJzLmNsZWFyKCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIGlm IChtYXJrZXJzLnNpemUoKSA9PSAxKSB7CiAgICAgICAgICAgICAgICAgICAgIHJhbmdlLT5zZXRT dGFydChyYW5nZS0+c3RhcnRDb250YWluZXIoKSwgbWFya2Vyc1swXS0+c3RhcnRPZmZzZXQoKSk7 CiAgICAgICAgICAgICAgICAgICAgIHJhbmdlLT5zZXRFbmQocmFuZ2UtPmVuZENvbnRhaW5lcigp LCBtYXJrZXJzWzBdLT5lbmRPZmZzZXQoKSk7CiAgICAgICAgICAgICAgICAgICAgIGRhdGEubWlz c3BlbGxlZFdvcmQgPSByYW5nZS0+dGV4dCgpOwpAQCAtMjk0LDcgKzMwMiw3IEBAIFBsYXRmb3Jt TWVudURlc2NyaXB0aW9uIENvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21E ZWZhdWx0SXRlbXMoCiAgICAgICAgICAgICAgICAgICAgICAgICBtX3dlYlZpZXctPnNwZWxsQ2hl Y2tDbGllbnQoKS0+c3BlbGxDaGVjayhkYXRhLm1pc3NwZWxsZWRXb3JkLCBtaXNzcGVsbGVkT2Zm c2V0LCBtaXNzcGVsbGVkTGVuZ3RoLCAmZGF0YS5kaWN0aW9uYXJ5U3VnZ2VzdGlvbnMpOwogICAg ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIHNlbGVjdGlvbiA9IFZpc2li bGVTZWxlY3Rpb24ocmFuZ2UuZ2V0KCkpOwotICAgICAgICAgICAgICAgICAgICBpZiAoc2VsZWN0 ZWRGcmFtZS0+c2VsZWN0aW9uKCktPnNob3VsZENoYW5nZVNlbGVjdGlvbihzZWxlY3Rpb24pKQor ICAgICAgICAgICAgICAgICAgICBpZiAoc2hvdWxkVXBkYXRlU2VsZWN0aW9uICYmIHNlbGVjdGVk RnJhbWUtPnNlbGVjdGlvbigpLT5zaG91bGRDaGFuZ2VTZWxlY3Rpb24oc2VsZWN0aW9uKSkKICAg ICAgICAgICAgICAgICAgICAgICAgIHNlbGVjdGVkRnJhbWUtPnNlbGVjdGlvbigpLT5zZXRTZWxl Y3Rpb24oc2VsZWN0aW9uLCBXb3JkR3JhbnVsYXJpdHkpOwogICAgICAgICAgICAgICAgIH0KICAg ICAgICAgICAgIH0K