104839 2012-12-12 13:47:04 -0800 build-webkit --chromium-android forces Make even when update-webkit used --ninja 2012-12-13 10:35:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric dbates dpranke peter thakis tony webkit.review.bot oldest_to_newest 789874 0 eric 2012-12-12 13:47:04 -0800 build-webkit --chromium-android forces Make even when update-webkit used --ninja 789876 1 179120 eric 2012-12-12 13:48:23 -0800 Created attachment 179120 Patch 789878 2 thakis 2012-12-12 13:50:59 -0800 lgtm, but I'm not an reviewer. 789880 3 eric 2012-12-12 13:51:21 -0800 This is mostly just reverting http://trac.webkit.org/changeset/124219, and thus should be reviewed by Peter. 789885 4 thakis 2012-12-12 13:52:34 -0800 Peter lgtm'd this in https://bugs.webkit.org/show_bug.cgi?id=104434#c4 789890 5 eric 2012-12-12 13:54:59 -0800 (In reply to comment #4) > Peter lgtm'd this in https://bugs.webkit.org/show_bug.cgi?id=104434#c4 Very true. But I'd like to have him do it again. :) Then he can be on the hook when his Android bots break. :) I'll let him r+ and cq+ this while I sleep tonight :) 789895 6 179120 tony 2012-12-12 14:02:35 -0800 Comment on attachment 179120 Patch Peter's not a reviewer. I'll r+ and Peter can cq+ or cq- when he sees this. 790722 7 179120 peter 2012-12-13 10:17:52 -0800 Comment on attachment 179120 Patch Thanks Eric! Verified that it starts using Ninja locally. 790743 8 179120 webkit.review.bot 2012-12-13 10:35:54 -0800 Comment on attachment 179120 Patch Clearing flags on attachment: 179120 Committed r137611: <http://trac.webkit.org/changeset/137611> 790744 9 webkit.review.bot 2012-12-13 10:35:58 -0800 All reviewed patches have been landed. Closing bug. 179120 2012-12-12 13:48:23 -0800 2012-12-13 10:35:54 -0800 Patch bug-104839-20121212134544.patch text/plain 1640 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzFjNTZiNzdjMzE0ZDcxN2VhODJhNzRhYjNkOGMxYjBm ZmY1NDBkOS4uOTNkYjY0NWJhZjNhYTg5OTZmYzMzMTQ2ZGExMTZiNjkxNGQxMjUzNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEyLTEyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBidWlsZC13ZWJraXQgLS1jaHJvbWl1bS1hbmRyb2lkIGZvcmNlcyBNYWtlIGV2ZW4gd2hlbiB1 cGRhdGUtd2Via2l0IHVzZWQgLS1uaW5qYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyB3YXMgcmVjb21tZW5kZWQgYnkgUGV0ZXIgYXMgcGFydCBv ZjoKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDQz NCNjNAorICAgICAgICBGaXhpbmcgdGhpcyBtYWtlcyBidWlsZC13ZWJraXQgLS1jaHJvbWl1bS1h bmRyb2lkIHdvcmsgZm9yIHRoZSBjb21tb24gKG5pbmphKSBjYXNlLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRDaHJvbWl1bSk6CisKIDIwMTItMTIt MTIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdIEFkZCBhdXRoZW50aWNhdGlvbiBzdXBwb3J0IHRvIERSVCBhbmQgZml4IGV4cG9zZWQgaXNz dWVzIGluIHRoZSBsaWJzb3VwIGJhY2tlbmQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCAzMWE0YmU0MmQw MGQ2ZDdjNDMxMGE4ZGY3ODJkYTY4YTY1NDQzOGNjLi5kM2U1MDk2YzA3OTJlZWRjYTg2ZTYyYjg3 MjZhYTcyOGM3ZDU0MGExIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0K KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yNTQzLDcgKzI1NDMsNyBAQCBz dWIgYnVpbGRDaHJvbWl1bSgkQCkKICAgICB9IGVsc2lmIChpc0N5Z3dpbigpIHx8IGlzV2luZG93 cygpKSB7CiAgICAgICAgICMgV2luZG93cyBidWlsZCAtIGJ1aWxkcyB0aGUgcm9vdCB2aXN1YWwg c3R1ZGlvIHNvbHV0aW9uLgogICAgICAgICAkcmVzdWx0ID0gYnVpbGRDaHJvbWl1bVZpc3VhbFN0 dWRpb1Byb2plY3QoIlNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQWxsLnNsbiIsICRjbGVhbik7Ci0g ICAgfSBlbHNpZiAoaXNDaHJvbWl1bU5pbmphKCkgJiYgIWlzQ2hyb21pdW1BbmRyb2lkKCkpIHsK KyAgICB9IGVsc2lmIChpc0Nocm9taXVtTmluamEoKSkgewogICAgICAgICAkcmVzdWx0ID0gYnVp bGRDaHJvbWl1bU5pbmphKCJhbGwiLCAkY2xlYW4sIEBvcHRpb25zKTsKICAgICB9IGVsc2lmIChp c0xpbnV4KCkgfHwgaXNDaHJvbWl1bUFuZHJvaWQoKSB8fCBpc0Nocm9taXVtTWFjTWFrZSgpKSB7 CiAgICAgICAgICMgTGludXggYnVpbGQgLSBidWlsZCB1c2luZyBtYWtlLgo=