104831 2012-12-12 12:08:26 -0800 [chromium] don't write additional idl files to a gyp temp file 2012-12-12 15:02:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104740 1 tony tony abarth haraken japhet webkit.review.bot oldest_to_newest 789781 0 tony 2012-12-12 12:08:26 -0800 During binding generation, we current write additional_idl_files_list with some special syntax. This will cause a problem for bug 104740 because we're going to generate an idl file, but <|( in gyp isn't able to handle build system variables. For example, if you try to write the file <(PRODUCT_DIR)/foo to a file using <|(, you end up with $!PRODUCT_DIR/foo or $(OutDir) in the file. We can work around this problem by not using <|( for additional_idl_files. 789801 1 179103 tony 2012-12-12 12:27:36 -0800 Created attachment 179103 Patch 789901 2 179103 haraken 2012-12-12 14:08:57 -0800 Comment on attachment 179103 Patch Looks good to me. 789956 3 179103 webkit.review.bot 2012-12-12 15:02:08 -0800 Comment on attachment 179103 Patch Clearing flags on attachment: 179103 Committed r137519: <http://trac.webkit.org/changeset/137519> 789957 4 webkit.review.bot 2012-12-12 15:02:13 -0800 All reviewed patches have been landed. Closing bug. 179103 2012-12-12 12:27:36 -0800 2012-12-12 15:02:08 -0800 Patch bug-104831-20121212122457.patch text/plain 5229 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQ2ZTZhYTIyMDc3ZjQ0 YmEwMzFhNWM3ZDM5ZmE2Nzg0OWYyYWY3Yy4uNGE3ZjYyNzFjMDA0NDU0YzM0MmNmMGI1MjU0OTE5 MjBiMDU3NDg3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEyLTEyICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBkb24ndCB3 cml0ZSBhZGRpdGlvbmFsIGlkbCBmaWxlcyB0byBhIGd5cCB0ZW1wIGZpbGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDgzMQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSA8fCggY29tbWFuZCBkb2Vz bid0IHdvcmsgZm9yIGZpbGVzIGxpa2UgPChQUk9EVUNUX0RJUikgb3IgPChTSEFSRURfSU5URVJN RURJQVRFX0RJUikuCisgICAgICAgIEZvciBhZGRpdGlvbmFsX2lkbF9maWxlcywgcGFzcyBpdCBh cyBhIHBhcmFtZXRlciBpbnN0ZWFkIG9mIGEgZmlsZSBsaXN0aW5nIHRoZSBmaWxlbmFtZXMuCisg ICAgICAgIFRoZXJlIGFyZSBjdXJyZW50bHkgb25seSAzIGZpbGVzIGluIHRoaXMgdmFyaWFibGUu IFRoaXMgc2hvdWxkbid0IG92ZXJmbG93IHRoZSBjb21tYW5kCisgICAgICAgIGxpbmUgc2luY2Ug dGhlIGxpbWl0IG9uIFdpbmRvd3MgaXMgOGsgYW5kIHdpdGggdGhpcyBjaGFuZ2UsIHdlJ3JlIHN0 aWxsIG9ubHkgYXJvdW5kIDQuNWsuCisgICAgICAgIEFsc28sIHRoZSBsb25nZXN0IHBhcnQgb2Yg dGhlIGNvbW1hbmQgbGluZSBpcyB0aGUgbGlzdCBvZiBkZWZpbmVzLiBJZiBuZWVkZWQsIHdlIGNv dWxkIHB1dAorICAgICAgICB0aGF0IGluIGEgZmlsZSBpbnN0ZWFkLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgdGhpcyBpcyBhIHJlZmFjdG9yaW5nIG9mIHRoZSBidWlsZCBmaWxlcy4KKworICAg ICAgICAqIFdlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwOiBEb24ndCB1c2UgPHwoIGZvciBhZGRpdGlv bmFsX2lkbF9maWxlcy4KKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL2dlbmVyYXRlLWJpbmRp bmdzLnBsOiBDaGFuZ2UgLS1hZGRpdGlvbmFsSWRsRmlsZXNMaXN0IHRvCisgICAgICAgIC0tYWRk aXRpb25hbElkbEZpbGVzLCB3aGljaCBpcyBhIHNoZWxsIGFyZ3VtZW50IGNvbnRhaW5pbmcgdGhl IGZpbGVuYW1lcy4KKwogMjAxMi0xMi0xMiAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBkZXN0cnVjdG9yIHRvIFdlYlByZXJlbmRl cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9T b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCA2ZGU4Zjc2Y2M3ZmZi Y2I4Y2JmZTVkMTU2NjE5YmIxYjMyYjdhNzYxLi44NTliMGFjZTlmMzg0MjAwNTc1YmMzNjQwNDg3 MTYzN2FkMTQxZTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJD b3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAt NTgwLDExICs1ODAsNiBAQAogICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgJ2dlbmVy YXRlX3N1cHBsZW1lbnRhbF9kZXBlbmRlbmN5JywKICAgICAgIF0sCi0gICAgICAndmFyaWFibGVz JzogewotICAgICAgICAjIFdyaXRlIHNvdXJjZXMgaW50byBhIGZpbGUsIHNvIHRoYXQgdGhlIGFj dGlvbiBjb21tYW5kIGxpbmUgd29uJ3QKLSAgICAgICAgIyBleGNlZWQgT1MgbGltaXRzLgotICAg ICAgICAnYWRkaXRpb25hbF9pZGxfZmlsZXNfbGlzdCc6ICc8fChhZGRpdGlvbmFsX2lkbF9maWxl c19saXN0LnRtcCA8QCh3ZWJjb3JlX3Rlc3Rfc3VwcG9ydF9pZGxfZmlsZXMpKScsCi0gICAgICB9 LAogICAgICAgJ3NvdXJjZXMnOiBbCiAgICAgICAgICMgYmlzb24gcnVsZQogICAgICAgICAnPChT SEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L0NTU0dyYW1tYXIueScsCkBAIC0xMTY5LDgg KzExNjQsNyBAQAogICAgICAgICAgICAgJy4uL2JpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBt JywKICAgICAgICAgICAgICcuLi9iaW5kaW5ncy9zY3JpcHRzL3ByZXByb2Nlc3Nvci5wbScsCiAg ICAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvc3VwcGxlbWVudGFsX2RlcGVu ZGVuY3kudG1wJywKLSAgICAgICAgICAgICc8KGFkZGl0aW9uYWxfaWRsX2ZpbGVzX2xpc3QpJywK LSAgICAgICAgICAgICc8IUAoY2F0IDwoYWRkaXRpb25hbF9pZGxfZmlsZXNfbGlzdCkpJywKKyAg ICAgICAgICAgICc8QCh3ZWJjb3JlX3Rlc3Rfc3VwcG9ydF9pZGxfZmlsZXMpJywKICAgICAgICAg ICBdLAogICAgICAgICAgICdvdXRwdXRzJzogWwogICAgICAgICAgICAgIyBGSVhNRTogIFRoZSAu Y3BwIGZpbGUgc2hvdWxkIGJlIGluIHdlYmtpdC9iaW5kaW5ncyBvbmNlCkBAIC0xMjI0LDggKzEy MTgsOCBAQAogICAgICAgICAgICAgJzxAKGdlbmVyYXRvcl9pbmNsdWRlX2RpcnMpJywKICAgICAg ICAgICAgICctLXN1cHBsZW1lbnRhbERlcGVuZGVuY3lGaWxlJywKICAgICAgICAgICAgICc8KFNI QVJFRF9JTlRFUk1FRElBVEVfRElSKS9zdXBwbGVtZW50YWxfZGVwZW5kZW5jeS50bXAnLAotICAg ICAgICAgICAgJy0tYWRkaXRpb25hbElkbEZpbGVzTGlzdCcsCi0gICAgICAgICAgICAnPChhZGRp dGlvbmFsX2lkbF9maWxlc19saXN0KScsCisgICAgICAgICAgICAnLS1hZGRpdGlvbmFsSWRsRmls ZXMnLAorICAgICAgICAgICAgJzwod2ViY29yZV90ZXN0X3N1cHBvcnRfaWRsX2ZpbGVzKScsCiAg ICAgICAgICAgICAnPChSVUxFX0lOUFVUX1BBVEgpJywKICAgICAgICAgICAgICc8QChwcmVwcm9j ZXNzb3IpJywKICAgICAgICAgICBdLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5wbCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3MucGwKaW5kZXggOGJlY2UwZmZkMmNmYzVhZjAzNzk5 N2E0NWIyYzM2MjM5ZWY5YmJhMS4uMGQxM2NlNmYxZjZhOTBjNzU0ZmVhMjViYzc5NDlmOGMwZTAx YTY4YSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0 ZS1iaW5kaW5ncy5wbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL2dlbmVy YXRlLWJpbmRpbmdzLnBsCkBAIC0zMyw2ICszMyw3IEBAIHVzZSBzdHJpY3Q7CiB1c2UgRmlsZTo6 UGF0aDsKIHVzZSBGaWxlOjpCYXNlbmFtZTsKIHVzZSBHZXRvcHQ6Okxvbmc7Cit1c2UgVGV4dDo6 UGFyc2VXb3JkczsKIHVzZSBDd2Q7CiAKIHVzZSBJRExQYXJzZXI7CkBAIC00OSw3ICs1MCw3IEBA IG15ICRwcmVwcm9jZXNzb3I7CiBteSAkd3JpdGVEZXBlbmRlbmNpZXM7CiBteSAkdmVyYm9zZTsK IG15ICRzdXBwbGVtZW50YWxEZXBlbmRlbmN5RmlsZTsKLW15ICRhZGRpdGlvbmFsSWRsRmlsZXNM aXN0OworbXkgJGFkZGl0aW9uYWxJZGxGaWxlczsKIAogR2V0T3B0aW9ucygnaW5jbHVkZT1zQCcg PT4gXEBpZGxEaXJlY3RvcmllcywKICAgICAgICAgICAgJ291dHB1dERpcj1zJyA9PiBcJG91dHB1 dERpcmVjdG9yeSwKQEAgLTYyLDcgKzYzLDcgQEAgR2V0T3B0aW9ucygnaW5jbHVkZT1zQCcgPT4g XEBpZGxEaXJlY3RvcmllcywKICAgICAgICAgICAgJ3ZlcmJvc2UnID0+IFwkdmVyYm9zZSwKICAg ICAgICAgICAgJ3dyaXRlLWRlcGVuZGVuY2llcycgPT4gXCR3cml0ZURlcGVuZGVuY2llcywKICAg ICAgICAgICAgJ3N1cHBsZW1lbnRhbERlcGVuZGVuY3lGaWxlPXMnID0+IFwkc3VwcGxlbWVudGFs RGVwZW5kZW5jeUZpbGUsCi0gICAgICAgICAgICdhZGRpdGlvbmFsSWRsRmlsZXNMaXN0PXMnID0+ IFwkYWRkaXRpb25hbElkbEZpbGVzTGlzdCk7CisgICAgICAgICAgICdhZGRpdGlvbmFsSWRsRmls ZXM9cycgPT4gXCRhZGRpdGlvbmFsSWRsRmlsZXMpOwogCiBteSAkdGFyZ2V0SWRsRmlsZSA9ICRB UkdWWzBdOwogCkBAIC0xMDIsMTkgKzEwMywxMiBAQCBpZiAoJHN1cHBsZW1lbnRhbERlcGVuZGVu Y3lGaWxlKSB7CiAgICAgfQogICAgIGNsb3NlIEZIOwogCi0gICAgIyBUaGUgZmlsZSAkYWRkaXRp b25hbElkbEZpbGVzTGlzdCBjb250YWlucyBvbmUgSURMIGZpbGUgcGVyIGxpbmU6Ci0gICAgIyBQ LmlkbAotICAgICMgUS5pZGwKLSAgICAjIC4uLgotICAgICMgVGhlc2UgSURMIGZpbGVzIGFyZSBv bmVzIHdoaWNoIHNob3VsZCBub3QgYmUgaW5jbHVkZWQgaW4gRGVyaXZlZFNvdXJjZXMqLmNwcAot ICAgICMgKGkuZS4gdGhleSBhcmUgbm90IGRlc2NyaWJlZCBpbiB0aGUgc3VwcGxlbWVudGFsIGRl cGVuZGVuY3kgZmlsZSkKLSAgICAjIGJ1dCBzaG91bGQgZ2VuZXJhdGUgLmggYW5kIC5jcHAgZmls ZXMuCi0gICAgaWYgKCEkaWRsRm91bmQgYW5kICRhZGRpdGlvbmFsSWRsRmlsZXNMaXN0KSB7Ci0g ICAgICAgIG9wZW4gRkgsICI8ICRhZGRpdGlvbmFsSWRsRmlsZXNMaXN0IiBvciBkaWUgIkNhbm5v dCBvcGVuICRhZGRpdGlvbmFsSWRsRmlsZXNMaXN0XG4iOwotICAgICAgICBteSBAaWRsRmlsZXMg PSA8Rkg+OwotICAgICAgICBjaG9tcChAaWRsRmlsZXMpOworICAgICMgJGFkZGl0aW9uYWxJZGxG aWxlcyBpcyBsaXN0IG9mIElETCBmaWxlcyB3aGljaCBzaG91bGQgbm90IGJlIGluY2x1ZGVkIGlu CisgICAgIyBEZXJpdmVkU291cmNlcyouY3BwIChpLmUuIHRoZXkgYXJlIG5vdCBkZXNjcmliZWQg aW4gdGhlIHN1cHBsZW1lbnRhbAorICAgICMgZGVwZW5kZW5jeSBmaWxlKSBidXQgc2hvdWxkIGdl bmVyYXRlIC5oIGFuZCAuY3BwIGZpbGVzLgorICAgIGlmICghJGlkbEZvdW5kIGFuZCAkYWRkaXRp b25hbElkbEZpbGVzKSB7CisgICAgICAgIG15IEBpZGxGaWxlcyA9IHNoZWxsd29yZHMoJGFkZGl0 aW9uYWxJZGxGaWxlcyk7CiAgICAgICAgICRpZGxGb3VuZCA9IGdyZXAgeyAkXyBhbmQgYmFzZW5h bWUoJF8pIGVxIGJhc2VuYW1lKCR0YXJnZXRJZGxGaWxlKSB9IEBpZGxGaWxlczsKLSAgICAgICAg Y2xvc2UgRkg7CiAgICAgfQogCiAgICAgaWYgKCEkaWRsRm91bmQpIHsK