104820 2012-12-12 09:16:57 -0800 [chromium] Add destructor to WebPrerender 2012-12-12 10:35:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gavinp gavinp abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 789620 0 gavinp 2012-12-12 09:16:57 -0800 Add destructor to WebPrerender 789625 1 179065 gavinp 2012-12-12 09:20:18 -0800 Created attachment 179065 Patch 789629 2 gavinp 2012-12-12 09:23:47 -0800 James, This change should have been part of https://bugs.webkit.org/show_bug.cgi?id=96474 , but we missed it during review. It's causing me some trouble now in Chrome, which is catching the default constructor and having bad juju. Adam's away this week, so I'd love it if you could look at this. What do you think? 789631 3 webkit.review.bot 2012-12-12 09:23:51 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 789645 4 179065 gavinp 2012-12-12 09:53:21 -0800 Comment on attachment 179065 Patch Thanks, James! 789685 5 179065 webkit.review.bot 2012-12-12 10:35:01 -0800 Comment on attachment 179065 Patch Clearing flags on attachment: 179065 Committed r137482: <http://trac.webkit.org/changeset/137482> 789686 6 webkit.review.bot 2012-12-12 10:35:05 -0800 All reviewed patches have been landed. Closing bug. 179065 2012-12-12 09:20:18 -0800 2012-12-12 10:35:01 -0800 Patch bug-104820-20121212121738.patch text/plain 3517 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBhN2MxZGZiMzNhNDZk YzY2ODI4OTQ1MWM2ZWY1NTcwYjI5MzE4YTIwLi4wODEyYjljM2E5OGFiZTk1MDFlYmNlZjJlMzk4 Mzc5YTllYWRiMmQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMi0xMiAg R2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEFkZCBkZXN0cnVjdG9yIHRvIFdlYlByZXJlbmRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0ODIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBtYWtpbmcgV2ViUHJlcmVuZGVyIGRlZmF1bHQg Y29uc3RydWN0aWJsZSBhbmQgYXNzaWduYWJsZSwgdGhlIGRlc3RydWN0b3Igc2hvdWxkIGhhdmUg YmVlbiBtb3ZlZCBvdXQgb2YgV0VCS0lUX0lNUExFTUVOVEFUSU9OLgorCisgICAgICAgICogY2hy b21pdW0vcHVibGljL1dlYlByZXJlbmRlci5oOgorICAgICAgICAoV2ViS2l0OjpXZWJQcmVyZW5k ZXI6On5XZWJQcmVyZW5kZXIpOgorICAgICAgICAoV2ViUHJlcmVuZGVyKToKKwogMjAxMi0xMi0x MCAgRGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21p dW1dIFJlbW92ZSBXZWJDb21wb3NpdG9yRnJhbWUoQWNrKSBhcyB0aGVzZSBjbGFzc2VzIGFyZSBu b3QgbmVlZGVkIG5vdyB0aGF0IHRoZXkgYXJlIHBhc3NlZCB0aHJvdWdoIGNjOjpPdXRwdXRTdXJm YWNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDQ2NTljNjA5NTg5ZDA3NjM5NzI0ZGRiMDE0Y2U3YjUzMTgzZmUw MWMuLjFkMGFlYWRjMWU2MmFjNjExNzdmOWU0MDJhMjI4ZDdlOTNiNDhkNjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMi0xMiAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBkZXN0cnVjdG9yIHRvIFdlYlByZXJl bmRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 ODIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hl biBtYWtpbmcgV2ViUHJlcmVuZGVyIGRlZmF1bHQgY29uc3RydWN0aWJsZSBhbmQgYXNzaWduYWJs ZSwgdGhlIGRlc3RydWN0b3Igc2hvdWxkIGhhdmUgYmVlbiBtb3ZlZCBvdXQgb2YgV0VCS0lUX0lN UExFTUVOVEFUSU9OLgorCisgICAgICAgIEV4aXN0aW5nIFdlYktpdCB1bml0IHRlc3RzIHNob3Vs ZCB0ZXN0IHRoaXMsIGFzIGRvIGNocm9taXVtIGJyb3dzZXIgdGVzdHMuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYlByZXJlbmRlci5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlByZXJlbmRlcjo6dG9QcmVyZW5kZXIpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcmVy ZW5kZXI6OnJlc2V0KToKKwogMjAxMi0xMi0xMSAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBw bGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgTWFjIGJ1aWxkIGFmdGVyIHIxMzcyNjEKZGlmZiAt LWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViUHJlcmVuZGVyLmggYi9T b3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlByZXJlbmRlci5oCmluZGV4IDRjMDhh ZjA5NzNlNWU1OTAyNjIxNjFhZDIyOWVmMjVkMWY4MjBkOGYuLjY3YTBjZDk3NTk3MzEwNWFmYmI2 NmRhMDhiMzgzNjMyMGZiYzllMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvV2ViUHJlcmVuZGVyLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJQcmVyZW5kZXIuaApAQCAtNTQsNiArNTQsNyBAQCBwdWJsaWM6CiAgICAgICAgIHZp cnR1YWwgfkV4dHJhRGF0YSgpIHsgfQogICAgIH07CiAKKyAgICB+V2ViUHJlcmVuZGVyKCkgeyBy ZXNldCgpOyB9CiAgICAgV2ViUHJlcmVuZGVyKCkgeyB9CiAgICAgV2ViUHJlcmVuZGVyKGNvbnN0 IFdlYlByZXJlbmRlciYgb3RoZXIpIHsgYXNzaWduKG90aGVyKTsgfQogICAgIFdlYlByZXJlbmRl ciYgb3BlcmF0b3I9KGNvbnN0IFdlYlByZXJlbmRlciYgb3RoZXIpCkBAIC02NCwxMSArNjUsMTEg QEAgcHVibGljOgogCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAgICAgZXhwbGljaXQgV2Vi UHJlcmVuZGVyKFBhc3NSZWZQdHI8V2ViQ29yZTo6UHJlcmVuZGVyPik7Ci0gICAgfldlYlByZXJl bmRlcigpOwogCiAgICAgY29uc3QgV2ViQ29yZTo6UHJlcmVuZGVyKiB0b1ByZXJlbmRlcigpIGNv bnN0OwogI2VuZGlmCiAKKyAgICBXRUJLSVRfRVhQT1JUIHZvaWQgcmVzZXQoKTsKICAgICBXRUJL SVRfRVhQT1JUIHZvaWQgYXNzaWduKGNvbnN0IFdlYlByZXJlbmRlciYpOwogICAgIFdFQktJVF9F WFBPUlQgYm9vbCBpc051bGwoKSBjb25zdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJQcmVyZW5kZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJQcmVyZW5kZXIuY3BwCmluZGV4IGU1MTk4 ODcxNDE5YzNjYTI2MjU1OGEyYjZjODk1OWM0OTk1YWMxZTQuLmZiZmIzMWVhODY0NTcxZTZkMGQ5 YTJlODM0NjUxN2NlMWE1NzU4ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2Nocm9taXVtL3N1cHBvcnQvV2ViUHJlcmVuZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYlByZXJlbmRlci5jcHAKQEAgLTY0LDE0ICs2NCwx NCBAQCBXZWJQcmVyZW5kZXI6OldlYlByZXJlbmRlcihQYXNzUmVmUHRyPFdlYkNvcmU6OlByZXJl bmRlcj4gcHJlcmVuZGVyKQogewogfQogCi1XZWJQcmVyZW5kZXI6On5XZWJQcmVyZW5kZXIoKQor Y29uc3QgV2ViQ29yZTo6UHJlcmVuZGVyKiBXZWJQcmVyZW5kZXI6OnRvUHJlcmVuZGVyKCkgY29u c3QKIHsKLSAgICBtX3ByaXZhdGUucmVzZXQoKTsKKyAgICByZXR1cm4gbV9wcml2YXRlLmdldCgp OwogfQogCi1jb25zdCBXZWJDb3JlOjpQcmVyZW5kZXIqIFdlYlByZXJlbmRlcjo6dG9QcmVyZW5k ZXIoKSBjb25zdAordm9pZCBXZWJQcmVyZW5kZXI6OnJlc2V0KCkKIHsKLSAgICByZXR1cm4gbV9w cml2YXRlLmdldCgpOworICAgIG1fcHJpdmF0ZS5yZXNldCgpOwogfQogCiB2b2lkIFdlYlByZXJl bmRlcjo6YXNzaWduKGNvbnN0IFdlYlByZXJlbmRlciYgb3RoZXIpCg==