104783 2012-12-12 02:00:27 -0800 [chromium] WebTestPlugin must not depend on WTF::String 2012-12-12 02:38:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen webkit.review.bot oldest_to_newest 789351 0 jochen 2012-12-12 02:00:27 -0800 [chromium] WebTestPlugin must not depend on WTF::String 789354 1 179005 jochen 2012-12-12 02:08:01 -0800 Created attachment 179005 Patch 789358 2 179005 tkent 2012-12-12 02:13:11 -0800 Comment on attachment 179005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179005&action=review > Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:108 > + snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", points[i].position.x, points[i].position.y, pointState(points[i].state)); I'm not sure snprintf is available in Visual Studio. 789360 3 jochen 2012-12-12 02:14:13 -0800 (In reply to comment #2) > (From update of attachment 179005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179005&action=review > > > Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:108 > > + snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", points[i].position.x, points[i].position.y, pointState(points[i].state)); > > I'm not sure snprintf is available in Visual Studio. It is (also, it's used in other files in the TestRunner library already) 789384 4 179005 webkit.review.bot 2012-12-12 02:38:31 -0800 Comment on attachment 179005 Patch Clearing flags on attachment: 179005 Committed r137439: <http://trac.webkit.org/changeset/137439> 789385 5 webkit.review.bot 2012-12-12 02:38:34 -0800 All reviewed patches have been landed. Closing bug. 179005 2012-12-12 02:08:01 -0800 2012-12-12 02:38:31 -0800 Patch bug-104783-20121212110522.patch text/plain 3316 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NDMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzk1YmZiZDhiN2YwNzI0ZWU3ZTlhYzdhYmEwZDA1YzIz OTk3NmIxYi4uMThlNjk1ZGQyZGEwNDE4YTkwMWFjZGM5NTNlZWI0MDRhYzIxZTdhMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEyLTEyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gV2ViVGVzdFBsdWdpbiBtdXN0IG5vdCBkZXBlbmQgb24gV1RG OjpTdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNDc4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluIGEgY29tcG9uZW50IGJ1aWxkLCB3ZSBjYW4ndCBhY2Nlc3MgdGhlIFdURiB0aGF0IGlzIHBh cnQgb2YgdGhlCisgICAgICAgIFdlYktpdCBjb21wb25lbnQuIEFjY2Vzc2luZyBXVEYgaW5zdGVh ZCB3aWxsIHB1bGwgaW4gYSBzZXBhcmF0ZSBjb3B5CisgICAgICAgIGludG8gdGhlIFRlc3RSdW5u ZXIgbGlicmFyeS4gSW5zdGVhZCBvZiBXVEY6OlN0cmluZzo6bnVtYmVyIHVzZQorICAgICAgICBz bnByaW50ZigpIHRvIHByaW50IG51bWJlcnMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0UGx1Z2luLmNwcDoKKwogMjAxMi0xMi0xMSAg Unlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgS29qaSBJc2hp aSB0byB0aGUgbGlzdCBvZiBjb250cmlidXRvcnMuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0UGx1Z2luLmNwcCBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dlYlRlc3RQbHVnaW4uY3Bw CmluZGV4IDE3MWZhMDMwNzk2YWIxOWY5YTA1OGY3MzRlYzdhZjNlYTg0MGI5NDguLmE2ZWIxMDY1 Mjg5MjliZDhlNjQxMDAzNjJhYzk5N2RhYWEwOTM4N2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dlYlRlc3RQbHVnaW4uY3BwCisrKyBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dlYlRlc3RQbHVn aW4uY3BwCkBAIC0zNyw3ICszNyw2IEBACiAjaW5jbHVkZSAicGxhdGZvcm0vV2ViS2l0UGxhdGZv cm1TdXBwb3J0LmgiCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYv dGV4dC9DU3RyaW5nLmg+Ci0jaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIHVzaW5n IG5hbWVzcGFjZSBXZWJLaXQ7CiAKQEAgLTEwNCw4ICsxMDMsMTEgQEAgY29uc3QgY2hhciogcG9p bnRTdGF0ZShXZWJUb3VjaFBvaW50OjpTdGF0ZSBzdGF0ZSkKIAogdm9pZCBwcmludFRvdWNoTGlz dChXZWJUZXN0RGVsZWdhdGUqIGRlbGVnYXRlLCBjb25zdCBXZWJUb3VjaFBvaW50KiBwb2ludHMs IGludCBsZW5ndGgpCiB7Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkKLSAg ICAgICAgZGVsZWdhdGUtPnByaW50TWVzc2FnZShzdGQ6OnN0cmluZygiKiAiKSArIFN0cmluZzo6 bnVtYmVyKHBvaW50c1tpXS5wb3NpdGlvbi54KS5hc2NpaSgpLmRhdGEoKSArICIsICIgKyBTdHJp bmc6Om51bWJlcihwb2ludHNbaV0ucG9zaXRpb24ueSkuYXNjaWkoKS5kYXRhKCkgKyAiOiAiICsg cG9pbnRTdGF0ZShwb2ludHNbaV0uc3RhdGUpICsgIlxuIik7CisgICAgZm9yIChpbnQgaSA9IDA7 IGkgPCBsZW5ndGg7ICsraSkgeworICAgICAgICBjaGFyIGJ1ZmZlclsxMDBdOworICAgICAgICBz bnByaW50ZihidWZmZXIsIHNpemVvZihidWZmZXIpLCAiKiAlZCwgJWQ6ICVzXG4iLCBwb2ludHNb aV0ucG9zaXRpb24ueCwgcG9pbnRzW2ldLnBvc2l0aW9uLnksIHBvaW50U3RhdGUocG9pbnRzW2ld LnN0YXRlKSk7CisgICAgICAgIGRlbGVnYXRlLT5wcmludE1lc3NhZ2UoYnVmZmVyKTsKKyAgICB9 CiB9CiAKIHZvaWQgcHJpbnRFdmVudERldGFpbHMoV2ViVGVzdERlbGVnYXRlKiBkZWxlZ2F0ZSwg Y29uc3QgV2ViSW5wdXRFdmVudCYgZXZlbnQpCkBAIC0xMTcsMTAgKzExOSwxNCBAQCB2b2lkIHBy aW50RXZlbnREZXRhaWxzKFdlYlRlc3REZWxlZ2F0ZSogZGVsZWdhdGUsIGNvbnN0IFdlYklucHV0 RXZlbnQmIGV2ZW50KQogICAgICAgICBwcmludFRvdWNoTGlzdChkZWxlZ2F0ZSwgdG91Y2gudGFy Z2V0VG91Y2hlcywgdG91Y2gudGFyZ2V0VG91Y2hlc0xlbmd0aCk7CiAgICAgfSBlbHNlIGlmIChX ZWJJbnB1dEV2ZW50Ojppc01vdXNlRXZlbnRUeXBlKGV2ZW50LnR5cGUpIHx8IGV2ZW50LnR5cGUg PT0gV2ViSW5wdXRFdmVudDo6TW91c2VXaGVlbCkgewogICAgICAgICBjb25zdCBXZWJNb3VzZUV2 ZW50JiBtb3VzZSA9IHN0YXRpY19jYXN0PGNvbnN0IFdlYk1vdXNlRXZlbnQmPihldmVudCk7Ci0g ICAgICAgIGRlbGVnYXRlLT5wcmludE1lc3NhZ2Uoc3RkOjpzdHJpbmcoIiogIikgKyBTdHJpbmc6 Om51bWJlcihtb3VzZS54KS5hc2NpaSgpLmRhdGEoKSArICIsICIgKyBTdHJpbmc6Om51bWJlciht b3VzZS55KS5hc2NpaSgpLmRhdGEoKSArICJcbiIpOworICAgICAgICBjaGFyIGJ1ZmZlclsxMDBd OworICAgICAgICBzbnByaW50ZihidWZmZXIsIHNpemVvZihidWZmZXIpLCAiKiAlZCwgJWRcbiIs IG1vdXNlLngsIG1vdXNlLnkpOworICAgICAgICBkZWxlZ2F0ZS0+cHJpbnRNZXNzYWdlKGJ1ZmZl cik7CiAgICAgfSBlbHNlIGlmIChXZWJJbnB1dEV2ZW50Ojppc0dlc3R1cmVFdmVudFR5cGUoZXZl bnQudHlwZSkpIHsKICAgICAgICAgY29uc3QgV2ViR2VzdHVyZUV2ZW50JiBnZXN0dXJlID0gc3Rh dGljX2Nhc3Q8Y29uc3QgV2ViR2VzdHVyZUV2ZW50Jj4oZXZlbnQpOwotICAgICAgICBkZWxlZ2F0 ZS0+cHJpbnRNZXNzYWdlKHN0ZDo6c3RyaW5nKCIqICIpICsgU3RyaW5nOjpudW1iZXIoZ2VzdHVy ZS54KS5hc2NpaSgpLmRhdGEoKSArICIsICIgKyBTdHJpbmc6Om51bWJlcihnZXN0dXJlLnkpLmFz Y2lpKCkuZGF0YSgpICsgIlxuIik7CisgICAgICAgIGNoYXIgYnVmZmVyWzEwMF07CisgICAgICAg IHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlciksICIqICVkLCAlZFxuIiwgZ2VzdHVyZS54 LCBnZXN0dXJlLnkpOworICAgICAgICBkZWxlZ2F0ZS0+cHJpbnRNZXNzYWdlKGJ1ZmZlcik7CiAg ICAgfQogfQogCg==