104779 2012-12-12 01:44:23 -0800 REGRESSION (r137286-r137296): unit test failure in WebKit2APITests/TestWebKitWebContext 2013-04-03 08:43:47 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 113282 113707 1 zan webkit-unassigned cgarcia gustavo mrobinson rego spena webkit.review.bot oldest_to_newest 789335 0 zan 2012-12-12 01:44:23 -0800 A regression was introduced between r137286 and r137296, with the following unit test failing: TEST: ./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/WebKit2APITests/TestWebKitWebContext... (pid=31822) /webkit2/WebKitWebContext/default-context: OK /webkit2/WebKitWebContext/get-plugins: OK /webkit2/WebKitWebContext/uri-scheme: ** ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp:206:void resourceGetDataCallback(GObject*, GAsyncResult*, gpointer): assertion failed: (data) FAIL The two related builds: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/32032 http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/32033 The commit range: http://trac.webkit.org/log/?verbose=on&rev=137296&stop_rev=137286 I'll just do the common thing and for starters blame the libsoup bump in r137286. http://trac.webkit.org/changeset/137286 789413 1 zan 2012-12-12 03:15:07 -0800 Skipped in r137434. http://trac.webkit.org/changeset/137434 795347 2 zan 2012-12-20 04:10:04 -0800 Was treating this as a regression after r137198, but that patch has since been rolled out and the test is still failing. http://trac.webkit.org/changeset/137198 Perhaps this is related to the recent MainResourceLoader modifications, for instance r137333 and similar patches. http://trac.webkit.org/changeset/137333 Good thing I have time for a bisection! 843061 3 zan 2013-02-27 07:47:09 -0800 Tested this with r144170 and the failure still occurs. 856563 4 rego 2013-03-16 03:34:38 -0700 *** Bug 112421 has been marked as a duplicate of this bug. *** 863450 5 rego 2013-03-26 01:27:59 -0700 I've been taking a look to this issue, I don't have too much information but I'd like to share it here. On one hand, the test works for me in the stable branch, however it's failing in trunk (and it was already failing when I reported the duplicated bug #112421). On the other hand, it seems that the problem is that DocumentLoader::mainResourceData() is returning NULL. This means that dataReference in WebPage::getMainResourceDataOfFrame() is not properly initialized. 866764 6 cgarcia 2013-03-31 03:26:34 -0700 It doesn't fail for me with a recent trunk (r146868) 866995 7 rego 2013-04-01 02:18:40 -0700 (In reply to comment #6) > It doesn't fail for me with a recent trunk (r146868) It's working for me too in r147306. 866998 8 cgarcia 2013-04-01 02:34:12 -0700 Could someone unskip it and close this, please? 867004 9 195947 rego 2013-04-01 02:43:40 -0700 Created attachment 195947 Patch 867022 10 195947 webkit.review.bot 2013-04-01 03:44:53 -0700 Comment on attachment 195947 Patch Clearing flags on attachment: 195947 Committed r147319: <http://trac.webkit.org/changeset/147319> 867023 11 webkit.review.bot 2013-04-01 03:44:57 -0700 All reviewed patches have been landed. Closing bug. 867182 12 webkit.review.bot 2013-04-01 09:44:52 -0700 Re-opened since this is blocked by bug 113707 867185 13 zan 2013-04-01 09:48:00 -0700 (In reply to comment #12) > Re-opened since this is blocked by bug 113707 The test is still failing on the 64-bit release builder, so rolling the unskip patch out. The failure is still the same. 868539 14 cgarcia 2013-04-03 01:56:54 -0700 (In reply to comment #13) > (In reply to comment #12) > > Re-opened since this is blocked by bug 113707 > > The test is still failing on the 64-bit release builder, so rolling the unskip patch out. The failure is still the same. hmm, I managed to reproduce the issue in the 64 bit release bot. It seems the scheme handlers are registered correctly, but libsoup is not handling them. I've just built a new libsoup in the bot and it works, so this will be fixed when bug #113282 lands. 868729 15 195947 zan 2013-04-03 08:15:03 -0700 Comment on attachment 195947 Patch Bug #113282 landed, perhaps just flipping the cq flag on this patch will do all the magic of landing, removing the need to reupload the same patch. 868732 16 195947 cgarcia 2013-04-03 08:17:58 -0700 Comment on attachment 195947 Patch Wait a bit bots still don't build, and the patch has Reviewed by NOBODY 868733 17 zan 2013-04-03 08:23:35 -0700 Ugh, right. Sorry for jumping forward with it. 868734 18 195947 cgarcia 2013-04-03 08:23:41 -0700 Comment on attachment 195947 Patch Sorry, it seems the 64 bit release bot is building fine now. 868742 19 195947 webkit.review.bot 2013-04-03 08:43:42 -0700 Comment on attachment 195947 Patch Clearing flags on attachment: 195947 Committed r147559: <http://trac.webkit.org/changeset/147559> 868743 20 webkit.review.bot 2013-04-03 08:43:47 -0700 All reviewed patches have been landed. Closing bug. 195947 2013-04-01 02:43:40 -0700 2013-04-03 08:43:42 -0700 Patch bug-104779-20130401114333.patch text/plain 1852 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MzA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTI2M2JjOGE0ZjY4YTAxZWE3MWI4YTgyZmNiYjA2YTZk MThkNjc1ZS4uMDNjOWZhNzE4YzUxM2NlZmQyYjI1ZjRlOGUxOTEyMTRiNzZmNTdiOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTA0LTAxICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdW1dLMl0gVW5za2lwIC93ZWJraXQyL1dlYktpdFdlYkNvbnRleHQv dXJpLXNjaGVtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA0Nzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6CisgICAgICAgIChUZXN0UnVubmVyKTogVW5za2lw IC93ZWJraXQyL1dlYktpdFdlYkNvbnRleHQvdXJpLXNjaGVtZSBhcyBpdCBpcworICAgICAgICBw YXNzaW5nIGluIGN1cnJlbnQgdHJ1bmsuCisKIDIwMTMtMDMtMzEgIFNoZXJpZmYgQm90ICA8d2Vi a2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHIxNDcyODkuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMgYi9U b29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKaW5kZXggZWY3MzczNTdhOTAzYTMzYTNhMThjOWYz NzZiMDU2OTBkNmZmMDgzZS4uYzQwYjlmYTRhNDk3NDk5Yjc3YjM5YjczMmI3ZjQyYWQyYzQ4MTVi MSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCisrKyBiL1Rvb2xzL1Nj cmlwdHMvcnVuLWd0ay10ZXN0cwpAQCAtNzIsNyArNzIsNiBAQCBjbGFzcyBUZXN0UnVubmVyOgog ICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0MkFQSVRlc3RzL1Rlc3RSZXNvdXJjZXMiLCAiL3dl YmtpdDIvV2ViS2l0V2ViVmlldy9yZXNvdXJjZXMiLCAiVGVzdCBpcyBmbGFreSBpbiBHVEsgTGlu dXggMzItYml0IFJlbGVhc2UgYm90IiwgODI4NjgpLAogICAgICAgICBTa2lwcGVkVGVzdCgiV2Vi S2l0MkFQSVRlc3RzL1Rlc3RXZWJLaXRBY2Nlc3NpYmlsaXR5IiwgIi93ZWJraXQyL1dlYktpdEFj Y2Vzc2liaWxpdHkvYXRzcGktYmFzaWMtaGllcmFyY2h5IiwgIlRlc3QgZmFpbHMiLCAxMDA0MDgp LAogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0MkFQSVRlc3RzL1Rlc3RXZWJLaXRGaW5kQ29u dHJvbGxlciIsICIvd2Via2l0Mi9XZWJLaXRGaW5kQ29udHJvbGxlci9oaWRlIiwgIlRlc3QgYWx3 YXlzIGZhaWxzIGluIFh2ZmIiLCA4OTgxMCksCi0gICAgICAgIFNraXBwZWRUZXN0KCJXZWJLaXQy QVBJVGVzdHMvVGVzdFdlYktpdFdlYkNvbnRleHQiLCAiL3dlYmtpdDIvV2ViS2l0V2ViQ29udGV4 dC91cmktc2NoZW1lIiwgIlRlc3QgZmFpbHMiLCAxMDQ3NzkpLAogICAgICAgICBTa2lwcGVkVGVz dCgiVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0MiIsICJXZWJLaXQyLkNhbkhhbmRsZVJlcXVlc3Qi LCAiVGVzdCBmYWlscyIsIDg4NDUzKSwKICAgICAgICAgU2tpcHBlZFRlc3QoIlRlc3RXZWJLaXRB UEkvVGVzdFdlYktpdDIiLCAiV2ViS2l0Mi5Nb3VzZU1vdmVBZnRlckNyYXNoIiwgIlRlc3QgaXMg Zmxha3kiLCA4NTA2NiksCiAgICAgICAgIFNraXBwZWRUZXN0KCJUZXN0V2ViS2l0QVBJL1Rlc3RX ZWJLaXQyIiwgIldlYktpdDIuTmV3Rmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9ySW1hZ2Vz IiwgIlRlc3QgaXMgZmxha3kiLCA4NTA2NiksCg==