10477 2006-08-17 19:53:08 -0700 Unix build failure due to using "String.h" instead of "PlatformString.h" 2006-08-18 07:07:33 -0700 1 1 1 Unclassified WebKit New Bugs 420+ PC OS X 10.4 RESOLVED DUPLICATE 10465 P2 Normal --- 1 kkowalczyk webkit-unassigned oldest_to_newest 52889 0 kkowalczyk 2006-08-17 19:53:08 -0700 A recent checkin to DOMParser.cpp does #include "String.h" I assume it was supposed to be #include "PlatfromString.h" because I can't see "String.h" anywhere in the sources and no other file (as far as I can tell) uses "Stringh" Patch attached. 52890 1 10114 kkowalczyk 2006-08-17 19:53:49 -0700 Created attachment 10114 #include "PlatfromString.h" instead of "String.h" 52891 2 mrowe 2006-08-17 21:41:23 -0700 Patches generally require ChangeLog entries. 52894 3 kkowalczyk 2006-08-17 22:35:38 -0700 I'll be happy to provide one but I was under the impression that ChangeLog entries are written by actual commiters. That's how it worked for all the patches I've submitted so far. Does that meant that I also have to provide a diff against ChangeLog or should it be written in the bug? I'm all for playing by the rules but for trivial patches like this one it seems like an overkill. 52899 4 10114 eric 2006-08-18 02:26:29 -0700 Comment on attachment 10114 #include "PlatfromString.h" instead of "String.h" I believe Wildfox fixed this in another recent patch. Either could land. 52921 5 ddkilzer 2006-08-18 07:00:35 -0700 (In reply to comment #3) > I'll be happy to provide one but I was under the impression that ChangeLog > entries are written by actual commiters. That's how it worked for all the > patches I've submitted so far. > > Does that meant that I also have to provide a diff against ChangeLog or should > it be written in the bug? > > I'm all for playing by the rules but for trivial patches like this one it seems > like an overkill. ChangeLog entries should be created for all bugs. Although the web page doesn't talk about it (yet), the WebKitTools/Scripts/prepare-ChangeLog script will create one for you--you just have to fill in the details. http://webkit.opendarwin.org/coding/contributing.html 52922 6 ddkilzer 2006-08-18 07:07:33 -0700 (In reply to comment #4) > (From update of attachment 10114 [edit]) > I believe Wildfox fixed this in another recent patch. Either could land. This was fixed in the patch for Bug 10465 by r15932. *** This bug has been marked as a duplicate of 10465 *** 10114 2006-08-17 19:53:49 -0700 2006-08-18 02:26:29 -0700 #include "PlatfromString.h" instead of "String.h" string_diff.txt text/plain 348 kkowalczyk SW5kZXg6IFdlYkNvcmUveG1sL0RPTVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS94 bWwvRE9NUGFyc2VyLmNwcAkocmV2aXNpb24gMTU5MjgpCisrKyBXZWJDb3JlL3htbC9ET01QYXJz ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMSw3ICsyMSw3IEBACiAjaW5jbHVkZSAiRE9NUGFy c2VyLmgiCiAKICNpbmNsdWRlICJET01JbXBsZW1lbnRhdGlvbi5oIgotI2luY2x1ZGUgIlN0cmlu Zy5oIgorI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAK