104760 2012-12-11 18:55:59 -0800 [EFL] Allow the build system to find OpenGL ES 2012-12-19 21:28:24 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101389 105286 1 laszlo.gombos webkit-unassigned gyuyoung.kim kalyan.kondapally laszlo.gombos lucas.de.marchi mxie ostap73 rakuco ryuan.choi webkit.review.bot yael oldest_to_newest 789107 0 laszlo.gombos 2012-12-11 18:55:59 -0800 Currently cmake/OptionsEfl.cmake requires OpenGL for ENABLE_WEBGL OR WTF_USE_TILED_BACKING_STORE support. This requirement can be relaxed to also enable OpenGL ES and not just OpenGL. FindOpenGL.cmake is included in CMake distributions but FindOpenGLES2.cmake likely needs to be implemented and checked in into the WebKit tree. Here is one implementation that likely can be used with a permissive license https://bitbucket.org/sinbad/ogre/src/3cbd67467fab3fef44d1b32bc42ccf4fb1ccfdd0/CMake/Packages/FindOpenGLES2.cmake?at=default. 793910 1 179996 yael 2012-12-18 12:08:59 -0800 Created attachment 179996 Patch 793916 2 webkit.review.bot 2012-12-18 12:14:59 -0800 Attachment 179996 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/cmake/FindGLES.cmake']" exit_code: 1 Source/cmake/FindGLES.cmake:31: Use lowercase command "find_path" [command/lowercase] [5] Source/cmake/FindGLES.cmake:33: Use lowercase command "find_library" [command/lowercase] [5] Source/cmake/FindGLES.cmake:35: Use lowercase command "if" [command/lowercase] [5] Source/cmake/FindGLES.cmake:36: No space after "(" [whitespace/parentheses] [5] Source/cmake/FindGLES.cmake:36: Use lowercase command "set" [command/lowercase] [5] Source/cmake/FindGLES.cmake:37: No space after "(" [whitespace/parentheses] [5] Source/cmake/FindGLES.cmake:37: No space before ")" [whitespace/parentheses] [5] Source/cmake/FindGLES.cmake:37: Use lowercase command "set" [command/lowercase] [5] Source/cmake/FindGLES.cmake:38: Use lowercase command "endif" [command/lowercase] [5] Source/cmake/FindGLES.cmake:40: Use lowercase command "mark_as_advanced" [command/lowercase] [5] Total errors found: 10 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 793947 3 180005 yael 2012-12-18 12:44:00 -0800 Created attachment 180005 Patch Fix style 794014 4 180005 laszlo.gombos 2012-12-18 13:55:15 -0800 Comment on attachment 180005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180005&action=review > Source/cmake/FindGLES.cmake:8 > +# Copyright (C) 2012 Intel Corporation. All rights reserved. It seems that you have not used much really from https://bitbucket.org/sinbad/ogre/src/3cbd67467fab3fef44d1b32bc42ccf4fb1ccfdd0/CMake/Packages/FindOpenGLES2.cmake?at=default, so I think this Copyright is ok. > Source/cmake/FindGLES.cmake:38 > +if (OPENGLES2_gl_LIBRARY) > + set(OPENGLES2_LIBRARIES ${OPENGLES2_gl_LIBRARY} ${OPENGLES2_LIBRARIES}) > + set(OPENGLES2_FOUND "YES") > +endif (OPENGLES2_gl_LIBRARY and EGL_egl_LIBRARY) I think we should use the FIND_PACKAGE_HANDLE_STANDARD_ARGS macro instead to align with other FindXX.cmake files. > Source/cmake/FindGLES.cmake:40 > +mark_as_advanced(OPENGLES2_INCLUDE_DIR OPENGLES2_gl_LIBRARY) Perhaps we can move this to the FIND_PACKAGE_HANDLE_STANDARD_ARGS macro (and remove it from the other FindXXX.cmake files that are already using FIND_PACKAGE_HANDLE_STANDARD_ARGS macro (e.g. FindFontconfig.cmake). This is unrelated so best to do it in a new bug. > ChangeLog:11 > + FindGLES.cmake is loosely based on the example from > + https://bitbucket.org/sinbad/ogre/src/3cbd67467fab3fef44d1b32bc42ccf4fb1ccfdd0/CMake/Packages/FindOpenGLES2.cmake?at=default. I do not think we need to mention this here. The bug has a reference to this if someone wants to extend this simple version in this patch and support more platforms. 794049 5 laszlo.gombos 2012-12-18 14:25:59 -0800 (In reply to comment #4) > (From update of attachment 180005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180005&action=review > > > Source/cmake/FindGLES.cmake:40 > > +mark_as_advanced(OPENGLES2_INCLUDE_DIR OPENGLES2_gl_LIBRARY) > > Perhaps we can move this to the FIND_PACKAGE_HANDLE_STANDARD_ARGS macro (and remove it from the other FindXXX.cmake files that are already using FIND_PACKAGE_HANDLE_STANDARD_ARGS macro (e.g. FindFontconfig.cmake). This is unrelated so best to do it in a new bug. I just noticed that FIND_PACKAGE_HANDLE_STANDARD_ARGS is a macro that comes with cmake - in that case this part of the patch is correct. I filed bug 105350 to follow this practice consistently. 794109 6 180005 kalyan.kondapally 2012-12-18 15:15:27 -0800 Comment on attachment 180005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180005&action=review > Source/cmake/FindGLES.cmake:37 > + set(OPENGLES2_FOUND "YES") Do we really need to set this?? I think this is done by cmake already. I am not that familiar with cmake though :) I dont see any other files doing this. > Source/cmake/FindGLES.cmake:39 > + Do we need the EGL check here ?? 794110 7 kalyan.kondapally 2012-12-18 15:16:53 -0800 (In reply to comment #6) > (From update of attachment 180005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180005&action=review > > Source/cmake/FindGLES.cmake:39 > > + > > Do we need the EGL check here ?? Meant this part: endif (OPENGLES2_gl_LIBRARY and EGL_egl_LIBRARY) 794670 8 yael 2012-12-19 07:49:28 -0800 (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 180005 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=180005&action=review > > > > Source/cmake/FindGLES.cmake:39 > > > + > > > > Do we need the EGL check here ?? > > Meant this part: > > endif (OPENGLES2_gl_LIBRARY and EGL_egl_LIBRARY) The original file was checking for both EGL and OPENGLES2, my patch is checking only for OPENGLES2, not for EGL. Is there a reason to keep the EGL checks? 794673 9 180168 yael 2012-12-19 07:52:44 -0800 Created attachment 180168 Patch Remove the URL from the Changelog, as suggested by comment #4. 794758 10 yael 2012-12-19 09:45:19 -0800 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > (From update of attachment 180005 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=180005&action=review > > > > > > Source/cmake/FindGLES.cmake:39 > > > > + > > > > > > Do we need the EGL check here ?? > > > > Meant this part: > > > > endif (OPENGLES2_gl_LIBRARY and EGL_egl_LIBRARY) > The original file was checking for both EGL and OPENGLES2, my patch is checking only for OPENGLES2, not for EGL. > Is there a reason to keep the EGL checks? Sorry, I misunderstood your comment, will fix this. 794780 11 180191 yael 2012-12-19 10:08:28 -0800 Created attachment 180191 Patch Update based on comments 794794 12 180191 laszlo.gombos 2012-12-19 10:38:18 -0800 Comment on attachment 180191 Patch lgtm. 795150 13 180191 webkit.review.bot 2012-12-19 21:28:19 -0800 Comment on attachment 180191 Patch Clearing flags on attachment: 180191 Committed r138217: <http://trac.webkit.org/changeset/138217> 795151 14 webkit.review.bot 2012-12-19 21:28:24 -0800 All reviewed patches have been landed. Closing bug. 179996 2012-12-18 12:08:59 -0800 2012-12-18 12:44:00 -0800 Patch 104760.patch text/plain 3094 yael SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzODA0 NikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEy LTE4ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQGludGVsLmNvbT4KKworICAgICAgICBbRUZM XSBBbGxvdyB0aGUgYnVpbGQgc3lzdGVtIHRvIGZpbmQgT3BlbkdMIEVTCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ3NjAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB3YXkgdG8gZmluZCBpZiBH TEVTdjIgaXMgc3VwcG9ydGVkIGJ5IHRoZSBidWlsZCBzeXN0ZW0uCisgICAgICAgIFN1cHBvcnQg Zm9yIEdMRVN2MiB3aWxsIGJlIGFkZGVkIHNlcGFyYXRlbHkuCisgICAgICAgIEZpbmRHTEVTLmNt YWtlIGlzIGxvb3NlbHkgYmFzZWQgb24gdGhlIGV4YW1wbGUgZnJvbQorICAgICAgICBodHRwczov L2JpdGJ1Y2tldC5vcmcvc2luYmFkL29ncmUvc3JjLzNjYmQ2NzQ2N2ZhYjNmZWY0NGQxYjMyYmM0 MmNjZjRmYjFjY2ZkZDAvQ01ha2UvUGFja2FnZXMvRmluZE9wZW5HTEVTMi5jbWFrZT9hdD1kZWZh dWx0LgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRHTEVTLmNtYWtlOiBBZGRlZC4KKwog MjAxMi0xMi0xOCAgS29uZGFwYWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5j b20+CiAKICAgICAgICAgW0VGTF0gQWxsb3cgdGhlIGJ1aWxkIHN5c3RlbSB0byBkZXRlY3QgRUdM IHN1cHBvcnQuCkluZGV4OiBTb3VyY2UvY21ha2UvRmluZEdMRVMuY21ha2UKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL2NtYWtlL0ZpbmRHTEVTLmNtYWtlCShyZXZpc2lvbiAwKQorKysgU291cmNlL2Nt YWtlL0ZpbmRHTEVTLmNtYWtlCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQwIEBACisjIC0gVHJ5 IHRvIGZpbmQgT3BlbkdMRVMKKyMgT25jZSBkb25lIHRoaXMgd2lsbCBkZWZpbmUKKyMgIAorIyAg T1BFTkdMRVMyX0ZPVU5EICAgICAgICAtIHN5c3RlbSBoYXMgT3BlbkdMRVN2MiBpbnN0YWxsZWQu CisjICBPUEVOR0xFUzJfSU5DTFVERV9ESVIgIC0gZGlyZWN0b3JpZXMgd2hpY2ggY29udGFpbiB0 aGUgT3BlbkdsRXN2MiBoZWFkZXJzLgorIyAgT1BFTkdMRVMyX0xJQlJBUklFUyAgICAtIGxpYnJh cmllcyByZXF1aXJlZCB0byBsaW5rIGFnYWluc3QgT3BlbkdMRVN2MgorIworIyBDb3B5cmlnaHQg KEMpIDIwMTIgSW50ZWwgQ29ycG9yYXRpb24uIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMgMS4gIFJlZGlzdHJpYnV0aW9ucyBv ZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIu CisjIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl IGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyAgICAgZG9jdW1lbnRhdGlvbiBh bmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyMK KyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUiBBTkQg SVRTIENPTlRSSUJVVE9SUyBgYEFTCisjIElTJycgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQg V0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisjIFRIRSBJTVBMSUVE IFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VM QVIKKyMgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlS SUdIVCBIT0xERVIgT1IgSVRTCisjIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJF Q1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLAorIyBFWEVNUExBUlksIE9SIENPTlNF UVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisjIFBST0NV UkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRB LCBPUiBQUk9GSVRTOworIyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VE IEFORCBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwKKyMgV0hFVEhFUiBJTiBDT05UUkFDVCwg U1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IKKyMgT1RI RVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FS RSwgRVZFTiBJRgorIyBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4K KworRklORF9QQVRIKE9QRU5HTEVTMl9JTkNMVURFX0RJUiBOQU1FUyBHTEVTMi9nbDIuaCkKKwor RklORF9MSUJSQVJZKE9QRU5HTEVTMl9nbF9MSUJSQVJZIE5BTUVTIEdMRVN2MikKKworSUYoT1BF TkdMRVMyX2dsX0xJQlJBUlkpCisgICAgU0VUKCBPUEVOR0xFUzJfTElCUkFSSUVTICR7T1BFTkdM RVMyX2dsX0xJQlJBUll9ICR7T1BFTkdMRVMyX0xJQlJBUklFU30pCisgICAgU0VUKCBPUEVOR0xF UzJfRk9VTkQgIllFUyIgKQorRU5ESUYoT1BFTkdMRVMyX2dsX0xJQlJBUlkgQU5EIEVHTF9lZ2xf TElCUkFSWSkKKworTUFSS19BU19BRFZBTkNFRChPUEVOR0xFUzJfSU5DTFVERV9ESVIgT1BFTkdM RVMyX2dsX0xJQlJBUlkpCg== 180005 2012-12-18 12:44:00 -0800 2012-12-19 07:52:44 -0800 Patch 104760.patch text/plain 3093 yael SW5kZXg6IFNvdXJjZS9jbWFrZS9GaW5kR0xFUy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv Y21ha2UvRmluZEdMRVMuY21ha2UJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvY21ha2UvRmluZEdM RVMuY21ha2UJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDAgQEAKKyMgLSBUcnkgdG8gZmluZCBP cGVuR0xFUworIyBPbmNlIGRvbmUgdGhpcyB3aWxsIGRlZmluZQorIyAgCisjICBPUEVOR0xFUzJf Rk9VTkQgICAgICAgIC0gc3lzdGVtIGhhcyBPcGVuR0xFU3YyIGluc3RhbGxlZC4KKyMgIE9QRU5H TEVTMl9JTkNMVURFX0RJUiAgLSBkaXJlY3RvcmllcyB3aGljaCBjb250YWluIHRoZSBPcGVuR2xF c3YyIGhlYWRlcnMuCisjICBPUEVOR0xFUzJfTElCUkFSSUVTICAgIC0gbGlicmFyaWVzIHJlcXVp cmVkIHRvIGxpbmsgYWdhaW5zdCBPcGVuR0xFU3YyCisjCisjIENvcHlyaWdodCAoQykgMjAxMiBJ bnRlbCBDb3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRp b24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0Cisj IG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcg Y29uZGl0aW9ucworIyBhcmUgbWV0OgorIyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBj b2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBs aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gIFJl ZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29w eXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhl ciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNP RlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSIEFORCBJVFMgQ09OVFJJ QlVUT1JTIGBgQVMKKyMgSVMnJyBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVT LCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyMgVEhFIElNUExJRUQgV0FSUkFOVElF UyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorIyBQVVJQ T1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIEhPTERF UiBPUiBJVFMKKyMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJF Q1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsCisjIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBE QU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyMgUFJPQ1VSRU1FTlQgT0Yg U1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJ VFM7CisjIE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFO WSBUSEVPUlkgT0YgTElBQklMSVRZLAorIyBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElB QklMSVRZLCBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUgorIyBPVEhFUldJU0UpIEFS SVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElG CisjIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitmaW5kX3Bh dGgoT1BFTkdMRVMyX0lOQ0xVREVfRElSIE5BTUVTIEdMRVMyL2dsMi5oKQorCitmaW5kX2xpYnJh cnkoT1BFTkdMRVMyX2dsX0xJQlJBUlkgTkFNRVMgR0xFU3YyKQorCitpZiAoT1BFTkdMRVMyX2ds X0xJQlJBUlkpCisgICAgc2V0KE9QRU5HTEVTMl9MSUJSQVJJRVMgJHtPUEVOR0xFUzJfZ2xfTElC UkFSWX0gJHtPUEVOR0xFUzJfTElCUkFSSUVTfSkKKyAgICBzZXQoT1BFTkdMRVMyX0ZPVU5EICJZ RVMiKQorZW5kaWYgKE9QRU5HTEVTMl9nbF9MSUJSQVJZIGFuZCBFR0xfZWdsX0xJQlJBUlkpCisK K21hcmtfYXNfYWR2YW5jZWQoT1BFTkdMRVMyX0lOQ0xVREVfRElSIE9QRU5HTEVTMl9nbF9MSUJS QVJZKQpJbmRleDogQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24g MTM4MDQ2KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIw MTItMTItMTggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25AaW50ZWwuY29tPgorCisgICAgICAg IFtFRkxdIEFsbG93IHRoZSBidWlsZCBzeXN0ZW0gdG8gZmluZCBPcGVuR0wgRVMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDc2MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHdheSB0byBmaW5k IGlmIEdMRVN2MiBpcyBzdXBwb3J0ZWQgYnkgdGhlIGJ1aWxkIHN5c3RlbS4KKyAgICAgICAgU3Vw cG9ydCBmb3IgR0xFU3YyIHdpbGwgYmUgYWRkZWQgc2VwYXJhdGVseS4KKyAgICAgICAgRmluZEdM RVMuY21ha2UgaXMgbG9vc2VseSBiYXNlZCBvbiB0aGUgZXhhbXBsZSBmcm9tCisgICAgICAgIGh0 dHBzOi8vYml0YnVja2V0Lm9yZy9zaW5iYWQvb2dyZS9zcmMvM2NiZDY3NDY3ZmFiM2ZlZjQ0ZDFi MzJiYzQyY2NmNGZiMWNjZmRkMC9DTWFrZS9QYWNrYWdlcy9GaW5kT3BlbkdMRVMyLmNtYWtlP2F0 PWRlZmF1bHQuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEdMRVMuY21ha2U6IEFkZGVk LgorCiAyMDEyLTEyLTE4ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGlu dGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBBbGxvdyB0aGUgYnVpbGQgc3lzdGVtIHRvIGRldGVj dCBFR0wgc3VwcG9ydC4K 180168 2012-12-19 07:52:44 -0800 2012-12-19 10:08:28 -0800 Patch 104760.patch text/plain 2897 yael SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzODA0 NikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEy LTE4ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQGludGVsLmNvbT4KKworICAgICAgICBbRUZM XSBBbGxvdyB0aGUgYnVpbGQgc3lzdGVtIHRvIGZpbmQgT3BlbkdMIEVTCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ3NjAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB3YXkgdG8gZmluZCBpZiBH TEVTdjIgaXMgc3VwcG9ydGVkIGJ5IHRoZSBidWlsZCBzeXN0ZW0uCisgICAgICAgIFN1cHBvcnQg Zm9yIEdMRVN2MiB3aWxsIGJlIGFkZGVkIHNlcGFyYXRlbHkuCisKKyAgICAgICAgKiBTb3VyY2Uv Y21ha2UvRmluZEdMRVMuY21ha2U6IEFkZGVkLgorCiAyMDEyLTEyLTE4ICBLb25kYXBhbGx5IEth bHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBBbGxv dyB0aGUgYnVpbGQgc3lzdGVtIHRvIGRldGVjdCBFR0wgc3VwcG9ydC4KSW5kZXg6IFNvdXJjZS9j bWFrZS9GaW5kR0xFUy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvRmluZEdMRVMu Y21ha2UJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvY21ha2UvRmluZEdMRVMuY21ha2UJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsNDAgQEAKKyMgLSBUcnkgdG8gZmluZCBPcGVuR0xFUworIyBPbmNl IGRvbmUgdGhpcyB3aWxsIGRlZmluZQorIyAgCisjICBPUEVOR0xFUzJfRk9VTkQgICAgICAgIC0g c3lzdGVtIGhhcyBPcGVuR0xFU3YyIGluc3RhbGxlZC4KKyMgIE9QRU5HTEVTMl9JTkNMVURFX0RJ UiAgLSBkaXJlY3RvcmllcyB3aGljaCBjb250YWluIHRoZSBPcGVuR2xFc3YyIGhlYWRlcnMuCisj ICBPUEVOR0xFUzJfTElCUkFSSUVTICAgIC0gbGlicmFyaWVzIHJlcXVpcmVkIHRvIGxpbmsgYWdh aW5zdCBPcGVuR0xFU3YyCisjCisjIENvcHlyaWdodCAoQykgMjAxMiBJbnRlbCBDb3Jwb3JhdGlv bi4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworIyBh cmUgbWV0OgorIyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWlu IHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gIFJlZGlzdHJpYnV0aW9ucyBp biBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIgaW4gdGhlCisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJv dmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJ REVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMKKyMg SVMnJyBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywKKyMgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFC SUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorIyBQVVJQT1NFIEFSRSBESVNDTEFJ TUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIEhPTERFUiBPUiBJVFMKKyMgQ09O VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws IFNQRUNJQUwsCisjIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJ TkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyMgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09E UyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7CisjIE9SIEJVU0lO RVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElB QklMSVRZLAorIyBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JU IChJTkNMVURJTkcgTkVHTElHRU5DRSBPUgorIyBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB WSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGCisjIEFEVklTRUQgT0Yg VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitmaW5kX3BhdGgoT1BFTkdMRVMyX0lO Q0xVREVfRElSIE5BTUVTIEdMRVMyL2dsMi5oKQorCitmaW5kX2xpYnJhcnkoT1BFTkdMRVMyX2ds X0xJQlJBUlkgTkFNRVMgR0xFU3YyKQorCitpZiAoT1BFTkdMRVMyX2dsX0xJQlJBUlkpCisgICAg c2V0KE9QRU5HTEVTMl9MSUJSQVJJRVMgJHtPUEVOR0xFUzJfZ2xfTElCUkFSWX0gJHtPUEVOR0xF UzJfTElCUkFSSUVTfSkKKyAgICBzZXQoT1BFTkdMRVMyX0ZPVU5EICJZRVMiKQorZW5kaWYgKE9Q RU5HTEVTMl9nbF9MSUJSQVJZIGFuZCBFR0xfZWdsX0xJQlJBUlkpCisKK21hcmtfYXNfYWR2YW5j ZWQoT1BFTkdMRVMyX0lOQ0xVREVfRElSIE9QRU5HTEVTMl9nbF9MSUJSQVJZKQo= 180191 2012-12-19 10:08:28 -0800 2012-12-19 21:28:19 -0800 Patch 104760.patch text/plain 2840 yael SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzODA0 NikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEy LTE4ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQGludGVsLmNvbT4KKworICAgICAgICBbRUZM XSBBbGxvdyB0aGUgYnVpbGQgc3lzdGVtIHRvIGZpbmQgT3BlbkdMIEVTCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ3NjAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB3YXkgdG8gZmluZCBpZiBH TEVTdjIgaXMgc3VwcG9ydGVkIGJ5IHRoZSBidWlsZCBzeXN0ZW0uCisgICAgICAgIFN1cHBvcnQg Zm9yIEdMRVN2MiB3aWxsIGJlIGFkZGVkIHNlcGFyYXRlbHkuCisKKyAgICAgICAgKiBTb3VyY2Uv Y21ha2UvRmluZEdMRVMuY21ha2U6IEFkZGVkLgorCiAyMDEyLTEyLTE4ICBLb25kYXBhbGx5IEth bHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBBbGxv dyB0aGUgYnVpbGQgc3lzdGVtIHRvIGRldGVjdCBFR0wgc3VwcG9ydC4KSW5kZXg6IFNvdXJjZS9j bWFrZS9GaW5kR0xFUy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvRmluZEdMRVMu Y21ha2UJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvY21ha2UvRmluZEdMRVMuY21ha2UJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsMzggQEAKKyMgLSBUcnkgdG8gZmluZCBPcGVuR0xFUworIyBPbmNl IGRvbmUgdGhpcyB3aWxsIGRlZmluZQorIyAgCisjICBPUEVOR0xFUzJfRk9VTkQgICAgICAgIC0g c3lzdGVtIGhhcyBPcGVuR0xFU3YyIGluc3RhbGxlZC4KKyMgIE9QRU5HTEVTMl9JTkNMVURFX0RJ UiAgLSBkaXJlY3RvcmllcyB3aGljaCBjb250YWluIHRoZSBPcGVuR2xFc3YyIGhlYWRlcnMuCisj ICBPUEVOR0xFUzJfTElCUkFSSUVTICAgIC0gbGlicmFyaWVzIHJlcXVpcmVkIHRvIGxpbmsgYWdh aW5zdCBPcGVuR0xFU3YyCisjCisjIENvcHlyaWdodCAoQykgMjAxMiBJbnRlbCBDb3Jwb3JhdGlv bi4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworIyBh cmUgbWV0OgorIyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWlu IHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gIFJlZGlzdHJpYnV0aW9ucyBp biBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIgaW4gdGhlCisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJv dmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJ REVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMKKyMg SVMnJyBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywKKyMgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFC SUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorIyBQVVJQT1NFIEFSRSBESVNDTEFJ TUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIEhPTERFUiBPUiBJVFMKKyMgQ09O VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws IFNQRUNJQUwsCisjIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJ TkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyMgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09E UyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7CisjIE9SIEJVU0lO RVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElB QklMSVRZLAorIyBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JU IChJTkNMVURJTkcgTkVHTElHRU5DRSBPUgorIyBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB WSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGCisjIEFEVklTRUQgT0Yg VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitmaW5kX3BhdGgoT1BFTkdMRVMyX0lO Q0xVREVfRElSIE5BTUVTIEdMRVMyL2dsMi5oKQorCitmaW5kX2xpYnJhcnkoT1BFTkdMRVMyX0xJ QlJBUlkgTkFNRVMgR0xFU3YyKQorCitpbmNsdWRlKEZpbmRQYWNrYWdlSGFuZGxlU3RhbmRhcmRB cmdzKQorRklORF9QQUNLQUdFX0hBTkRMRV9TVEFOREFSRF9BUkdTKEdMRVN2MiBERUZBVUxUX01T RyBPUEVOR0xFUzJfSU5DTFVERV9ESVIgT1BFTkdMRVMyX0xJQlJBUlkpCisKK21hcmtfYXNfYWR2 YW5jZWQoT1BFTkdMRVMyX0lOQ0xVREVfRElSIE9QRU5HTEVTMl9MSUJSQVJZKQo=