104746 2012-12-11 17:15:49 -0800 REGRESSION (r137006): TileCache flashes to linen, rather than the background color, when scrolling fast 2012-12-15 11:39:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin dglazkov eric noam ojan.autocc simon.fraser thorton webkit-bug-importer webkit.review.bot oldest_to_newest 789012 0 simon.fraser 2012-12-11 17:15:49 -0800 After r137006, tile cache flashes now flash to linen rather than the background color, making them look much worse. 789013 1 webkit-bug-importer 2012-12-11 17:16:10 -0800 <rdar://problem/12860678> 789022 2 noam 2012-12-11 17:21:19 -0800 How does one reproduce this? 789042 3 simon.fraser 2012-12-11 17:35:16 -0800 Scroll really fast (or hit Home/End) on a long page, like http://www.w3.org/2012/08/13-css-irc 789093 4 178942 simon.fraser 2012-12-11 18:29:38 -0800 Created attachment 178942 Patch, but test updates needed 789094 5 178942 simon.fraser 2012-12-11 18:30:34 -0800 Comment on attachment 178942 Patch, but test updates needed I think this patch is correct, but it affects all the layout test results, and I wonder if we should set the root layer's background color on all platforms. 789136 6 178942 webkit.review.bot 2012-12-11 20:04:44 -0800 Comment on attachment 178942 Patch, but test updates needed Attachment 178942 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15277406 New failing tests: compositing/geometry/bounds-clipped-composited-child.html compositing/geometry/clip.html compositing/geometry/limit-layer-bounds-positioned.html compositing/geometry/bounds-ignores-hidden-composited-descendant.html compositing/geometry/bounds-ignores-hidden.html compositing/geometry/limit-layer-bounds-clipping-ancestor.html compositing/backing/no-backing-for-clip-overlap.html compositing/bounds-in-flipped-writing-mode.html compositing/geometry/fixed-position-composited-switch.html compositing/geometry/limit-layer-bounds-transformed-overflow.html compositing/iframes/become-overlapped-iframe.html compositing/geometry/foreground-layer.html compositing/absolute-inside-out-of-view-fixed.html compositing/geometry/limit-layer-bounds-overflow-root.html compositing/geometry/limit-layer-bounds-fixed-positioned.html compositing/geometry/layer-due-to-layer-children-deep-switch.html compositing/geometry/ancestor-overflow-change.html compositing/geometry/limit-layer-bounds-positioned-transition.html compositing/geometry/clip-inside.html compositing/geometry/layer-due-to-layer-children-switch.html compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html compositing/columns/composited-in-paginated.html compositing/iframes/become-composited-nested-iframes.html compositing/geometry/bounds-ignores-hidden-dynamic.html compositing/geometry/limit-layer-bounds-transformed.html compositing/clip-child-by-non-stacking-ancestor.html compositing/geometry/flipped-writing-mode.html compositing/overflow-trumps-transform-style.html compositing/backing/no-backing-for-clip.html compositing/backing/no-backing-for-perspective.html 789192 7 178963 simon.fraser 2012-12-11 22:05:38 -0800 Created attachment 178963 Patch 789621 8 178963 darin 2012-12-12 09:18:27 -0800 Comment on attachment 178963 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178963&action=review > Source/WebCore/ChangeLog:19 > + (WebCore::clipBox): Remove blank linke. Typo "linke". 789643 9 178963 simon.fraser 2012-12-12 09:51:23 -0800 Comment on attachment 178963 Patch This broke a couple of the new background tests. 789698 10 noam 2012-12-12 10:50:40 -0800 (In reply to comment #9) > (From update of attachment 178963 [details]) > This broke a couple of the new background tests. > compositing/background-color/background-color-text-change.html failed unexpectedly (reference mismatch) At least this one seems like a legitimate failure, probably from the change to updateBackgroundColor. Let me know if you want me to take a look. 792148 11 simon.fraser 2012-12-15 11:39:14 -0800 http://trac.webkit.org/changeset/137800 178942 2012-12-11 18:29:38 -0800 2012-12-11 22:05:36 -0800 Patch, but test updates needed bug-104746-20121211182659.patch text/plain 5826 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3Mzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQ2YzA3MWIxYmE1ODkz N2U3YWZmODc4NjQ2NmEwZWQ1NmNhZDY1Yi4uZDk1NDBkNzk2ZmYzMDZiOGIyZGYyMzE3MzMwYjJh Yzk3NDZiODUxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDEyLTEyLTExICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04g KHIxMzcwMDYpOiBUaWxlQ2FjaGUgZmxhc2hlcyB0byBsaW5lbiwgcmF0aGVyIHRoYW4gdGhlIGJh Y2tncm91bmQgY29sb3IsIHdoZW4gc2Nyb2xsaW5nIGZhc3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDc0NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRh dGVCYWNrZ3JvdW5kQ29sb3IoKSByZXNwb25zaWJsZSBmb3Igc2V0dGluZyB0aGUgYmFja2dyb3Vu ZAorICAgICAgICBjb2xvciBvZiB0aGUgbWFpbiBmcmFtZSdzIHJvb3QgbGF5ZXIgdG8gdGhlIGRv Y3VtZW50IGJhY2tncm91bmQgY29sb3IgKHJhdGhlciB0aGFuIGRvaW5nCisgICAgICAgIGl0IGlu IGNvZGUgcmVsYXRlZCB0byBvdmVybGF5IHNjcm9sbGJhcnMsIHdoaWNoIHdhcyBjcmF6eSkuCisg ICAgICAgIAorICAgICAgICBBbHNvIGZpeCB1cGRhdGVCYWNrZ3JvdW5kQ29sb3IoKSB0byBub3Qg Y2FsbCBtX2dyYXBoaWNzTGF5ZXItPnNldENvbnRlbnRzVG9CYWNrZ3JvdW5kQ29sb3IoKQorICAg ICAgICBhbmQgdGhlbiBjYWxsIGNsZWFyQmFja2dyb3VuZENvbG9yKCkgcmlnaHQgYXdheSBpZiB0 aGUgY29sb3Igd2FzIHRyYW5zcGFyZW50LgorICAgICAgICAKKyAgICAgICAgKiBwYWdlL0ZyYW1l Vmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnJlY2FsY3VsYXRlU2Nyb2xs YmFyT3ZlcmxheVN0eWxlKTogUmVtb3ZlIGNvZGUgdGhhdCBjYWxscyBkb2N1bWVudEJhY2tncm91 bmRDb2xvckRpZENoYW5nZSgpLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tp bmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2xpcEJveCk6IFJlbW92ZSBibGFuayBsaW5rZS4K KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlQmFja2dyb3VuZENv bG9yKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmg6CisgICAgICAgIChSZW5k ZXJMYXllckNvbXBvc2l0b3IpOgorCisyMDEyLTEyLTExICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIEVuaGFuY2UgdGhlIFRpbGVDYWNoZSB0byBjYWNo ZSBtb3JlIHRpbGVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDQ2MTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDUzZDE0NmE4OGM3 YjBjZDlmYTUwZWY0NWIyN2FlZmM4OTBjYTQ3N2MuLjU3NWE1OGRmZGRmNDYzOWY4MTY0NzJjNjky NTA1N2U2Y2E2M2ZkZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTM4NiwxMyAr Mzg2LDYgQEAgdm9pZCBGcmFtZVZpZXc6OnJlY2FsY3VsYXRlU2Nyb2xsYmFyT3ZlcmxheVN0eWxl KCkKICAgICBTY3JvbGxiYXJPdmVybGF5U3R5bGUgb3ZlcmxheVN0eWxlID0gU2Nyb2xsYmFyT3Zl cmxheVN0eWxlRGVmYXVsdDsKIAogICAgIENvbG9yIGJhY2tncm91bmRDb2xvciA9IGRvY3VtZW50 QmFja2dyb3VuZENvbG9yKCk7Ci0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAg IGlmIChSZW5kZXJWaWV3KiByb290ID0gcm9vdFJlbmRlcmVyKHRoaXMpKSB7Ci0gICAgICAgIFJl bmRlckxheWVyQ29tcG9zaXRvciogY29tcG9zaXRvciA9IHJvb3QtPmNvbXBvc2l0b3IoKTsKLSAg ICAgICAgY29tcG9zaXRvci0+ZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3JEaWRDaGFuZ2UoKTsKLSAg ICB9Ci0jZW5kaWYKLQogICAgIGlmIChiYWNrZ3JvdW5kQ29sb3IuaXNWYWxpZCgpKSB7CiAgICAg ICAgIC8vIFJlZHVjZSB0aGUgYmFja2dyb3VuZCBjb2xvciBmcm9tIFJHQiB0byBhIGxpZ2h0bmVz cyB2YWx1ZQogICAgICAgICAvLyBhbmQgZGV0ZXJtaW5lIHdoaWNoIHNjcm9sbGJhciBzdHlsZSB0 byB1c2UgYmFzZWQgb24gYSBsaWdodG5lc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggMTRkNzE2NTI5NmUxMjRjYTg3NDQyOGQyNzc5 YmJjMTU2Yjc2MzVjYS4uNmFlMGI0NzQ0Yjc0MjkwNDY3Nzk1Mjg5YzY0Yzc5MmY5MzkxODFjYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAK QEAgLTUyMSw3ICs1MjEsNiBAQCBzdGF0aWMgSW50UmVjdCBjbGlwQm94KFJlbmRlckJveCogcmVu ZGVyZXIpCiAgICAgICAgIHJlc3VsdC5pbnRlcnNlY3QocmVuZGVyZXItPmNsaXBSZWN0KExheW91 dFBvaW50KCksIDApKTsgLy8gRklYTUU6IEluY29ycmVjdCBmb3IgQ1NTIHJlZ2lvbnMuCiAKICAg ICByZXR1cm4gcGl4ZWxTbmFwcGVkSW50UmVjdChyZXN1bHQpOwotCiB9CiAKIHZvaWQgUmVuZGVy TGF5ZXJCYWNraW5nOjp1cGRhdGVHcmFwaGljc0xheWVyR2VvbWV0cnkoKQpAQCAtMTE1MSwxMSAr MTE1MCwyNiBAQCBDb2xvciBSZW5kZXJMYXllckJhY2tpbmc6OnJlbmRlcmVyQmFja2dyb3VuZENv bG9yKCkgY29uc3QKIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVCYWNrZ3JvdW5kQ29s b3IoYm9vbCBpc1NpbXBsZUNvbnRhaW5lcikKIHsKICAgICBDb2xvciBiYWNrZ3JvdW5kQ29sb3Ig PSBDb2xvcjo6dHJhbnNwYXJlbnQ7CisgICAgCisgICAgaWYgKG1faXNNYWluRnJhbWVSZW5kZXJW aWV3TGF5ZXIpIHsKKyAgICAgICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSB0b1JlbmRlclZpZXco cmVuZGVyZXIoKSktPmZyYW1lVmlldygpOworICAgICAgICBpZiAoIWZyYW1lVmlldy0+aXNUcmFu c3BhcmVudCgpKSB7CisgICAgICAgICAgICBiYWNrZ3JvdW5kQ29sb3IgPSBmcmFtZVZpZXctPmRv Y3VtZW50QmFja2dyb3VuZENvbG9yKCk7CisgICAgICAgICAgICBpZiAoIWJhY2tncm91bmRDb2xv ci5pc1ZhbGlkKCkgfHwgYmFja2dyb3VuZENvbG9yLmhhc0FscGhhKCkpCisgICAgICAgICAgICAg ICAgYmFja2dyb3VuZENvbG9yID0gQ29sb3I6OndoaXRlOworICAgICAgICB9CisKKyAgICAgICAg bV9ncmFwaGljc0xheWVyLT5zZXRCYWNrZ3JvdW5kQ29sb3IoYmFja2dyb3VuZENvbG9yKTsKKyAg ICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGlmIChpc1NpbXBsZUNvbnRhaW5lcikKICAgICAg ICAgYmFja2dyb3VuZENvbG9yID0gcmVuZGVyZXJCYWNrZ3JvdW5kQ29sb3IoKTsKLSAgICBtX2dy YXBoaWNzTGF5ZXItPnNldENvbnRlbnRzVG9CYWNrZ3JvdW5kQ29sb3IoYmFja2dyb3VuZENvbG9y KTsKKwogICAgIGlmIChiYWNrZ3JvdW5kQ29sb3IgPT0gQ29sb3I6OnRyYW5zcGFyZW50KQogICAg ICAgICBtX2dyYXBoaWNzTGF5ZXItPmNsZWFyQmFja2dyb3VuZENvbG9yKCk7CisgICAgZWxzZQor ICAgICAgICBtX2dyYXBoaWNzTGF5ZXItPnNldENvbnRlbnRzVG9CYWNrZ3JvdW5kQ29sb3IoYmFj a2dyb3VuZENvbG9yKTsKIH0KIAogc3RhdGljIGJvb2wgc3VwcG9ydHNEaXJlY3RCb3hEZWNvcmF0 aW9uc0NvbXBvc2l0aW9uKGNvbnN0IFJlbmRlck9iamVjdCogcmVuZGVyZXIpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDM3 YmI2NTE4NjFjYjRhMTJhYjk2MzA0ZWRmZDE5OWRiNWIzOTI5YzMuLjIwOTYwYmVjZWEzNjNhNzUz MjVhZTg1YmYzMjA1ODkyZjIyMjU3ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBAIC0yMDY4LDIwICsyMDY4LDYgQEAgdm9p ZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnBhaW50Q29udGVudHMoY29uc3QgR3JhcGhpY3NMYXll ciogZ3JhcGhpY3NMYXllciwgR3IKICAgICB9CiB9CiAKLXZvaWQgUmVuZGVyTGF5ZXJDb21wb3Np dG9yOjpkb2N1bWVudEJhY2tncm91bmRDb2xvckRpZENoYW5nZSgpCi17Ci0gICAgUmVuZGVyTGF5 ZXJCYWNraW5nKiBiYWNraW5nID0gcm9vdFJlbmRlckxheWVyKCktPmJhY2tpbmcoKTsKLSAgICBp ZiAoIWJhY2tpbmcgfHwgIWJhY2tpbmctPnVzaW5nVGlsZUNhY2hlKCkpCi0gICAgICAgIHJldHVy bjsKLQotICAgIEdyYXBoaWNzTGF5ZXIqIGdyYXBoaWNzTGF5ZXIgPSBiYWNraW5nLT5ncmFwaGlj c0xheWVyKCk7Ci0gICAgQ29sb3IgYmFja2dyb3VuZENvbG9yID0gbV9yZW5kZXJWaWV3LT5mcmFt ZVZpZXcoKS0+ZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IoKTsKLSAgICBpZiAoIWJhY2tncm91bmRD b2xvci5pc1ZhbGlkKCkgfHwgYmFja2dyb3VuZENvbG9yLmhhc0FscGhhKCkpCi0gICAgICAgIGJh Y2tncm91bmRDb2xvciA9IENvbG9yOjp3aGl0ZTsKLQotICAgIGdyYXBoaWNzTGF5ZXItPnNldEJh Y2tncm91bmRDb2xvcihiYWNrZ3JvdW5kQ29sb3IpOwotfQotCiBzdGF0aWMgdm9pZCByZXNldFRy YWNrZWRSZXBhaW50UmVjdHNSZWN1cnNpdmUoR3JhcGhpY3NMYXllciogZ3JhcGhpY3NMYXllcikK IHsKICAgICBpZiAoIWdyYXBoaWNzTGF5ZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKaW5kZXggMjQ5NjlkZjg1MmM5NTI3MTRjZGU5M2Rh NmZmYWExZmRmOTQ5Zjg5My4uNDlmZWU0NzczZWVhODEzZDRjYzEyZDFiNDlkODg3NDljNzk0MDYx MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0 b3IuaApAQCAtMjE5LDggKzIxOSw2IEBAIHB1YmxpYzoKICAgICBHcmFwaGljc0xheWVyKiBsYXll ckZvck92ZXJoYW5nQXJlYXMoKSBjb25zdCB7IHJldHVybiBtX2xheWVyRm9yT3ZlcmhhbmdBcmVh cy5nZXQoKTsgfQogI2VuZGlmCiAKLSAgICB2b2lkIGRvY3VtZW50QmFja2dyb3VuZENvbG9yRGlk Q2hhbmdlKCk7Ci0KICAgICB2b2lkIHVwZGF0ZVZpZXdwb3J0Q29uc3RyYWludFN0YXR1cyhSZW5k ZXJMYXllciopOwogICAgIHZvaWQgcmVtb3ZlVmlld3BvcnRDb25zdHJhaW5lZExheWVyKFJlbmRl ckxheWVyKik7CiAK 178963 2012-12-11 22:05:38 -0800 2012-12-12 09:51:23 -0800 Patch bug-104746-20121211220300.patch text/plain 5844 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFiNjU2NjBkMzU3ZTVj YmI1ZGQwZDY5NGZhNzYwM2I1ZThkYWEyMy4uNTFjODkyYThkZDQyNjRhNzk5MTdmY2VhYmU3Yzc1 YTRiZWNhMzY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTEyLTExICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIxMzcwMDYpOiBUaWxlQ2FjaGUgZmxhc2hlcyB0byBsaW5lbiwgcmF0aGVyIHRoYW4gdGhlIGJh Y2tncm91bmQgY29sb3IsIHdoZW4gc2Nyb2xsaW5nIGZhc3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDc0NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRh dGVCYWNrZ3JvdW5kQ29sb3IoKSByZXNwb25zaWJsZSBmb3Igc2V0dGluZyB0aGUgYmFja2dyb3Vu ZAorICAgICAgICBjb2xvciBvZiB0aGUgbWFpbiBmcmFtZSdzIHJvb3QgbGF5ZXIgdG8gdGhlIGRv Y3VtZW50IGJhY2tncm91bmQgY29sb3IgKHJhdGhlciB0aGFuIGRvaW5nCisgICAgICAgIGl0IGlu IGNvZGUgcmVsYXRlZCB0byBvdmVybGF5IHNjcm9sbGJhcnMsIHdoaWNoIHdhcyBjcmF6eSkuIFRo aXMgaXMgb25seSBkb25lIGZvciBwbGF0Zm9ybXMKKyAgICAgICAgdGhhdCB1c2UgYSBUaWxlZEJh Y2tpbmcgKGN1cnJlbnRseSwganVzdCBNYWMpLgorICAgICAgICAKKyAgICAgICAgQWxzbyBmaXgg dXBkYXRlQmFja2dyb3VuZENvbG9yKCkgdG8gbm90IGNhbGwgbV9ncmFwaGljc0xheWVyLT5zZXRD b250ZW50c1RvQmFja2dyb3VuZENvbG9yKCkKKyAgICAgICAgYW5kIHRoZW4gY2FsbCBjbGVhckJh Y2tncm91bmRDb2xvcigpIHJpZ2h0IGF3YXkgaWYgdGhlIGNvbG9yIHdhcyB0cmFuc3BhcmVudC4K KyAgICAgICAgCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RnJhbWVWaWV3OjpyZWNhbGN1bGF0ZVNjcm9sbGJhck92ZXJsYXlTdHlsZSk6IFJlbW92ZSBj b2RlIHRoYXQgY2FsbHMgZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3JEaWRDaGFuZ2UoKS4KKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmNsaXBCb3gpOiBSZW1vdmUgYmxhbmsgbGlua2UuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM YXllckJhY2tpbmc6OnVwZGF0ZUJhY2tncm91bmRDb2xvcik6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxh eWVyQ29tcG9zaXRvci5oOgorICAgICAgICAoUmVuZGVyTGF5ZXJDb21wb3NpdG9yKToKKwogMjAx Mi0xMi0xMSAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1No YWRvdyBET01dIEtpbGwgU2hhZG93Um9vdCBjb25zdHJ1Y3RvcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuY3BwCmluZGV4IDUzZDE0NmE4OGM3YjBjZDlmYTUwZWY0NWIyN2FlZmM4OTBjYTQ3N2MuLjU3 NWE1OGRmZGRmNDYzOWY4MTY0NzJjNjkyNTA1N2U2Y2E2M2ZkZTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKQEAgLTM4NiwxMyArMzg2LDYgQEAgdm9pZCBGcmFtZVZpZXc6OnJlY2FsY3Vs YXRlU2Nyb2xsYmFyT3ZlcmxheVN0eWxlKCkKICAgICBTY3JvbGxiYXJPdmVybGF5U3R5bGUgb3Zl cmxheVN0eWxlID0gU2Nyb2xsYmFyT3ZlcmxheVN0eWxlRGVmYXVsdDsKIAogICAgIENvbG9yIGJh Y2tncm91bmRDb2xvciA9IGRvY3VtZW50QmFja2dyb3VuZENvbG9yKCk7Ci0jaWYgVVNFKEFDQ0VM RVJBVEVEX0NPTVBPU0lUSU5HKQotICAgIGlmIChSZW5kZXJWaWV3KiByb290ID0gcm9vdFJlbmRl cmVyKHRoaXMpKSB7Ci0gICAgICAgIFJlbmRlckxheWVyQ29tcG9zaXRvciogY29tcG9zaXRvciA9 IHJvb3QtPmNvbXBvc2l0b3IoKTsKLSAgICAgICAgY29tcG9zaXRvci0+ZG9jdW1lbnRCYWNrZ3Jv dW5kQ29sb3JEaWRDaGFuZ2UoKTsKLSAgICB9Ci0jZW5kaWYKLQogICAgIGlmIChiYWNrZ3JvdW5k Q29sb3IuaXNWYWxpZCgpKSB7CiAgICAgICAgIC8vIFJlZHVjZSB0aGUgYmFja2dyb3VuZCBjb2xv ciBmcm9tIFJHQiB0byBhIGxpZ2h0bmVzcyB2YWx1ZQogICAgICAgICAvLyBhbmQgZGV0ZXJtaW5l IHdoaWNoIHNjcm9sbGJhciBzdHlsZSB0byB1c2UgYmFzZWQgb24gYSBsaWdodG5lc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggMTRk NzE2NTI5NmUxMjRjYTg3NDQyOGQyNzc5YmJjMTU2Yjc2MzVjYS4uNGFkNmRlNGU5YWI2NjU2Y2M2 MmYzMWZkZGFiZjUwZDE4MTk0Zjg1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTUyMSw3ICs1MjEsNiBAQCBzdGF0aWMgSW50UmVj dCBjbGlwQm94KFJlbmRlckJveCogcmVuZGVyZXIpCiAgICAgICAgIHJlc3VsdC5pbnRlcnNlY3Qo cmVuZGVyZXItPmNsaXBSZWN0KExheW91dFBvaW50KCksIDApKTsgLy8gRklYTUU6IEluY29ycmVj dCBmb3IgQ1NTIHJlZ2lvbnMuCiAKICAgICByZXR1cm4gcGl4ZWxTbmFwcGVkSW50UmVjdChyZXN1 bHQpOwotCiB9CiAKIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVHcmFwaGljc0xheWVy R2VvbWV0cnkoKQpAQCAtMTE1MSwxMSArMTE1MCwyNiBAQCBDb2xvciBSZW5kZXJMYXllckJhY2tp bmc6OnJlbmRlcmVyQmFja2dyb3VuZENvbG9yKCkgY29uc3QKIHZvaWQgUmVuZGVyTGF5ZXJCYWNr aW5nOjp1cGRhdGVCYWNrZ3JvdW5kQ29sb3IoYm9vbCBpc1NpbXBsZUNvbnRhaW5lcikKIHsKICAg ICBDb2xvciBiYWNrZ3JvdW5kQ29sb3IgPSBDb2xvcjo6dHJhbnNwYXJlbnQ7CisgICAgCisgICAg aWYgKG1fdXNpbmdUaWxlZENhY2hlTGF5ZXIpIHsKKyAgICAgICAgRnJhbWVWaWV3KiBmcmFtZVZp ZXcgPSB0b1JlbmRlclZpZXcocmVuZGVyZXIoKSktPmZyYW1lVmlldygpOworICAgICAgICBpZiAo IWZyYW1lVmlldy0+aXNUcmFuc3BhcmVudCgpKSB7CisgICAgICAgICAgICBiYWNrZ3JvdW5kQ29s b3IgPSBmcmFtZVZpZXctPmRvY3VtZW50QmFja2dyb3VuZENvbG9yKCk7CisgICAgICAgICAgICBp ZiAoIWJhY2tncm91bmRDb2xvci5pc1ZhbGlkKCkgfHwgYmFja2dyb3VuZENvbG9yLmhhc0FscGhh KCkpCisgICAgICAgICAgICAgICAgYmFja2dyb3VuZENvbG9yID0gQ29sb3I6OndoaXRlOworICAg ICAgICB9CisKKyAgICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRCYWNrZ3JvdW5kQ29sb3IoYmFj a2dyb3VuZENvbG9yKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGlmIChpc1NpbXBs ZUNvbnRhaW5lcikKICAgICAgICAgYmFja2dyb3VuZENvbG9yID0gcmVuZGVyZXJCYWNrZ3JvdW5k Q29sb3IoKTsKLSAgICBtX2dyYXBoaWNzTGF5ZXItPnNldENvbnRlbnRzVG9CYWNrZ3JvdW5kQ29s b3IoYmFja2dyb3VuZENvbG9yKTsKKwogICAgIGlmIChiYWNrZ3JvdW5kQ29sb3IgPT0gQ29sb3I6 OnRyYW5zcGFyZW50KQogICAgICAgICBtX2dyYXBoaWNzTGF5ZXItPmNsZWFyQmFja2dyb3VuZENv bG9yKCk7CisgICAgZWxzZQorICAgICAgICBtX2dyYXBoaWNzTGF5ZXItPnNldENvbnRlbnRzVG9C YWNrZ3JvdW5kQ29sb3IoYmFja2dyb3VuZENvbG9yKTsKIH0KIAogc3RhdGljIGJvb2wgc3VwcG9y dHNEaXJlY3RCb3hEZWNvcmF0aW9uc0NvbXBvc2l0aW9uKGNvbnN0IFJlbmRlck9iamVjdCogcmVu ZGVyZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJD b21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBv c2l0b3IuY3BwCmluZGV4IDZlZmQ1ZDUxZTNkZWQ3MjBjYTkyMzg1OGUxYWEwZDRkYTMxNjg2YjIu LjAxYmIxNWRlNzhjNDg1NmY2N2RhOTViODgxNDMxNTA2ODJiZDlhOTcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBAIC0yMDY5 LDIwICsyMDY5LDYgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnBhaW50Q29udGVudHMo Y29uc3QgR3JhcGhpY3NMYXllciogZ3JhcGhpY3NMYXllciwgR3IKICAgICB9CiB9CiAKLXZvaWQg UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpkb2N1bWVudEJhY2tncm91bmRDb2xvckRpZENoYW5nZSgp Ci17Ci0gICAgUmVuZGVyTGF5ZXJCYWNraW5nKiBiYWNraW5nID0gcm9vdFJlbmRlckxheWVyKCkt PmJhY2tpbmcoKTsKLSAgICBpZiAoIWJhY2tpbmcgfHwgIWJhY2tpbmctPnVzaW5nVGlsZUNhY2hl KCkpCi0gICAgICAgIHJldHVybjsKLQotICAgIEdyYXBoaWNzTGF5ZXIqIGdyYXBoaWNzTGF5ZXIg PSBiYWNraW5nLT5ncmFwaGljc0xheWVyKCk7Ci0gICAgQ29sb3IgYmFja2dyb3VuZENvbG9yID0g bV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+ZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IoKTsKLSAg ICBpZiAoIWJhY2tncm91bmRDb2xvci5pc1ZhbGlkKCkgfHwgYmFja2dyb3VuZENvbG9yLmhhc0Fs cGhhKCkpCi0gICAgICAgIGJhY2tncm91bmRDb2xvciA9IENvbG9yOjp3aGl0ZTsKLQotICAgIGdy YXBoaWNzTGF5ZXItPnNldEJhY2tncm91bmRDb2xvcihiYWNrZ3JvdW5kQ29sb3IpOwotfQotCiBz dGF0aWMgdm9pZCByZXNldFRyYWNrZWRSZXBhaW50UmVjdHNSZWN1cnNpdmUoR3JhcGhpY3NMYXll ciogZ3JhcGhpY3NMYXllcikKIHsKICAgICBpZiAoIWdyYXBoaWNzTGF5ZXIpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmggYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKaW5kZXggMjQ5Njlk Zjg1MmM5NTI3MTRjZGU5M2RhNmZmYWExZmRmOTQ5Zjg5My4uNDlmZWU0NzczZWVhODEzZDRjYzEy ZDFiNDlkODg3NDljNzk0MDYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtMjE5LDggKzIxOSw2IEBAIHB1YmxpYzoKICAgICBH cmFwaGljc0xheWVyKiBsYXllckZvck92ZXJoYW5nQXJlYXMoKSBjb25zdCB7IHJldHVybiBtX2xh eWVyRm9yT3ZlcmhhbmdBcmVhcy5nZXQoKTsgfQogI2VuZGlmCiAKLSAgICB2b2lkIGRvY3VtZW50 QmFja2dyb3VuZENvbG9yRGlkQ2hhbmdlKCk7Ci0KICAgICB2b2lkIHVwZGF0ZVZpZXdwb3J0Q29u c3RyYWludFN0YXR1cyhSZW5kZXJMYXllciopOwogICAgIHZvaWQgcmVtb3ZlVmlld3BvcnRDb25z dHJhaW5lZExheWVyKFJlbmRlckxheWVyKik7CiAK