104728 2012-12-11 15:16:19 -0800 [soup] Unused parameter in ResourceHandleSoup.cpp 2012-12-11 18:06:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim haraken mrobinson webkit.review.bot oldest_to_newest 788847 0 ktf.kim 2012-12-11 15:16:19 -0800 The soupLogPrinter has unused parameter 'logger', comment out it to fix 'unused parameter' build warning. Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:82:20: warning: unused parameter ‘logger’ [-Wunused-parameter] 788850 1 178890 ktf.kim 2012-12-11 15:19:01 -0800 Created attachment 178890 Patch 788864 2 178890 mrobinson 2012-12-11 15:30:46 -0800 Comment on attachment 178890 Patch It's a bit odd that some of the arguments are removed entirely and one is commented out. Why the inconsistency? 788875 3 178897 ktf.kim 2012-12-11 15:42:29 -0800 Created attachment 178897 Patch 788876 4 178897 haraken 2012-12-11 15:42:55 -0800 Comment on attachment 178897 Patch ok 788931 5 178911 ktf.kim 2012-12-11 16:17:34 -0800 Created attachment 178911 Patch 789071 6 178911 webkit.review.bot 2012-12-11 18:06:29 -0800 Comment on attachment 178911 Patch Clearing flags on attachment: 178911 Committed r137400: <http://trac.webkit.org/changeset/137400> 789072 7 webkit.review.bot 2012-12-11 18:06:33 -0800 All reviewed patches have been landed. Closing bug. 178890 2012-12-11 15:19:01 -0800 2012-12-11 15:42:23 -0800 Patch bug-104728-20121212081621.patch text/plain 1518 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFiODJkMjg0N2MyZTlk M2RiZTA0OWQwM2E3M2JjZWUzMzRjNGYwNS4uNGNhNjJiNWEzYTM0NTdmN2ZiMTJmZTYyMTJiZWZl MmQxYmEzM2U4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTExICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtzb3VwXSBVbnVzZWQg cGFyYW1ldGVyIGluIFJlc291cmNlSGFuZGxlU291cC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDcyOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBzb3VwTG9nUHJpbnRlciBoYXMgdW51c2Vk IHBhcmFtZXRlciAnbG9nZ2VyJywgCisgICAgICAgIGNvbW1lbnQgb3V0IGl0IHRvIGZpeCAndW51 c2VkIHBhcmFtZXRlcicgYnVpbGQgd2FybmluZy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c291cExv Z1ByaW50ZXIpOgorCiAyMDEyLTEyLTExICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBDbGFtcCBvdXQtb2YtcmFuZ2UgbnVtYmVycyBpbiBDU1MKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu ZGxlU291cC5jcHAKaW5kZXggNDc3NjY3OGFkMDRhZTQzNmM1ZjRhNjUyMDhhNWQxMjAwOWFmMzIz Mi4uZTI2NTEzNjYxOWI4ZmJhY2Y1YWIzOTZjM2Q0N2FiMWUyMjZhMjM0NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu ZGxlU291cC5jcHAKQEAgLTc5LDcgKzc5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAjZGVm aW5lIFJFQURfQlVGRkVSX1NJWkUgODE5MgogCi1pbmxpbmUgc3RhdGljIHZvaWQgc291cExvZ1By aW50ZXIoU291cExvZ2dlciogbG9nZ2VyLCBTb3VwTG9nZ2VyTG9nTGV2ZWwsIGNoYXIgZGlyZWN0 aW9uLCBjb25zdCBjaGFyKiBkYXRhLCBncG9pbnRlcikKK2lubGluZSBzdGF0aWMgdm9pZCBzb3Vw TG9nUHJpbnRlcihTb3VwTG9nZ2VyKiAvKmxvZ2dlciovLCBTb3VwTG9nZ2VyTG9nTGV2ZWwsIGNo YXIgZGlyZWN0aW9uLCBjb25zdCBjaGFyKiBkYXRhLCBncG9pbnRlcikKIHsKICAgICBMT0coTmV0 d29yaywgIiVjICVzIiwgZGlyZWN0aW9uLCBkYXRhKTsKIH0K 178897 2012-12-11 15:42:29 -0800 2012-12-11 16:17:21 -0800 Patch bug-104728-20121212083949.patch text/plain 1518 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFiODJkMjg0N2MyZTlk M2RiZTA0OWQwM2E3M2JjZWUzMzRjNGYwNS4uMzE1NDFiODc2YmQ3ZWQyM2E2OWYyNTQ5YzgyMjky NzA3MjNkM2RjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTExICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtzb3VwXSBVbnVzZWQg cGFyYW1ldGVyIGluIFJlc291cmNlSGFuZGxlU291cC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDcyOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBzb3VwTG9nUHJpbnRlciBoYXMgdW51c2Vk IHBhcmFtZXRlciAnbG9nZ2VyJywgCisgICAgICAgIHJlbW92ZSB0aGUgcGFyYW1ldGVyIG5hbWUg dG8gZml4ICd1bnVzZWQgcGFyYW1ldGVyJyBidWlsZCB3YXJuaW5nLgorCisgICAgICAgICogcGxh dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpzb3VwTG9nUHJpbnRlcik6CisKIDIwMTItMTItMTEgIEVtaWwgQSBFa2x1bmQgIDxlYWVA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIENsYW1wIG91dC1vZi1yYW5nZSBudW1iZXJzIGluIENT UwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291 cmNlSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCA0Nzc2Njc4YWQwNGFlNDM2YzVmNGE2NTIwOGE1 ZDEyMDA5YWYzMjMyLi5hYzQzOGZjN2RjN2RkMzY4ZmQ0ZmE2YzUyMTA0ZTc0NWQ4ZmIyMmYzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VI YW5kbGVTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNzksNyArNzksNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKICNkZWZpbmUgUkVBRF9CVUZGRVJfU0laRSA4MTkyCiAKLWlubGluZSBzdGF0aWMgdm9p ZCBzb3VwTG9nUHJpbnRlcihTb3VwTG9nZ2VyKiBsb2dnZXIsIFNvdXBMb2dnZXJMb2dMZXZlbCwg Y2hhciBkaXJlY3Rpb24sIGNvbnN0IGNoYXIqIGRhdGEsIGdwb2ludGVyKQoraW5saW5lIHN0YXRp YyB2b2lkIHNvdXBMb2dQcmludGVyKFNvdXBMb2dnZXIqLCBTb3VwTG9nZ2VyTG9nTGV2ZWwsIGNo YXIgZGlyZWN0aW9uLCBjb25zdCBjaGFyKiBkYXRhLCBncG9pbnRlcikKIHsKICAgICBMT0coTmV0 d29yaywgIiVjICVzIiwgZGlyZWN0aW9uLCBkYXRhKTsKIH0K 178911 2012-12-11 16:17:34 -0800 2012-12-11 18:06:29 -0800 Patch bug-104728-20121212091454.patch text/plain 1624 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzlkYzM0YWI1MmEzOTY5 NjVmYzhjYjI3MWY4ZGE5OTYwMjk1NDViZC4uNjFiNjdjZDAxZWI0NTY5MzM2OTAwZWE3ZGFkNjc0 MGI3ODE1MmExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTExICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtzb3VwXSBVbnVzZWQg cGFyYW1ldGVyIGluIFJlc291cmNlSGFuZGxlU291cC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDcyOAorCisgICAgICAgIFJldmlld2VkIGJ5 IEtlbnRhcm8gSGFyYS4KKworICAgICAgICBUaGUgc291cExvZ1ByaW50ZXIgaGFzIHVudXNlZCBw YXJhbWV0ZXIgJ2xvZ2dlcicsIAorICAgICAgICByZW1vdmUgdGhlIHBhcmFtZXRlciBuYW1lIHRv IGZpeCAndW51c2VkIHBhcmFtZXRlcicgYnVpbGQgd2FybmluZy4KKworICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6c291cExvZ1ByaW50ZXIpOgorCiAyMDEyLTEyLTExICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIE1haWwgaGFuZ3Mgd2hlbiByZXNpemluZyB0aGUgZm9udCBz aXplIG9mIGEgbGFyZ2UgUlRMIHRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggNDc3NjY3 OGFkMDRhZTQzNmM1ZjRhNjUyMDhhNWQxMjAwOWFmMzIzMi4uOWY2MDdhNzg1NDM4ZWNiMTA0MTBj ZGRkMzBkYzBhMTg1ZDg5OWIwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKQEAgLTc5LDggKzc5 LDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogI2RlZmluZSBSRUFEX0JVRkZFUl9TSVpFIDgx OTIKIAotaW5saW5lIHN0YXRpYyB2b2lkIHNvdXBMb2dQcmludGVyKFNvdXBMb2dnZXIqIGxvZ2dl ciwgU291cExvZ2dlckxvZ0xldmVsLCBjaGFyIGRpcmVjdGlvbiwgY29uc3QgY2hhciogZGF0YSwg Z3BvaW50ZXIpCitpbmxpbmUgc3RhdGljIHZvaWQgc291cExvZ1ByaW50ZXIoU291cExvZ2dlcios IFNvdXBMb2dnZXJMb2dMZXZlbCwgY2hhciBkaXJlY3Rpb24sIGNvbnN0IGNoYXIqIGRhdGEsIGdw b2ludGVyKQogeworI2lmIExPR19ESVNBQkxFRAorICAgIFVOVVNFRF9QQVJBTShkaXJlY3Rpb24p OworICAgIFVOVVNFRF9QQVJBTShkYXRhKTsKKyNlbmRpZgogICAgIExPRyhOZXR3b3JrLCAiJWMg JXMiLCBkaXJlY3Rpb24sIGRhdGEpOwogfQogCg==