104725 2012-12-11 15:00:29 -0800 Crash in EventHandler::selectCursor() on Mac bots running fast/events/mouse-cursor-image-set.html 2012-12-12 15:00:07 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin bdakin cmarcelo macpherson menard ojan.autocc rbyers webkit.review.bot oldest_to_newest 788831 0 bdakin 2012-12-11 15:00:29 -0800 https://bugs.webkit.org/show_bug.cgi?id=99493 enabled image-set for the CSS cursor property. Most of the change is guarded behind #if ENABLE(MOUSE_CURSOR_SCALE). On the Mac port, we have image-set enabled, so we still parse the image-set in the CSSParser for cursors. But MOUSE_CURSOR_SCALE is not yet enabled, see https://bugs.webkit.org/show_bug.cgi?id=102579 Because we parse the image-set anyway, we see this crash: ASSERT(scale == 1); Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x000000010faa8eb6 WebCore::EventHandler::selectCursor(WebCore::MouseEventWithHitTestResults const&, WebCore::Scrollbar*) + 1526 (EventHandler.cpp:1481) 1 com.apple.WebCore 0x000000010faab46c WebCore::EventHandler::handleMouseMoveEvent(WebCore::PlatformMouseEvent const&, WebCore::HitTestResult*, bool) + 1772 (EventHandler.cpp:1912) 2 com.apple.WebCore 0x000000010faaabd6 WebCore::EventHandler::mouseMoved(WebCore::PlatformMouseEvent const&) + 134 (EventHandler.cpp:1795) 3 com.apple.WebKit2 0x000000010d37e44c WebKit::handleMouseEvent(WebKit::WebMouseEvent const&, WebKit::WebPage*, bool) + 396 (WebPage.cpp:1526) 4 com.apple.WebKit2 0x000000010d37e5aa WebKit::WebPage::mouseEventSyncForTesting(WebKit::WebMouseEvent const&, bool&) + 234 (WebPage.cpp:1576) etc. I think that the right way to fix this is to avoid parsing the image-set for cursors until it's fully supported on Mac. 788844 1 178889 bdakin 2012-12-11 15:11:26 -0800 Created attachment 178889 Patch 788849 2 bdakin 2012-12-11 15:17:45 -0800 Thanks, Tim! http://trac.webkit.org/changeset/137367 789917 3 rbyers 2012-12-12 14:25:24 -0800 Shoot, sorry about that! Doing exactly what you've done was always my intention (and how I was thinking I had written it) - sorry I missed that. 789952 4 bdakin 2012-12-12 15:00:07 -0800 (In reply to comment #3) > Shoot, sorry about that! Doing exactly what you've done was always my intention (and how I was thinking I had written it) - sorry I missed that. No worries! It happens. 178889 2012-12-11 15:11:26 -0800 2012-12-11 15:13:35 -0800 Patch for-review.txt text/plain 1996 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzM2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEyLTExICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NzI1CisgICAgICAgIENyYXNoIGluIEV2ZW50SGFuZGxlcjo6 c2VsZWN0Q3Vyc29yKCkgb24gTWFjIGJvdHMgcnVubmluZyAKKyAgICAgICAgZmFzdC9ldmVudHMv bW91c2UtY3Vyc29yLWltYWdlLXNldC5odG1sCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk5NDkzIGVuYWJsZWQgaW1hZ2Utc2V0IGZvciAKKyAgICAgICAgdGhlIENTUyBjdXJzb3Ig cHJvcGVydHkuIE1vc3Qgb2YgdGhlIGNoYW5nZSBpcyBndWFyZGVkIGJlaGluZCAjaWYgCisgICAg ICAgIEVOQUJMRShNT1VTRV9DVVJTT1JfU0NBTEUpLiBIb3dldmVyLCBpbWFnZS1zZXQgd2FzIHN0 aWxsIGFsbG93ZWQgdG8gCisgICAgICAgIHBhcnNlIGZvciB0aGUgY3Vyc29yIHByb3BlcnR5IGFz IGxvbmcgYXMgaW1hZ2Utc2V0IGlzIGVuYWJsZWQgCisgICAgICAgICh3aGljaCBpcyB0aGUgY3Vy cmVudCBzdGF0ZSBvbiB0aGUgTWFjKS4gVGhpcyB3b3VsZCBsZWFkIHRvIGFuIAorICAgICAgICBp bmNvbnNpc3RlbnQgc3RhdGUgd2hlcmUgc3R5bGUgaW5mb3JtYXRpb24gd291bGQgcmVmbGVjdCBh IHdvcmxkIAorICAgICAgICB3aGVyZSBtb3VzZSBjdXJzb3Igc2NhbGluZyBpcyBlbmFibGVkIGV2 ZW4gdGhvdWdoIG5vdGhpbmcgZWxzZSBvbiAKKyAgICAgICAgdGhlIE1hYyB3b3VsZC4gCisKKyAg ICAgICAgVGhlIHBhcnNpbmcgc2hvdWxkIGFsc28gYmUgZ3VhcmRlZCBieSB0aGUgY3Vyc29yIHNj YWxpbmcgZmxhZy4KKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1BhcnNlcjo6cGFyc2VWYWx1ZSk6CisKIDIwMTItMTItMTEgIEVtaWwgQSBFa2x1bmQg IDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENsYW1wIG91dC1vZi1yYW5nZSBudW1iZXJz IGluIENTUwpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAJKHJldmlzaW9uIDEzNzM1MCkK KysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x OTE4LDcgKzE5MTgsNyBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VWYWx1ZShDU1NQcm9wZXJ0eUlE CiAgICAgICAgICAgICAgICAgU3RyaW5nIHVyaSA9IHZhbHVlLT5zdHJpbmc7CiAgICAgICAgICAg ICAgICAgaWYgKCF1cmkuaXNOdWxsKCkpCiAgICAgICAgICAgICAgICAgICAgIGltYWdlID0gQ1NT SW1hZ2VWYWx1ZTo6Y3JlYXRlKGNvbXBsZXRlVVJMKHVyaSkpOwotI2lmIEVOQUJMRShDU1NfSU1B R0VfU0VUKQorI2lmIEVOQUJMRShDU1NfSU1BR0VfU0VUKSAmJiBFTkFCTEUoTU9VU0VfQ1VSU09S X1NDQUxFKQogICAgICAgICAgICAgfSBlbHNlIGlmICh2YWx1ZS0+dW5pdCA9PSBDU1NQYXJzZXJW YWx1ZTo6RnVuY3Rpb24gJiYgZXF1YWxJZ25vcmluZ0Nhc2UodmFsdWUtPmZ1bmN0aW9uLT5uYW1l LCAiLXdlYmtpdC1pbWFnZS1zZXQoIikpIHsKICAgICAgICAgICAgICAgICBpbWFnZSA9IHBhcnNl SW1hZ2VTZXQobV92YWx1ZUxpc3QuZ2V0KCkpOwogICAgICAgICAgICAgICAgIGlmICghaW1hZ2Up Cg==