104704 2012-12-11 12:53:50 -0800 [Chromium] Remove all references to sharedWorkerRepository() 2013-01-03 14:27:24 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104838 105505 82948 1 pilgrim pilgrim abarth dglazkov fishd haraken jamesr tkent+wkapi webkit.review.bot yurys oldest_to_newest 788693 0 pilgrim 2012-12-11 12:53:50 -0800 [Chromium] Remove all references to sharedWorkerRepository() 788694 1 178855 pilgrim 2012-12-11 12:54:29 -0800 Created attachment 178855 Patch 788696 2 pilgrim 2012-12-11 12:54:47 -0800 *** Bug 85768 has been marked as a duplicate of this bug. *** 788704 3 webkit.review.bot 2012-12-11 12:57:44 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 789744 4 178855 webkit.review.bot 2012-12-12 11:33:13 -0800 Comment on attachment 178855 Patch Clearing flags on attachment: 178855 Committed r137490: <http://trac.webkit.org/changeset/137490> 789745 5 webkit.review.bot 2012-12-12 11:33:16 -0800 All reviewed patches have been landed. Closing bug. 789854 6 webkit.review.bot 2012-12-12 13:31:18 -0800 Re-opened since this is blocked by bug 104838 794663 7 180163 pilgrim 2012-12-19 07:45:27 -0800 Created attachment 180163 Patch 794666 8 180163 pilgrim 2012-12-19 07:46:19 -0800 Comment on attachment 180163 Patch No longer breaks downstream build because https://codereview.chromium.org/11576028/ has landed. 795146 9 180163 webkit.review.bot 2012-12-19 21:24:14 -0800 Comment on attachment 180163 Patch Clearing flags on attachment: 180163 Committed r138215: <http://trac.webkit.org/changeset/138215> 795147 10 webkit.review.bot 2012-12-19 21:24:18 -0800 All reviewed patches have been landed. Closing bug. 795250 11 webkit.review.bot 2012-12-20 01:04:58 -0800 Re-opened since this is blocked by bug 105505 795252 12 yurys 2012-12-20 01:06:25 -0800 (In reply to comment #9) > (From update of attachment 180163 [details]) > Clearing flags on attachment: 180163 > > Committed r138215: <http://trac.webkit.org/changeset/138215> The change breaks Chromium compilation: ../../content/renderer/renderer_webkitplatformsupport_impl.h:71:46: error: 'sharedWorkerRepository' marked 'override' but does not override any member functions virtual WebKit::WebSharedWorkerRepository* sharedWorkerRepository() OVERRIDE; ^ 1 error generated. You should have removed Chromium override before landing this patch. 799645 13 180163 pilgrim 2013-01-03 13:52:59 -0800 Comment on attachment 180163 Patch Should no longer break Chromium compilation now that https://codereview.chromium.org/11744005/ has landed downstream. Patch still applies cleanly to ToT. 799685 14 180163 webkit.review.bot 2013-01-03 14:27:20 -0800 Comment on attachment 180163 Patch Clearing flags on attachment: 180163 Committed r138742: <http://trac.webkit.org/changeset/138742> 799686 15 webkit.review.bot 2013-01-03 14:27:24 -0800 All reviewed patches have been landed. Closing bug. 178855 2012-12-11 12:54:29 -0800 2012-12-19 07:45:23 -0800 Patch bug-104704-20121211155109.patch text/plain 3182 pilgrim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzczNDIpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIz IEBACisyMDEyLTEyLTExICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSBhbGwgcmVmZXJlbmNlcyB0byBzaGFyZWRXb3JrZXJS ZXBvc2l0b3J5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNDcwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vdyB0aGF0IENocm9taXVtIGNhbGxzIHNldFNoYXJlZFdvcmtlclJlcG9zaXRvcnkgdXBv bgorICAgICAgICBpbml0aWFsaXppbmcgV2ViS2l0ICgKKyAgICAgICAgaHR0cHM6Ly9jaHJvbWl1 bWNvZGVyZXZpZXcuYXBwc3BvdC5jb20vMTA5OTAxMjEvICkgYW5kIG5vIGxvbmdlcgorICAgICAg ICB0cmllcyB0byBvdmVycmlkZSBzaGFyZWRXb3JrZXJSZXBvc2l0b3J5LCBpdCBpcyBzYWZlIHRv IHJlbW92ZQorICAgICAgICBhbGwgcmVmZXJlbmNlcyB0byB0aGlzIGZ1bmN0aW9uLgorCisgICAg ICAgICogcHVibGljL3BsYXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAo V2ViS2l0KToKKyAgICAgICAgKFdlYktpdDo6V2ViS2l0UGxhdGZvcm1TdXBwb3J0OjppZGJGYWN0 b3J5KToKKyAgICAgICAgKiBzcmMvU2hhcmVkV29ya2VyUmVwb3NpdG9yeS5jcHA6CisgICAgICAg IChXZWJLaXQ6OnNoYXJlZFdvcmtlclJlcG9zaXRvcnkpOgorICAgICAgICAoV2ViQ29yZTo6U2hh cmVkV29ya2VyUmVwb3NpdG9yeTo6aXNBdmFpbGFibGUpOgorCiAyMDEyLTEyLTExICBKb3NodWEg QmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBJbmRleGVk REI6IE1lbW9yeSBsZWFrIGluIElEQkNhbGxiYWNrc1Byb3h5OjpvblN1Y2Nlc3MoUGFzc1JlZlB0 cjxJREJEYXRhYmFzZUJhY2tlbmRJbnRlcmZhY2U+KQpJbmRleDogU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViS2l0UGxhdGZvcm1T dXBwb3J0LmgJKHJldmlzaW9uIDEzNzMzOSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL3BsYXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCSh3b3JraW5nIGNvcHkpCkBAIC0z Niw3ICszNiw2IEBACiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogY2xhc3MgV2ViSURCRmFjdG9yeTsg Ly8gRklYTUU6IERvZXMgdGhpcyBiZWxvbmcgaW4gcGxhdGZvcm0/Ci1jbGFzcyBXZWJTaGFyZWRX b3JrZXJSZXBvc2l0b3J5OyAvLyBGSVhNRTogRG9lcyB0aGlzIGJlbG9uZyBpbiBwbGF0Zm9ybT8K IAogLy8gRklYTUU6IEV2ZW50dWFsbHkgYWxsIHRoZXNlIEFQSSB3aWxsIG5lZWQgdG8gbW92ZSB0 byBXZWJLaXQ6OlBsYXRmb3JtLgogY2xhc3MgV2ViS2l0UGxhdGZvcm1TdXBwb3J0IDogcHVibGlj IFBsYXRmb3JtIHsKQEAgLTQ1LDExICs0NCw2IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgV2Vi SURCRmFjdG9yeSogaWRiRmFjdG9yeSgpIHsgcmV0dXJuIDA7IH0KIAotCi0gICAgLy8gU2hhcmVk IFdvcmtlcnMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCi0KLSAgICB2aXJ0dWFsIFdlYlNoYXJlZFdvcmtlclJlcG9zaXRvcnkqIHNoYXJlZFdv cmtlclJlcG9zaXRvcnkoKSB7IHJldHVybiAwOyB9Ci0KIHByb3RlY3RlZDoKICAgICB+V2ViS2l0 UGxhdGZvcm1TdXBwb3J0KCkgeyB9CiB9OwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvU2hhcmVkV29ya2VyUmVwb3NpdG9yeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvU2hhcmVkV29ya2VyUmVwb3NpdG9yeS5jcHAJKHJldmlzaW9uIDEzNzMz OSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NoYXJlZFdvcmtlclJlcG9zaXRvcnku Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OSwxNSArNjksOCBAQCB2b2lkIHNldFNoYXJlZFdvcmtl clJlcG9zaXRvcnkoV2ViU2hhcmVkCiAKIHN0YXRpYyBXZWJTaGFyZWRXb3JrZXJSZXBvc2l0b3J5 KiBzaGFyZWRXb3JrZXJSZXBvc2l0b3J5KCkKIHsKLSAgICBXZWJTaGFyZWRXb3JrZXJSZXBvc2l0 b3J5KiByZXBvc2l0b3J5OwotCi0gICAgcmVwb3NpdG9yeSA9IHNfc2hhcmVkV29ya2VyUmVwb3Np dG9yeTsKLSAgICBpZiAoIXJlcG9zaXRvcnkpIHsKLSAgICAgICAgcmVwb3NpdG9yeSA9IHdlYktp dFBsYXRmb3JtU3VwcG9ydCgpLT5zaGFyZWRXb3JrZXJSZXBvc2l0b3J5KCk7Ci0gICAgICAgIHNl dFNoYXJlZFdvcmtlclJlcG9zaXRvcnkocmVwb3NpdG9yeSk7Ci0gICAgfQotCi0gICAgcmV0dXJu IHJlcG9zaXRvcnk7CisgICAgLy8gV2lsbCBvbmx5IGJlIG5vbi16ZXJvIGlmIHRoZSBlbWJlZGRl ciBoYXMgc2V0IHRoZSBzaGFyZWQgd29ya2VyIHJlcG9zaXRvcnkgdXBvbiBpbml0aWFsaXphdGlv bi4gTm90aGluZyBpbiBXZWJLaXQgc2V0cyB0aGlzLgorICAgIHJldHVybiBzX3NoYXJlZFdvcmtl clJlcG9zaXRvcnk7CiB9CiAKIH0KQEAgLTIxOCw4ICsyMTEsNiBAQCB2b2lkIFNoYXJlZFdvcmtl clNjcmlwdExvYWRlcjo6Y29ubmVjdGVkCiAKIGJvb2wgU2hhcmVkV29ya2VyUmVwb3NpdG9yeTo6 aXNBdmFpbGFibGUoKQogewotICAgIC8vIEFsbG93IHRoZSBXZWJLaXRQbGF0Zm9ybVN1cHBvcnQg dG8gZGV0ZXJtaW5lIGlmIFNoYXJlZFdvcmtlcnMKLSAgICAvLyBhcmUgYXZhaWxhYmxlLgogICAg IHJldHVybiBXZWJLaXQ6OnNoYXJlZFdvcmtlclJlcG9zaXRvcnkoKTsKIH0KIAo= 180163 2012-12-19 07:45:27 -0800 2013-01-03 14:27:20 -0800 Patch bug-104704-20121219104156.patch text/plain 3161 pilgrim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzgxNTcpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTEyLTE5ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSBhbGwgcmVmZXJlbmNlcyB0byBzaGFyZWRXb3JrZXJS ZXBvc2l0b3J5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNDcwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vdyB0aGF0IENocm9taXVtIGNhbGxzIHNldFNoYXJlZFdvcmtlclJlcG9zaXRvcnkgdXBv bgorICAgICAgICBpbml0aWFsaXppbmcgV2ViS2l0ICgKKyAgICAgICAgaHR0cHM6Ly9jb2RlcmV2 aWV3LmNocm9taXVtLm9yZy8xMDk5MDEyMS8gYW5kCisgICAgICAgIGh0dHBzOi8vY29kZXJldmll dy5jaHJvbWl1bS5vcmcvMTE1NzYwMjgvICkgYW5kIG5vIGxvbmdlcgorICAgICAgICB0cmllcyB0 byBvdmVycmlkZSBzaGFyZWRXb3JrZXJSZXBvc2l0b3J5LCBpdCBpcyBzYWZlIHRvIHJlbW92ZQor ICAgICAgICBhbGwgcmVmZXJlbmNlcyB0byB0aGlzIGZ1bmN0aW9uLgorCisgICAgICAgICogcHVi bGljL3BsYXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAoV2ViS2l0KToK KyAgICAgICAgKFdlYktpdDo6V2ViS2l0UGxhdGZvcm1TdXBwb3J0OjppZGJGYWN0b3J5KToKKyAg ICAgICAgKiBzcmMvU2hhcmVkV29ya2VyUmVwb3NpdG9yeS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OnNoYXJlZFdvcmtlclJlcG9zaXRvcnkpOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkV29ya2Vy UmVwb3NpdG9yeTo6aXNBdmFpbGFibGUpOgorCiAyMDEyLTEyLTE4ICBJbHlhIFRpa2hvbm92c2t5 ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTM4MDYxLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0v V2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgJKHJldmlzaW9uIDEz ODE1NykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3BsYXRmb3JtL1dlYktpdFBs YXRmb3JtU3VwcG9ydC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw2IEBACiBuYW1lc3Bh Y2UgV2ViS2l0IHsKIAogY2xhc3MgV2ViSURCRmFjdG9yeTsgLy8gRklYTUU6IERvZXMgdGhpcyBi ZWxvbmcgaW4gcGxhdGZvcm0/Ci1jbGFzcyBXZWJTaGFyZWRXb3JrZXJSZXBvc2l0b3J5OyAvLyBG SVhNRTogRG9lcyB0aGlzIGJlbG9uZyBpbiBwbGF0Zm9ybT8KIAogLy8gRklYTUU6IEV2ZW50dWFs bHkgYWxsIHRoZXNlIEFQSSB3aWxsIG5lZWQgdG8gbW92ZSB0byBXZWJLaXQ6OlBsYXRmb3JtLgog Y2xhc3MgV2ViS2l0UGxhdGZvcm1TdXBwb3J0IDogcHVibGljIFBsYXRmb3JtIHsKQEAgLTQ1LDEx ICs0NCw2IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgV2ViSURCRmFjdG9yeSogaWRiRmFjdG9y eSgpIHsgcmV0dXJuIDA7IH0KIAotCi0gICAgLy8gU2hhcmVkIFdvcmtlcnMgLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCi0KLSAgICB2aXJ0dWFs IFdlYlNoYXJlZFdvcmtlclJlcG9zaXRvcnkqIHNoYXJlZFdvcmtlclJlcG9zaXRvcnkoKSB7IHJl dHVybiAwOyB9Ci0KIHByb3RlY3RlZDoKICAgICB+V2ViS2l0UGxhdGZvcm1TdXBwb3J0KCkgeyB9 CiB9OwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU2hhcmVkV29ya2VyUmVwb3Np dG9yeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU2hhcmVk V29ya2VyUmVwb3NpdG9yeS5jcHAJKHJldmlzaW9uIDEzODE1NykKKysrIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1NoYXJlZFdvcmtlclJlcG9zaXRvcnkuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02OSwxNSArNjksOCBAQCB2b2lkIHNldFNoYXJlZFdvcmtlclJlcG9zaXRvcnkoV2ViU2hhcmVk CiAKIHN0YXRpYyBXZWJTaGFyZWRXb3JrZXJSZXBvc2l0b3J5KiBzaGFyZWRXb3JrZXJSZXBvc2l0 b3J5KCkKIHsKLSAgICBXZWJTaGFyZWRXb3JrZXJSZXBvc2l0b3J5KiByZXBvc2l0b3J5OwotCi0g ICAgcmVwb3NpdG9yeSA9IHNfc2hhcmVkV29ya2VyUmVwb3NpdG9yeTsKLSAgICBpZiAoIXJlcG9z aXRvcnkpIHsKLSAgICAgICAgcmVwb3NpdG9yeSA9IHdlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5z aGFyZWRXb3JrZXJSZXBvc2l0b3J5KCk7Ci0gICAgICAgIHNldFNoYXJlZFdvcmtlclJlcG9zaXRv cnkocmVwb3NpdG9yeSk7Ci0gICAgfQotCi0gICAgcmV0dXJuIHJlcG9zaXRvcnk7CisgICAgLy8g V2lsbCBvbmx5IGJlIG5vbi16ZXJvIGlmIHRoZSBlbWJlZGRlciBoYXMgc2V0IHRoZSBzaGFyZWQg d29ya2VyIHJlcG9zaXRvcnkgdXBvbiBpbml0aWFsaXphdGlvbi4gTm90aGluZyBpbiBXZWJLaXQg c2V0cyB0aGlzLgorICAgIHJldHVybiBzX3NoYXJlZFdvcmtlclJlcG9zaXRvcnk7CiB9CiAKIH0K QEAgLTIxOCw4ICsyMTEsNiBAQCB2b2lkIFNoYXJlZFdvcmtlclNjcmlwdExvYWRlcjo6Y29ubmVj dGVkCiAKIGJvb2wgU2hhcmVkV29ya2VyUmVwb3NpdG9yeTo6aXNBdmFpbGFibGUoKQogewotICAg IC8vIEFsbG93IHRoZSBXZWJLaXRQbGF0Zm9ybVN1cHBvcnQgdG8gZGV0ZXJtaW5lIGlmIFNoYXJl ZFdvcmtlcnMKLSAgICAvLyBhcmUgYXZhaWxhYmxlLgogICAgIHJldHVybiBXZWJLaXQ6OnNoYXJl ZFdvcmtlclJlcG9zaXRvcnkoKTsKIH0KIAo=