104699 2012-12-11 12:04:37 -0800 Cleanup: Use consistent naming in CSSParser when dealing with the forward slash operator. 2012-12-11 12:56:56 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard cmarcelo dbates macpherson ojan.autocc webkit.review.bot oldest_to_newest 788651 0 menard 2012-12-11 12:04:37 -0800 Cleanup: Use consistent naming in CSSParser when dealing with the forward slash operator. 788657 1 178844 menard 2012-12-11 12:13:58 -0800 Created attachment 178844 Patch 788660 2 178844 dbates 2012-12-11 12:16:29 -0800 Comment on attachment 178844 Patch r=me 788701 3 178844 webkit.review.bot 2012-12-11 12:56:52 -0800 Comment on attachment 178844 Patch Clearing flags on attachment: 178844 Committed r137345: <http://trac.webkit.org/changeset/137345> 788702 4 webkit.review.bot 2012-12-11 12:56:56 -0800 All reviewed patches have been landed. Closing bug. 178844 2012-12-11 12:13:58 -0800 2012-12-11 12:56:52 -0800 Patch bug-104699-20121211171118.patch text/plain 6871 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3Mjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM3ZTQzNDZkMTM4Mjdh NmNmZjU5NDg1NzQ0ZTEzZjY4Nzc0MTcwOS4uMDA1YmJlMTQ1YzQ3NzBiMGJmZWRhMzQ3YTQxNzA2 YjY0OGNkYjg4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEyLTEyLTExICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ2xlYW51cDogVXNlIGNv bnNpc3RlbnQgbmFtaW5nIGluIENTU1BhcnNlciB3aGVuIGRlYWxpbmcgd2l0aCB0aGUgZm9yd2Fy ZCBzbGFzaCBvcGVyYXRvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNDY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzNjUyNSBhZGRlZCBh biBoZWxwZXIgZnVuY3Rpb24gdG8KKyAgICAgICAgY2hlY2sgaWYgYSBDU1NQYXJzZXJWYWx1ZSBp cyBhIGZvcndhcmQgc2xhc2ggb3BlcmF0b3IuCisgICAgICAgIEJvcmRlckltYWdlUGFyc2VDb250 ZXh0IGlzIGFsc28gZGVhbGluZyB3aXRoIHRoZSBmb3J3YXJkIHNsYXNoIG9wZXJhdG9yCisgICAg ICAgIGJ1dCBpdHMgbmFtaW5nIGlzIGluY29uc2lzdGVudCB3aXRoIGlzRm9yd2FyZFNsYXNoT3Bl cmF0b3IoKS4gVGhpcyBpcworICAgICAgICBmaXhlZCB3aXRoIHRoaXMgcGF0Y2ggd2hlcmUgQm9y ZGVySW1hZ2VQYXJzZUNvbnRleHQ6OnthbGxvd1NsYXNoLAorICAgICAgICBjb21taXRTbGFzaH0o KSBpcyBub3cgcmVwbGFjZWQgYnkgQm9yZGVySW1hZ2VQYXJzZUNvbnRleHQ6OnthbGxvd0Zvcndh cmRTbGFzaE9wZXJhdG9yLAorICAgICAgICBjb21taXRGb3J3YXJkU2xhc2hPcGVyYXRvcn0oKS4K KworICAgICAgICBObyBuZXcgdGVzdHMgOiBqdXN0IGEgcmVuYW1pbmcsIGNvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlRmlsbFBvc2l0aW9uKTogQSBsaXR0bGUgZml4dXAgb24g dGhlIHdheSwgdXNlCisgICAgICAgIGlzRm9yd2FyZFNsYXNoT3BlcmF0b3IoKSBpbnN0ZWFkIG9m IHRoZSBjdXJyZW50IGNvZGUgaGVyZS4KKyAgICAgICAgKFdlYkNvcmU6OkJvcmRlckltYWdlUGFy c2VDb250ZXh0OjpCb3JkZXJJbWFnZVBhcnNlQ29udGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpC b3JkZXJJbWFnZVBhcnNlQ29udGV4dDo6YWxsb3dGb3J3YXJkU2xhc2hPcGVyYXRvcik6CisgICAg ICAgIChXZWJDb3JlOjpCb3JkZXJJbWFnZVBhcnNlQ29udGV4dDo6Y29tbWl0SW1hZ2UpOgorICAg ICAgICAoV2ViQ29yZTo6Qm9yZGVySW1hZ2VQYXJzZUNvbnRleHQ6OmNvbW1pdEltYWdlU2xpY2Up OgorICAgICAgICAoV2ViQ29yZTo6Qm9yZGVySW1hZ2VQYXJzZUNvbnRleHQ6OmNvbW1pdEZvcndh cmRTbGFzaE9wZXJhdG9yKToKKyAgICAgICAgKFdlYkNvcmU6OkJvcmRlckltYWdlUGFyc2VDb250 ZXh0Ojpjb21taXRCb3JkZXJXaWR0aCk6CisgICAgICAgIChXZWJDb3JlOjpCb3JkZXJJbWFnZVBh cnNlQ29udGV4dDo6Y29tbWl0Qm9yZGVyT3V0c2V0KToKKyAgICAgICAgKFdlYkNvcmU6OkJvcmRl ckltYWdlUGFyc2VDb250ZXh0Ojpjb21taXRSZXBlYXQpOgorICAgICAgICAoQm9yZGVySW1hZ2VQ YXJzZUNvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUJvcmRlcklt YWdlKToKKwogMjAxMi0xMi0xMSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IER1cGxpY2F0ZSBlbXVsYXRlZCB0b3VjaCBl dmVudHMgaW4gaWZyYW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDhkMmI1YzdiNDZj Zjk4OTQ5MTcyYjNhMWE2OTJkNjRiNmVlNGE1YjcuLjRiN2Q3Njc3ZDBhMGM2YzVhM2I1MDczNTUz OTNkOGJjYjFiZTAwNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0zODg0LDcgKzM4 ODQsNyBAQCB2b2lkIENTU1BhcnNlcjo6cGFyc2VGaWxsUG9zaXRpb24oQ1NTUGFyc2VyVmFsdWVM aXN0KiB2YWx1ZUxpc3QsIFJlZlB0cjxDU1NWYWx1ZQogICAgIHVuc2lnbmVkIG51bWJlck9mVmFs dWVzID0gMDsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSB2YWx1ZUxpc3QtPmN1cnJlbnRJbmRleCgp OyBpIDwgdmFsdWVMaXN0LT5zaXplKCk7ICsraSwgKytudW1iZXJPZlZhbHVlcykgewogICAgICAg ICBDU1NQYXJzZXJWYWx1ZSogY3VycmVudCA9IHZhbHVlTGlzdC0+dmFsdWVBdChpKTsKLSAgICAg ICAgaWYgKGlzQ29tbWEoY3VycmVudCkgfHwgIWN1cnJlbnQgfHwgKGN1cnJlbnQtPnVuaXQgPT0g Q1NTUGFyc2VyVmFsdWU6Ok9wZXJhdG9yICYmIGN1cnJlbnQtPmlWYWx1ZSA9PSAnLycpIHx8ICFp c1BvdGVudGlhbFBvc2l0aW9uVmFsdWUoY3VycmVudCkpCisgICAgICAgIGlmIChpc0NvbW1hKGN1 cnJlbnQpIHx8ICFjdXJyZW50IHx8IGlzRm9yd2FyZFNsYXNoT3BlcmF0b3IoY3VycmVudCkgfHwg IWlzUG90ZW50aWFsUG9zaXRpb25WYWx1ZShjdXJyZW50KSkKICAgICAgICAgICAgIGJyZWFrOwog ICAgIH0KIApAQCAtNjI4NCw3ICs2Mjg0LDcgQEAgc3RydWN0IEJvcmRlckltYWdlUGFyc2VDb250 ZXh0IHsKICAgICAsIG1fYWxsb3dJbWFnZSh0cnVlKQogICAgICwgbV9hbGxvd0ltYWdlU2xpY2Uo dHJ1ZSkKICAgICAsIG1fYWxsb3dSZXBlYXQodHJ1ZSkKLSAgICAsIG1fYWxsb3dTbGFzaChmYWxz ZSkKKyAgICAsIG1fYWxsb3dGb3J3YXJkU2xhc2hPcGVyYXRvcihmYWxzZSkKICAgICAsIG1fcmVx dWlyZVdpZHRoKGZhbHNlKQogICAgICwgbV9yZXF1aXJlT3V0c2V0KGZhbHNlKQogICAgIHt9CkBA IC02Mjk2LDcgKzYyOTYsNyBAQCBzdHJ1Y3QgQm9yZGVySW1hZ2VQYXJzZUNvbnRleHQgewogICAg IGJvb2wgYWxsb3dJbWFnZSgpIGNvbnN0IHsgcmV0dXJuIG1fYWxsb3dJbWFnZTsgfQogICAgIGJv b2wgYWxsb3dJbWFnZVNsaWNlKCkgY29uc3QgeyByZXR1cm4gbV9hbGxvd0ltYWdlU2xpY2U7IH0K ICAgICBib29sIGFsbG93UmVwZWF0KCkgY29uc3QgeyByZXR1cm4gbV9hbGxvd1JlcGVhdDsgfQot ICAgIGJvb2wgYWxsb3dTbGFzaCgpIGNvbnN0IHsgcmV0dXJuIG1fYWxsb3dTbGFzaDsgfQorICAg IGJvb2wgYWxsb3dGb3J3YXJkU2xhc2hPcGVyYXRvcigpIGNvbnN0IHsgcmV0dXJuIG1fYWxsb3dG b3J3YXJkU2xhc2hPcGVyYXRvcjsgfQogCiAgICAgYm9vbCByZXF1aXJlV2lkdGgoKSBjb25zdCB7 IHJldHVybiBtX3JlcXVpcmVXaWR0aDsgfQogICAgIGJvb2wgcmVxdWlyZU91dHNldCgpIGNvbnN0 IHsgcmV0dXJuIG1fcmVxdWlyZU91dHNldDsgfQpAQCAtNjMwNiw3ICs2MzA2LDcgQEAgc3RydWN0 IEJvcmRlckltYWdlUGFyc2VDb250ZXh0IHsKICAgICAgICAgbV9pbWFnZSA9IGltYWdlOwogICAg ICAgICBtX2NhbkFkdmFuY2UgPSB0cnVlOwogICAgICAgICBtX2FsbG93Q29tbWl0ID0gdHJ1ZTsK LSAgICAgICAgbV9hbGxvd0ltYWdlID0gbV9hbGxvd1NsYXNoID0gbV9yZXF1aXJlV2lkdGggPSBt X3JlcXVpcmVPdXRzZXQgPSBmYWxzZTsKKyAgICAgICAgbV9hbGxvd0ltYWdlID0gbV9hbGxvd0Zv cndhcmRTbGFzaE9wZXJhdG9yID0gbV9yZXF1aXJlV2lkdGggPSBtX3JlcXVpcmVPdXRzZXQgPSBm YWxzZTsKICAgICAgICAgbV9hbGxvd0ltYWdlU2xpY2UgPSAhbV9pbWFnZVNsaWNlOwogICAgICAg ICBtX2FsbG93UmVwZWF0ID0gIW1fcmVwZWF0OwogICAgIH0KQEAgLTYzMTQsMTUgKzYzMTQsMTUg QEAgc3RydWN0IEJvcmRlckltYWdlUGFyc2VDb250ZXh0IHsKICAgICB7CiAgICAgICAgIG1faW1h Z2VTbGljZSA9IHNsaWNlOwogICAgICAgICBtX2NhbkFkdmFuY2UgPSB0cnVlOwotICAgICAgICBt X2FsbG93Q29tbWl0ID0gbV9hbGxvd1NsYXNoID0gdHJ1ZTsKKyAgICAgICAgbV9hbGxvd0NvbW1p dCA9IG1fYWxsb3dGb3J3YXJkU2xhc2hPcGVyYXRvciA9IHRydWU7CiAgICAgICAgIG1fYWxsb3dJ bWFnZVNsaWNlID0gbV9yZXF1aXJlV2lkdGggPSBtX3JlcXVpcmVPdXRzZXQgPSBmYWxzZTsKICAg ICAgICAgbV9hbGxvd0ltYWdlID0gIW1faW1hZ2U7CiAgICAgICAgIG1fYWxsb3dSZXBlYXQgPSAh bV9yZXBlYXQ7CiAgICAgfQotICAgIHZvaWQgY29tbWl0U2xhc2goKQorICAgIHZvaWQgY29tbWl0 Rm9yd2FyZFNsYXNoT3BlcmF0b3IoKQogICAgIHsKICAgICAgICAgbV9jYW5BZHZhbmNlID0gdHJ1 ZTsKLSAgICAgICAgbV9hbGxvd0NvbW1pdCA9IG1fYWxsb3dJbWFnZSA9IG1fYWxsb3dJbWFnZVNs aWNlID0gbV9hbGxvd1JlcGVhdCA9IG1fYWxsb3dTbGFzaCA9IGZhbHNlOworICAgICAgICBtX2Fs bG93Q29tbWl0ID0gbV9hbGxvd0ltYWdlID0gbV9hbGxvd0ltYWdlU2xpY2UgPSBtX2FsbG93UmVw ZWF0ID0gbV9hbGxvd0ZvcndhcmRTbGFzaE9wZXJhdG9yID0gZmFsc2U7CiAgICAgICAgIGlmICgh bV9ib3JkZXJTbGljZSkgewogICAgICAgICAgICAgbV9yZXF1aXJlV2lkdGggPSB0cnVlOwogICAg ICAgICAgICAgbV9yZXF1aXJlT3V0c2V0ID0gZmFsc2U7CkBAIC02MzM1LDcgKzYzMzUsNyBAQCBz dHJ1Y3QgQm9yZGVySW1hZ2VQYXJzZUNvbnRleHQgewogICAgIHsKICAgICAgICAgbV9ib3JkZXJT bGljZSA9IHNsaWNlOwogICAgICAgICBtX2NhbkFkdmFuY2UgPSB0cnVlOwotICAgICAgICBtX2Fs bG93Q29tbWl0ID0gbV9hbGxvd1NsYXNoID0gdHJ1ZTsKKyAgICAgICAgbV9hbGxvd0NvbW1pdCA9 IG1fYWxsb3dGb3J3YXJkU2xhc2hPcGVyYXRvciA9IHRydWU7CiAgICAgICAgIG1fYWxsb3dJbWFn ZVNsaWNlID0gbV9yZXF1aXJlV2lkdGggPSBtX3JlcXVpcmVPdXRzZXQgPSBmYWxzZTsKICAgICAg ICAgbV9hbGxvd0ltYWdlID0gIW1faW1hZ2U7CiAgICAgICAgIG1fYWxsb3dSZXBlYXQgPSAhbV9y ZXBlYXQ7CkBAIC02MzQ1LDcgKzYzNDUsNyBAQCBzdHJ1Y3QgQm9yZGVySW1hZ2VQYXJzZUNvbnRl eHQgewogICAgICAgICBtX291dHNldCA9IG91dHNldDsKICAgICAgICAgbV9jYW5BZHZhbmNlID0g dHJ1ZTsKICAgICAgICAgbV9hbGxvd0NvbW1pdCA9IHRydWU7Ci0gICAgICAgIG1fYWxsb3dJbWFn ZVNsaWNlID0gbV9hbGxvd1NsYXNoID0gbV9yZXF1aXJlV2lkdGggPSBtX3JlcXVpcmVPdXRzZXQg PSBmYWxzZTsKKyAgICAgICAgbV9hbGxvd0ltYWdlU2xpY2UgPSBtX2FsbG93Rm9yd2FyZFNsYXNo T3BlcmF0b3IgPSBtX3JlcXVpcmVXaWR0aCA9IG1fcmVxdWlyZU91dHNldCA9IGZhbHNlOwogICAg ICAgICBtX2FsbG93SW1hZ2UgPSAhbV9pbWFnZTsKICAgICAgICAgbV9hbGxvd1JlcGVhdCA9ICFt X3JlcGVhdDsKICAgICB9CkBAIC02MzU0LDcgKzYzNTQsNyBAQCBzdHJ1Y3QgQm9yZGVySW1hZ2VQ YXJzZUNvbnRleHQgewogICAgICAgICBtX3JlcGVhdCA9IHJlcGVhdDsKICAgICAgICAgbV9jYW5B ZHZhbmNlID0gdHJ1ZTsKICAgICAgICAgbV9hbGxvd0NvbW1pdCA9IHRydWU7Ci0gICAgICAgIG1f YWxsb3dSZXBlYXQgPSBtX2FsbG93U2xhc2ggPSBtX3JlcXVpcmVXaWR0aCA9IG1fcmVxdWlyZU91 dHNldCA9IGZhbHNlOworICAgICAgICBtX2FsbG93UmVwZWF0ID0gbV9hbGxvd0ZvcndhcmRTbGFz aE9wZXJhdG9yID0gbV9yZXF1aXJlV2lkdGggPSBtX3JlcXVpcmVPdXRzZXQgPSBmYWxzZTsKICAg ICAgICAgbV9hbGxvd0ltYWdlU2xpY2UgPSAhbV9pbWFnZVNsaWNlOwogICAgICAgICBtX2FsbG93 SW1hZ2UgPSAhbV9pbWFnZTsKICAgICB9CkBAIC02Mzg3LDcgKzYzODcsNyBAQCBzdHJ1Y3QgQm9y ZGVySW1hZ2VQYXJzZUNvbnRleHQgewogICAgIGJvb2wgbV9hbGxvd0ltYWdlOwogICAgIGJvb2wg bV9hbGxvd0ltYWdlU2xpY2U7CiAgICAgYm9vbCBtX2FsbG93UmVwZWF0OwotICAgIGJvb2wgbV9h bGxvd1NsYXNoOworICAgIGJvb2wgbV9hbGxvd0ZvcndhcmRTbGFzaE9wZXJhdG9yOwogCiAgICAg Ym9vbCBtX3JlcXVpcmVXaWR0aDsKICAgICBib29sIG1fcmVxdWlyZU91dHNldDsKQEAgLTY0MDcs OCArNjQwNyw4IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUJvcmRlckltYWdlKENTU1Byb3BlcnR5 SUQgcHJvcElkLCBSZWZQdHI8Q1NTVmFsdWU+JiByZXN1bHQsCiAgICAgd2hpbGUgKENTU1BhcnNl clZhbHVlKiB2YWwgPSBtX3ZhbHVlTGlzdC0+Y3VycmVudCgpKSB7CiAgICAgICAgIGNvbnRleHQu c2V0Q2FuQWR2YW5jZShmYWxzZSk7CiAKLSAgICAgICAgaWYgKCFjb250ZXh0LmNhbkFkdmFuY2Uo KSAmJiBjb250ZXh0LmFsbG93U2xhc2goKSAmJiBpc0ZvcndhcmRTbGFzaE9wZXJhdG9yKHZhbCkp Ci0gICAgICAgICAgICBjb250ZXh0LmNvbW1pdFNsYXNoKCk7CisgICAgICAgIGlmICghY29udGV4 dC5jYW5BZHZhbmNlKCkgJiYgY29udGV4dC5hbGxvd0ZvcndhcmRTbGFzaE9wZXJhdG9yKCkgJiYg aXNGb3J3YXJkU2xhc2hPcGVyYXRvcih2YWwpKQorICAgICAgICAgICAgY29udGV4dC5jb21taXRG b3J3YXJkU2xhc2hPcGVyYXRvcigpOwogCiAgICAgICAgIGlmICghY29udGV4dC5jYW5BZHZhbmNl KCkgJiYgY29udGV4dC5hbGxvd0ltYWdlKCkpIHsKICAgICAgICAgICAgIGlmICh2YWwtPnVuaXQg PT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19VUkkpCg==