<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>104693</bug_id>
          
          <creation_ts>2012-12-11 11:46:09 -0800</creation_ts>
          <short_desc>REGRESSION: Very poor performance on IE&apos;s Chalkboard benchmark</short_desc>
          <delta_ts>2013-02-14 12:18:32 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://ie.microsoft.com/testdrive/Performance/Chalkboard/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, Regression</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Philip Rogers">pdr</assigned_to>
          <cc>abarth</cc>
    
    <cc>fmalita</cc>
    
    <cc>krit</cc>
    
    <cc>pdr</cc>
    
    <cc>peter</cc>
    
    <cc>schenney</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>788635</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-12-11 11:46:09 -0800</bug_when>
    <thetext>http://ie.microsoft.com/testdrive/Performance/Chalkboard/

A vague history of our performance on this test:

a) bad (15 seconds to completion, pretty jerky) before SVGImageCache (http://trac.webkit.org/changeset/99539)
b) sort of OK (5 seconds to completion, relatively smooth) after SVGImageCache, but pixelated.
c) absolutely horrific (hundreds of seconds to completion, completely stalling for seconds at a time) after Niko&apos;s fix to actually use the right image size. But not pixelated anymore. (http://trac.webkit.org/changeset/112229)

&lt;rdar://problem/11769350&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>788642</commentid>
    <comment_count>1</comment_count>
    <who name="Florin Malita">fmalita</who>
    <bug_when>2012-12-11 11:54:16 -0800</bug_when>
    <thetext>I believe Philip is taking a hard look at the SVG image cache :)

FWIW, bypassing the SVG image cache completely (by hacking SVGImageCache::lookupOrCreateBitmapImageForRenderer to always return Image::nullImage for example) fixes this issue (runs in under 5s on my workstation, not pixelated).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>788646</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-12-11 11:55:51 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; I believe Philip is taking a hard look at the SVG image cache :)

That is *fantastic* news.

&gt; FWIW, bypassing the SVG image cache completely (by hacking SVGImageCache::lookupOrCreateBitmapImageForRenderer to always return Image::nullImage for example) fixes this issue (runs in under 5s on my workstation, not pixelated).

Heh, good to know!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>800793</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-01-04 18:07:03 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (In reply to comment #1)
&gt; &gt; I believe Philip is taking a hard look at the SVG image cache :)
&gt; 
&gt; That is *fantastic* news.

pdr, do you have a bug tracking your work?

&gt; &gt; FWIW, bypassing the SVG image cache completely (by hacking SVGImageCache::lookupOrCreateBitmapImageForRenderer to always return Image::nullImage for example) fixes this issue (runs in under 5s on my workstation, not pixelated).
&gt; 
&gt; Heh, good to know!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>800808</commentid>
    <comment_count>4</comment_count>
    <who name="Philip Rogers">pdr</who>
    <bug_when>2013-01-04 18:34:42 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; (In reply to comment #1)
&gt; &gt; &gt; I believe Philip is taking a hard look at the SVG image cache :)
&gt; &gt; 
&gt; &gt; That is *fantastic* news.
&gt; 
&gt; pdr, do you have a bug tracking your work?

I&apos;ve been plugging away at this but our image cache is really not well :/ My current plan is to get the cache into a decent, working state and then switch it over to be non-image-based.

I went ahead and filed several of the larger bugs:
https://bugs.webkit.org/show_bug.cgi?id=106156
https://bugs.webkit.org/show_bug.cgi?id=106158
https://bugs.webkit.org/show_bug.cgi?id=106159 (this is the imagebuffer change)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>833316</commentid>
    <comment_count>5</comment_count>
    <who name="Philip Rogers">pdr</who>
    <bug_when>2013-02-14 12:18:32 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; (In reply to comment #2)
&gt; &gt; &gt; (In reply to comment #1)
&gt; &gt; &gt; &gt; I believe Philip is taking a hard look at the SVG image cache :)
&gt; &gt; &gt; 
&gt; &gt; &gt; That is *fantastic* news.
&gt; &gt; 
&gt; &gt; pdr, do you have a bug tracking your work?
&gt; 
&gt; I&apos;ve been plugging away at this but our image cache is really not well :/ My current plan is to get the cache into a decent, working state and then switch it over to be non-image-based.
&gt; 
&gt; I went ahead and filed several of the larger bugs:
&gt; https://bugs.webkit.org/show_bug.cgi?id=106156
&gt; https://bugs.webkit.org/show_bug.cgi?id=106158
&gt; https://bugs.webkit.org/show_bug.cgi?id=106159 (this is the imagebuffer change)

We now pass the IE chalkboard demo in 9s at 1280x1024!</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>