104679 2012-12-11 09:20:38 -0800 Web inspector prints a warning about "Debug" not being localized 2012-12-12 00:18:40 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson apavlov gtk-ews keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot xan.lopez yurys oldest_to_newest 788499 0 mrobinson 2012-12-11 09:20:38 -0800 In the stderr output for the GTK+ tests we are getting a lot of spurious output about "Debug" not being a localized string. For instance see: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r137316%20(32039)/inspector/debugger/scripts-panel-stderr.txt 788501 1 178819 mrobinson 2012-12-11 09:25:28 -0800 Created attachment 178819 Patch 788514 2 178819 gtk-ews 2012-12-11 09:39:39 -0800 Comment on attachment 178819 Patch Attachment 178819 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15260479 788608 3 178819 buildbot 2012-12-11 11:00:21 -0800 Comment on attachment 178819 Patch Attachment 178819 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15242919 New failing tests: fast/frames/sandboxed-iframe-attribute-parsing.html svg/as-image/img-preserveAspectRatio-support-2.html 788857 4 mrobinson 2012-12-11 15:23:48 -0800 I'm not sure if the GTK+ failure really relates to this patch, but I'll investigate further. I don't know how this could cause the tests listed to fail on Mac either. All I did was add a new localized string. Did you have a comment to attach to your r-? 789279 5 vsevik 2012-12-12 00:10:59 -0800 (In reply to comment #4) > I'm not sure if the GTK+ failure really relates to this patch, but I'll investigate further. I don't know how this could cause the tests listed to fail on Mac either. All I did was add a new localized string. Did you have a comment to attach to your r-? I'm pretty sure Pavel meant to r+ this. :) 789287 6 178819 webkit.review.bot 2012-12-12 00:18:36 -0800 Comment on attachment 178819 Patch Clearing flags on attachment: 178819 Committed r137430: <http://trac.webkit.org/changeset/137430> 789288 7 webkit.review.bot 2012-12-12 00:18:40 -0800 All reviewed patches have been landed. Closing bug. 178819 2012-12-11 09:25:28 -0800 2012-12-12 00:18:36 -0800 Patch bug-104679-20121211182249.patch text/plain 1587 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2JjZTU3MTk3MDkwMmJm NDliODA3OGQxZWU5Yzk3OTc3ODVlM2RkMC4uMTVmZDlkNjA4MjZlNDM1NGYyOTllNTQwMmY4Njk3 NTRlYjc3OGVhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTExICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBXZWIgaW5zcGVj dG9yIHByaW50cyBhIHdhcm5pbmcgYWJvdXQgIkRlYnVnIiBub3QgYmVpbmcgbG9jYWxpemVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ2NzkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBtaXNz aW5nIGxvY2FsaXphdGlvbiBlbnRyeSBmb3IgdGhlICJEZWJ1ZyIgc3RyaW5nIHdoaWNoIGlzIHVz ZWQgaW4gdGhlIHdlYgorICAgICAgICBpbnNwZWN0b3IgZnJvbnQtZW5kLiBUaGlzIHByZXZlbnRz IHdhcm5pbmdzIGFib3V0IGEgbWlzc2luZyBsb2NhbGl6ZWQgdmVyc2lvbgorICAgICAgICBvZiB0 aGUgd29yZCAiRGVidWciIGFuZCBhbGxvd3MgaXQgdG8gYmUgcHJvcGVybHkgbG9jYWxpemVkLgor CisgICAgICAgICogRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOiBBZGQgIkRlYnVn IgorCiAyMDEyLTEyLTExICBKZXNzaWUgQmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2ZXJ0IGluY29ycmVjdCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViQ29yZS9F bmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggOGZiMThlZTE2ZTcwMjhjMzVl ZjJiZjUzNTUyYmIxYzViOGUwZDQ3OC4uZTdmOTYxMDM1Y2VlN2RhOWYxN2YzZTU1MjE2NmY3MDlh YTY5MjY2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6 ZWRTdHJpbmdzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVk U3RyaW5ncy5qcwpAQCAtMjQ2LDYgKzI0Niw3IEBAIGxvY2FsaXplZFN0cmluZ3NbIkxvY2FsIEZp bGVzIl0gPSAiTG9jYWwgRmlsZXMiOwogbG9jYWxpemVkU3RyaW5nc1siTG9jYWwiXSA9ICJMb2Nh bCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJMb2NhdGlvbiJdID0gIkxvY2F0aW9uIjsKIGxvY2FsaXpl ZFN0cmluZ3NbIkxvZ3MiXSA9ICJMb2dzIjsKK2xvY2FsaXplZFN0cmluZ3NbIkRlYnVnIl0gPSAi RGVidWciOwogbG9jYWxpemVkU3RyaW5nc1siTUlNRSBUeXBlIl0gPSAiTUlNRSBUeXBlIjsKIGxv Y2FsaXplZFN0cmluZ3NbIk1JTUUgdHlwZSJdID0gIk1JTUUgdHlwZSI7CiBsb2NhbGl6ZWRTdHJp bmdzWyJNYXRjaGVkIENTUyBSdWxlcyJdID0gIk1hdGNoZWQgQ1NTIFJ1bGVzIjsK