104668 2012-12-11 06:38:32 -0800 [GTK] Soup network logs are frequently interrupted by other logging messages 2012-12-11 10:59:23 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 0 jonathon webkit-unassigned danw gustavo mrobinson rakuco webkit.review.bot oldest_to_newest 788392 0 jonathon 2012-12-11 06:38:32 -0800 The libsoup network logging should use the webkit logging infrastructure to print out network logging messages so that messages from all logging channels can be properly synchronized. 788404 1 178793 jonathon 2012-12-11 06:53:31 -0800 Created attachment 178793 add custom soup log printer 788419 2 178793 mrobinson 2012-12-11 07:12:07 -0800 Comment on attachment 178793 add custom soup log printer View in context: https://bugs.webkit.org/attachment.cgi?id=178793&action=review Thanks! > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:81 > +inline static void soupLogPrinter(SoupLogger *logger, SoupLoggerLogLevel level, char direction, const char* data, gpointer userData) Nit: SoupLogger *logger should be SoupLogger* logger and you can omit the "userData" and "level" here entirely. 788495 3 178818 jonathon 2012-12-11 09:16:41 -0800 Created attachment 178818 fix nits 788604 4 178818 webkit.review.bot 2012-12-11 10:59:20 -0800 Comment on attachment 178818 fix nits Clearing flags on attachment: 178818 Committed r137337: <http://trac.webkit.org/changeset/137337> 788606 5 webkit.review.bot 2012-12-11 10:59:23 -0800 All reviewed patches have been landed. Closing bug. 178793 2012-12-11 06:53:31 -0800 2012-12-11 09:16:34 -0800 add custom soup log printer bug-104668-20121211085031.patch text/plain 2208 jonathon U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjBkZTQwNzRlODIxNDQ1 YzE2NDMxZmMwMmJmYzU5YTE0OWM2NmU5OS4uM2VjODI2YjQyZTBhMWQ0YTllMzkwYWNhYzk4NWU0 M2U1MjZjNTFhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTExICBKb25h dGhvbiBKb25nc21hICA8am9uYXRob24uam9uZ3NtYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAg ICAgW0dUS10gU291cCBuZXR3b3JrIGxvZ3MgYXJlIGZyZXF1ZW50bHkgaW50ZXJydXB0ZWQgYnkg b3RoZXIgbG9nZ2luZyBtZXNzYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA0NjY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU2V0IGFuIGV4dGVybmFsIHNvdXAgbG9nIHByaW50ZXIgdGhhdCB1c2Vz IHRoZSBXZWJLaXQgbG9nZ2luZworICAgICAgICBpbmZyYXN0cnVjdHVyZSBzbyB0aGF0IGxvZyBt ZXNzYWdlcyBhcmUgcHJvcGVybHkgc3luY2hyb25pemVkLgorCisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpz b3VwTG9nUHJpbnRlcik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmVu c3VyZVNlc3Npb25Jc0luaXRpYWxpemVkKToKKwogMjAxMi0xMi0xMCAgSGFqaW1lIE1vcnJpdGEg IDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgW1NoYWRvdyBET01dW1JlZmFjZHRvcmlu Z10gbmV4dFRvKCkgYW5kIHByZXZpb3VzVG8oKSBjYW4gYmUgcGFydCBvZiBDb250ZW50RGlzdHJp YnV0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IGE1ZmY5MGU1NzYyZjc5MWE4ZDc2NzFm ZmIxOTg3ZmQ0MTliMjAyNGIuLmM1ZWI0NjlkMGU2ZDQ2MWQ0MWZkNDQyZGE3MTg1ZDQ3YTg3Yzli ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZUhhbmRsZVNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBAIC03OCw2ICs3OCwxMSBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKICNkZWZpbmUgUkVBRF9CVUZGRVJfU0laRSA4MTkyCiAKK2lubGluZSBzdGF0 aWMgdm9pZCBzb3VwTG9nUHJpbnRlcihTb3VwTG9nZ2VyICpsb2dnZXIsIFNvdXBMb2dnZXJMb2dM ZXZlbCBsZXZlbCwgY2hhciBkaXJlY3Rpb24sIGNvbnN0IGNoYXIqIGRhdGEsIGdwb2ludGVyIHVz ZXJEYXRhKQoreworICAgIExPRyhOZXR3b3JrLCAiJWMgJXMiLCBkaXJlY3Rpb24sIGRhdGEpOwor fQorCiBzdGF0aWMgYm9vbCBsb2FkaW5nU3luY2hyb25vdXNSZXF1ZXN0ID0gZmFsc2U7CiAKIGNs YXNzIFdlYkNvcmVTeW5jaHJvbm91c0xvYWRlciA6IHB1YmxpYyBSZXNvdXJjZUhhbmRsZUNsaWVu dCB7CkBAIC0yNjUsNiArMjcwLDcgQEAgc3RhdGljIHZvaWQgZW5zdXJlU2Vzc2lvbklzSW5pdGlh bGl6ZWQoU291cFNlc3Npb24qIHNlc3Npb24pCiAgICAgaWYgKCFzb3VwX3Nlc3Npb25fZ2V0X2Zl YXR1cmUoc2Vzc2lvbiwgU09VUF9UWVBFX0xPR0dFUikgJiYgTG9nTmV0d29yay5zdGF0ZSA9PSBX VEZMb2dDaGFubmVsT24pIHsKICAgICAgICAgU291cExvZ2dlciogbG9nZ2VyID0gc291cF9sb2dn ZXJfbmV3KHN0YXRpY19jYXN0PFNvdXBMb2dnZXJMb2dMZXZlbD4oU09VUF9MT0dHRVJfTE9HX0JP RFkpLCAtMSk7CiAgICAgICAgIHNvdXBfc2Vzc2lvbl9hZGRfZmVhdHVyZShzZXNzaW9uLCBTT1VQ X1NFU1NJT05fRkVBVFVSRShsb2dnZXIpKTsKKyAgICAgICAgc291cF9sb2dnZXJfc2V0X3ByaW50 ZXIobG9nZ2VyLCBzb3VwTG9nUHJpbnRlciwgMCwgMCk7CiAgICAgICAgIGdfb2JqZWN0X3VucmVm KGxvZ2dlcik7CiAgICAgfQogI2VuZGlmIC8vICFMT0dfRElTQUJMRUQK 178818 2012-12-11 09:16:41 -0800 2012-12-11 10:59:19 -0800 fix nits bug-104668-20121211111341.patch text/plain 2193 jonathon U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjBkZTQwNzRlODIxNDQ1 YzE2NDMxZmMwMmJmYzU5YTE0OWM2NmU5OS4uM2VjODI2YjQyZTBhMWQ0YTllMzkwYWNhYzk4NWU0 M2U1MjZjNTFhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTExICBKb25h dGhvbiBKb25nc21hICA8am9uYXRob24uam9uZ3NtYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAg ICAgW0dUS10gU291cCBuZXR3b3JrIGxvZ3MgYXJlIGZyZXF1ZW50bHkgaW50ZXJydXB0ZWQgYnkg b3RoZXIgbG9nZ2luZyBtZXNzYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA0NjY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU2V0IGFuIGV4dGVybmFsIHNvdXAgbG9nIHByaW50ZXIgdGhhdCB1c2Vz IHRoZSBXZWJLaXQgbG9nZ2luZworICAgICAgICBpbmZyYXN0cnVjdHVyZSBzbyB0aGF0IGxvZyBt ZXNzYWdlcyBhcmUgcHJvcGVybHkgc3luY2hyb25pemVkLgorCisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpz b3VwTG9nUHJpbnRlcik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmVu c3VyZVNlc3Npb25Jc0luaXRpYWxpemVkKToKKwogMjAxMi0xMi0xMCAgSGFqaW1lIE1vcnJpdGEg IDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgW1NoYWRvdyBET01dW1JlZmFjZHRvcmlu Z10gbmV4dFRvKCkgYW5kIHByZXZpb3VzVG8oKSBjYW4gYmUgcGFydCBvZiBDb250ZW50RGlzdHJp YnV0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IGE1ZmY5MGU1NzYyZjc5MWE4ZDc2NzFm ZmIxOTg3ZmQ0MTliMjAyNGIuLmRkMmMxYjZiOThjY2Q4OWJhMDM1MTE2OWIwNWUxMzdhMTYwYjQ3 NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZUhhbmRsZVNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBAIC03OCw2ICs3OCwxMSBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKICNkZWZpbmUgUkVBRF9CVUZGRVJfU0laRSA4MTkyCiAKK2lubGluZSBzdGF0 aWMgdm9pZCBzb3VwTG9nUHJpbnRlcihTb3VwTG9nZ2VyKiBsb2dnZXIsIFNvdXBMb2dnZXJMb2dM ZXZlbCwgY2hhciBkaXJlY3Rpb24sIGNvbnN0IGNoYXIqIGRhdGEsIGdwb2ludGVyKQoreworICAg IExPRyhOZXR3b3JrLCAiJWMgJXMiLCBkaXJlY3Rpb24sIGRhdGEpOworfQorCiBzdGF0aWMgYm9v bCBsb2FkaW5nU3luY2hyb25vdXNSZXF1ZXN0ID0gZmFsc2U7CiAKIGNsYXNzIFdlYkNvcmVTeW5j aHJvbm91c0xvYWRlciA6IHB1YmxpYyBSZXNvdXJjZUhhbmRsZUNsaWVudCB7CkBAIC0yNjUsNiAr MjcwLDcgQEAgc3RhdGljIHZvaWQgZW5zdXJlU2Vzc2lvbklzSW5pdGlhbGl6ZWQoU291cFNlc3Np b24qIHNlc3Npb24pCiAgICAgaWYgKCFzb3VwX3Nlc3Npb25fZ2V0X2ZlYXR1cmUoc2Vzc2lvbiwg U09VUF9UWVBFX0xPR0dFUikgJiYgTG9nTmV0d29yay5zdGF0ZSA9PSBXVEZMb2dDaGFubmVsT24p IHsKICAgICAgICAgU291cExvZ2dlciogbG9nZ2VyID0gc291cF9sb2dnZXJfbmV3KHN0YXRpY19j YXN0PFNvdXBMb2dnZXJMb2dMZXZlbD4oU09VUF9MT0dHRVJfTE9HX0JPRFkpLCAtMSk7CiAgICAg ICAgIHNvdXBfc2Vzc2lvbl9hZGRfZmVhdHVyZShzZXNzaW9uLCBTT1VQX1NFU1NJT05fRkVBVFVS RShsb2dnZXIpKTsKKyAgICAgICAgc291cF9sb2dnZXJfc2V0X3ByaW50ZXIobG9nZ2VyLCBzb3Vw TG9nUHJpbnRlciwgMCwgMCk7CiAgICAgICAgIGdfb2JqZWN0X3VucmVmKGxvZ2dlcik7CiAgICAg fQogI2VuZGlmIC8vICFMT0dfRElTQUJMRUQK