104657 2012-12-11 04:09:37 -0800 Remove unused GErrors 2012-12-11 05:14:01 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 0 berto webkit-unassigned cgarcia webkit.review.bot oldest_to_newest 788299 0 berto 2012-12-11 04:09:37 -0800 There's a few unused GErrors in the tools' source code. Most functions that receive a GError can also accept NULL instead, so they can be removed. 788303 1 178772 berto 2012-12-11 04:14:14 -0800 Created attachment 178772 Patch 788337 2 178772 webkit.review.bot 2012-12-11 05:13:58 -0800 Comment on attachment 178772 Patch Clearing flags on attachment: 178772 Committed r137296: <http://trac.webkit.org/changeset/137296> 788338 3 webkit.review.bot 2012-12-11 05:14:01 -0800 All reviewed patches have been landed. Closing bug. 178772 2012-12-11 04:14:14 -0800 2012-12-11 05:13:58 -0800 Patch gerror.diff text/plain 3662 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ODVi ZjFmLi40OGE2MTEzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTItMTEgIEFsYmVydG8gR2FyY2lhICA8YWdh cmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgR0Vycm9ycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NjU3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSB1bnVzZWQg R0Vycm9ycyB3aXRoIG51bGwgcG9pbnRlcnMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9n dGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoaW5pdGlhbGl6ZUZvbnRzKToKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRWRpdGluZ0NhbGxiYWNrcy5jcHA6CisgICAgICAgIChk dW1wUmFuZ2UpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvZ3Rr L0FjdGl2YXRlRm9udHNHdGsuY3BwOgorICAgICAgICAoV1RSOjppbml0aXRpYWxpemVGb250Q29u ZmlnU2V0dGluZyk6CisKIDIwMTItMTItMTAgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9i ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkaW5nIE1paGFpIE1hZXJlYW4gdG8gdGhl IGxpc3Qgb2YgY29udHJpYnV0b3JzLCB3b3JraW5nIG9uIENTU1JlZ2lvbnMuCmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBlNjhlMmEwLi4wN2E1Yzc5 IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3Bw CisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTI0 Myw4ICsyNDMsNyBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXplRm9udHMoY29uc3QgY2hhciogdGVz dFVSTCA9IDApCiAgICAgaWYgKGZvbnRzUGF0aC5pc051bGwoKSkKICAgICAgICAgZ19lcnJvcigi Q291bGQgbm90IGxvY2F0ZSB0ZXN0IGZvbnRzIGF0ICVzLiBJcyBXRUJLSVRfVE9QX0xFVkVMIHNl dD8iLCBmb250c1BhdGguZGF0YSgpKTsKIAotICAgIEdPd25QdHI8R0Vycm9yPiBlcnJvcjsKLSAg ICBHT3duUHRyPEdEaXI+IGZvbnRzRGlyZWN0b3J5KGdfZGlyX29wZW4oZm9udHNQYXRoLmRhdGEo KSwgMCwgJmVycm9yLm91dFB0cigpKSk7CisgICAgR093blB0cjxHRGlyPiBmb250c0RpcmVjdG9y eShnX2Rpcl9vcGVuKGZvbnRzUGF0aC5kYXRhKCksIDAsIDApKTsKICAgICB3aGlsZSAoY29uc3Qg Y2hhciogZGlyZWN0b3J5RW50cnkgPSBnX2Rpcl9yZWFkX25hbWUoZm9udHNEaXJlY3RvcnkuZ2V0 KCkpKSB7CiAgICAgICAgIGlmICghZ19zdHJfaGFzX3N1ZmZpeChkaXJlY3RvcnlFbnRyeSwgIi50 dGYiKSAmJiAhZ19zdHJfaGFzX3N1ZmZpeChkaXJlY3RvcnlFbnRyeSwgIi5vdGYiKSkKICAgICAg ICAgICAgIGNvbnRpbnVlOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0Vk aXRpbmdDYWxsYmFja3MuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0VkaXRpbmdDYWxs YmFja3MuY3BwCmluZGV4IDRjOTY4ZDkuLmFkZWNkYjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2d0ay9FZGl0aW5nQ2FsbGJhY2tzLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9ndGsvRWRpdGluZ0NhbGxiYWNrcy5jcHAKQEAgLTU5LDE1ICs1OSwxMiBAQCBzdGF0aWMg Q1N0cmluZyBkdW1wUmFuZ2UoV2ViS2l0RE9NUmFuZ2UqIHJhbmdlKQogICAgIGlmICghcmFuZ2Up CiAgICAgICAgIHJldHVybiAiKG51bGwpIjsKIAotICAgIEdPd25QdHI8R0Vycm9yPiBlcnJvcjE7 Ci0gICAgR093blB0cjxHRXJyb3I+IGVycm9yMjsKLSAgICBHT3duUHRyPEdFcnJvcj4gZXJyb3Iz OwotICAgIEdPd25QdHI8R0Vycm9yPiBlcnJvcjQ7CiAgICAgR093blB0cjxnY2hhcj4gZHVtcChn X3N0cmR1cF9wcmludGYoInJhbmdlIGZyb20gJWxpIG9mICVzIHRvICVsaSBvZiAlcyIsCi0gICAg ICAgIHdlYmtpdF9kb21fcmFuZ2VfZ2V0X3N0YXJ0X29mZnNldChyYW5nZSwgJmVycm9yMS5vdXRQ dHIoKSksCi0gICAgICAgIGR1bXBOb2RlUGF0aCh3ZWJraXRfZG9tX3JhbmdlX2dldF9zdGFydF9j b250YWluZXIocmFuZ2UsICZlcnJvcjIub3V0UHRyKCkpKS5kYXRhKCksCi0gICAgICAgIHdlYmtp dF9kb21fcmFuZ2VfZ2V0X2VuZF9vZmZzZXQocmFuZ2UsICZlcnJvcjMub3V0UHRyKCkpLAotICAg ICAgICBkdW1wTm9kZVBhdGgod2Via2l0X2RvbV9yYW5nZV9nZXRfZW5kX2NvbnRhaW5lcihyYW5n ZSwgJmVycm9yNC5vdXRQdHIoKSkpLmRhdGEoKSkpOworICAgICAgICB3ZWJraXRfZG9tX3Jhbmdl X2dldF9zdGFydF9vZmZzZXQocmFuZ2UsIDApLAorICAgICAgICBkdW1wTm9kZVBhdGgod2Via2l0 X2RvbV9yYW5nZV9nZXRfc3RhcnRfY29udGFpbmVyKHJhbmdlLCAwKSkuZGF0YSgpLAorICAgICAg ICB3ZWJraXRfZG9tX3JhbmdlX2dldF9lbmRfb2Zmc2V0KHJhbmdlLCAwKSwKKyAgICAgICAgZHVt cE5vZGVQYXRoKHdlYmtpdF9kb21fcmFuZ2VfZ2V0X2VuZF9jb250YWluZXIocmFuZ2UsIDApKS5k YXRhKCkpKTsKKwogICAgIHJldHVybiBkdW1wLmdldCgpOwogfQogCmRpZmYgLS1naXQgYS9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2d0ay9BY3RpdmF0ZUZvbnRzR3RrLmNw cCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvZ3RrL0FjdGl2YXRlRm9u dHNHdGsuY3BwCmluZGV4IGM4NDM1OTEuLjQxN2U0Y2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvZ3RrL0FjdGl2YXRlRm9udHNHdGsuY3BwCisrKyBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvZ3RrL0FjdGl2YXRlRm9udHNH dGsuY3BwCkBAIC0xMTYsOCArMTE2LDcgQEAgdm9pZCBpbml0aXRpYWxpemVGb250Q29uZmlnU2V0 dGluZygpCiAgICAgaWYgKGZvbnRzUGF0aC5pc051bGwoKSkKICAgICAgICAgZ19lcnJvcigiQ291 bGQgbm90IGxvY2F0ZSB0ZXN0IGZvbnRzIGF0ICVzLiBJcyBXRUJLSVRfVE9QX0xFVkVMIHNldD8i LCBmb250c1BhdGguZGF0YSgpKTsKIAotICAgIEdPd25QdHI8R0Vycm9yPiBlcnJvcjsKLSAgICBH T3duUHRyPEdEaXI+IGZvbnRzRGlyZWN0b3J5KGdfZGlyX29wZW4oZm9udHNQYXRoLmRhdGEoKSwg MCwgJmVycm9yLm91dFB0cigpKSk7CisgICAgR093blB0cjxHRGlyPiBmb250c0RpcmVjdG9yeShn X2Rpcl9vcGVuKGZvbnRzUGF0aC5kYXRhKCksIDAsIDApKTsKICAgICB3aGlsZSAoY29uc3QgY2hh ciogZGlyZWN0b3J5RW50cnkgPSBnX2Rpcl9yZWFkX25hbWUoZm9udHNEaXJlY3RvcnkuZ2V0KCkp KSB7CiAgICAgICAgIGlmICghZ19zdHJfaGFzX3N1ZmZpeChkaXJlY3RvcnlFbnRyeSwgIi50dGYi KSAmJiAhZ19zdHJfaGFzX3N1ZmZpeChkaXJlY3RvcnlFbnRyeSwgIi5vdGYiKSkKICAgICAgICAg ICAgIGNvbnRpbnVlOwo=