104653 2012-12-11 02:52:02 -0800 Web Inspector: Duplicate emulated touch events in iframe 2012-12-11 05:01:57 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov dglazkov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 788244 0 apavlov 2012-12-11 02:52:02 -0800 Steps to reproduce the problem: 1. Save the following to a html file, and open in browser. <html><body><script> window.addEventListener('DOMContentLoaded', function() { var e; if (location.hash == '#iframe') { e = document.createElement('div'); e.innerHTML = 'touchstarting this element will fire a spurious event in Chrome using "Emulate touch events".'; e.addEventListener('touchstart', function() { console.log("touchstart event"); }); e.addEventListener('touchend', function() { console.log("touchend event"); }); } else { e = document.createElement('IFRAME'); e.src = "#iframe"; } document.body.appendChild(e); }); </script></body></html> 2. Open the Developer Console and enable 'emulate touch events' (Settings sprocket, Overrides). 3. Click on the div element within the iframe What is the expected behavior? The developer console to show 'touchstart event' and 'touchend event' once per click. What went wrong? The events are fired exactly twice for each click. Upstreaming http://code.google.com/p/chromium/issues/detail?id=164510 The issue is that the synthetic touch events are dispatched for all frames in the hierarchy, down to the one containing the hit element. 788252 1 178760 apavlov 2012-12-11 03:01:22 -0800 Created attachment 178760 Patch 788301 2 178760 webkit.review.bot 2012-12-11 04:10:32 -0800 Comment on attachment 178760 Patch Attachment 178760 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15259455 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 788309 3 178760 vsevik 2012-12-11 04:20:39 -0800 Comment on attachment 178760 Patch Consider adding bail out for mouse events on scroll bar. 788311 4 178760 vsevik 2012-12-11 04:21:24 -0800 Comment on attachment 178760 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178760&action=review > Source/WebCore/page/EventHandler.cpp:4062 > + LayoutPoint documentPoint = documentPointForWindowPoint(m_frame, event.position()); MouseEventWithHitTestResults mev = prepareMouseEvent(request, event); > Source/WebCore/page/EventHandler.cpp:4065 > + RefPtr<Frame> subframe = subframeForHitTestResult(mev); if (subframeForHitTestResult(mev)) return false; 788334 5 apavlov 2012-12-11 05:01:57 -0800 Committed r137295: <http://trac.webkit.org/changeset/137295> 178760 2012-12-11 03:01:22 -0800 2012-12-11 04:21:24 -0800 Patch bug-104653-20121211145842.patch text/plain 5303 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTc3YzBmYzAzNTY2NWY5 ZDY0ODI0ZGI4YzgyMGYxNWJhYjU4NmQ4Yy4uMTMwMzhjMGJlNzZkZjRhMTBiNTI4ZTQ1NmNlNDY4 MmQ5MmI4YTRlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTExICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogRHVwbGljYXRlIGVtdWxhdGVkIHRvdWNoIGV2ZW50cyBpbiBpZnJhbWUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDY1MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN5bnRoZXRpYyB0b3VjaCBl dmVudHMgc2hvdWxkIGJlIGRpc3BhdGNoZWQgb25seSBvbiB0aGUgZnJhbWUgY29udGFpbmluZyBp dHMgdGFyZ2V0LCBub3Qgb24gaXRzIGFuY2VzdG9yIGZyYW1lcywKKyAgICAgICAgdXAgdG8gdGhl IHRvcCBmcmFtZS4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZGlzcGF0Y2hTeW50aGV0aWNUb3VjaEV2ZW50SWZFbmFi bGVkKToKKyAgICAgICAgICBEbyBub3QgZGlzcGF0Y2ggYSBzeW50aGV0aWMgdG91Y2ggZXZlbnQg b24gdGhlIGN1cnJlbnQgZnJhbWUgaWYgaXRzIHRhcmdldCBpcyBpbiBhIHN1YmZyYW1lLgorCiAy MDEyLTEyLTExICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCBidWlsZCBmaXggYWZ0ZXIgcjEzNzI0My4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmNwcAppbmRleCA1Nzc1NjRiODRmZDI1NWZjNTljZDhjNmMyOWU3NDYxMDgwYzA1 OTk5Li42MTNkMjZhNDk0ZWQxMGE1MDFkZDIzZDg1MTRmYzQyM2EyZjBiYzUyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC00MDU4LDYgKzQwNTgsMTQgQEAgYm9vbCBFdmVu dEhhbmRsZXI6OmRpc3BhdGNoU3ludGhldGljVG91Y2hFdmVudElmRW5hYmxlZChjb25zdCBQbGF0 Zm9ybU1vdXNlRXZlbnQKICAgICBpZiAoZXZlbnRUeXBlID09IFBsYXRmb3JtRXZlbnQ6Ok1vdXNl TW92ZWQgJiYgIW1fdG91Y2hQcmVzc2VkKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBI aXRUZXN0UmVxdWVzdCByZXF1ZXN0KEhpdFRlc3RSZXF1ZXN0OjpBY3RpdmUpOworICAgIExheW91 dFBvaW50IGRvY3VtZW50UG9pbnQgPSBkb2N1bWVudFBvaW50Rm9yV2luZG93UG9pbnQobV9mcmFt ZSwgZXZlbnQucG9zaXRpb24oKSk7CisgICAgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyBt ZXYgPSBtX2ZyYW1lLT5kb2N1bWVudCgpLT5wcmVwYXJlTW91c2VFdmVudChyZXF1ZXN0LCBkb2N1 bWVudFBvaW50LCBldmVudCk7CisKKyAgICBSZWZQdHI8RnJhbWU+IHN1YmZyYW1lID0gc3ViZnJh bWVGb3JIaXRUZXN0UmVzdWx0KG1ldik7CisgICAgaWYgKHN1YmZyYW1lICYmIHN1YmZyYW1lLmdl dCgpICE9IG1fZnJhbWUpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIFN5bnRoZXRpY1Np bmdsZVRvdWNoRXZlbnQgdG91Y2hFdmVudChldmVudCk7CiAgICAgcmV0dXJuIGhhbmRsZVRvdWNo RXZlbnQodG91Y2hFdmVudCk7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWFiMzU3MGMwYjg5M2NmMzk5MTYwYTFmODc4 MGU3NjZmMWUyYzgzYS4uYzhmMjliMDM3NjZiZmU4OWY4Zjc0OTQ3NTc2Mjk2ZDBmZjVmMmM0NyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTExICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRHVwbGljYXRlIGVt dWxhdGVkIHRvdWNoIGV2ZW50cyBpbiBpZnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDY1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0ZXN0IGluY29ycmVjdGx5IGV4cGVjdGVkIHR3byBz eW50aGV0aWMgdG91Y2hlbmQgZXZlbnRzIGZyb20gYW4gaWZyYW1lLAorICAgICAgICB3aGlsZSBv bmx5IG9uZSB0b3VjaHN0YXJ0IGFuZCBvbmUgdG91Y2hlbmQgc2hvdWxkIGJlIGRpc3BhdGNoZWQu CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9lbXVsYXRlZC10b3VjaC1pZnJhbWUtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZXZlbnRzL3RvdWNoL2VtdWxhdGVkLXRvdWNoLWlm cmFtZS5odG1sOgorICAgICAgICAqIGZhc3QvZXZlbnRzL3RvdWNoL3Jlc291cmNlcy9lbXVsYXRl ZC10b3VjaC1pZnJhbWUyLmh0bWw6CisKIDIwMTItMTItMTAgIE5vZWwgR29yZG9uICA8bm9lbC5n b3Jkb25AZ21haWwuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gVW5yZXZpZXdlZCBnYXJkZW5p bmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2VtdWxhdGVkLXRv dWNoLWlmcmFtZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9l bXVsYXRlZC10b3VjaC1pZnJhbWUtZXhwZWN0ZWQudHh0CmluZGV4IGQyZjRhMDM3ODU5YzA5M2M2 ZDE3ZjM3OGQzYmM4OWZhMzdlOTZiZjQuLmNmOGU2YmQ3MGExN2RmZmM0YzJhNzc4ZDZiMGY1NDgz Zjg4MzdkN2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2VtdWxh dGVkLXRvdWNoLWlmcmFtZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvdG91Y2gvZW11bGF0ZWQtdG91Y2gtaWZyYW1lLWV4cGVjdGVkLnR4dApAQCAtMSw1ICsxLDUg QEAKIAogVGVzdCB0b3VjaGVuZCBldmVudHMgYXJlIGVtdWxhdGVkIGluIGlmcmFtZXMgY29ycmVj dGx5LgogCi1GaW5hbCB0b3VjaGVuZCAodGVzdCB3aWxsIHRpbWUgb3V0IGlmIGJyb2tlbikKK3Rv dWNoZW5kICh0ZXN0IHdpbGwgdGltZSBvdXQgaWYgYnJva2VuKQogCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9lbXVsYXRlZC10b3VjaC1pZnJhbWUuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2VtdWxhdGVkLXRvdWNoLWlmcmFtZS5odG1sCmlu ZGV4IDBkODE5MTFkMjMwY2M1MzRiMzI2ZTBlOGE0Y2RmYWI3NWUzMmQ5YWUuLjg4NzFjZDYxNmI1 ZGNkMTAxYTg4MjE2N2M1ZGJlNmE5MmUyY2VhY2MgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL3RvdWNoL2VtdWxhdGVkLXRvdWNoLWlmcmFtZS5odG1sCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2VtdWxhdGVkLXRvdWNoLWlmcmFtZS5odG1sCkBAIC02LDE1 ICs2LDI3IEBACiA8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KIDxzY3JpcHQgdHlwZT0idGV4dC9q YXZhc2NyaXB0Ij4KIAotdmFyIGV2ZW50Q291bnQgPSAwOwotdmFyIEVYUEVDVEVEX0VWRU5UX0NP VU5UID0gMjsKK3ZhciB0b3VjaHN0YXJ0Q291bnQgPSAwOwordmFyIEVYUEVDVEVEX1RPVUNIU1RB UlRfQ09VTlQgPSAxOwordmFyIHNob3VsZEJhaWw7CiAKIGZ1bmN0aW9uIHRlc3RDb21wbGV0ZSgp CiB7Ci0gICAgaWYgKCsrZXZlbnRDb3VudCA9PT0gRVhQRUNURURfRVZFTlRfQ09VTlQpIHsKLSAg ICAgICAgZGVidWcoIkZpbmFsIHRvdWNoZW5kICh0ZXN0IHdpbGwgdGltZSBvdXQgaWYgYnJva2Vu KSIpOwotICAgICAgICB3aW5kb3cudGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgaWYgKHNo b3VsZEJhaWwpCisgICAgICAgIHJldHVybjsKKworICAgIGlmICh0b3VjaHN0YXJ0Q291bnQgPiBF WFBFQ1RFRF9UT1VDSFNUQVJUX0NPVU5UKSB7CisgICAgICAgIGRlYnVnKCJ0b3VjaHN0YXJ0IGZp cmVkIGZvciB0aGUgdG9wIGZyYW1lLCB0b28sIGJ1dCBzaG91bGQgb25seSBmaXJlIGZvciB0aGUg aWZyYW1lISIpOworICAgICAgICBzaG91bGRCYWlsID0gdHJ1ZTsKICAgICB9CisKKyAgICBkZWJ1 ZygidG91Y2hlbmQgKHRlc3Qgd2lsbCB0aW1lIG91dCBpZiBicm9rZW4pIik7CisgICAgd2luZG93 LnRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfQorCitmdW5jdGlvbiBoYW5kbGVUb3VjaHN0YXJ0 KCkKK3sKKyAgICArK3RvdWNoc3RhcnRDb3VudDsKIH0KIAogZnVuY3Rpb24gcnVuVGVzdCgpIHsK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL3Jlc291cmNlcy9lbXVs YXRlZC10b3VjaC1pZnJhbWUyLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9y ZXNvdXJjZXMvZW11bGF0ZWQtdG91Y2gtaWZyYW1lMi5odG1sCmluZGV4IGE0MDI3ZTNlZDJkZmFj ODQ5ZDg1MWMxYzM3YTlkYWIwMzA3MGJlZDIuLmZkODgzMWQ0MDM2ZDdiYzgyMGJiNjkzYWJhYzll NDU4NWYxZjUwMDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL3Jl c291cmNlcy9lbXVsYXRlZC10b3VjaC1pZnJhbWUyLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9ldmVudHMvdG91Y2gvcmVzb3VyY2VzL2VtdWxhdGVkLXRvdWNoLWlmcmFtZTIuaHRtbApAQCAt Myw2ICszLDcgQEAKIDxkaXYgaWQ9J215ZGl2JyBzdHlsZT0nd2lkdGg6MTAwcHg7aGVpZ2h0OjEw MHB4O3Bvc2l0aW9uOmFic29sdXRlO3RvcDowcHg7IGxlZnQ6MHB4OyBiYWNrZ3JvdW5kLWNvbG9y OmJsdWU7Jz48L2Rpdj4KIDxzY3JpcHQgdHlwZT0ndGV4dC9qYXZhc2NyaXB0Jz4KIHZhciBteURp diA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdteWRpdicpOworbXlEaXYuYWRkRXZlbnRMaXN0 ZW5lcigndG91Y2hzdGFydCcsIGZ1bmN0aW9uKCkgeyBwYXJlbnQuaGFuZGxlVG91Y2hzdGFydCgp OyB9LCBmYWxzZSk7CiBteURpdi5hZGRFdmVudExpc3RlbmVyKCd0b3VjaGVuZCcsIGZ1bmN0aW9u KCkgeyBwYXJlbnQudGVzdENvbXBsZXRlKCk7IH0sIGZhbHNlKTsKIDwvc2NyaXB0PgogPC9ib2R5 Pgo=