10465 2006-08-17 12:48:46 -0700 General WebKit Linux build fixes 2006-08-18 07:07:33 -0700 1 1 1 Unclassified WebKit WebKit Misc. 420+ Other OS X 10.4 RESOLVED FIXED P2 Normal --- 1 zimmermann zimmermann kkowalczyk oldest_to_newest 52852 0 zimmermann 2006-08-17 12:48:46 -0700 Building WebKit on Linux (gcc-4.1.0) highlights some problems: * math.h includes needed in SVG* files * RenderStyle.h has a problem with a BindingURI cast (to 0) * Superflous Quartz includes in kcanvas And a FrameQt friend declaration is needed in Frame.h - no bug but needed for the Qt integration. 52853 1 10103 zimmermann 2006-08-17 12:51:18 -0700 Created attachment 10103 Initial patch 52898 2 10103 eric 2006-08-18 02:23:11 -0700 Comment on attachment 10103 Initial patch + SET_VAR(css3NonInheritedData, bindingURI, (BindingURI*) 0); confuses me. -#include "KCanvasMaskerQuartz.h" #include "KCanvasRenderingStyle.h" -#include "KCanvasResourcesQuartz.h" was a mistake on my part, sorry. However, are we sure this won't break the mac build? Assuming this doesn't break the mac build, r=me. 52901 3 zimmermann 2006-08-18 02:31:38 -0700 (In reply to comment #2) > (From update of attachment 10103 [edit]) > + SET_VAR(css3NonInheritedData, bindingURI, (BindingURI*) 0); > > confuses me. It also confused me & maciej - I tried 0L, NULL. Though there seems an overloading problem, at least visible with gcc-4.1 on linux. This fixes it though... > > -#include "KCanvasMaskerQuartz.h" > #include "KCanvasRenderingStyle.h" > -#include "KCanvasResourcesQuartz.h" > > was a mistake on my part, sorry. However, are we sure this won't break the mac > build? > > Assuming this doesn't break the mac build, r=me. > Nope. Rob built & ran the regression tests with all of my patches yesterday... Thanks for your time Eric! 52919 4 ddkilzer 2006-08-18 06:53:13 -0700 Landed by rwlbuis in r15932. 52923 5 ddkilzer 2006-08-18 07:07:33 -0700 *** Bug 10477 has been marked as a duplicate of this bug. *** 10103 2006-08-17 12:51:18 -0700 2006-08-18 02:23:11 -0700 Initial patch general-build-fixes.diff text/plain 5233 zimmermann SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShSZXZpc2lvbiAxNTkyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCShBcmJlaXRza29waWUpCkBA IC0xLDUgKzEsMjQgQEAKIDIwMDYtMDgtMTcgIE5pa29sYXMgWmltbWVybWFubiAgPHppbW1lcm1h bm5Aa2RlLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXhlczogaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQ2NQorICAgICAgICBHZW5lcmFsIFdlYktpdCBMaW51eCBidWlsZCBmaXhlcy4KKworICAg ICAgICAqIGtjYW52YXMvS0NhbnZhc0ZpbHRlcnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6b3Bl cmF0b3I8PCk6CisgICAgICAgICoga2NhbnZhcy9SZW5kZXJTVkdJbWFnZS5jcHA6CisgICAgICAg ICoga3N2ZzIvY3NzL1NWR0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAqIGtzdmcyL3N2 Zy9TVkdBbmltYXRlQ29sb3JFbGVtZW50LmNwcDoKKyAgICAgICAgKiBrc3ZnMi9zdmcvU1ZHTWFz a0VsZW1lbnQuY3BwOgorICAgICAgICAqIGtzdmcyL3N2Zy9TVkdQYXR0ZXJuRWxlbWVudC5jcHA6 CisgICAgICAgICogcGFnZS9GcmFtZS5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJTdHls ZS5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU3R5bGU6OmRlbGV0ZUJpbmRpbmdVUklzKToK KyAgICAgICAgKiB4bWwvRE9NUGFyc2VyLmNwcDoKKworMjAwNi0wOC0xNyAgTmlrb2xhcyBaaW1t ZXJtYW5uICA8emltbWVybWFubkBrZGUub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVy cy4KIAogICAgICAgICBGaXhlczogaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3df YnVnLmNnaT9pZD0xMDQ0NwpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU3R5bGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTdHlsZS5oCShSZXZpc2lvbiAx NTkyNCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclN0eWxlLmgJKEFyYmVpdHNrb3BpZSkK QEAgLTE1MzYsNyArMTUzNiw3IEBACiAjaWZuZGVmIEtIVE1MX05PX1hCTAogICAgIHZvaWQgZGVs ZXRlQmluZGluZ1VSSXMoKSB7IAogICAgICAgICBkZWxldGUgY3NzM05vbkluaGVyaXRlZERhdGEt PmJpbmRpbmdVUkk7IAotICAgICAgICBTRVRfVkFSKGNzczNOb25Jbmhlcml0ZWREYXRhLCBiaW5k aW5nVVJJLCAwKTsKKyAgICAgICAgU0VUX1ZBUihjc3MzTm9uSW5oZXJpdGVkRGF0YSwgYmluZGlu Z1VSSSwgKEJpbmRpbmdVUkkqKSAwKTsKICAgICB9CiAgICAgdm9pZCBpbmhlcml0QmluZGluZ1VS SXMoQmluZGluZ1VSSSogb3RoZXIpIHsKICAgICAgICAgU0VUX1ZBUihjc3MzTm9uSW5oZXJpdGVk RGF0YSwgYmluZGluZ1VSSSwgb3RoZXItPmNvcHkoKSk7CkluZGV4OiBXZWJDb3JlL2tjYW52YXMv UmVuZGVyU1ZHSW1hZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUva2NhbnZhcy9SZW5kZXJT VkdJbWFnZS5jcHAJKFJldmlzaW9uIDE1OTI0KQorKysgV2ViQ29yZS9rY2FudmFzL1JlbmRlclNW R0ltYWdlLmNwcAkoQXJiZWl0c2tvcGllKQpAQCAtMjYsOSArMjYsNyBAQAogCiAjaW5jbHVkZSAi QXR0ci5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgotI2luY2x1ZGUgIktDYW52YXNN YXNrZXJRdWFydHouaCIKICNpbmNsdWRlICJLQ2FudmFzUmVuZGVyaW5nU3R5bGUuaCIKLSNpbmNs dWRlICJLQ2FudmFzUmVzb3VyY2VzUXVhcnR6LmgiCiAjaW5jbHVkZSAiS1JlbmRlcmluZ0Rldmlj ZS5oIgogI2luY2x1ZGUgIlNWR0FuaW1hdGVkTGVuZ3RoLmgiCiAjaW5jbHVkZSAiU1ZHQW5pbWF0 ZWRQcmVzZXJ2ZUFzcGVjdFJhdGlvLmgiCkluZGV4OiBXZWJDb3JlL2tjYW52YXMvS0NhbnZhc0Zp bHRlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUva2NhbnZhcy9LQ2FudmFzRmlsdGVycy5j cHAJKFJldmlzaW9uIDE1OTI0KQorKysgV2ViQ29yZS9rY2FudmFzL0tDYW52YXNGaWx0ZXJzLmNw cAkoQXJiZWl0c2tvcGllKQpAQCAtMzAsNiArMzAsNyBAQAogI2luY2x1ZGUgIlRleHRTdHJlYW0u aCIKICNpbmNsdWRlICJLQ2FudmFzVHJlZURlYnVnLmgiCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlv bnMuaD4KKyNpbmNsdWRlIDxtYXRoLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMjQy LDYgKzI0Myw3IEBACiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDVF9UQUJMRToK ICAgICAgICAgY2FzZSBDVF9ESVNDUkVURToKKyAgICAgICAgewogICAgICAgICAgICAgdHMgPDwg IiBbdGFibGUgdmFsdWVzPSI7CiAgICAgICAgICAgICBWZWN0b3I8ZmxvYXQ+Ojpjb25zdF9pdGVy YXRvciBpdHI9ZnVuYy50YWJsZVZhbHVlcy5iZWdpbigpOwogICAgICAgICAgICAgaWYgKGl0ciAh PSBmdW5jLnRhYmxlVmFsdWVzLmVuZCgpKSB7CkBAIC0yNTIsNiArMjU0LDcgQEAKICAgICAgICAg ICAgIH0KICAgICAgICAgICAgIHRzIDw8ICJdIjsKICAgICAgICAgICAgIGJyZWFrOworICAgICAg ICB9CiAgICAgICAgIGNhc2UgQ1RfTElORUFSOgogICAgICAgICAgICAgdHMgPDwgIiBbc2xvcGU9 IiA8PCBmdW5jLnNsb3BlIDw8ICJdIgogICAgICAgICAgICAgICAgPDwgIiBbaW50ZXJjZXB0PSIg PDwgZnVuYy5pbnRlcmNlcHQgPDwgIl0iOwpJbmRleDogV2ViQ29yZS9rc3ZnMi9zdmcvU1ZHQW5p bWF0ZUNvbG9yRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9rc3ZnMi9zdmcvU1ZH QW5pbWF0ZUNvbG9yRWxlbWVudC5jcHAJKFJldmlzaW9uIDE1OTI0KQorKysgV2ViQ29yZS9rc3Zn Mi9zdmcvU1ZHQW5pbWF0ZUNvbG9yRWxlbWVudC5jcHAJKEFyYmVpdHNrb3BpZSkKQEAgLTI4LDYg KzI4LDcgQEAKICNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIlNWR0RvY3VtZW50RXh0 ZW5zaW9ucy5oIgogI2luY2x1ZGUgIlNWR1NWR0VsZW1lbnQuaCIKKyNpbmNsdWRlIDxtYXRoLmg+ CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApJbmRleDogV2ViQ29yZS9rc3ZnMi9zdmcvU1ZHTWFz a0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUva3N2ZzIvc3ZnL1NWR01hc2tFbGVt ZW50LmNwcAkoUmV2aXNpb24gMTU5MjQpCisrKyBXZWJDb3JlL2tzdmcyL3N2Zy9TVkdNYXNrRWxl bWVudC5jcHAJKEFyYmVpdHNrb3BpZSkKQEAgLTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlICJrc3Zn LmgiCiAjaW5jbHVkZSAiQXR0ci5oIgogI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyNpbmNsdWRl IDxtYXRoLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApJbmRleDogV2ViQ29yZS9rc3ZnMi9z dmcvU1ZHUGF0dGVybkVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUva3N2ZzIvc3Zn L1NWR1BhdHRlcm5FbGVtZW50LmNwcAkoUmV2aXNpb24gMTU5MjQpCisrKyBXZWJDb3JlL2tzdmcy L3N2Zy9TVkdQYXR0ZXJuRWxlbWVudC5jcHAJKEFyYmVpdHNrb3BpZSkKQEAgLTQ2LDYgKzQ2LDcg QEAKICNpbmNsdWRlICJTVkdUcmFuc2Zvcm1hYmxlLmgiCiAjaW5jbHVkZSAia3N2Zy5oIgogI2lu Y2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyNpbmNsdWRlIDxtYXRoLmg+CiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIApJbmRleDogV2ViQ29yZS9rc3ZnMi9jc3MvU1ZHQ1NTU3R5bGVTZWxlY3Rvci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9rc3ZnMi9jc3MvU1ZHQ1NTU3R5bGVTZWxlY3Rvci5jcHAJ KFJldmlzaW9uIDE1OTI0KQorKysgV2ViQ29yZS9rc3ZnMi9jc3MvU1ZHQ1NTU3R5bGVTZWxlY3Rv ci5jcHAJKEFyYmVpdHNrb3BpZSkKQEAgLTQzLDYgKzQzLDcgQEAKICNpbmNsdWRlICJrc3ZnY3Nz dmFsdWVzLmgiCiAjaW5jbHVkZSAia3N2Z2Nzc3Byb3BlcnRpZXMuaCIKICNpbmNsdWRlIDxzdGRs aWIuaD4KKyNpbmNsdWRlIDxtYXRoLmg+CiAKICNkZWZpbmUgSEFORExFX0lOSEVSSVQocHJvcCwg UHJvcCkgXAogaWYgKGlzSW5oZXJpdCkgXApJbmRleDogV2ViQ29yZS94bWwvRE9NUGFyc2VyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3htbC9ET01QYXJzZXIuY3BwCShSZXZpc2lvbiAxNTky NCkKKysrIFdlYkNvcmUveG1sL0RPTVBhcnNlci5jcHAJKEFyYmVpdHNrb3BpZSkKQEAgLTIxLDcg KzIxLDcgQEAKICNpbmNsdWRlICJET01QYXJzZXIuaCIKIAogI2luY2x1ZGUgIkRPTUltcGxlbWVu dGF0aW9uLmgiCi0jaW5jbHVkZSAiU3RyaW5nLmgiCisjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcu aCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIApJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1l LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0ZyYW1lLmgJKFJldmlzaW9uIDE1OTI0KQor KysgV2ViQ29yZS9wYWdlL0ZyYW1lLmgJKEFyYmVpdHNrb3BpZSkKQEAgLTc4NCw2ICs3ODQsOSBA QAogI2lmIFBMQVRGT1JNKEdESykKICAgZnJpZW5kIGNsYXNzIEZyYW1lR2RrOwogI2VuZGlmCisj aWYgUExBVEZPUk0oUVQpCisgIGZyaWVuZCBjbGFzcyBGcmFtZVF0OworI2VuZGlmCiAKICAgUmVu ZGVyT2JqZWN0OjpOb2RlSW5mbyBub2RlSW5mb0F0UG9pbnQoY29uc3QgSW50UG9pbnQmLCBib29s IGFsbG93U2hhZG93Q29udGVudCk7CiAgIGJvb2wgaGFzU2VsZWN0aW9uKCk7Cg==