104629 2012-12-10 21:46:40 -0800 [EFL][WK2] MiniBrowser is not built 2012-12-11 05:29:51 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song gyuyoung.kim laszlo.gombos lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 788019 0 jinwoo7.song 2012-12-10 21:46:40 -0800 Currently, MiniBrowser is not built therefore the binary is not generated. As we are finding elementary package in Tools/MiniBrowser/efl/CMakeList.txt since r137203, we need to check the package finding in the same place not in the Tools/CMakeList.txt. 788021 1 178708 jinwoo7.song 2012-12-10 21:48:56 -0800 Created attachment 178708 Patch 788248 2 178708 gyuyoung.kim 2012-12-11 02:59:02 -0800 Comment on attachment 178708 Patch I think this is side effect by r137203. I think we need to build WebKit EFL on Tizen as well. So, LGTM. 788260 3 178708 gyuyoung.kim 2012-12-11 03:11:54 -0800 Comment on attachment 178708 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178708&action=review > Tools/MiniBrowser/efl/CMakeLists.txt:54 > +if (ELEMENTARY_FOUND) BTW, is this guard needed ? If elementary can't be found, main.c in MiniBrowser won't be compiled. 788261 4 178708 webkit.review.bot 2012-12-11 03:11:55 -0800 Comment on attachment 178708 Patch Clearing flags on attachment: 178708 Committed r137279: <http://trac.webkit.org/changeset/137279> 788262 5 webkit.review.bot 2012-12-11 03:11:59 -0800 All reviewed patches have been landed. Closing bug. 788268 6 jinwoo7.song 2012-12-11 03:23:13 -0800 (In reply to comment #3) > (From update of attachment 178708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178708&action=review > > > Tools/MiniBrowser/efl/CMakeLists.txt:54 > > +if (ELEMENTARY_FOUND) > > BTW, is this guard needed ? If elementary can't be found, main.c in MiniBrowser won't be compiled. I added that guard to prevent the build error although the elementary package is not found. 788343 7 laszlo.gombos 2012-12-11 05:29:51 -0800 Thanks for the follow-up fix, it looks good to me ! 178708 2012-12-10 21:48:56 -0800 2012-12-11 03:11:55 -0800 Patch bug-104629-20121211144617.patch text/plain 2208 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MjM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ1NzNjZGQ3MGJlZWY5NWEzYzgxNjQxZmFjYjRhNzEy MTM0NjkzNC4uMGRhNmEwNDczZWFkYTg2NDQ3MWI5MzE1M2Q2NjRhYTg2ZTRhYjM3NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEyLTEwICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXVtXSzJdIE1pbmlCcm93c2VyIGlzIG5vdCBidWlsdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NjI5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgd2UgYXJlIGZpbmRpbmcg YW4gZWxlbWVudGFyeSBwYWNrYWdlIGluIFRvb2xzL01pbmlCcm93c2VyL2VmbC9DTWFrZUxpc3Qu dHh0IHNpbmNlIHIxMzcyMDMsCisgICAgICAgIHdlIG5lZWQgdG8gY2hlY2sgaWYgdGhlIHBhY2th Z2UgaXMgZm91bmQgaW4gdGhlIHNhbWUgcGxhY2Ugbm90IGluIHRoZSBUb29scy9DTWFrZUxpc3Qu dHh0LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogTWluaUJyb3dzZXIv ZWZsL0NNYWtlTGlzdHMudHh0OgorCiAyMDEyLTEyLTEwICBEaXJrIFByYW5rZSAgPGRwcmFua2VA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIGNoYW5nZSAtLW5vLWxhdW5jaC1zYWZhcmkgdG8gLS1u by1zaG93LXJlc3VsdHMgaW4gc2NyaXB0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ01ha2VMaXN0cy50 eHQgYi9Ub29scy9DTWFrZUxpc3RzLnR4dAppbmRleCBlNTIxMDVjMmM3MDUzNDBiZmJhM2ViNWNi NWI3MDAyOTJmZDFiMzFjLi5lNTM5NmEzYmI4MDVjZTY2M2NjMGZmZmJkZTAwNDU3MjExMjI1ZWRi IDEwMDY0NAotLS0gYS9Ub29scy9DTWFrZUxpc3RzLnR4dAorKysgYi9Ub29scy9DTWFrZUxpc3Rz LnR4dApAQCAtMTAsNyArMTAsNyBAQCBpZiAoIiR7UE9SVH0iIFNUUkVRVUFMICJFZmwiKQogICAg ICAgICBhZGRfc3ViZGlyZWN0b3J5KEVXZWJMYXVuY2hlcikKICAgICBlbmRpZiAoKQogCi0gICAg aWYgKEVOQUJMRV9XRUJLSVQyIEFORCBFTEVNRU5UQVJZX0ZPVU5EKQorICAgIGlmIChFTkFCTEVf V0VCS0lUMikKICAgICAgICAgYWRkX3N1YmRpcmVjdG9yeShNaW5pQnJvd3Nlci9lZmwpCiAgICAg ZW5kaWYgKCkKICAgICBhZGRfc3ViZGlyZWN0b3J5KER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2Fw ZVBsdWdJbikKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9DTWFrZUxpc3RzLnR4 dCBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9DTWFrZUxpc3RzLnR4dAppbmRleCA5NjU4NmJjY2I0 NjdkMTAzOTExNjBlZTZjYWJkNmEyOTY1NjE4OTk3Li5hZjEzNzYzN2FhZGZjZjE1NzU4NTQzMmY3 NWQ5ZGE5NGZhNjA4Yzc3IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvQ01ha2VM aXN0cy50eHQKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL0NNYWtlTGlzdHMudHh0CkBAIC01 MSw4ICs1MSw5IEBAIHNldChNaW5pQnJvd3Nlcl9MSUJSQVJJRVMKIAogYWRkX2RlZmluaXRpb25z KC1EVEhFTUVfRElSPVwiJHtUSEVNRV9CSU5BUllfRElSfVwiKQogCi1pbmNsdWRlX2RpcmVjdG9y aWVzKCR7TWluaUJyb3dzZXJfSU5DTFVERV9ESVJFQ1RPUklFU30pCi0KLWFkZF9leGVjdXRhYmxl KE1pbmlCcm93c2VyICR7TWluaUJyb3dzZXJfU09VUkNFU30pCi10YXJnZXRfbGlua19saWJyYXJp ZXMoTWluaUJyb3dzZXIgJHtNaW5pQnJvd3Nlcl9MSUJSQVJJRVN9KQotc2V0X3RhcmdldF9wcm9w ZXJ0aWVzKE1pbmlCcm93c2VyIFBST1BFUlRJRVMgRk9MREVSICJUb29scyIpCitpZiAoRUxFTUVO VEFSWV9GT1VORCkKKyAgICBpbmNsdWRlX2RpcmVjdG9yaWVzKCR7TWluaUJyb3dzZXJfSU5DTFVE RV9ESVJFQ1RPUklFU30pCisgICAgYWRkX2V4ZWN1dGFibGUoTWluaUJyb3dzZXIgJHtNaW5pQnJv d3Nlcl9TT1VSQ0VTfSkKKyAgICB0YXJnZXRfbGlua19saWJyYXJpZXMoTWluaUJyb3dzZXIgJHtN aW5pQnJvd3Nlcl9MSUJSQVJJRVN9KQorICAgIHNldF90YXJnZXRfcHJvcGVydGllcyhNaW5pQnJv d3NlciBQUk9QRVJUSUVTIEZPTERFUiAiVG9vbHMiKQorZW5kaWYgKCkK