104622 2012-12-10 18:27:21 -0800 CoreIPC: ArgumentEncoder should have an inline buffer. 2013-04-25 15:29:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 109367 1 kling kling andersca kling webkit.review.bot oldest_to_newest 787927 0 kling 2012-12-10 18:27:21 -0800 We could give ArgumentEncoder a little inline buffer for smaller messages to avoid churning the malloc heap. 787931 1 178684 kling 2012-12-10 18:30:09 -0800 Created attachment 178684 Proposed patch 788517 2 178684 webkit.review.bot 2012-12-11 09:42:27 -0800 Comment on attachment 178684 Proposed patch Clearing flags on attachment: 178684 Committed r137328: <http://trac.webkit.org/changeset/137328> 788518 3 webkit.review.bot 2012-12-11 09:42:30 -0800 All reviewed patches have been landed. Closing bug. 829161 4 webkit.review.bot 2013-02-09 19:45:09 -0800 Re-opened since this is blocked by bug 109367 178684 2012-12-10 18:30:09 -0800 2012-12-11 09:42:27 -0800 Proposed patch bug-104622.diff text/plain 4693 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZmNkNTVjLi40NDg0M2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMTItMTAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIENvcmVJUEM6IEFyZ3VtZW50RW5jb2RlciBzaG91bGQgaGF2ZSBhbiBpbmxpbmUgYnVmZmVy LgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMDQ2MjI+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgNEsgaW5saW5lIGJ1ZmZlciB0 byBDb3JlSVBDOjpBcmd1bWVudEVuY29kZXIgdG8gYXZvaWQgbWFsbG9jL2ZyZWUgY2h1cm4uCisg ICAgICAgIEl0IHdhcyBkb21pbmF0aW5nIHRoZSB0cmFuc2llbnQgYWxsb2NhdGlvbnMgZ3JhcGgg aW4gSW5zdHJ1bWVudHMuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5j b2Rlci5jcHA6CisgICAgICAgIChDb3JlSVBDOjpBcmd1bWVudEVuY29kZXI6OkFyZ3VtZW50RW5j b2Rlcik6CisgICAgICAgIChDb3JlSVBDOjpBcmd1bWVudEVuY29kZXI6Omdyb3cpOgorICAgICAg ICAqIFBsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmg6CisgICAgICAgIChDb3JlSVBD OjpBcmd1bWVudEVuY29kZXI6OmJ1ZmZlcik6CisgICAgICAgIChBcmd1bWVudEVuY29kZXIpOgor ICAgICAgICAoQ29yZUlQQzo6QXJndW1lbnRFbmNvZGVyOjp1c2VzSW5saW5lQnVmZmVyKToKKwog MjAxMi0xMi0xMCAgRWR1YXJkbyBMaW1hIE1pdGV2ICA8ZWxpbWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBFeHBvc2UgSGl0VGVzdFJlc3VsdDo6c2Nyb2xsYmFyKCkgY29uZGl0aW9uIGlu IEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVu dEVuY29kZXIuY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudEVu Y29kZXIuY3BwCmluZGV4IDk0ODAxMTMuLmJkZWYwZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHAKQEAgLTM5LDkgKzM5LDgg QEAgUGFzc093blB0cjxBcmd1bWVudEVuY29kZXI+IEFyZ3VtZW50RW5jb2Rlcjo6Y3JlYXRlKCkK IAogQXJndW1lbnRFbmNvZGVyOjpBcmd1bWVudEVuY29kZXIoKQogICAgIDogbV9idWZmZXIoMCkK LSAgICAsIG1fYnVmZmVyUG9pbnRlcigwKQogICAgICwgbV9idWZmZXJTaXplKDApCi0gICAgLCBt X2J1ZmZlckNhcGFjaXR5KDApCisgICAgLCBtX2J1ZmZlckNhcGFjaXR5KGlubGluZUJ1ZmZlclNp emUpCiB7CiB9CiAKQEAgLTY4LDI3ICs2NywzMSBAQCB1aW50OF90KiBBcmd1bWVudEVuY29kZXI6 Omdyb3codW5zaWduZWQgYWxpZ25tZW50LCBzaXplX3Qgc2l6ZSkKICAgICAKICAgICBpZiAoYWxp Z25lZFNpemUgKyBzaXplID4gbV9idWZmZXJDYXBhY2l0eSkgewogICAgICAgICBzaXplX3QgbmV3 Q2FwYWNpdHkgPSBzdGQ6Om1heChhbGlnbmVkU2l6ZSArIHNpemUsIHN0ZDo6bWF4KHN0YXRpY19j YXN0PHNpemVfdD4oMzIpLCBtX2J1ZmZlckNhcGFjaXR5ICsgbV9idWZmZXJDYXBhY2l0eSAvIDQg KyAxKSk7Ci0gICAgICAgIC8vIFVzZSBzeXN0ZW0gbWFsbG9jIC8gcmVhbGxvYyBpbnN0ZWFkIG9m IGZhc3RNYWxsb2MgZHVlIHRvIAotICAgICAgICAvLyBmYXN0TWFsbG9jIHVzaW5nIE1BRFZfRlJF RV9SRVVTQUJMRSB3aGljaCBkb2Vzbid0IHdvcmsgd2l0aAotICAgICAgICAvLyBtYWNoIG1lc3Nh Z2VzIHdpdGggT09MIG1lc3NhZ2UgYW5kIE1BQ0hfTVNHX1ZJUlRVQUxfQ09QWS4KLSAgICAgICAg Ly8gU3lzdGVtIG1hbGxvYyBhbHNvIGNhbGxzIG1hZHZpc2UoTUFEVl9GUkVFX1JFVVNBQkxFKSBi dXQgYWZ0ZXIgZmlyc3QKLSAgICAgICAgLy8gY2hlY2tpbmcgdmlhIG1hZHZpc2UoQ0FOX1JFVVNF KSB0aGF0IGl0IHdpbGwgc3VjY2VlZC4gU2hvdWxkIHRoaXMKLSAgICAgICAgLy8gYmVoYXZpb3Ig Y2hhbmdlIHdlJ2xsIG5lZWQgdG8gcmV2aXNpdCB0aGlzLgotICAgICAgICBpZiAoIW1fYnVmZmVy KQotICAgICAgICAgICAgbV9idWZmZXIgPSBzdGF0aWNfY2FzdDx1aW50OF90Kj4obWFsbG9jKG5l d0NhcGFjaXR5KSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1fYnVmZmVyID0gc3RhdGlj X2Nhc3Q8dWludDhfdCo+KHJlYWxsb2MobV9idWZmZXIsIG5ld0NhcGFjaXR5KSk7Ci0KLSAgICAg ICAgaWYgKCFtX2J1ZmZlcikKLSAgICAgICAgICAgIENSQVNIKCk7CisKKyAgICAgICAgaWYgKG5l d0NhcGFjaXR5ID4gaW5saW5lQnVmZmVyU2l6ZSkgeworICAgICAgICAgICAgLy8gVXNlIHN5c3Rl bSBtYWxsb2MgLyByZWFsbG9jIGluc3RlYWQgb2YgZmFzdE1hbGxvYyBkdWUgdG8KKyAgICAgICAg ICAgIC8vIGZhc3RNYWxsb2MgdXNpbmcgTUFEVl9GUkVFX1JFVVNBQkxFIHdoaWNoIGRvZXNuJ3Qg d29yayB3aXRoCisgICAgICAgICAgICAvLyBtYWNoIG1lc3NhZ2VzIHdpdGggT09MIG1lc3NhZ2Ug YW5kIE1BQ0hfTVNHX1ZJUlRVQUxfQ09QWS4KKyAgICAgICAgICAgIC8vIFN5c3RlbSBtYWxsb2Mg YWxzbyBjYWxscyBtYWR2aXNlKE1BRFZfRlJFRV9SRVVTQUJMRSkgYnV0IGFmdGVyIGZpcnN0Cisg ICAgICAgICAgICAvLyBjaGVja2luZyB2aWEgbWFkdmlzZShDQU5fUkVVU0UpIHRoYXQgaXQgd2ls bCBzdWNjZWVkLiBTaG91bGQgdGhpcworICAgICAgICAgICAgLy8gYmVoYXZpb3IgY2hhbmdlIHdl J2xsIG5lZWQgdG8gcmV2aXNpdCB0aGlzLgorICAgICAgICAgICAgaWYgKCFtX2J1ZmZlcikKKyAg ICAgICAgICAgICAgICBtX2J1ZmZlciA9IHN0YXRpY19jYXN0PHVpbnQ4X3QqPihtYWxsb2MobmV3 Q2FwYWNpdHkpKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBtX2J1ZmZlciA9 IHN0YXRpY19jYXN0PHVpbnQ4X3QqPihyZWFsbG9jKG1fYnVmZmVyLCBuZXdDYXBhY2l0eSkpOwor CisgICAgICAgICAgICBpZiAoIW1fYnVmZmVyKQorICAgICAgICAgICAgICAgIENSQVNIKCk7CisK KyAgICAgICAgICAgIGlmICh1c2VzSW5saW5lQnVmZmVyKCkpCisgICAgICAgICAgICAgICAgbWVt Y3B5KG1fYnVmZmVyLCBtX2lubGluZUJ1ZmZlciwgbV9idWZmZXJDYXBhY2l0eSk7CisgICAgICAg IH0KIAogICAgICAgICBtX2J1ZmZlckNhcGFjaXR5ID0gbmV3Q2FwYWNpdHk7ICAgICAgICAKICAg ICB9CiAKICAgICBtX2J1ZmZlclNpemUgPSBhbGlnbmVkU2l6ZSArIHNpemU7Ci0gICAgbV9idWZm ZXJQb2ludGVyID0gbV9idWZmZXIgKyBhbGlnbmVkU2l6ZSArIHNpemU7Ci0gICAgCi0gICAgcmV0 dXJuIG1fYnVmZmVyICsgYWxpZ25lZFNpemU7CisgICAgcmV0dXJuIGJ1ZmZlcigpICsgYWxpZ25l ZFNpemU7CiB9CiAKIHZvaWQgQXJndW1lbnRFbmNvZGVyOjplbmNvZGVGaXhlZExlbmd0aERhdGEo Y29uc3QgdWludDhfdCogZGF0YSwgc2l6ZV90IHNpemUsIHVuc2lnbmVkIGFsaWdubWVudCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRFbmNvZGVy LmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5oCmlu ZGV4IDVmYTAwNmYuLjM5ODU3ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt L0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0v Q29yZUlQQy9Bcmd1bWVudEVuY29kZXIuaApAQCAtOTgsNyArOTgsNyBAQCBwdWJsaWM6CiAgICAg ICAgIHJldHVybiAqdGhpczsKICAgICB9CiAKLSAgICB1aW50OF90KiBidWZmZXIoKSBjb25zdCB7 IHJldHVybiBtX2J1ZmZlcjsgfQorICAgIHVpbnQ4X3QqIGJ1ZmZlcigpIHsgcmV0dXJuIHVzZXNJ bmxpbmVCdWZmZXIoKSA/IG1faW5saW5lQnVmZmVyIDogbV9idWZmZXI7IH0KICAgICBzaXplX3Qg YnVmZmVyU2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fYnVmZmVyU2l6ZTsgfQogCiAgICAgdm9pZCBh ZGRBdHRhY2htZW50KGNvbnN0IEF0dGFjaG1lbnQmKTsKQEAgLTEwOCwxNSArMTA4LDE4IEBAIHBy b3RlY3RlZDoKICAgICBBcmd1bWVudEVuY29kZXIoKTsKIAogcHJpdmF0ZToKKyAgICBzdGF0aWMg Y29uc3Qgc2l6ZV90IGlubGluZUJ1ZmZlclNpemUgPSA0MDk2OworICAgIGJvb2wgdXNlc0lubGlu ZUJ1ZmZlcigpIGNvbnN0IHsgcmV0dXJuIG1fYnVmZmVyQ2FwYWNpdHkgPD0gaW5saW5lQnVmZmVy U2l6ZTsgfQogICAgIHVpbnQ4X3QqIGdyb3codW5zaWduZWQgYWxpZ25tZW50LCBzaXplX3Qgc2l6 ZSk7CiAgICAgCiAgICAgdWludDhfdCogbV9idWZmZXI7Ci0gICAgdWludDhfdCogbV9idWZmZXJQ b2ludGVyOwogICAgIAogICAgIHNpemVfdCBtX2J1ZmZlclNpemU7CiAgICAgc2l6ZV90IG1fYnVm ZmVyQ2FwYWNpdHk7CiAKICAgICBWZWN0b3I8QXR0YWNobWVudD4gbV9hdHRhY2htZW50czsKKwor ICAgIHVpbnQ4X3QgbV9pbmxpbmVCdWZmZXJbaW5saW5lQnVmZmVyU2l6ZV07CiB9OwogCiB9IC8v IG5hbWVzcGFjZSBDb3JlSVBDCg==