104621 2012-12-10 18:25:26 -0800 Don't OSR exit just because a string is a rope 2012-12-10 21:24:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 787924 0 fpizlo 2012-12-10 18:25:26 -0800 Patch forthcoming. 787926 1 178681 fpizlo 2012-12-10 18:26:43 -0800 Created attachment 178681 the patch 788009 2 fpizlo 2012-12-10 21:24:00 -0800 Landed in http://trac.webkit.org/changeset/137247 178681 2012-12-10 18:26:43 -0800 2012-12-10 18:47:03 -0800 the patch strings.patch text/plain 7375 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM3MjM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDEyLTEyLTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RG9uJ3QgT1NSIGV4aXQganVzdCBiZWNhdXNlIGEgc3RyaW5nIGlzIGEgcm9wZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NjIxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2xpZ2h0IFN1blNwaWRlciBz cGVlZC11cC4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcDoKKyAgICAgICAg KEpTQzo6REZHOjpBYnN0cmFjdFN0YXRlOjpleGVjdXRlKToKKyAgICAgICAgKiBkZmcvREZHQXJy YXlNb2RlLmg6CisgICAgICAgIChKU0M6OkRGRzo6QXJyYXlNb2RlOjpnZXRJbmRleGVkUHJvcGVy dHlTdG9yYWdlTWF5VHJpZ2dlckdDKToKKyAgICAgICAgKEFycmF5TW9kZSk6CisgICAgICAgICog ZGZnL0RGR0NTRVBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpDU0VQaGFzZTo6cHV0U3Ry dWN0dXJlU3RvcmVFbGltaW5hdGlvbik6CisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuY3Bw OgorICAgICAgICAqIGRmZy9ERkdPcGVyYXRpb25zLmg6CisgICAgICAgICogZGZnL0RGR1NwZWN1 bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGls ZUdldEluZGV4ZWRQcm9wZXJ0eVN0b3JhZ2UpOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2 ZUpJVC5oOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjYWxsT3BlcmF0aW9u KToKKwogMjAxMi0xMi0xMCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkIGRpc3RjaGVjayBmaXguCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0U3RhdGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAJKHJldmlzaW9uIDEzNzIyNikK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE1OTgsMTYgKzE1OTgsNyBAQCBib29sIEFic3RyYWN0U3RhdGU6OmV4ZWN1 dGUodW5zaWduZWQgaW5kCiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIEdldEluZGV4 ZWRQcm9wZXJ0eVN0b3JhZ2U6IHsKLSAgICAgICAgc3dpdGNoIChub2RlLmFycmF5TW9kZSgpLnR5 cGUoKSkgewotICAgICAgICBjYXNlIEFycmF5OjpTdHJpbmc6Ci0gICAgICAgICAgICAvLyBTdHJp bmdzIGFyZSB3ZWlyZCAtIHdlIG1heSBzcGVjIGZhaWwgaWYgdGhlIHN0cmluZyB3YXMgYSByb3Bl LiBUaGF0IGlzIG9mIGNvdXJzZQotICAgICAgICAgICAgLy8gc3R1cGlkLCBhbmQgd2Ugc2hvdWxk IGZpeCB0aGF0LCBidXQgZm9yIG5vdyBsZXQncyBhdCBsZWFzdCBiZSBob25lc3QgYWJvdXQgaXQu Ci0gICAgICAgICAgICBub2RlLnNldENhbkV4aXQodHJ1ZSk7Ci0gICAgICAgICAgICBicmVhazsK LSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIG5vZGUuc2V0Q2FuRXhpdChmYWxzZSk7Ci0g ICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQorICAgICAgICBub2RlLnNldENhbkV4aXQoZmFs c2UpOwogICAgICAgICBmb3JOb2RlKG5vZGVJbmRleCkuY2xlYXIoKTsKICAgICAgICAgYnJlYWs7 IAogICAgIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2RlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcnJheU1vZGUuaAko cmV2aXNpb24gMTM3MjI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcnJheU1v ZGUuaAkod29ya2luZyBjb3B5KQpAQCAtMzgzLDYgKzM4MywxMSBAQCBwdWJsaWM6CiAgICAgICAg IH0KICAgICB9CiAgICAgCisgICAgYm9vbCBnZXRJbmRleGVkUHJvcGVydHlTdG9yYWdlTWF5VHJp Z2dlckdDKCkgY29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiB0eXBlKCkgPT0gQXJyYXk6OlN0 cmluZzsKKyAgICB9CisgICAgCiAgICAgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEFycmF5TW9kZSYg b3RoZXIpIGNvbnN0CiAgICAgewogICAgICAgICByZXR1cm4gdHlwZSgpID09IG90aGVyLnR5cGUo KQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDU0VQaGFzZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDU0VQaGFzZS5jcHAJKHJldmlz aW9uIDEzNzIyNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01NjQsNiArNTY0LDExIEBAIHByaXZhdGU6CiAgICAgICAgICAg ICBjYXNlIFJlYWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2U6CiAgICAgICAgICAgICAgICAgcmV0dXJu IE5vTm9kZTsKICAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgIGNhc2UgR2V0SW5kZXhlZFBy b3BlcnR5U3RvcmFnZToKKyAgICAgICAgICAgICAgICBpZiAobm9kZS5hcnJheU1vZGUoKS5nZXRJ bmRleGVkUHJvcGVydHlTdG9yYWdlTWF5VHJpZ2dlckdDKCkpCisgICAgICAgICAgICAgICAgICAg IHJldHVybiBOb05vZGU7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAg CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAg ICAgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3Bw CShyZXZpc2lvbiAxMzcyMjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJh dGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDYwLDYgKzE0NjAsMTQgQEAgY2hhciogREZH X09QRVJBVElPTiBvcGVyYXRpb25FbnN1cmVBcnJheQogICAgIHJldHVybiByZWludGVycHJldF9j YXN0PGNoYXIqPihvYmplY3QtPmVuc3VyZUFycmF5U3RvcmFnZShnbG9iYWxEYXRhKSk7CiB9CiAK K1N0cmluZ0ltcGwqIERGR19PUEVSQVRJT04gb3BlcmF0aW9uUmVzb2x2ZVJvcGUoRXhlY1N0YXRl KiBleGVjLCBKU1N0cmluZyogc3RyaW5nKQoreworICAgIEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0 YSA9IGV4ZWMtPmdsb2JhbERhdGEoKTsKKyAgICBOYXRpdmVDYWxsRnJhbWVUcmFjZXIgdHJhY2Vy KCZnbG9iYWxEYXRhLCBleGVjKTsKKworICAgIHJldHVybiBzdHJpbmctPnZhbHVlKGV4ZWMpLmlt cGwoKTsKK30KKwogZG91YmxlIERGR19PUEVSQVRJT04gb3BlcmF0aW9uRk1vZE9uSW50cyhpbnQz Ml90IGEsIGludDMyX3QgYikKIHsKICAgICByZXR1cm4gZm1vZChhLCBiKTsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5oCShyZXZpc2lvbiAxMzcyMjYpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaAkod29ya2luZyBjb3B5 KQpAQCAtMTE3LDYgKzExNyw3IEBAIHR5cGVkZWYgY2hhciogREZHX09QRVJBVElPTiAoKlBfREZH T3BlcmEKIHR5cGVkZWYgY2hhciogREZHX09QRVJBVElPTiAoKlBfREZHT3BlcmF0aW9uX0VTdFBT KShFeGVjU3RhdGUqLCBTdHJ1Y3R1cmUqLCB2b2lkKiwgc2l6ZV90KTsKIHR5cGVkZWYgY2hhciog REZHX09QRVJBVElPTiAoKlBfREZHT3BlcmF0aW9uX0VTdFNTKShFeGVjU3RhdGUqLCBTdHJ1Y3R1 cmUqLCBzaXplX3QsIHNpemVfdCk7CiB0eXBlZGVmIGNoYXIqIERGR19PUEVSQVRJT04gKCpQX0RG R09wZXJhdGlvbl9FU3RaKShFeGVjU3RhdGUqLCBTdHJ1Y3R1cmUqLCBpbnQzMl90KTsKK3R5cGVk ZWYgU3RyaW5nSW1wbCogREZHX09QRVJBVElPTiAoKlN0cl9ERkdPcGVyYXRpb25fRUpzcykoRXhl Y1N0YXRlKiwgSlNTdHJpbmcqKTsKIAogLy8gVGhlc2Ugcm91dGluZXMgYXJlIHByb3ZpZGUgY2Fs bGJhY2tzIG91dCB0byBDKysgaW1wbGVtZW50YXRpb25zIG9mIG9wZXJhdGlvbnMgdG9vIGNvbXBs ZXggdG8gSklULgogSlNDZWxsKiBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbk5ld09iamVjdChFeGVj U3RhdGUqLCBTdHJ1Y3R1cmUqKSBXVEZfSU5URVJOQUw7CkBAIC0yMDcsNiArMjA4LDcgQEAgY2hh ciogREZHX09QRVJBVElPTiBvcGVyYXRpb25FbnN1cmVEb3VibAogY2hhciogREZHX09QRVJBVElP TiBvcGVyYXRpb25FbnN1cmVDb250aWd1b3VzKEV4ZWNTdGF0ZSosIEpTT2JqZWN0Kik7CiBjaGFy KiBERkdfT1BFUkFUSU9OIG9wZXJhdGlvblJhZ2VFbnN1cmVDb250aWd1b3VzKEV4ZWNTdGF0ZSos IEpTT2JqZWN0Kik7CiBjaGFyKiBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbkVuc3VyZUFycmF5U3Rv cmFnZShFeGVjU3RhdGUqLCBKU09iamVjdCopOworU3RyaW5nSW1wbCogREZHX09QRVJBVElPTiBv cGVyYXRpb25SZXNvbHZlUm9wZShFeGVjU3RhdGUqLCBKU1N0cmluZyopOwogCiAvLyBUaGlzIG1l dGhvZCBpcyB1c2VkIHRvIGxvb2t1cCBhbiBleGNlcHRpb24gaGFuZGVyLCBrZXllZCBieSBmYXVs dExvY2F0aW9uLCB3aGljaCBpcwogLy8gdGhlIHJldHVybiBsb2NhdGlvbiBmcm9tIG9uZSBvZiB0 aGUgY2FsbHMgb3V0IHRvIG9uZSBvZiB0aGUgaGVscGVyIG9wZXJhdGlvbnMgYWJvdmUuCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAko cmV2aXNpb24gMTM3MjI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzNjUsOCArMzM2NSwxMCBAQCB2b2lkIFNw ZWN1bGF0aXZlSklUOjpjb21waWxlR2V0SW5kZXhlZFByCiAgICAgY2FzZSBBcnJheTo6U3RyaW5n OgogICAgICAgICBtX2ppdC5sb2FkUHRyKE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKGJhc2VSZWcs IEpTU3RyaW5nOjpvZmZzZXRPZlZhbHVlKCkpLCBzdG9yYWdlUmVnKTsKICAgICAgICAgCi0gICAg ICAgIC8vIFNwZWN1bGF0ZSB0aGF0IHdlJ3JlIG5vdCBhY2Nlc3NpbmcgYSByb3BlCi0gICAgICAg IHNwZWN1bGF0aW9uQ2hlY2soVW5jb3VudGFibGUsIEpTVmFsdWVSZWdzKCksIE5vTm9kZSwgbV9q aXQuYnJhbmNoVGVzdDMyKE1hY3JvQXNzZW1ibGVyOjpaZXJvLCBzdG9yYWdlUmVnKSk7CisgICAg ICAgIGFkZFNsb3dQYXRoR2VuZXJhdG9yKAorICAgICAgICAgICAgc2xvd1BhdGhDYWxsKAorICAg ICAgICAgICAgICAgIG1faml0LmJyYW5jaFRlc3QzMihNYWNyb0Fzc2VtYmxlcjo6WmVybywgc3Rv cmFnZVJlZyksCisgICAgICAgICAgICAgICAgdGhpcywgb3BlcmF0aW9uUmVzb2x2ZVJvcGUsIHN0 b3JhZ2VSZWcsIGJhc2VSZWcpKTsKIAogICAgICAgICBtX2ppdC5sb2FkUHRyKE1hY3JvQXNzZW1i bGVyOjpBZGRyZXNzKHN0b3JhZ2VSZWcsIFN0cmluZ0ltcGw6OmRhdGFPZmZzZXQoKSksIHN0b3Jh Z2VSZWcpOwogICAgICAgICBicmVhazsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHU3BlY3VsYXRpdmVKSVQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHJldmlzaW9uIDEzNzIyNikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAkod29ya2luZyBjb3B5KQpAQCAtMTUy NCw2ICsxNTI0LDExIEBAIHB1YmxpYzoKICAgICAgICAgbV9qaXQuc2V0dXBBcmd1bWVudHMoYXJn MSwgYXJnMik7CiAgICAgICAgIHJldHVybiBhcHBlbmRDYWxsU2V0UmVzdWx0KG9wZXJhdGlvbiwg cmVzdWx0KTsKICAgICB9CisgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbE9wZXJhdGlvbihTdHJf REZHT3BlcmF0aW9uX0VKc3Mgb3BlcmF0aW9uLCBHUFJSZWcgcmVzdWx0LCBHUFJSZWcgYXJnMSkK KyAgICB7CisgICAgICAgIG1faml0LnNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShhcmcxKTsK KyAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2tTZXRSZXN1bHQob3Bl cmF0aW9uLCByZXN1bHQpOworICAgIH0KICNlbHNlCiAKIC8vIEVuY29kZWRKU1ZhbHVlIGluIEpT VkFMVUUzMl82NCBpcyBhIDY0LWJpdCBpbnRlZ2VyLiBXaGVuIGJlaW5nIGNvbXBpbGVkIGluIEFS TSBFQUJJLCBpdCBtdXN0IGJlIGFsaWduZWQgZXZlbi1udW1iZXJlZCByZWdpc3RlciAocjAsIHIy IG9yIFtzcF0pLgpAQCAtMTkxMiw2ICsxOTE3LDExIEBAIHB1YmxpYzoKICAgICAgICAgbV9qaXQu c2V0dXBBcmd1bWVudHMoYXJnMSwgYXJnMik7CiAgICAgICAgIHJldHVybiBhcHBlbmRDYWxsU2V0 UmVzdWx0KG9wZXJhdGlvbiwgcmVzdWx0KTsKICAgICB9CisgICAgSklUQ29tcGlsZXI6OkNhbGwg Y2FsbE9wZXJhdGlvbihTdHJfREZHT3BlcmF0aW9uX0VKc3Mgb3BlcmF0aW9uLCBHUFJSZWcgcmVz dWx0LCBHUFJSZWcgYXJnMSkKKyAgICB7CisgICAgICAgIG1faml0LnNldHVwQXJndW1lbnRzV2l0 aEV4ZWNTdGF0ZShhcmcxKTsKKyAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9u Q2hlY2tTZXRSZXN1bHQob3BlcmF0aW9uLCByZXN1bHQpOworICAgIH0KIAogI3VuZGVmIEVBQklf MzJCSVRfRFVNTVlfQVJHCiAgICAgCg==