104608 2012-12-10 16:02:16 -0800 old-run-webkit-tests: add --show-results properly 2012-12-10 17:14:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke dbates eric webkit.review.bot oldest_to_newest 787807 0 dpranke 2012-12-10 16:02:16 -0800 old-run-webkit-tests: add --show-results properly 787809 1 178657 dpranke 2012-12-10 16:03:04 -0800 Created attachment 178657 Patch 787812 2 178659 dpranke 2012-12-10 16:04:06 -0800 Created attachment 178659 fix bug number in comment 787814 3 178659 eric 2012-12-10 16:05:36 -0800 Comment on attachment 178659 fix bug number in comment View in context: https://bugs.webkit.org/attachment.cgi?id=178659&action=review > Tools/Scripts/old-run-webkit-tests:362 > - 'show-results' => sub { $launchSafari = 1; }, > + 'show-results!' => sub { $launchSafari = $_[1]; }, You shouldn't need the sub to do this. :) Notice how sample-on-timeout works. 787817 4 178661 dpranke 2012-12-10 16:07:20 -0800 Created attachment 178661 no need for the sub 787818 5 dpranke 2012-12-10 16:07:49 -0800 You're right. Some days I just shouldn't be coding, apparently ... 787822 6 178661 eric 2012-12-10 16:12:47 -0800 Comment on attachment 178661 no need for the sub LGTM. 787867 7 178661 webkit.review.bot 2012-12-10 17:14:18 -0800 Comment on attachment 178661 no need for the sub Clearing flags on attachment: 178661 Committed r137228: <http://trac.webkit.org/changeset/137228> 787868 8 webkit.review.bot 2012-12-10 17:14:22 -0800 All reviewed patches have been landed. Closing bug. 178657 2012-12-10 16:03:04 -0800 2012-12-10 16:04:04 -0800 Patch bug-104608-20121210160031.patch text/plain 1754 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MjE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODI1NzllM2UyZTRiMTYwOWQzYTk0OWMyOTVlNjgzNDIx ZjYyZjA2Ni4uZDZlMTE3YTNhNWYxY2U1MjAyNjI4ODA4MjM3NjE1NDgxZGM1NGJmYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDEyLTEyLTEwICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG9sZC1ydW4td2Via2l0LXRlc3RzOiBhZGQgLS1zaG93LXJlc3VsdHMgcHJvcGVybHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDYwOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJld29yayBy MTM3MjE5IC8gYnVnIDEwNDYwOCB0byB1c2UgdGhlIGNvcnJlY3QgcGVybCBpZGlvbS4KKworICAg ICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6CisKKzIwMTItMTItMTAgIERpcmsg UHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgb2xkLXJ1bi13ZWJraXQt dGVzdHM6IHN1cHBvcnQgLS1uby1zaG93LXJlc3VsdHMgZm9yIGNvbXBhdGliaWxpdHkgdy8gTlJX VAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NjAx CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29s cy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IDdjZjFjMjdiNGRhMmY4Y2M0YjAy MWJiMjllMjE3ZTJjN2NjNjM3ZDMuLjUyNjZhZjQ4MzIwMTRhOTc3MmMzNDljYmE5ZjUxMDlhMWQx OTc0ZTkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysr IGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtMzQ3LDcgKzM0Nyw2IEBA IG15ICRnZXRPcHRpb25zUmVzdWx0ID0gR2V0T3B0aW9ucygKICAgICAnbWVyZ2UtbGVhay1kZXB0 aHxtOjUnID0+IFwkbWVyZ2VEZXB0aCwKICAgICAnbmV3LXRlc3QtcmVzdWx0cyEnID0+IFwkZ2Vu ZXJhdGVOZXdSZXN1bHRzLAogICAgICduby1idWlsZCcgPT4gXCRub0J1aWxkRHVtcFRvb2wsCi0g ICAgJ25vLXNob3ctcmVzdWx0cycgPT4gc3ViICB7ICRsYXVuY2hTYWZhcmkgPSAwOyB9LAogICAg ICdudGhseT1pJyA9PiBcJHRlc3RzUGVyRHVtcFRvb2wsCiAgICAgJ3BpeGVsLXRlc3RzfHAnID0+ IFwkcGl4ZWxUZXN0cywKICAgICAncGxhdGZvcm09cycgPT4gXCRwbGF0Zm9ybSwKQEAgLTM2MCw3 ICszNTksNyBAQCBteSAkZ2V0T3B0aW9uc1Jlc3VsdCA9IEdldE9wdGlvbnMoCiAgICAgJ3JldmVy c2UnID0+IFwkcmV2ZXJzZVRlc3RzLAogICAgICdyb290PXMnID0+IFwkcm9vdCwKICAgICAnc2Ft cGxlLW9uLXRpbWVvdXQhJyA9PiBcJHJ1blNhbXBsZSwKLSAgICAnc2hvdy1yZXN1bHRzJyA9PiBz dWIgIHsgJGxhdW5jaFNhZmFyaSA9IDE7IH0sCisgICAgJ3Nob3ctcmVzdWx0cyEnID0+IHN1YiAg eyAkbGF1bmNoU2FmYXJpID0gJF9bMV07IH0sCiAgICAgJ3NpbmdseXwxJyA9PiBzdWIgeyAkdGVz dHNQZXJEdW1wVG9vbCA9IDE7IH0sCiAgICAgJ3NraXBwZWQ9cycgPT4gXCZ2YWxpZGF0ZVNraXBw ZWRBcmcsCiAgICAgJ3Nsb3dlc3QnID0+IFwkcmVwb3J0MTBTbG93ZXN0LAo= 178659 2012-12-10 16:04:06 -0800 2012-12-10 16:07:17 -0800 fix bug number in comment bug-104608-20121210160134.patch text/plain 1754 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MjE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODI1NzllM2UyZTRiMTYwOWQzYTk0OWMyOTVlNjgzNDIx ZjYyZjA2Ni4uMDI1NDAyYThlNWU2NjI4MDJmMDI3N2UzMzFjNzhiY2ZkZDk4NzMwNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDEyLTEyLTEwICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG9sZC1ydW4td2Via2l0LXRlc3RzOiBhZGQgLS1zaG93LXJlc3VsdHMgcHJvcGVybHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDYwOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJld29yayBy MTM3MjE5IC8gYnVnIDEwNDYwMSB0byB1c2UgdGhlIGNvcnJlY3QgcGVybCBpZGlvbS4KKworICAg ICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6CisKKzIwMTItMTItMTAgIERpcmsg UHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgb2xkLXJ1bi13ZWJraXQt dGVzdHM6IHN1cHBvcnQgLS1uby1zaG93LXJlc3VsdHMgZm9yIGNvbXBhdGliaWxpdHkgdy8gTlJX VAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NjAx CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29s cy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IDdjZjFjMjdiNGRhMmY4Y2M0YjAy MWJiMjllMjE3ZTJjN2NjNjM3ZDMuLjUyNjZhZjQ4MzIwMTRhOTc3MmMzNDljYmE5ZjUxMDlhMWQx OTc0ZTkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysr IGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtMzQ3LDcgKzM0Nyw2IEBA IG15ICRnZXRPcHRpb25zUmVzdWx0ID0gR2V0T3B0aW9ucygKICAgICAnbWVyZ2UtbGVhay1kZXB0 aHxtOjUnID0+IFwkbWVyZ2VEZXB0aCwKICAgICAnbmV3LXRlc3QtcmVzdWx0cyEnID0+IFwkZ2Vu ZXJhdGVOZXdSZXN1bHRzLAogICAgICduby1idWlsZCcgPT4gXCRub0J1aWxkRHVtcFRvb2wsCi0g ICAgJ25vLXNob3ctcmVzdWx0cycgPT4gc3ViICB7ICRsYXVuY2hTYWZhcmkgPSAwOyB9LAogICAg ICdudGhseT1pJyA9PiBcJHRlc3RzUGVyRHVtcFRvb2wsCiAgICAgJ3BpeGVsLXRlc3RzfHAnID0+ IFwkcGl4ZWxUZXN0cywKICAgICAncGxhdGZvcm09cycgPT4gXCRwbGF0Zm9ybSwKQEAgLTM2MCw3 ICszNTksNyBAQCBteSAkZ2V0T3B0aW9uc1Jlc3VsdCA9IEdldE9wdGlvbnMoCiAgICAgJ3JldmVy c2UnID0+IFwkcmV2ZXJzZVRlc3RzLAogICAgICdyb290PXMnID0+IFwkcm9vdCwKICAgICAnc2Ft cGxlLW9uLXRpbWVvdXQhJyA9PiBcJHJ1blNhbXBsZSwKLSAgICAnc2hvdy1yZXN1bHRzJyA9PiBz dWIgIHsgJGxhdW5jaFNhZmFyaSA9IDE7IH0sCisgICAgJ3Nob3ctcmVzdWx0cyEnID0+IHN1YiAg eyAkbGF1bmNoU2FmYXJpID0gJF9bMV07IH0sCiAgICAgJ3NpbmdseXwxJyA9PiBzdWIgeyAkdGVz dHNQZXJEdW1wVG9vbCA9IDE7IH0sCiAgICAgJ3NraXBwZWQ9cycgPT4gXCZ2YWxpZGF0ZVNraXBw ZWRBcmcsCiAgICAgJ3Nsb3dlc3QnID0+IFwkcmVwb3J0MTBTbG93ZXN0LAo= 178661 2012-12-10 16:07:20 -0800 2012-12-10 17:14:18 -0800 no need for the sub bug-104608-20121210160447.patch text/plain 1737 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MjE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODI1NzllM2UyZTRiMTYwOWQzYTk0OWMyOTVlNjgzNDIx ZjYyZjA2Ni4uMDI1NDAyYThlNWU2NjI4MDJmMDI3N2UzMzFjNzhiY2ZkZDk4NzMwNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDEyLTEyLTEwICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG9sZC1ydW4td2Via2l0LXRlc3RzOiBhZGQgLS1zaG93LXJlc3VsdHMgcHJvcGVybHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDYwOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJld29yayBy MTM3MjE5IC8gYnVnIDEwNDYwMSB0byB1c2UgdGhlIGNvcnJlY3QgcGVybCBpZGlvbS4KKworICAg ICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6CisKKzIwMTItMTItMTAgIERpcmsg UHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgb2xkLXJ1bi13ZWJraXQt dGVzdHM6IHN1cHBvcnQgLS1uby1zaG93LXJlc3VsdHMgZm9yIGNvbXBhdGliaWxpdHkgdy8gTlJX VAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NjAx CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29s cy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IDdjZjFjMjdiNGRhMmY4Y2M0YjAy MWJiMjllMjE3ZTJjN2NjNjM3ZDMuLjJiNjFkMjM5NGI4OWY5MjUyNWE0NDY2MDUyNTBmZWU0MDhk NGJmYzggMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysr IGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtMzQ3LDcgKzM0Nyw2IEBA IG15ICRnZXRPcHRpb25zUmVzdWx0ID0gR2V0T3B0aW9ucygKICAgICAnbWVyZ2UtbGVhay1kZXB0 aHxtOjUnID0+IFwkbWVyZ2VEZXB0aCwKICAgICAnbmV3LXRlc3QtcmVzdWx0cyEnID0+IFwkZ2Vu ZXJhdGVOZXdSZXN1bHRzLAogICAgICduby1idWlsZCcgPT4gXCRub0J1aWxkRHVtcFRvb2wsCi0g ICAgJ25vLXNob3ctcmVzdWx0cycgPT4gc3ViICB7ICRsYXVuY2hTYWZhcmkgPSAwOyB9LAogICAg ICdudGhseT1pJyA9PiBcJHRlc3RzUGVyRHVtcFRvb2wsCiAgICAgJ3BpeGVsLXRlc3RzfHAnID0+ IFwkcGl4ZWxUZXN0cywKICAgICAncGxhdGZvcm09cycgPT4gXCRwbGF0Zm9ybSwKQEAgLTM2MCw3 ICszNTksNyBAQCBteSAkZ2V0T3B0aW9uc1Jlc3VsdCA9IEdldE9wdGlvbnMoCiAgICAgJ3JldmVy c2UnID0+IFwkcmV2ZXJzZVRlc3RzLAogICAgICdyb290PXMnID0+IFwkcm9vdCwKICAgICAnc2Ft cGxlLW9uLXRpbWVvdXQhJyA9PiBcJHJ1blNhbXBsZSwKLSAgICAnc2hvdy1yZXN1bHRzJyA9PiBz dWIgIHsgJGxhdW5jaFNhZmFyaSA9IDE7IH0sCisgICAgJ3Nob3ctcmVzdWx0cyEnID0+IFwkbGF1 bmNoU2FmYXJpLAogICAgICdzaW5nbHl8MScgPT4gc3ViIHsgJHRlc3RzUGVyRHVtcFRvb2wgPSAx OyB9LAogICAgICdza2lwcGVkPXMnID0+IFwmdmFsaWRhdGVTa2lwcGVkQXJnLAogICAgICdzbG93 ZXN0JyA9PiBcJHJlcG9ydDEwU2xvd2VzdCwK