104595 2012-12-10 14:21:45 -0800 fast/css/empty-generated-content.html needs to be rebaselined after 104462 2013-03-21 00:34:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104462 1 esprehn webkit-unassigned pkasting rniwa oldest_to_newest 787714 0 esprehn 2012-12-10 14:21:45 -0800 This test used to have an extra anonymous block for some reason I can't explain. The new generated content implementation seems to fix it. 859869 1 rniwa 2013-03-20 17:05:29 -0700 Committed r146414: <http://trac.webkit.org/changeset/146414> 860081 2 pkasting 2013-03-21 00:03:03 -0700 Rebaselined in r146441. 860086 3 rniwa 2013-03-21 00:08:37 -0700 Don't we need rebaselines on Qt, GTK+, EFL, etc...? 860087 4 pkasting 2013-03-21 00:13:06 -0700 Bug 104462 only touched the Mac and Chromium TestExpectations files. The Qt, GTK, and EFL TestExpectations files don't refer to this test, unless I looked at the wrong files. Did I miss anything? 860092 5 rniwa 2013-03-21 00:19:02 -0700 (In reply to comment #4) > Bug 104462 only touched the Mac and Chromium TestExpectations files. The Qt, GTK, and EFL TestExpectations files don't refer to this test, unless I looked at the wrong files. I suspect that's because only Mac and Chromium ports' EWS bots run tests. 860094 6 esprehn 2013-03-21 00:20:16 -0700 (In reply to comment #5) > (In reply to comment #4) > > Bug 104462 only touched the Mac and Chromium TestExpectations files. The Qt, GTK, and EFL TestExpectations files don't refer to this test, unless I looked at the wrong files. > > I suspect that's because only Mac and Chromium ports' EWS bots run tests. Yup. I asked at the time (which was before the global TestExpectations file existed) and was told to only change ones for the EWS. 860095 7 rniwa 2013-03-21 00:20:42 -0700 But it does seem like they all have .txt/.png results. 860097 8 rniwa 2013-03-21 00:21:22 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Bug 104462 only touched the Mac and Chromium TestExpectations files. The Qt, GTK, and EFL TestExpectations files don't refer to this test, unless I looked at the wrong files. > > > > I suspect that's because only Mac and Chromium ports' EWS bots run tests. > > Yup. I asked at the time (which was before the global TestExpectations file existed) and was told to only change ones for the EWS. That's just insanely stupid. We're working around the fact EWS would cq- the patch. We need to improve the tool so that we don't have to do such a thing. 860105 9 pkasting 2013-03-21 00:33:00 -0700 I am fine with this being reopened (hopefully with clarity added as to what someone who wants to fix should do). It's past midnight here and my brain is getting fuzzy enough that I'm not sure I would write the right thing myself. 860107 10 rniwa 2013-03-21 00:34:29 -0700 (In reply to comment #9) > I am fine with this being reopened (hopefully with clarity added as to what someone who wants to fix should do). It's past midnight here and my brain is getting fuzzy enough that I'm not sure I would write the right thing myself. Sorry, I think closing the bug is the right thing to do for now. I just had to manually verify that EFL, GTK+, & Qt have respective -expected files, and they indeed do.