104586 2012-12-10 12:11:16 -0800 [chromium] Expose quickRedirectComing via WebDataSource 2012-12-12 17:29:43 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 creis creis abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 787625 0 creis 2012-12-10 12:11:16 -0800 In Chromium, there are cases that the WebFrameClient needs to know whether the current navigation is a redirect that should replace the current history item. This is kept in FrameLoader::quickRedirectComing(). We'd like to expose it via WebDataSource so that the client can use it in decidePolicyForNavigation. Note that quickRedirectComing() is also exposed via DocumentLoader::isClientRedirect(). However, this isn't set until after decidePolicyForNavigation is called. It's also confusingly named, since WebFrameClient::willPerformClientRedirect is called whether isClientRedirect() is true or not. (willPerformClientRedirect refers to JavaScript navigations, whether they occur before or after the current document finishes loading, and thus it may sometimes leave the current history item in place.) For reference, this is needed to fix http://crbug.com/164419. 787627 1 178609 creis 2012-12-10 12:18:00 -0800 Created attachment 178609 Patch 787628 2 webkit.review.bot 2012-12-10 12:23:04 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 788040 3 fishd 2012-12-10 22:01:49 -0800 I think we should fix willPerformClientRedirect to only be called when indeed there is a client redirect (a.k.a., a navigation that replaces the current history item). I haven't studied the logic in willPerformClientRedirect very carefully on the Chromium side, but I wouldn't be surprised if it is confused / buggy. I think we should expose the method on WebDataSource as isClientRedirect, and I think the DocumentLoader can have its isClientRedirect field set very early on (before decidePolicyForNavigation). We know when we create a DocumentLoader if it is going to be a client redirect or not. (That's not something that changes over the course of the lifetime of a DocumentLoader.) 788902 4 creis 2012-12-11 15:56:50 -0800 (In reply to comment #3) > I think we should fix willPerformClientRedirect to only be called when indeed there is a client redirect (a.k.a., a navigation that replaces the current history item). > > I haven't studied the logic in willPerformClientRedirect very carefully on the Chromium side, but I wouldn't be surprised if it is confused / buggy. > > I think we should expose the method on WebDataSource as isClientRedirect, and I think the DocumentLoader can have its isClientRedirect field set very early on (before decidePolicyForNavigation). We know when we create a DocumentLoader if it is going to be a client redirect or not. (That's not something that changes over the course of the lifetime of a DocumentLoader.) I think those are great ideas, though I'm concerned about the risk of changing this behavior just before a branch point. Can I file a separate bug for changing willPerformClientRedirect and setting DocumentLoader::isClientRedirect earlier? I've changed this patch to expose WebDataSource::isClientRedirect, which for now actually exposes FrameLoader::quickRedirectComing. We can change it to return DocumentLoader::isClientRedirect once we set that value earlier. 788903 5 178904 creis 2012-12-11 15:57:05 -0800 Created attachment 178904 Patch 790048 6 178904 japhet 2012-12-12 16:30:25 -0800 Comment on attachment 178904 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178904&action=review > Source/WebKit/chromium/src/WebDataSourceImpl.cpp:93 > +bool WebDataSourceImpl::isClientRedirect() const > +{ > + // FIXME: This should return DocumentLoader::isClientRedirect() once that is > + // changed to be set earlier than the call to WebFrameClient::decidePolicyForNavigation. > + return frameLoader() ? frameLoader()->quickRedirectComing() : false; > +} > + I worry about depending on quickRedirectComing(), but I understand that using DocumentLoader::isClientRedirect() is a much more complex undertaking. So long as we tackle this FIXME sometime soon, this LGTM. 790062 7 creis 2012-12-12 16:42:23 -0800 (In reply to comment #6) > (From update of attachment 178904 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178904&action=review > > > Source/WebKit/chromium/src/WebDataSourceImpl.cpp:93 > > +bool WebDataSourceImpl::isClientRedirect() const > > +{ > > + // FIXME: This should return DocumentLoader::isClientRedirect() once that is > > + // changed to be set earlier than the call to WebFrameClient::decidePolicyForNavigation. > > + return frameLoader() ? frameLoader()->quickRedirectComing() : false; > > +} > > + > > I worry about depending on quickRedirectComing(), but I understand that using DocumentLoader::isClientRedirect() is a much more complex undertaking. So long as we tackle this FIXME sometime soon, this LGTM. Thanks. I filed bug 104860 to tackle it. Darin Fisher is on board with this plan, so I'll go ahead with landing it. 790106 8 178904 webkit.review.bot 2012-12-12 17:29:39 -0800 Comment on attachment 178904 Patch Clearing flags on attachment: 178904 Committed r137542: <http://trac.webkit.org/changeset/137542> 790107 9 webkit.review.bot 2012-12-12 17:29:43 -0800 All reviewed patches have been landed. Closing bug. 178609 2012-12-10 12:18:00 -0800 2012-12-11 15:57:02 -0800 Patch bug-104586-20121210121545.patch text/plain 3069 creis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGE2OTlkMjY1YTMwMzg1MmE4ZWIxNGNlYmViNDRkMDc5ZDE5YTBkMjkuLjMwZjE5ZGE2YzJlZGU3 YzRlOGJkYThkM2MzMjFmMGIzNzNlMGY0OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMTItMTAgIENoYXJsaWUgUmVpcyAgPGNyZWlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEV4cG9zZSBxdWlja1JlZGlyZWN0Q29taW5nIHZp YSBXZWJEYXRhU291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDQ1ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFeHBvc2VzIHdoZXRoZXIgdGhlIGN1cnJlbnQgbmF2aWdhdGlvbiBzaG91bGQgcmVw bGFjZSB0aGUgY3VycmVudCBoaXN0b3J5IGl0ZW0uCisKKyAgICAgICAgKiBwdWJsaWMvV2ViRGF0 YVNvdXJjZS5oOgorICAgICAgICAoV2ViRGF0YVNvdXJjZSk6IEFkZHMgc2hvdWxkUmVwbGFjZUhp c3RvcnlJdGVtLgorICAgICAgICAqIHNyYy9XZWJEYXRhU291cmNlSW1wbC5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYkRhdGFTb3VyY2VJbXBsOjpzaG91bGRSZXBsYWNlSGlzdG9yeUl0ZW0pOgor ICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViRGF0YVNvdXJjZUltcGwuaDoKKyAg ICAgICAgKFdlYkRhdGFTb3VyY2VJbXBsKToKKwogMjAxMi0xMi0xMCAgTWFyayBQaWxncmltICA8 cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBNb3ZlIGdldFBsdWdp bnNMaXN0IG91dCBvZiBQbGF0Zm9ybVN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkRhdGFTb3VyY2UuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYkRhdGFTb3VyY2UuaAppbmRleCA3N2Q2ZTc4ZGNjMzZlNmNjMGI5M2JkMTdjMGRl NWExZTc4YWRlYTBlLi5mODFmZTFhMGE1ODc5M2NhZGE4YWQ3NGY5MDFjYjZiNDllNjdlZmJlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEYXRhU291cmNlLmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGF0YVNvdXJjZS5oCkBAIC03 Niw2ICs3NiwxMCBAQCBwdWJsaWM6CiAgICAgLy8gVVJMKS4KICAgICB2aXJ0dWFsIHZvaWQgcmVk aXJlY3RDaGFpbihXZWJWZWN0b3I8V2ViVVJMPiYpIGNvbnN0ID0gMDsKIAorICAgIC8vIFJldHVy bnMgd2hldGhlciB0aGUgbmF2aWdhdGlvbiBhc3NvY2lhdGVkIHdpdGggdGhpcyBkYXRhc291cmNl IGlzIGEKKyAgICAvLyByZWRpcmVjdCB0aGF0IHNob3VsZCByZXBsYWNlIHRoZSBjdXJyZW50IGhp c3RvcnkgaXRlbS4KKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkUmVwbGFjZUhpc3RvcnlJdGVtKCkg Y29uc3QgPSAwOworCiAgICAgLy8gUmV0dXJucyB0aGUgdGl0bGUgZm9yIHRoZSBjdXJyZW50IHBh Z2UuCiAgICAgdmlydHVhbCBXZWJTdHJpbmcgcGFnZVRpdGxlKCkgY29uc3QgPSAwOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5jcHAKaW5kZXgg Y2M5NGI2MmVjNzYwYTFiYmE1ZjkxOWRhOWEyZWRlNzcyYmJjN2Y5ZC4uNGQ1YjY2ZGNmNTBmNjBj NjRmZjY1ZGQ4Y2ZkMmY4NDI5Njk1ZGZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRGF0YVNvdXJjZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRhdGFTb3VyY2VJbXBsLmNwcApAQCAtODQsNiArODQsMTEgQEAgdm9pZCBXZWJE YXRhU291cmNlSW1wbDo6cmVkaXJlY3RDaGFpbihXZWJWZWN0b3I8V2ViVVJMPiYgcmVzdWx0KSBj b25zdAogICAgIHJlc3VsdC5hc3NpZ24obV9yZWRpcmVjdENoYWluKTsKIH0KIAorYm9vbCBXZWJE YXRhU291cmNlSW1wbDo6c2hvdWxkUmVwbGFjZUhpc3RvcnlJdGVtKCkgY29uc3QKK3sKKyAgICBy ZXR1cm4gZnJhbWVMb2FkZXIoKSA/IGZyYW1lTG9hZGVyKCktPnF1aWNrUmVkaXJlY3RDb21pbmco KSA6IGZhbHNlOworfQorCiBXZWJTdHJpbmcgV2ViRGF0YVNvdXJjZUltcGw6OnBhZ2VUaXRsZSgp IGNvbnN0CiB7CiAgICAgcmV0dXJuIHRpdGxlKCkuc3RyaW5nKCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5oIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRGF0YVNvdXJjZUltcGwuaAppbmRleCAzZThjOGJiNTU4ZGEyZmEx OWI5YzllMzA3NWQwMzhiYTRkNjhlZjI1Li42ZGUwM2Q5ZTNlNzM0NDg4OTEyZTJhZTQ1ZjY1MjJi ZjQ2NmE4MGM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRh U291cmNlSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRhdGFTb3Vy Y2VJbXBsLmgKQEAgLTYyLDYgKzYyLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBoYXNV bnJlYWNoYWJsZVVSTCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViVVJMIHVucmVhY2hhYmxlVVJM KCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHJlZGlyZWN0Q2hhaW4oV2ViVmVjdG9yPFdlYlVS TD4mKSBjb25zdDsKKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkUmVwbGFjZUhpc3RvcnlJdGVtKCkg Y29uc3Q7CiAgICAgdmlydHVhbCBXZWJTdHJpbmcgcGFnZVRpdGxlKCkgY29uc3Q7CiAgICAgdmly dHVhbCBXZWJUZXh0RGlyZWN0aW9uIHBhZ2VUaXRsZURpcmVjdGlvbigpIGNvbnN0OwogICAgIHZp cnR1YWwgV2ViTmF2aWdhdGlvblR5cGUgbmF2aWdhdGlvblR5cGUoKSBjb25zdDsK 178904 2012-12-11 15:57:05 -0800 2012-12-12 17:29:39 -0800 Patch bug-104586-20121211155426.patch text/plain 3252 creis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGE2OTlkMjY1YTMwMzg1MmE4ZWIxNGNlYmViNDRkMDc5ZDE5YTBkMjkuLjE1YTdiMTE1ZjVjYzZm ZmUzNjVlYmNhNDc3YzM5NzIyOTZhZWFiYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMTItMTAgIENoYXJsaWUgUmVpcyAgPGNyZWlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEV4cG9zZSBxdWlja1JlZGlyZWN0Q29taW5nIHZp YSBXZWJEYXRhU291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDQ1ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFeHBvc2VzIHdoZXRoZXIgdGhlIGN1cnJlbnQgbmF2aWdhdGlvbiBpcyBhIGNsaWVu dCByZWRpcmVjdCwgYW5kCisgICAgICAgIHRodXMgc2hvdWxkIHJlcGxhY2UgdGhlIGN1cnJlbnQg aGlzdG9yeSBpdGVtLgorCisgICAgICAgICogcHVibGljL1dlYkRhdGFTb3VyY2UuaDoKKyAgICAg ICAgKFdlYkRhdGFTb3VyY2UpOiBBZGRzIGlzQ2xpZW50UmVkaXJlY3QuCisgICAgICAgICogc3Jj L1dlYkRhdGFTb3VyY2VJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRGF0YVNvdXJjZUlt cGw6OmlzQ2xpZW50UmVkaXJlY3QpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMv V2ViRGF0YVNvdXJjZUltcGwuaDoKKyAgICAgICAgKFdlYkRhdGFTb3VyY2VJbXBsKToKKwogMjAx Mi0xMi0xMCAgTWFyayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W0Nocm9taXVtXSBNb3ZlIGdldFBsdWdpbnNMaXN0IG91dCBvZiBQbGF0Zm9ybVN1cHBvcnQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRhdGFTb3VyY2UuaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRhdGFTb3VyY2UuaAppbmRleCA3N2Q2 ZTc4ZGNjMzZlNmNjMGI5M2JkMTdjMGRlNWExZTc4YWRlYTBlLi44OTQzMDEwMzE0MGE3ZWZhNzY3 Yjc1Yzg2YTk2YTI0YjBhM2ExYTU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJEYXRhU291cmNlLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViRGF0YVNvdXJjZS5oCkBAIC03Niw2ICs3NiwxMCBAQCBwdWJsaWM6CiAgICAgLy8gVVJM KS4KICAgICB2aXJ0dWFsIHZvaWQgcmVkaXJlY3RDaGFpbihXZWJWZWN0b3I8V2ViVVJMPiYpIGNv bnN0ID0gMDsKIAorICAgIC8vIFJldHVybnMgd2hldGhlciB0aGUgbmF2aWdhdGlvbiBhc3NvY2lh dGVkIHdpdGggdGhpcyBkYXRhc291cmNlIGlzIGEKKyAgICAvLyBjbGllbnQgcmVkaXJlY3QgdGhh dCBzaG91bGQgcmVwbGFjZSB0aGUgY3VycmVudCBoaXN0b3J5IGl0ZW0uCisgICAgdmlydHVhbCBi b29sIGlzQ2xpZW50UmVkaXJlY3QoKSBjb25zdCA9IDA7CisKICAgICAvLyBSZXR1cm5zIHRoZSB0 aXRsZSBmb3IgdGhlIGN1cnJlbnQgcGFnZS4KICAgICB2aXJ0dWFsIFdlYlN0cmluZyBwYWdlVGl0 bGUoKSBjb25zdCA9IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkRhdGFTb3VyY2VJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRh dGFTb3VyY2VJbXBsLmNwcAppbmRleCBjYzk0YjYyZWM3NjBhMWJiYTVmOTE5ZGE5YTJlZGU3NzJi YmM3ZjlkLi40OTBmMjk4YmY4ZjdlMzYwYTQwOWI4ZGJiZDk0MzVkYWQ0ZGJiZDk5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGF0YVNvdXJjZUltcGwuY3BwCkBAIC04 NCw2ICs4NCwxMyBAQCB2b2lkIFdlYkRhdGFTb3VyY2VJbXBsOjpyZWRpcmVjdENoYWluKFdlYlZl Y3RvcjxXZWJVUkw+JiByZXN1bHQpIGNvbnN0CiAgICAgcmVzdWx0LmFzc2lnbihtX3JlZGlyZWN0 Q2hhaW4pOwogfQogCitib29sIFdlYkRhdGFTb3VyY2VJbXBsOjppc0NsaWVudFJlZGlyZWN0KCkg Y29uc3QKK3sKKyAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcmV0dXJuIERvY3VtZW50TG9hZGVy Ojppc0NsaWVudFJlZGlyZWN0KCkgb25jZSB0aGF0IGlzCisgICAgLy8gY2hhbmdlZCB0byBiZSBz ZXQgZWFybGllciB0aGFuIHRoZSBjYWxsIHRvIFdlYkZyYW1lQ2xpZW50OjpkZWNpZGVQb2xpY3lG b3JOYXZpZ2F0aW9uLgorICAgIHJldHVybiBmcmFtZUxvYWRlcigpID8gZnJhbWVMb2FkZXIoKS0+ cXVpY2tSZWRpcmVjdENvbWluZygpIDogZmFsc2U7Cit9CisKIFdlYlN0cmluZyBXZWJEYXRhU291 cmNlSW1wbDo6cGFnZVRpdGxlKCkgY29uc3QKIHsKICAgICByZXR1cm4gdGl0bGUoKS5zdHJpbmco KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRhdGFTb3VyY2VJ bXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5oCmlu ZGV4IDNlOGM4YmI1NThkYTJmYTE5YjljOWUzMDc1ZDAzOGJhNGQ2OGVmMjUuLjMxMWMxZWNmYjg2 MzhiZTI2YjQxMzQ3OGJmNjcxMGFjODhhMmE5NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkRhdGFTb3VyY2VJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRGF0YVNvdXJjZUltcGwuaApAQCAtNjIsNiArNjIsNyBAQCBwdWJsaWM6CiAg ICAgdmlydHVhbCBib29sIGhhc1VucmVhY2hhYmxlVVJMKCkgY29uc3Q7CiAgICAgdmlydHVhbCBX ZWJVUkwgdW5yZWFjaGFibGVVUkwoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgcmVkaXJlY3RD aGFpbihXZWJWZWN0b3I8V2ViVVJMPiYpIGNvbnN0OworICAgIHZpcnR1YWwgYm9vbCBpc0NsaWVu dFJlZGlyZWN0KCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJTdHJpbmcgcGFnZVRpdGxlKCkgY29u c3Q7CiAgICAgdmlydHVhbCBXZWJUZXh0RGlyZWN0aW9uIHBhZ2VUaXRsZURpcmVjdGlvbigpIGNv bnN0OwogICAgIHZpcnR1YWwgV2ViTmF2aWdhdGlvblR5cGUgbmF2aWdhdGlvblR5cGUoKSBjb25z dDsK