104570 2012-12-10 10:17:24 -0800 [Coverity] [GTK] Remove some redundant null checks in DumpRenderTree 2012-12-12 16:41:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 1 mrobinson mrobinson cgarcia dbates oldest_to_newest 787482 0 mrobinson 2012-12-10 10:17:24 -0800 We shoul remove some redundant null checks in DumpRenderTree. 787539 1 178590 mrobinson 2012-12-10 10:52:20 -0800 Created attachment 178590 Patch 787781 2 178651 mrobinson 2012-12-10 15:33:59 -0800 Created attachment 178651 Patch 787828 3 178651 dbates 2012-12-10 16:18:46 -0800 Comment on attachment 178651 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178651&action=review OK. This patch doesn't change the existing functionality. That is, we currently return an empty string for the NSURLRequest portion of the willSendRequest string when soupMessage is null. I'm unclear how some ports came to the decision to return an empty string for the NSURLRequest portion of the willSendRequest string and some ports return a NSURLRequest string with "(none)" for the HTTP method. > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1235 > + path.data(), mainDocumentURIString.data(), soupMessage->method)); For completeness, the Mac and EFL ports return "(none)" when the HTTP method isn't known. 788362 4 mrobinson 2012-12-11 05:53:27 -0800 (In reply to comment #3) Thanks for the review! > For completeness, the Mac and EFL ports return "(none)" when the HTTP method isn't known. Dan Winship, the libsoup maintainer, informs me that the method is "GET" by default for SoupMessages. The only way that it is null is if you manually override it (which as far as I know, we never do). I cannot find any examples of test expectations that "have the (none)" output as well. 788364 5 mrobinson 2012-12-11 05:54:15 -0800 Committed r137300: <http://trac.webkit.org/changeset/137300> 790060 6 mrobinson 2012-12-12 16:41:54 -0800 Committed r137536: <http://trac.webkit.org/changeset/137536> 178590 2012-12-10 10:52:20 -0800 2012-12-10 15:33:55 -0800 Patch bug-104570-20121210194941.patch text/plain 3249 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMmE0OTgyY2Qx OGVmY2I1YTEyZDI2MmY2OTIwNDcwM2M3YWVmNjY2Yi4uNDBlMDc1NzMxNDVkZWMzZmQ0YmY4ZWFi OTUwN2M5NjI1OWVkMzZmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEy LTEyLTEwICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAg ICBbQ292ZXJpdHldIFtHVEtdIFJlbW92ZSBzb21lIHJlZHVuZGFudCBudWxsIGNoZWNrcyBpbiBE dW1wUmVuZGVyVHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA0NTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwOgorICAg ICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjplbGVtZW50RG9lc0F1dG9Db21wbGV0ZUZv ckVsZW1lbnRXaXRoSWQpOiBSZW1vdmUgYSByZWR1bmRhbnQgbnVsbCBjaGVjay4KKwogMjAxMi0x Mi0wNSAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtHdGtdIG5hdmlnYXRvci5wbHVnaW5zIGNvbnRhaW5zIHRvbyBtYW55IHBsdWdpbiBl bnRyaWVzLiBGaXJzdCBvbmUgYXJlIGdhcmJhZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwIGIvU291cmNl L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcApp bmRleCBhYThlZjYwY2FjNmNmODcxOGVlM2RhOWViN2Q3M2NjOGVmZWJiYzRmLi4xM2ExM2FlZjM0 YjEyMjM2MDhkMTE5MmE5OTI5ZjQ1MGMwMGI0NzBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5j cHAKQEAgLTczOCw5ICs3MzgsNiBAQCBib29sIER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6ZWxl bWVudERvZXNBdXRvQ29tcGxldGVGb3JFbGVtZW50V2l0aElkKFdlYktpdFdlYgogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKICAgICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dEVsZW1lbnQgPSBzdGF0 aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oY29yZU5vZGUpOwotICAgIGlmICghaW5wdXRFbGVt ZW50KQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICByZXR1cm4gaW5wdXRFbGVtZW50LT5p c1RleHRGaWVsZCgpICYmICFpbnB1dEVsZW1lbnQtPmlzUGFzc3dvcmRGaWVsZCgpICYmIGlucHV0 RWxlbWVudC0+c2hvdWxkQXV0b2NvbXBsZXRlKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0No YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNzU4YzEwMjgwZGZjOTI1ZGZjMWFlODk2 MzBkOWFlMTNmZGZlNDY0Li44ZDI5ZDUxZWE2MDQwMWMwOTJhZjEzZmM2MTY5MDZlMWEyZTMzMTRl IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTItMTItMTAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtDb3Zlcml0eV0gW0dUS10gUmVtb3ZlIHNvbWUgcmVkdW5kYW50 IG51bGwgY2hlY2tzIGluIER1bXBSZW5kZXJUcmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJl ZS5jcHA6CisgICAgICAgIChkZXNjcmlwdGlvblN1aXRhYmxlRm9yVGVzdFJlc3VsdCk6IFJlbW92 ZSBhIHJlZHVuZGFudCBudWxsIGNoZWNrLgorCiAyMDEyLTEyLTEwICBWw61jdG9yIE1hbnVlbCBK w6FxdWV6IExlYWwgIDx2amFxdWV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihy MTM1ODYzKTogR3RrTGF1bmNoZXIgLS1oZWxwIG5vIGxvbmdlciBkaXNwbGF5cyBhbGwgaGVscCBv cHRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRy ZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRl eCBlNjhlMmEwMjNlYzQ3YjA5ODUzMjcyMjMwODI5YTU0ZTkxODUyNTZkLi4zMjliNTcwODAzZGFm YWFkYmNhMDZiZDZlZjZhM2ZmM2VhYTBkODQ0IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTEyMzIsOCArMTIzMiw3IEBAIHN0YXRpYyBDU3RyaW5n IGRlc2NyaXB0aW9uU3VpdGFibGVGb3JUZXN0UmVzdWx0KFdlYktpdE5ldHdvcmtSZXF1ZXN0KiBy ZXF1ZXN0KQogICAgIENTdHJpbmcgbWFpbkRvY3VtZW50VVJJU3RyaW5nKGRlc2NyaXB0aW9uU3Vp dGFibGVGb3JUZXN0UmVzdWx0KG1haW5Eb2N1bWVudFVSSSkpOwogICAgIENTdHJpbmcgcGF0aChj b252ZXJ0TmV0d29ya1JlcXVlc3RUb1VSTFBhdGgocmVxdWVzdCkpOwogICAgIEdPd25QdHI8Y2hh cj4gZGVzY3JpcHRpb24oZ19zdHJkdXBfcHJpbnRmKCI8TlNVUkxSZXF1ZXN0IFVSTCAlcywgbWFp biBkb2N1bWVudCBVUkwgJXMsIGh0dHAgbWV0aG9kICVzPiIsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcGF0aC5kYXRhKCksIG1haW5Eb2N1bWVudFVSSVN0 cmluZy5kYXRhKCksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc291cE1lc3NhZ2UgPyBzb3VwTWVzc2FnZS0+bWV0aG9kIDogIihub25lKSIpKTsKKyAgICAg ICAgcGF0aC5kYXRhKCksIG1haW5Eb2N1bWVudFVSSVN0cmluZy5kYXRhKCksIHNvdXBNZXNzYWdl LT5tZXRob2QpKTsKICAgICByZXR1cm4gQ1N0cmluZyhkZXNjcmlwdGlvbi5nZXQoKSk7CiB9CiAK 178651 2012-12-10 15:33:59 -0800 2012-12-10 16:18:46 -0800 Patch bug-104570-20121211003119.patch text/plain 3249 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMmE0OTgyY2Qx OGVmY2I1YTEyZDI2MmY2OTIwNDcwM2M3YWVmNjY2Yi4uNDBlMDc1NzMxNDVkZWMzZmQ0YmY4ZWFi OTUwN2M5NjI1OWVkMzZmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEy LTEyLTEwICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAg ICBbQ292ZXJpdHldIFtHVEtdIFJlbW92ZSBzb21lIHJlZHVuZGFudCBudWxsIGNoZWNrcyBpbiBE dW1wUmVuZGVyVHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA0NTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwOgorICAg ICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjplbGVtZW50RG9lc0F1dG9Db21wbGV0ZUZv ckVsZW1lbnRXaXRoSWQpOiBSZW1vdmUgYSByZWR1bmRhbnQgbnVsbCBjaGVjay4KKwogMjAxMi0x Mi0wNSAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtHdGtdIG5hdmlnYXRvci5wbHVnaW5zIGNvbnRhaW5zIHRvbyBtYW55IHBsdWdpbiBl bnRyaWVzLiBGaXJzdCBvbmUgYXJlIGdhcmJhZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwIGIvU291cmNl L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcApp bmRleCBhYThlZjYwY2FjNmNmODcxOGVlM2RhOWViN2Q3M2NjOGVmZWJiYzRmLi4xM2ExM2FlZjM0 YjEyMjM2MDhkMTE5MmE5OTI5ZjQ1MGMwMGI0NzBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5j cHAKQEAgLTczOCw5ICs3MzgsNiBAQCBib29sIER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6ZWxl bWVudERvZXNBdXRvQ29tcGxldGVGb3JFbGVtZW50V2l0aElkKFdlYktpdFdlYgogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKICAgICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dEVsZW1lbnQgPSBzdGF0 aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oY29yZU5vZGUpOwotICAgIGlmICghaW5wdXRFbGVt ZW50KQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICByZXR1cm4gaW5wdXRFbGVtZW50LT5p c1RleHRGaWVsZCgpICYmICFpbnB1dEVsZW1lbnQtPmlzUGFzc3dvcmRGaWVsZCgpICYmIGlucHV0 RWxlbWVudC0+c2hvdWxkQXV0b2NvbXBsZXRlKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0No YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNzU4YzEwMjgwZGZjOTI1ZGZjMWFlODk2 MzBkOWFlMTNmZGZlNDY0Li44ZDI5ZDUxZWE2MDQwMWMwOTJhZjEzZmM2MTY5MDZlMWEyZTMzMTRl IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTItMTItMTAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtDb3Zlcml0eV0gW0dUS10gUmVtb3ZlIHNvbWUgcmVkdW5kYW50 IG51bGwgY2hlY2tzIGluIER1bXBSZW5kZXJUcmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJl ZS5jcHA6CisgICAgICAgIChkZXNjcmlwdGlvblN1aXRhYmxlRm9yVGVzdFJlc3VsdCk6IFJlbW92 ZSBhIHJlZHVuZGFudCBudWxsIGNoZWNrLgorCiAyMDEyLTEyLTEwICBWw61jdG9yIE1hbnVlbCBK w6FxdWV6IExlYWwgIDx2amFxdWV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihy MTM1ODYzKTogR3RrTGF1bmNoZXIgLS1oZWxwIG5vIGxvbmdlciBkaXNwbGF5cyBhbGwgaGVscCBv cHRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRy ZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRl eCBlNjhlMmEwMjNlYzQ3YjA5ODUzMjcyMjMwODI5YTU0ZTkxODUyNTZkLi4zMjliNTcwODAzZGFm YWFkYmNhMDZiZDZlZjZhM2ZmM2VhYTBkODQ0IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTEyMzIsOCArMTIzMiw3IEBAIHN0YXRpYyBDU3RyaW5n IGRlc2NyaXB0aW9uU3VpdGFibGVGb3JUZXN0UmVzdWx0KFdlYktpdE5ldHdvcmtSZXF1ZXN0KiBy ZXF1ZXN0KQogICAgIENTdHJpbmcgbWFpbkRvY3VtZW50VVJJU3RyaW5nKGRlc2NyaXB0aW9uU3Vp dGFibGVGb3JUZXN0UmVzdWx0KG1haW5Eb2N1bWVudFVSSSkpOwogICAgIENTdHJpbmcgcGF0aChj b252ZXJ0TmV0d29ya1JlcXVlc3RUb1VSTFBhdGgocmVxdWVzdCkpOwogICAgIEdPd25QdHI8Y2hh cj4gZGVzY3JpcHRpb24oZ19zdHJkdXBfcHJpbnRmKCI8TlNVUkxSZXF1ZXN0IFVSTCAlcywgbWFp biBkb2N1bWVudCBVUkwgJXMsIGh0dHAgbWV0aG9kICVzPiIsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcGF0aC5kYXRhKCksIG1haW5Eb2N1bWVudFVSSVN0 cmluZy5kYXRhKCksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc291cE1lc3NhZ2UgPyBzb3VwTWVzc2FnZS0+bWV0aG9kIDogIihub25lKSIpKTsKKyAgICAg ICAgcGF0aC5kYXRhKCksIG1haW5Eb2N1bWVudFVSSVN0cmluZy5kYXRhKCksIHNvdXBNZXNzYWdl LT5tZXRob2QpKTsKICAgICByZXR1cm4gQ1N0cmluZyhkZXNjcmlwdGlvbi5nZXQoKSk7CiB9CiAK