104561 2012-12-10 08:10:03 -0800 WebKitWebViewBase produces a warning if compiled with gcc 2012-12-10 09:15:15 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 0 berto webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 787346 0 berto 2012-12-10 08:10:03 -0800 The webkit_web_view_base_get_type() prototype uses C++ syntax that produces a warning when compiled with gcc: WebKitWebViewBase.h:68:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] 787354 1 178558 berto 2012-12-10 08:18:46 -0800 Created attachment 178558 Patch 787376 2 178558 webkit.review.bot 2012-12-10 08:49:35 -0800 Comment on attachment 178558 Patch Rejecting attachment 178558 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15227688 787382 3 178563 berto 2012-12-10 08:56:01 -0800 Created attachment 178563 Patch v2 Oops, I removed the "Reviewed by" line from the ChangeLog by mistake. Here's the new patch. 787388 4 webkit.review.bot 2012-12-10 08:59:10 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 787396 5 178563 webkit.review.bot 2012-12-10 09:15:12 -0800 Comment on attachment 178563 Patch v2 Clearing flags on attachment: 178563 Committed r137164: <http://trac.webkit.org/changeset/137164> 787397 6 webkit.review.bot 2012-12-10 09:15:15 -0800 All reviewed patches have been landed. Closing bug. 178558 2012-12-10 08:18:46 -0800 2012-12-10 08:56:01 -0800 Patch get-type.diff text/plain 1185 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlMDEzN2U1Li44NGMyYWViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMTItMTAgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFdlYktpdFdlYlZpZXdCYXNlIHByb2R1Y2VzIGEgd2FybmluZyBpZiBjb21waWxlZCB3 aXRoIGdjYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA0NTYxCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5o OgorICAgICAgICBzaW5jZSB0aGlzIGZpbGUgY2FuIGJlIGluY2x1ZGVkIGZyb20gQyBjb2RlLCB1 c2Ugdm9pZCB0bworICAgICAgICBleHBsaWNpdGx5IHNwZWNpZnkgdGhhdCB3ZWJraXRfd2ViX3Zp ZXdfYmFzZV9nZXRfdHlwZSgpIGRvZXNuJ3QKKyAgICAgICAgaGF2ZSBwYXJhbWV0ZXJzLgorCiAy MDEyLTEyLTEwICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCiAg ICAgICAgIENvb3JkaW5hdGVkIEdyYXBoaWNzOiBBZGQgQ29vcmRpbmF0ZWRTdXJmYWNlIHRvIHJl bW92ZSB0aGUgZGVwZW5kZW5jeSBvZiBTaGFyZWFibGVTdXJmYWNlIGZyb20gQ29vcmRpbmF0ZWQg R3JhcGhpY3MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0V2ViVmlld0Jhc2UuaAppbmRleCA5OWM0ZDMwLi4xNzYyM2MyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmgKQEAgLTY1 LDcgKzY1LDcgQEAgc3RydWN0IF9XZWJLaXRXZWJWaWV3QmFzZUNsYXNzIHsKIH07CiAKIFdFQktJ VF9BUEkgR1R5cGUKLXdlYmtpdF93ZWJfdmlld19iYXNlX2dldF90eXBlKCk7Cit3ZWJraXRfd2Vi X3ZpZXdfYmFzZV9nZXRfdHlwZSAodm9pZCk7CiAKIEdfRU5EX0RFQ0xTCiAK 178563 2012-12-10 08:56:01 -0800 2012-12-10 09:15:12 -0800 Patch v2 get-type.diff text/plain 1326 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlMDEzN2U1Li5hYTM5NWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTItMTAgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFdlYktpdFdlYlZpZXdCYXNlIHByb2R1Y2VzIGEgd2FybmluZyBpZiBjb21waWxlZCB3 aXRoIGdjYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA0NTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5oOgorICAgICAgICBzaW5jZSB0 aGlzIGZpbGUgY2FuIGJlIGluY2x1ZGVkIGZyb20gQyBjb2RlLCB1c2Ugdm9pZCB0bworICAgICAg ICBleHBsaWNpdGx5IHNwZWNpZnkgdGhhdCB3ZWJraXRfd2ViX3ZpZXdfYmFzZV9nZXRfdHlwZSgp IGRvZXNuJ3QKKyAgICAgICAgaGF2ZSBwYXJhbWV0ZXJzLiBPdGhlcndpc2Ugd2UgZ2V0ICJ3YXJu aW5nOiBmdW5jdGlvbiBkZWNsYXJhdGlvbgorICAgICAgICBpc24ndCBhIHByb3RvdHlwZSIgd2l0 aCAtV3N0cmljdC1wcm90b3R5cGVzLgorCiAyMDEyLTEyLTEwICBIdWFuZyBEb25nc3VuZyAgPGx1 eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIENvb3JkaW5hdGVkIEdyYXBoaWNzOiBB ZGQgQ29vcmRpbmF0ZWRTdXJmYWNlIHRvIHJlbW92ZSB0aGUgZGVwZW5kZW5jeSBvZiBTaGFyZWFi bGVTdXJmYWNlIGZyb20gQ29vcmRpbmF0ZWQgR3JhcGhpY3MuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5oIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuaAppbmRleCA5OWM0ZDMw Li4xNzYyM2MyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXdCYXNlLmgKQEAgLTY1LDcgKzY1LDcgQEAgc3RydWN0IF9XZWJLaXRXZWJW aWV3QmFzZUNsYXNzIHsKIH07CiAKIFdFQktJVF9BUEkgR1R5cGUKLXdlYmtpdF93ZWJfdmlld19i YXNlX2dldF90eXBlKCk7Cit3ZWJraXRfd2ViX3ZpZXdfYmFzZV9nZXRfdHlwZSAodm9pZCk7CiAK IEdfRU5EX0RFQ0xTCiAK